128548 2014-02-10 12:05:11 -0800 Crash in copyShortASCIIString after r163793 2014-02-10 15:33:28 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED P2 Normal --- 1 enrica enrica ap benjamin cmarcelo commit-queue oldest_to_newest 978995 0 enrica 2014-02-10 12:05:11 -0800 A null check is missing. It happens in iOS. 978996 1 223733 enrica 2014-02-10 12:06:34 -0800 Created attachment 223733 Patch 978999 2 223733 ap 2014-02-10 12:20:59 -0800 Comment on attachment 223733 Patch r=me, however would addressing Darin's FIXME fix this in a better way? // FIXME: Documentation claims the code above would work on iOS 4.0 and later. After test that works, we should remove this and use that instead. 979014 3 enrica 2014-02-10 13:05:15 -0800 (In reply to comment #2) > (From update of attachment 223733 [details]) > r=me, however would addressing Darin's FIXME fix this in a better way? > > // FIXME: Documentation claims the code above would work on iOS 4.0 and later. After test that works, we should remove this and use that instead. I'm not sure about it. The code existed before and was performing a null check. 979093 4 ap 2014-02-10 15:33:28 -0800 Enrica landed this patch in <http://trac.webkit.org/changeset/163809>. 223733 2014-02-10 12:06:34 -0800 2014-02-10 12:20:58 -0800 Patch stringcrash.txt text/plain 1317 enrica SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNjM4MDYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAyLTEwICBFbnJpY2EgQ2FzdWNjaSAgPGVu cmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgY29weVNob3J0QVNDSUlTdHJpbmcgY3Jhc2hlcyBv biBpT1MgYWZ0ZXIgcjE2Mzc5My4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyODU0OC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGRpbmcgbnVsbCBjaGVjay4KKworICAgICAgICAqIHd0Zi91bmljb2Rl L2ljdS9Db2xsYXRvcklDVS5jcHA6CisgICAgICAgIChXVEY6OmNvcHlTaG9ydEFTQ0lJU3RyaW5n KToKKwogMjAxNC0wMi0xMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0dMSUJdIEFkZCBHVW5pcXVlT3V0UHRyIGFuZCB1c2UgaXQgaW5zdGVh ZCBvZiBHT3duUHRyCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi91bmljb2RlL2ljdS9Db2xsYXRvcklD VS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvdW5pY29kZS9pY3UvQ29sbGF0b3JJ Q1UuY3BwCShyZXZpc2lvbiAxNjM4MDApCisrKyBTb3VyY2UvV1RGL3d0Zi91bmljb2RlL2ljdS9D b2xsYXRvcklDVS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcyLDcgKzcyLDcgQEAgc3RhdGljIGlu bGluZSBjaGFyKiBjb3B5U2hvcnRBU0NJSVN0cmluZwogewogICAgIC8vIE9LIHRvIGhhdmUgYSBm aXhlZCBzaXplIGJ1ZmZlciBhbmQgdG8gb25seSBoYW5kbGUgQVNDSUkgc2luY2Ugd2Ugb25seSB1 c2UgdGhpcyBmb3IgbG9jYWxlIG5hbWVzLgogICAgIGNoYXIgYnVmZmVyWzI1Nl07Ci0gICAgaWYg KCFDRlN0cmluZ0dldENTdHJpbmcoc3RyaW5nLCBidWZmZXIsIHNpemVvZihidWZmZXIpLCBrQ0ZT dHJpbmdFbmNvZGluZ0FTQ0lJKSkKKyAgICBpZiAoIXN0cmluZyB8fCAhQ0ZTdHJpbmdHZXRDU3Ry aW5nKHN0cmluZywgYnVmZmVyLCBzaXplb2YoYnVmZmVyKSwga0NGU3RyaW5nRW5jb2RpbmdBU0NJ SSkpCiAgICAgICAgIHJldHVybiBzdHJkdXAoIiIpOwogICAgIHJldHVybiBzdHJkdXAoYnVmZmVy KTsKIH0K