128530 2014-02-10 06:27:49 -0800 Enable CSS_SHAPE_INSIDE in CMake files 2014-02-10 07:57:23 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 k.wolanski webkit-unassigned bunhere commit-queue gyuyoung.kim gyuyoung.kim ossy rakuco sergio oldest_to_newest 978851 0 k.wolanski 2014-02-10 06:27:49 -0800 CSS_SHAPE_INSIDE flag was added in r163333, this patch is turning on this flag in CMake files. 978852 1 223703 k.wolanski 2014-02-10 06:29:33 -0800 Created attachment 223703 proposed patch 978857 2 223703 gyuyoung.kim 2014-02-10 06:57:32 -0800 Comment on attachment 223703 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=223703&action=review Please land this after modifying description of changelog. > ChangeLog:3 > + Enable CSS_SHAPE_INSIDE in CMake files Current patch is just to add the CSS_SHAPE_INSIDE to CMake feature list. > ChangeLog:9 > + this patch is turning on this flag in CMake files. ditto. 978859 3 ossy 2014-02-10 07:00:25 -0800 *** Bug 128525 has been marked as a duplicate of this bug. *** 978861 4 223705 k.wolanski 2014-02-10 07:06:13 -0800 Created attachment 223705 apply suggestions 978862 5 223705 commit-queue 2014-02-10 07:09:41 -0800 Comment on attachment 223705 apply suggestions Rejecting attachment 223705 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 223705, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/6623476500660224 978864 6 gyuyoung.kim 2014-02-10 07:13:09 -0800 Krzysztof, if you get r+, you need to fill "Reviewed by XXX" in ChangeLog. If you use Tools/Script/webkit-patch apply-attachment apply-attachment *attachment number*, the webkit-patch will fill it automatically. 978867 7 223707 k.wolanski 2014-02-10 07:18:57 -0800 Created attachment 223707 apply suggestions 978869 8 gyuyoung.kim 2014-02-10 07:23:05 -0800 (In reply to comment #3) > *** Bug 128525 has been marked as a duplicate of this bug. *** Sorry for missing it before taking a look this one. 978881 9 223707 commit-queue 2014-02-10 07:57:19 -0800 Comment on attachment 223707 apply suggestions Clearing flags on attachment: 223707 Committed r163786: <http://trac.webkit.org/changeset/163786> 978882 10 commit-queue 2014-02-10 07:57:23 -0800 All reviewed patches have been landed. Closing bug. 223703 2014-02-10 06:29:33 -0800 2014-02-10 07:06:13 -0800 proposed patch CSS_SHAPE_INSIDE.patch text/plain 1985 k.wolanski ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyNWQwMDM0Li5mMzgwYjc1 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTQtMDItMTAgIEtyenlzenRvZiBXb2xhbnNraSAgPGsud29sYW5za2lAc2Ftc3VuZy5jb20+ CisKKyAgICAgICAgRW5hYmxlIENTU19TSEFQRV9JTlNJREUgaW4gQ01ha2UgZmlsZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODUzMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENTU19TSEFQRV9JTlNJ REUgZmxhZyB3YXMgYWRkZWQgaW4gcjE2MzMzMywKKyAgICAgICAgdGhpcyBwYXRjaCBpcyB0dXJu aW5nIG9uIHRoaXMgZmxhZyBpbiBDTWFrZSBmaWxlcy4KKworICAgICAgICAqIFNvdXJjZS9jbWFr ZS9XZWJLaXRGZWF0dXJlcy5jbWFrZToKKyAgICAgICAgKiBTb3VyY2UvY21ha2Vjb25maWcuaC5j bWFrZToKKwogMjAxNC0wMi0wOSAgQ2FybG9zIEdhcm5hY2hvICA8Y2FybG9zZ0Bnbm9tZS5vcmc+ CiAKICAgICAgICAgW0dUS10gRW5hYmxlIHRvdWNoIGZlYXR1cmVzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVy ZXMuY21ha2UKaW5kZXggMWY1MTJlNy4uYjJjZWZmNSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtl L1dlYktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5j bWFrZQpAQCAtMzYsNiArMzYsNyBAQCBtYWNybyhXRUJLSVRfT1BUSU9OX0JFR0lOKQogICAgIFdF QktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9DU1NfSU1BR0VfU0VUICJUb2dnbGUgQ1NTIGltYWdl LXNldCBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0NTU19S RUdJT05TICJUb2dnbGUgQ1NTIHJlZ2lvbnMgc3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJ T05fREVGSU5FKEVOQUJMRV9DU1NfU0hBUEVTICJUb2dnbGUgQ1NTIFNoYXBlcyBzdXBwb3J0IiBP RkYpCisgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0NTU19TSEFQRV9JTlNJREUgIlRv Z2dsZSBDU1MgU2hhcGVzIEluc2lkZSBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9E RUZJTkUoRU5BQkxFX0NTU19TVElDS1lfUE9TSVRJT04gIlRvZ2dsZSBDU1Mgc3RpY2t5IHBvc2l0 aW9uIHN1cHBvcnQiIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfQ1NTX1RS QU5TRk9STVNfQU5JTUFUSU9OU19VTlBSRUZJWEVEICJUb2dnbGUgc3VwcG9ydCBmb3IgdW5wcmVm aXhlZCBDU1MgYW5pbWF0aW9ucyBhbmQgdHJhbnNmb3JtcyIgT04pCiAgICAgV0VCS0lUX09QVElP Tl9ERUZJTkUoRU5BQkxFX0NVU1RPTV9TQ0hFTUVfSEFORExFUiAiVG9nZ2xlIEN1c3RvbSBTY2hl bWUgSGFuZGxlciBzdXBwb3J0IiBPRkYpCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2Vjb25maWcu aC5jbWFrZSBiL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlCmluZGV4IDUwODY0NWEuLjRlNDll MjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlCisrKyBiL1NvdXJjZS9j bWFrZWNvbmZpZy5oLmNtYWtlCkBAIC0yNSw2ICsyNSw3IEBACiAjY21ha2VkZWZpbmUwMSBFTkFC TEVfQ1NTX0lNQUdFX1NFVAogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0NTU19SRUdJT05TCiAjY21h a2VkZWZpbmUwMSBFTkFCTEVfQ1NTX1NIQVBFUworI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0NTU19T SEFQRV9JTlNJREUKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9DU1NfU1RJQ0tZX1BPU0lUSU9OCiAj Y21ha2VkZWZpbmUwMSBFTkFCTEVfQ1NTX1RSQU5TRk9STVNfQU5JTUFUSU9OU19VTlBSRUZJWEVE CiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQ1NTM19DT05ESVRJT05BTF9SVUxFUwo= 223705 2014-02-10 07:06:13 -0800 2014-02-10 07:18:57 -0800 apply suggestions CSS_SHAPE_INSIDE.patch text/plain 1996 k.wolanski ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyNWQwMDM0Li5mY2YxNjRh IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTQtMDItMTAgIEtyenlzenRvZiBXb2xhbnNraSAgPGsud29sYW5za2lAc2Ftc3VuZy5jb20+ CisKKyAgICAgICAgQWRkIHRoZSBDU1NfU0hBUEVfSU5TSURFIHRvIENNYWtlIGZlYXR1cmUgbGlz dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4NTMw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ1NTX1NI QVBFX0lOU0lERSBmbGFnIHdhcyBhZGRlZCBpbiByMTYzMzMzLAorICAgICAgICB0aGlzIHBhdGNo IGlzIGFkZGluZyB0aGlzIGZsYWcgdG8gQ01ha2UgZmVhdHVyZSBsaXN0LgorCisgICAgICAgICog U291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlOgorICAgICAgICAqIFNvdXJjZS9jbWFr ZWNvbmZpZy5oLmNtYWtlOgorCiAyMDE0LTAyLTA5ICBDYXJsb3MgR2FybmFjaG8gIDxjYXJsb3Nn QGdub21lLm9yZz4KIAogICAgICAgICBbR1RLXSBFbmFibGUgdG91Y2ggZmVhdHVyZXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9X ZWJLaXRGZWF0dXJlcy5jbWFrZQppbmRleCAxZjUxMmU3Li5iMmNlZmY1IDEwMDY0NAotLS0gYS9T b3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktp dEZlYXR1cmVzLmNtYWtlCkBAIC0zNiw2ICszNiw3IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fQkVH SU4pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0NTU19JTUFHRV9TRVQgIlRvZ2ds ZSBDU1MgaW1hZ2Utc2V0IHN1cHBvcnQiIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShF TkFCTEVfQ1NTX1JFR0lPTlMgIlRvZ2dsZSBDU1MgcmVnaW9ucyBzdXBwb3J0IiBPRkYpCiAgICAg V0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0NTU19TSEFQRVMgIlRvZ2dsZSBDU1MgU2hhcGVz IHN1cHBvcnQiIE9GRikKKyAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfQ1NTX1NIQVBF X0lOU0lERSAiVG9nZ2xlIENTUyBTaGFwZXMgSW5zaWRlIHN1cHBvcnQiIE9GRikKICAgICBXRUJL SVRfT1BUSU9OX0RFRklORShFTkFCTEVfQ1NTX1NUSUNLWV9QT1NJVElPTiAiVG9nZ2xlIENTUyBz dGlja3kgcG9zaXRpb24gc3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVO QUJMRV9DU1NfVFJBTlNGT1JNU19BTklNQVRJT05TX1VOUFJFRklYRUQgIlRvZ2dsZSBzdXBwb3J0 IGZvciB1bnByZWZpeGVkIENTUyBhbmltYXRpb25zIGFuZCB0cmFuc2Zvcm1zIiBPTikKICAgICBX RUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfQ1VTVE9NX1NDSEVNRV9IQU5ETEVSICJUb2dnbGUg Q3VzdG9tIFNjaGVtZSBIYW5kbGVyIHN1cHBvcnQiIE9GRikKZGlmZiAtLWdpdCBhL1NvdXJjZS9j bWFrZWNvbmZpZy5oLmNtYWtlIGIvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UKaW5kZXggNTA4 NjQ1YS4uNGU0OWUyNiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UKKysr IGIvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UKQEAgLTI1LDYgKzI1LDcgQEAKICNjbWFrZWRl ZmluZTAxIEVOQUJMRV9DU1NfSU1BR0VfU0VUCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQ1NTX1JF R0lPTlMKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9DU1NfU0hBUEVTCisjY21ha2VkZWZpbmUwMSBF TkFCTEVfQ1NTX1NIQVBFX0lOU0lERQogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0NTU19TVElDS1lf UE9TSVRJT04KICNjbWFrZWRlZmluZTAxIEVOQUJMRV9DU1NfVFJBTlNGT1JNU19BTklNQVRJT05T X1VOUFJFRklYRUQKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9DU1MzX0NPTkRJVElPTkFMX1JVTEVT Cg== 223707 2014-02-10 07:18:57 -0800 2014-02-10 07:57:19 -0800 apply suggestions CSS_SHAPE_INSIDE.patch text/plain 1994 k.wolanski ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyNWQwMDM0Li5mY2YxNjRh IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTQtMDItMTAgIEtyenlzenRvZiBXb2xhbnNraSAgPGsud29sYW5za2lAc2Ftc3VuZy5jb20+ CisKKyAgICAgICAgQWRkIHRoZSBDU1NfU0hBUEVfSU5TSURFIHRvIENNYWtlIGZlYXR1cmUgbGlz dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4NTMw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgR3l1eW91bmcgS2ltLgorCisgICAgICAgIENTU19TSEFQ RV9JTlNJREUgZmxhZyB3YXMgYWRkZWQgaW4gcjE2MzMzMywKKyAgICAgICAgdGhpcyBwYXRjaCBp cyBhZGRpbmcgdGhpcyBmbGFnIHRvIENNYWtlIGZlYXR1cmUgbGlzdC4KKworICAgICAgICAqIFNv dXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZToKKyAgICAgICAgKiBTb3VyY2UvY21ha2Vj b25maWcuaC5jbWFrZToKKwogMjAxNC0wMi0wOSAgQ2FybG9zIEdhcm5hY2hvICA8Y2FybG9zZ0Bn bm9tZS5vcmc+CiAKICAgICAgICAgW0dUS10gRW5hYmxlIHRvdWNoIGZlYXR1cmVzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UKaW5kZXggMWY1MTJlNy4uYjJjZWZmNSAxMDA2NDQKLS0tIGEvU291 cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRG ZWF0dXJlcy5jbWFrZQpAQCAtMzYsNiArMzYsNyBAQCBtYWNybyhXRUJLSVRfT1BUSU9OX0JFR0lO KQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9DU1NfSU1BR0VfU0VUICJUb2dnbGUg Q1NTIGltYWdlLXNldCBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5B QkxFX0NTU19SRUdJT05TICJUb2dnbGUgQ1NTIHJlZ2lvbnMgc3VwcG9ydCIgT0ZGKQogICAgIFdF QktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9DU1NfU0hBUEVTICJUb2dnbGUgQ1NTIFNoYXBlcyBz dXBwb3J0IiBPRkYpCisgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0NTU19TSEFQRV9J TlNJREUgIlRvZ2dsZSBDU1MgU2hhcGVzIEluc2lkZSBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lU X09QVElPTl9ERUZJTkUoRU5BQkxFX0NTU19TVElDS1lfUE9TSVRJT04gIlRvZ2dsZSBDU1Mgc3Rp Y2t5IHBvc2l0aW9uIHN1cHBvcnQiIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFC TEVfQ1NTX1RSQU5TRk9STVNfQU5JTUFUSU9OU19VTlBSRUZJWEVEICJUb2dnbGUgc3VwcG9ydCBm b3IgdW5wcmVmaXhlZCBDU1MgYW5pbWF0aW9ucyBhbmQgdHJhbnNmb3JtcyIgT04pCiAgICAgV0VC S0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0NVU1RPTV9TQ0hFTUVfSEFORExFUiAiVG9nZ2xlIEN1 c3RvbSBTY2hlbWUgSGFuZGxlciBzdXBwb3J0IiBPRkYpCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21h a2Vjb25maWcuaC5jbWFrZSBiL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlCmluZGV4IDUwODY0 NWEuLjRlNDllMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlCisrKyBi L1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlCkBAIC0yNSw2ICsyNSw3IEBACiAjY21ha2VkZWZp bmUwMSBFTkFCTEVfQ1NTX0lNQUdFX1NFVAogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0NTU19SRUdJ T05TCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQ1NTX1NIQVBFUworI2NtYWtlZGVmaW5lMDEgRU5B QkxFX0NTU19TSEFQRV9JTlNJREUKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9DU1NfU1RJQ0tZX1BP U0lUSU9OCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQ1NTX1RSQU5TRk9STVNfQU5JTUFUSU9OU19V TlBSRUZJWEVECiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQ1NTM19DT05ESVRJT05BTF9SVUxFUwo=