128525 2014-02-10 04:14:58 -0800 [cmake] Feature flag for shape-inside 2014-02-13 03:54:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 128530 P2 Normal --- 128001 1 ossy ossy bunhere commit-queue dino gyuyoung.kim ossy rakuco sergio oldest_to_newest 978818 0 ossy 2014-02-10 04:14:58 -0800 https://trac.webkit.org/changeset/163333 added CSS_SHAPE_INSIDE guards and enabled it on Mac. But this change didn't add this new guard to cmake build system which disabled it automatically and made ~100 tests fail. We should add it to cmake to enable it automatically and make tests pass again. Patch is coming soon. 978820 1 223694 ossy 2014-02-10 04:17:17 -0800 Created attachment 223694 Patch tested locally, fast/shapes/shape-inside/* tests pass again with it 978822 2 ossy 2014-02-10 04:29:59 -0800 Otherwise it is a little bit strange for me that there are many default OFF features in Source/cmake/WebKitFeatures.cmake which are always overridden by build-webkit ... (defaults in FeatureList.pm) Shouldn't we unify the two file somehow? 978824 3 ossy 2014-02-10 04:32:09 -0800 not to mention OptionsEfl.cmake ... 978858 4 ossy 2014-02-10 07:00:25 -0800 *** This bug has been marked as a duplicate of bug 128530 *** 979492 5 dino 2014-02-11 10:15:30 -0800 Sorry :( 980227 6 223694 ossy 2014-02-13 03:54:36 -0800 Comment on attachment 223694 Patch Cleared review? from attachment 223694 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 223694 2014-02-10 04:17:17 -0800 2014-02-13 03:54:35 -0800 Patch bug-128525-20140210131716.patch text/plain 2094 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggMWY1MTJlN2M4OTNkNTQxYzFmYjU4NTY0Y2U5NDE2MzUxZDc4NTkzNi4uMGM2MmNjZmUxMWMy MzQ2OWVmMWJhNjQ2YTRiODQ5ZDIxZDhmNzY5MSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMzYsNiArMzYsNyBAQCBtYWNybyhXRUJLSVRfT1BUSU9OX0JFR0lOKQogICAgIFdFQktJ VF9PUFRJT05fREVGSU5FKEVOQUJMRV9DU1NfSU1BR0VfU0VUICJUb2dnbGUgQ1NTIGltYWdlLXNl dCBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0NTU19SRUdJ T05TICJUb2dnbGUgQ1NTIHJlZ2lvbnMgc3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05f REVGSU5FKEVOQUJMRV9DU1NfU0hBUEVTICJUb2dnbGUgQ1NTIFNoYXBlcyBzdXBwb3J0IiBPRkYp CisgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0NTU19TSEFQRV9JTlNJREUgIlRvZ2ds ZSBDU1MgU2hhcGVzIHNoYXBlLWluc2lkZSBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElP Tl9ERUZJTkUoRU5BQkxFX0NTU19TVElDS1lfUE9TSVRJT04gIlRvZ2dsZSBDU1Mgc3RpY2t5IHBv c2l0aW9uIHN1cHBvcnQiIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfQ1NT X1RSQU5TRk9STVNfQU5JTUFUSU9OU19VTlBSRUZJWEVEICJUb2dnbGUgc3VwcG9ydCBmb3IgdW5w cmVmaXhlZCBDU1MgYW5pbWF0aW9ucyBhbmQgdHJhbnNmb3JtcyIgT04pCiAgICAgV0VCS0lUX09Q VElPTl9ERUZJTkUoRU5BQkxFX0NVU1RPTV9TQ0hFTUVfSEFORExFUiAiVG9nZ2xlIEN1c3RvbSBT Y2hlbWUgSGFuZGxlciBzdXBwb3J0IiBPRkYpCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2Vjb25m aWcuaC5jbWFrZSBiL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlCmluZGV4IDUwODY0NWE2NzM3 YTc0ZDMxYWQ3MjEzMWZhMGNmYjhmNDgzZDdmMzkuLjRlNDllMjZmODkyNjgwZjkyNzIzZGQyZWUz YjFhYzc5YWMwNjFhOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlCisr KyBiL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlCkBAIC0yNSw2ICsyNSw3IEBACiAjY21ha2Vk ZWZpbmUwMSBFTkFCTEVfQ1NTX0lNQUdFX1NFVAogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0NTU19S RUdJT05TCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQ1NTX1NIQVBFUworI2NtYWtlZGVmaW5lMDEg RU5BQkxFX0NTU19TSEFQRV9JTlNJREUKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9DU1NfU1RJQ0tZ X1BPU0lUSU9OCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQ1NTX1RSQU5TRk9STVNfQU5JTUFUSU9O U19VTlBSRUZJWEVECiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfQ1NTM19DT05ESVRJT05BTF9SVUxF UwpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDI1ZDAwMzQwYjkyMzgy NTkzZDYyOWRjZjFlOTdjYzQzYmQ4ODM0OTIuLmMwMmE3Yzk1MmJjNDc1NmY1ZTBiODRmMDU5ZWUz ZDBkNzU1OTI3ZWUgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNC0wMi0xMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFtjbWFrZV0gRmVhdHVyZSBmbGFnIGZvciBzaGFwZS1pbnNpZGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODUyNQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2Nt YWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlOgorICAgICAgICAqIFNvdXJjZS9jbWFrZWNvbmZpZy5o LmNtYWtlOgorCiAyMDE0LTAyLTA5ICBDYXJsb3MgR2FybmFjaG8gIDxjYXJsb3NnQGdub21lLm9y Zz4KIAogICAgICAgICBbR1RLXSBFbmFibGUgdG91Y2ggZmVhdHVyZXMK