<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>128507</bug_id>
          
          <creation_ts>2014-02-09 16:10:19 -0800</creation_ts>
          <short_desc>Fix EFL build fallout from bug 128505 by #including Operations.h into those .cpp files that are broken</short_desc>
          <delta_ts>2014-02-10 00:53:04 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>128505</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Filip Pizlo">fpizlo</assigned_to>
          <cc>fpizlo</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>978664</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2014-02-09 16:10:19 -0800</bug_when>
    <thetext>Operations.h is JSC&apos;s umbrella for definitions of inline functions.  If your build fails because an inline function is not defined, just #include Operations.h.

Other workarounds are likely to create long-term problems.  For example, including the specific BlahInlines.h file is harmful because it means that if someone moves any other inline functions out to a *Inlines.h file, they will have to potentially add that include to every .cpp file in the system that may transitively include the place where the inline function was declared.  Alternatively, adding #include &quot;Operations.h&quot; into any other JSC headers is harmful since it risks introducing circular dependencies.  The *whole point* of the *Inlines.h files that Operations.h includes is that they are never included by JSC&apos;s interface headers.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>