128497 2014-02-09 02:49:41 -0800 Pass VM instead of ExecState to JSCell::fastGetOwnProperty(). 2014-02-09 13:28:21 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue oldest_to_newest 978576 0 kling 2014-02-09 02:49:41 -0800 From the random-diffs-in-my-home-directory department. 978579 1 223623 kling 2014-02-09 02:51:17 -0800 Created attachment 223623 Patch 978580 2 commit-queue 2014-02-09 02:52:58 -0800 Attachment 223623 did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSCellInlines.h:179: Wrong number of spaces before statement. (expected: 16) [whitespace/indent] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 978637 3 223623 commit-queue 2014-02-09 13:28:19 -0800 Comment on attachment 223623 Patch Clearing flags on attachment: 223623 Committed r163755: <http://trac.webkit.org/changeset/163755> 978638 4 commit-queue 2014-02-09 13:28:21 -0800 All reviewed patches have been landed. Closing bug. 223623 2014-02-09 02:51:17 -0800 2014-02-09 13:28:19 -0800 Patch bug-128497.diff text/plain 6322 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDIyZDFmNDEuLjAzOWU1MGYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTAyLTA5ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBQYXNzIFZNIGluc3RlYWQgb2YgRXhlY1N0 YXRlIHRvIEpTQ2VsbDo6ZmFzdEdldE93blByb3BlcnR5KCkuCisgICAgICAgIDxodHRwczovL3dl YmtpdC5vcmcvYi8xMjg0OTc+CisKKyAgICAgICAgS25vY2tzIG9mZiBhIGNvdXBsZSBvZiBpbnN0 cnVjdGlvbnMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBkZmcvREZHT3BlcmF0aW9ucy5jcHA6CisgICAgICAgICogaml0L0pJVE9wZXJhdGlvbnMu Y3BwOgorICAgICAgICAoSlNDOjpnZXRCeVZhbCk6CisgICAgICAgICogbGxpbnQvTExJbnRTbG93 UGF0aHMuY3BwOgorICAgICAgICAoSlNDOjpMTEludDo6Z2V0QnlWYWwpOgorICAgICAgICAqIHJ1 bnRpbWUvSlNDZWxsLmg6CisgICAgICAgICogcnVudGltZS9KU0NlbGxJbmxpbmVzLmg6CisgICAg ICAgIChKU0M6OkpTQ2VsbDo6ZmFzdEdldE93blByb3BlcnR5KToKKwogMjAxNC0wMi0wOCAgTWFy ayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIEJhc2VsaW5l IEpJVCB1c2VzIHRoZSB3cm9uZyB2ZXJzaW9uIG9mIGNoZWNrTWFya1dvcmQgaW4gZW1pdFdyaXRl QmFycmllcgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRp b25zLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAKaW5k ZXggY2E1ZTBjYS4uMTdhYzA5OSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdPcGVyYXRpb25zLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09w ZXJhdGlvbnMuY3BwCkBAIC0yNzgsOCArMjc4LDggQEAgc3RhdGljIGlubGluZSBFbmNvZGVkSlNW YWx1ZSBnZXRCeVZhbChFeGVjU3RhdGUqIGV4ZWMsIEpTQ2VsbCogYmFzZSwgdWludDMyX3QgaW4K IAogRW5jb2RlZEpTVmFsdWUgSklUX09QRVJBVElPTiBvcGVyYXRpb25HZXRCeVZhbChFeGVjU3Rh dGUqIGV4ZWMsIEVuY29kZWRKU1ZhbHVlIGVuY29kZWRCYXNlLCBFbmNvZGVkSlNWYWx1ZSBlbmNv ZGVkUHJvcGVydHkpCiB7Ci0gICAgVk0qIHZtID0gJmV4ZWMtPnZtKCk7Ci0gICAgTmF0aXZlQ2Fs bEZyYW1lVHJhY2VyIHRyYWNlcih2bSwgZXhlYyk7CisgICAgVk0mIHZtID0gZXhlYy0+dm0oKTsK KyAgICBOYXRpdmVDYWxsRnJhbWVUcmFjZXIgdHJhY2VyKCZ2bSwgZXhlYyk7CiAgICAgCiAgICAg SlNWYWx1ZSBiYXNlVmFsdWUgPSBKU1ZhbHVlOjpkZWNvZGUoZW5jb2RlZEJhc2UpOwogICAgIEpT VmFsdWUgcHJvcGVydHkgPSBKU1ZhbHVlOjpkZWNvZGUoZW5jb2RlZFByb3BlcnR5KTsKQEAgLTI5 NSw3ICsyOTUsNyBAQCBFbmNvZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbkdldEJ5 VmFsKEV4ZWNTdGF0ZSogZXhlYywgRW5jb2RlZEpTVmFsdWUgZQogICAgICAgICAgICAgaWYgKHBy b3BlcnR5QXNVSW50MzIgPT0gcHJvcGVydHlBc0RvdWJsZSkKICAgICAgICAgICAgICAgICByZXR1 cm4gZ2V0QnlWYWwoZXhlYywgYmFzZSwgcHJvcGVydHlBc1VJbnQzMik7CiAgICAgICAgIH0gZWxz ZSBpZiAocHJvcGVydHkuaXNTdHJpbmcoKSkgewotICAgICAgICAgICAgaWYgKEpTVmFsdWUgcmVz dWx0ID0gYmFzZS0+ZmFzdEdldE93blByb3BlcnR5KGV4ZWMsIGFzU3RyaW5nKHByb3BlcnR5KS0+ dmFsdWUoZXhlYykpKQorICAgICAgICAgICAgaWYgKEpTVmFsdWUgcmVzdWx0ID0gYmFzZS0+ZmFz dEdldE93blByb3BlcnR5KHZtLCBhc1N0cmluZyhwcm9wZXJ0eSktPnZhbHVlKGV4ZWMpKSkKICAg ICAgICAgICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKHJlc3VsdCk7CiAgICAgICAgIH0K ICAgICB9CkBAIC0zMDksOCArMzA5LDggQEAgRW5jb2RlZEpTVmFsdWUgSklUX09QRVJBVElPTiBv cGVyYXRpb25HZXRCeVZhbChFeGVjU3RhdGUqIGV4ZWMsIEVuY29kZWRKU1ZhbHVlIGUKIAogRW5j b2RlZEpTVmFsdWUgSklUX09QRVJBVElPTiBvcGVyYXRpb25HZXRCeVZhbENlbGwoRXhlY1N0YXRl KiBleGVjLCBKU0NlbGwqIGJhc2UsIEVuY29kZWRKU1ZhbHVlIGVuY29kZWRQcm9wZXJ0eSkKIHsK LSAgICBWTSogdm0gPSAmZXhlYy0+dm0oKTsKLSAgICBOYXRpdmVDYWxsRnJhbWVUcmFjZXIgdHJh Y2VyKHZtLCBleGVjKTsKKyAgICBWTSYgdm0gPSBleGVjLT52bSgpOworICAgIE5hdGl2ZUNhbGxG cmFtZVRyYWNlciB0cmFjZXIoJnZtLCBleGVjKTsKICAgICAKICAgICBKU1ZhbHVlIHByb3BlcnR5 ID0gSlNWYWx1ZTo6ZGVjb2RlKGVuY29kZWRQcm9wZXJ0eSk7CiAKQEAgLTMyMiw3ICszMjIsNyBA QCBFbmNvZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbkdldEJ5VmFsQ2VsbChFeGVj U3RhdGUqIGV4ZWMsIEpTQ2VsbCogYmFzZQogICAgICAgICBpZiAocHJvcGVydHlBc1VJbnQzMiA9 PSBwcm9wZXJ0eUFzRG91YmxlKQogICAgICAgICAgICAgcmV0dXJuIGdldEJ5VmFsKGV4ZWMsIGJh c2UsIHByb3BlcnR5QXNVSW50MzIpOwogICAgIH0gZWxzZSBpZiAocHJvcGVydHkuaXNTdHJpbmco KSkgewotICAgICAgICBpZiAoSlNWYWx1ZSByZXN1bHQgPSBiYXNlLT5mYXN0R2V0T3duUHJvcGVy dHkoZXhlYywgYXNTdHJpbmcocHJvcGVydHkpLT52YWx1ZShleGVjKSkpCisgICAgICAgIGlmIChK U1ZhbHVlIHJlc3VsdCA9IGJhc2UtPmZhc3RHZXRPd25Qcm9wZXJ0eSh2bSwgYXNTdHJpbmcocHJv cGVydHkpLT52YWx1ZShleGVjKSkpCiAgICAgICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2Rl KHJlc3VsdCk7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0 L0pJVE9wZXJhdGlvbnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRp b25zLmNwcAppbmRleCBhMjg4NTdmLi5lMTM1YTI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAKQEAgLTE0MDEsNyArMTQwMSw3IEBAIEVuY29kZWRKU1Zh bHVlIEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uR2V0QXJndW1lbnRzTGVuZ3RoKEV4ZWNTdGF0ZSog ZXhlYywgaW50MzJfCiBzdGF0aWMgSlNWYWx1ZSBnZXRCeVZhbChFeGVjU3RhdGUqIGV4ZWMsIEpT VmFsdWUgYmFzZVZhbHVlLCBKU1ZhbHVlIHN1YnNjcmlwdCwgUmV0dXJuQWRkcmVzc1B0ciByZXR1 cm5BZGRyZXNzKQogewogICAgIGlmIChMSUtFTFkoYmFzZVZhbHVlLmlzQ2VsbCgpICYmIHN1YnNj cmlwdC5pc1N0cmluZygpKSkgewotICAgICAgICBpZiAoSlNWYWx1ZSByZXN1bHQgPSBiYXNlVmFs dWUuYXNDZWxsKCktPmZhc3RHZXRPd25Qcm9wZXJ0eShleGVjLCBhc1N0cmluZyhzdWJzY3JpcHQp LT52YWx1ZShleGVjKSkpCisgICAgICAgIGlmIChKU1ZhbHVlIHJlc3VsdCA9IGJhc2VWYWx1ZS5h c0NlbGwoKS0+ZmFzdEdldE93blByb3BlcnR5KGV4ZWMtPnZtKCksIGFzU3RyaW5nKHN1YnNjcmlw dCktPnZhbHVlKGV4ZWMpKSkKICAgICAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnRTbG93UGF0aHMuY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50U2xvd1BhdGhzLmNwcAppbmRleCBm Yzc1NzY1Li4xZDA5YmRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQv TExJbnRTbG93UGF0aHMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTElu dFNsb3dQYXRocy5jcHAKQEAgLTcwNyw3ICs3MDcsNyBAQCBMTElOVF9TTE9XX1BBVEhfREVDTChz bG93X3BhdGhfZGVsX2J5X2lkKQogaW5saW5lIEpTVmFsdWUgZ2V0QnlWYWwoRXhlY1N0YXRlKiBl eGVjLCBKU1ZhbHVlIGJhc2VWYWx1ZSwgSlNWYWx1ZSBzdWJzY3JpcHQpCiB7CiAgICAgaWYgKExJ S0VMWShiYXNlVmFsdWUuaXNDZWxsKCkgJiYgc3Vic2NyaXB0LmlzU3RyaW5nKCkpKSB7Ci0gICAg ICAgIGlmIChKU1ZhbHVlIHJlc3VsdCA9IGJhc2VWYWx1ZS5hc0NlbGwoKS0+ZmFzdEdldE93blBy b3BlcnR5KGV4ZWMsIGFzU3RyaW5nKHN1YnNjcmlwdCktPnZhbHVlKGV4ZWMpKSkKKyAgICAgICAg aWYgKEpTVmFsdWUgcmVzdWx0ID0gYmFzZVZhbHVlLmFzQ2VsbCgpLT5mYXN0R2V0T3duUHJvcGVy dHkoZXhlYy0+dm0oKSwgYXNTdHJpbmcoc3Vic2NyaXB0KS0+dmFsdWUoZXhlYykpKQogICAgICAg ICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICB9CiAgICAgCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9KU0NlbGwuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0pTQ2VsbC5oCmluZGV4IGRlODVhNGIuLmU1MTI2OGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ2VsbC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0pTQ2VsbC5oCkBAIC0xMzMsNyArMTMzLDcgQEAgcHVibGljOgogICAgIHZvaWQg emFwKCkgeyAqcmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3QqKj4odGhpcykgPSAwOyB9CiAgICAg Ym9vbCBpc1phcHBlZCgpIGNvbnN0IHsgcmV0dXJuICEqcmVpbnRlcnByZXRfY2FzdDx1aW50cHRy X3QqIGNvbnN0Kj4odGhpcyk7IH0KIAotICAgIEpTVmFsdWUgZmFzdEdldE93blByb3BlcnR5KEV4 ZWNTdGF0ZSosIGNvbnN0IFN0cmluZyYpOworICAgIEpTVmFsdWUgZmFzdEdldE93blByb3BlcnR5 KFZNJiwgY29uc3QgU3RyaW5nJik7CiAKICAgICBzdGF0aWMgcHRyZGlmZl90IHN0cnVjdHVyZU9m ZnNldCgpCiAgICAgewpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNDZWxsSW5saW5lcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDZWxsSW5s aW5lcy5oCmluZGV4IGY3Yzg0NDYuLmU3ZGJiNDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTQ2VsbElubGluZXMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU0NlbGxJbmxpbmVzLmgKQEAgLTE3MSwxMiArMTcxLDEyIEBAIGlubGluZSBi b29sIEpTQ2VsbDo6aW5oZXJpdHMoY29uc3QgQ2xhc3NJbmZvKiBpbmZvKSBjb25zdAogLy8gaWRl bnRpZmllci4gVGhlIGZpcnN0IHRpbWUgd2UgcGVyZm9ybSBhIHByb3BlcnR5IGFjY2VzcyB3aXRo IGEgZ2l2ZW4gc3RyaW5nLCB0cnkKIC8vIHBlcmZvcm1pbmcgdGhlIHByb3BlcnR5IG1hcCBsb29r dXAgd2l0aG91dCBmb3JtaW5nIGFuIGlkZW50aWZpZXIuIFdlIGRldGVjdCB0aGlzCiAvLyBjYXNl IGJ5IGNoZWNraW5nIHdoZXRoZXIgdGhlIGhhc2ggaGFzIHlldCBiZWVuIHNldCBmb3IgdGhpcyBz dHJpbmcuCi1BTFdBWVNfSU5MSU5FIEpTVmFsdWUgSlNDZWxsOjpmYXN0R2V0T3duUHJvcGVydHko RXhlY1N0YXRlKiBleGVjLCBjb25zdCBTdHJpbmcmIG5hbWUpCitBTFdBWVNfSU5MSU5FIEpTVmFs dWUgSlNDZWxsOjpmYXN0R2V0T3duUHJvcGVydHkoVk0mIHZtLCBjb25zdCBTdHJpbmcmIG5hbWUp CiB7CiAgICAgaWYgKCFzdHJ1Y3R1cmUoKS0+dHlwZUluZm8oKS5vdmVycmlkZXNHZXRPd25Qcm9w ZXJ0eVNsb3QoKSAmJiAhc3RydWN0dXJlKCktPmhhc0dldHRlclNldHRlclByb3BlcnRpZXMoKSkg ewogICAgICAgICBQcm9wZXJ0eU9mZnNldCBvZmZzZXQgPSBuYW1lLmltcGwoKS0+aGFzSGFzaCgp Ci0gICAgICAgICAgICA/IHN0cnVjdHVyZSgpLT5nZXQoZXhlYy0+dm0oKSwgSWRlbnRpZmllcihl eGVjLCBuYW1lKSkKLSAgICAgICAgICAgIDogc3RydWN0dXJlKCktPmdldChleGVjLT52bSgpLCBu YW1lKTsKKyAgICAgICAgICAgID8gc3RydWN0dXJlKCktPmdldCh2bSwgSWRlbnRpZmllcigmdm0s IG5hbWUpKQorICAgICAgICAgICAgOiBzdHJ1Y3R1cmUoKS0+Z2V0KHZtLCBuYW1lKTsKICAgICAg ICAgaWYgKG9mZnNldCAhPSBpbnZhbGlkT2Zmc2V0KQogICAgICAgICAgICAgcmV0dXJuIGFzT2Jq ZWN0KHRoaXMpLT5sb2NhdGlvbkZvck9mZnNldChvZmZzZXQpLT5nZXQoKTsKICAgICB9Cg==