128496 2014-02-09 02:21:07 -0800 [GTK] Fix modifiers on EventSenderProxy::keyDown 2014-02-09 03:34:34 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 carlosg webkit-unassigned cgarcia commit-queue oldest_to_newest 978565 0 carlosg 2014-02-09 02:21:07 -0800 On my patch in bug #128171, I went far too eagerly to check direct usages of wkModifiers, failing to realize that keyDown() was already transforming that to a GTK+ modifier mask at the beginning of the function, I'm attaching a patch that fixes it back, sorry about that... 978567 1 223621 carlosg 2014-02-09 02:23:07 -0800 Created attachment 223621 patch, fixes modifiers on keyDown 978569 2 commit-queue 2014-02-09 02:25:25 -0800 Attachment 223621 did not pass style-queue: ERROR: Tools/ChangeLog:3: Line contains tab character. [whitespace/tab] [5] ERROR: Tools/ChangeLog:4: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 978570 3 223621 cgarcia 2014-02-09 02:26:00 -0800 Comment on attachment 223621 patch, fixes modifiers on keyDown Oops 978571 4 223621 cgarcia 2014-02-09 02:26:29 -0800 Comment on attachment 223621 patch, fixes modifiers on keyDown Oh, please fix the changelog. 978575 5 223622 carlosg 2014-02-09 02:36:00 -0800 Created attachment 223622 patch, fix indentation issues 978585 6 223622 commit-queue 2014-02-09 03:34:32 -0800 Comment on attachment 223622 patch, fix indentation issues Clearing flags on attachment: 223622 Committed r163750: <http://trac.webkit.org/changeset/163750> 978586 7 commit-queue 2014-02-09 03:34:34 -0800 All reviewed patches have been landed. Closing bug. 223621 2014-02-09 02:23:07 -0800 2014-02-09 02:36:00 -0800 patch, fixes modifiers on keyDown patch-fix-modifiers.diff text/plain 1483 carlosg ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyMzc0 NDQyLi44ZGQxZDU2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDItMDkgIENhcmxvcyBHYXJuYWNobyAgPGNh cmxvc2dAZ25vbWUub3JnPgorCisJW0dUS10gRml4IG1vZGlmaWVycyBvbiBFdmVudFNlbmRlclBy b3h5OjprZXlEb3duCisJaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy ODQ5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog V2ViS2l0VGVzdFJ1bm5lci9ndGsvRXZlbnRTZW5kZXJQcm94eUd0ay5jcHA6CisgICAgICAgIChX VFI6OkV2ZW50U2VuZGVyUHJveHk6OmtleURvd24pOiBkbyBub3QgYXR0ZW1wdCB0byBkb3VibHkg dHJhbnNmb3JtIG1vZGlmaWVycworICAgICAgICBpbnRvIEdUSysgb25lcy4KKwogMjAxMy0xMi0y NCAgQ2FybG9zIEdhcm5hY2hvICA8Y2FybG9zZ0Bnbm9tZS5vcmc+CiAKICAgICAgICAgW0dUS10g RW5hYmxlIHRvdWNoIGZlYXR1cmVzCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVy L2d0ay9FdmVudFNlbmRlclByb3h5R3RrLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3Rr L0V2ZW50U2VuZGVyUHJveHlHdGsuY3BwCmluZGV4IDk2ZDNiOWYuLjQyYmVkZmYgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL0V2ZW50U2VuZGVyUHJveHlHdGsuY3BwCisr KyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL0V2ZW50U2VuZGVyUHJveHlHdGsuY3BwCkBA IC0yOTEsNyArMjkxLDcgQEAgdm9pZCBFdmVudFNlbmRlclByb3h5OjprZXlEb3duKFdLU3RyaW5n UmVmIGtleVJlZiwgV0tFdmVudE1vZGlmaWVycyB3a01vZGlmaWVycywKIAogICAgIEdka0V2ZW50 KiBwcmVzc0V2ZW50ID0gZ2RrX2V2ZW50X25ldyhHREtfS0VZX1BSRVNTKTsKICAgICBwcmVzc0V2 ZW50LT5rZXkua2V5dmFsID0gZ2RrS2V5U3ltOwotICAgIHByZXNzRXZlbnQtPmtleS5zdGF0ZSA9 IHdlYmtpdE1vZGlmaWVyc1RvR0RLTW9kaWZpZXJzKG1vZGlmaWVycyk7CisgICAgcHJlc3NFdmVu dC0+a2V5LnN0YXRlID0gbW9kaWZpZXJzOwogICAgIHByZXNzRXZlbnQtPmtleS53aW5kb3cgPSBn dGtfd2lkZ2V0X2dldF93aW5kb3coR1RLX1dJREdFVChtX3Rlc3RDb250cm9sbGVyLT5tYWluV2Vi VmlldygpLT5wbGF0Zm9ybVdpbmRvdygpKSk7CiAgICAgZ19vYmplY3RfcmVmKHByZXNzRXZlbnQt PmtleS53aW5kb3cpOwogICAgIGdka19ldmVudF9zZXRfZGV2aWNlKHByZXNzRXZlbnQsIGdka19k ZXZpY2VfbWFuYWdlcl9nZXRfY2xpZW50X3BvaW50ZXIoZ2RrX2Rpc3BsYXlfZ2V0X2RldmljZV9t YW5hZ2VyKGdka193aW5kb3dfZ2V0X2Rpc3BsYXkocHJlc3NFdmVudC0+a2V5LndpbmRvdykpKSk7 Cg== 223622 2014-02-09 02:36:00 -0800 2014-02-09 03:34:32 -0800 patch, fix indentation issues patch-fix-modifiers.diff text/plain 1503 carlosg ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyMzc0 NDQyLi41MTZkMTRhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDItMDkgIENhcmxvcyBHYXJuYWNobyAgPGNh cmxvc2dAZ25vbWUub3JnPgorCisgICAgICAgIFtHVEtdIEZpeCBtb2RpZmllcnMgb24gRXZlbnRT ZW5kZXJQcm94eTo6a2V5RG93bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTI4NDk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ2FybG9zIEdhcmNpYSBD YW1wb3MuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2d0ay9FdmVudFNlbmRlclByb3h5 R3RrLmNwcDoKKyAgICAgICAgKFdUUjo6RXZlbnRTZW5kZXJQcm94eTo6a2V5RG93bik6IGRvIG5v dCBhdHRlbXB0IHRvIGRvdWJseSB0cmFuc2Zvcm0gbW9kaWZpZXJzCisgICAgICAgIGludG8gR1RL KyBvbmVzLgorCiAyMDEzLTEyLTI0ICBDYXJsb3MgR2FybmFjaG8gIDxjYXJsb3NnQGdub21lLm9y Zz4KIAogICAgICAgICBbR1RLXSBFbmFibGUgdG91Y2ggZmVhdHVyZXMKZGlmZiAtLWdpdCBhL1Rv b2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL0V2ZW50U2VuZGVyUHJveHlHdGsuY3BwIGIvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9ndGsvRXZlbnRTZW5kZXJQcm94eUd0ay5jcHAKaW5kZXggOTZkM2I5 Zi4uNDJiZWRmZiAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9ndGsvRXZlbnRT ZW5kZXJQcm94eUd0ay5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9ndGsvRXZlbnRT ZW5kZXJQcm94eUd0ay5jcHAKQEAgLTI5MSw3ICsyOTEsNyBAQCB2b2lkIEV2ZW50U2VuZGVyUHJv eHk6OmtleURvd24oV0tTdHJpbmdSZWYga2V5UmVmLCBXS0V2ZW50TW9kaWZpZXJzIHdrTW9kaWZp ZXJzLAogCiAgICAgR2RrRXZlbnQqIHByZXNzRXZlbnQgPSBnZGtfZXZlbnRfbmV3KEdES19LRVlf UFJFU1MpOwogICAgIHByZXNzRXZlbnQtPmtleS5rZXl2YWwgPSBnZGtLZXlTeW07Ci0gICAgcHJl c3NFdmVudC0+a2V5LnN0YXRlID0gd2Via2l0TW9kaWZpZXJzVG9HREtNb2RpZmllcnMobW9kaWZp ZXJzKTsKKyAgICBwcmVzc0V2ZW50LT5rZXkuc3RhdGUgPSBtb2RpZmllcnM7CiAgICAgcHJlc3NF dmVudC0+a2V5LndpbmRvdyA9IGd0a193aWRnZXRfZ2V0X3dpbmRvdyhHVEtfV0lER0VUKG1fdGVz dENvbnRyb2xsZXItPm1haW5XZWJWaWV3KCktPnBsYXRmb3JtV2luZG93KCkpKTsKICAgICBnX29i amVjdF9yZWYocHJlc3NFdmVudC0+a2V5LndpbmRvdyk7CiAgICAgZ2RrX2V2ZW50X3NldF9kZXZp Y2UocHJlc3NFdmVudCwgZ2RrX2RldmljZV9tYW5hZ2VyX2dldF9jbGllbnRfcG9pbnRlcihnZGtf ZGlzcGxheV9nZXRfZGV2aWNlX21hbmFnZXIoZ2RrX3dpbmRvd19nZXRfZGlzcGxheShwcmVzc0V2 ZW50LT5rZXkud2luZG93KSkpKTsK