128490 2014-02-08 23:19:14 -0800 [iOS][wk2] ASSERT(WebThreadIsCurrent()) in [WebDisplayLinkHandler handleDisplayLink:] 2014-02-09 16:21:37 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca commit-queue dino sam simon.fraser oldest_to_newest 978533 0 thorton 2014-02-08 23:19:14 -0800 [WebDisplayLinkHandler handleDisplayLink:] has an ASSERT(WebThreadIsCurrent()). We don't use the Web Thread in WebKit2, but it looks to me like isMainThread() does the right thing (main thread if web thread is disabled, web thread otherwise), so let's use that. 978534 1 223613 thorton 2014-02-08 23:21:47 -0800 Created attachment 223613 patch Hopefully someone can clarify if isMainThead does the right thing. And maybe we should audit other callers of WebThreadIsCurrent? 978665 2 223613 commit-queue 2014-02-09 16:21:34 -0800 Comment on attachment 223613 patch Clearing flags on attachment: 223613 Committed r163758: <http://trac.webkit.org/changeset/163758> 978666 3 commit-queue 2014-02-09 16:21:37 -0800 All reviewed patches have been landed. Closing bug. 223613 2014-02-08 23:21:47 -0800 2014-02-09 16:21:34 -0800 patch wt.diff text/plain 1506 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMzZiNzBiLi5mZGQ4YTMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTQtMDItMDggIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgW2lPU11bd2syXSBBU1NFUlQoV2ViVGhyZWFkSXNDdXJyZW50KCkpIGluIFtXZWJE aXNwbGF5TGlua0hhbmRsZXIgaGFuZGxlRGlzcGxheUxpbms6XQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4NDkwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9pb3MvRGlz cGxheVJlZnJlc2hNb25pdG9ySU9TLm1tOgorICAgICAgICAoLVtXZWJEaXNwbGF5TGlua0hhbmRs ZXIgaGFuZGxlRGlzcGxheUxpbms6XSk6CisgICAgICAgIFtXZWJEaXNwbGF5TGlua0hhbmRsZXIg aGFuZGxlRGlzcGxheUxpbms6XSBoYXMgYW4gQVNTRVJUKFdlYlRocmVhZElzQ3VycmVudCgpKS4K KworICAgICAgICBXZSBkb24ndCB1c2UgdGhlIFdlYiBUaHJlYWQgaW4gV2ViS2l0MiwgYnV0IGl0 IGxvb2tzIGxpa2UgaXNNYWluVGhyZWFkKCkKKyAgICAgICAgZG9lcyB0aGUgcmlnaHQgdGhpbmcg KG1haW4gdGhyZWFkIGlmIHdlYiB0aHJlYWQgaXMgZGlzYWJsZWQsIHdlYiB0aHJlYWQKKyAgICAg ICAgb3RoZXJ3aXNlKSwgc28gdXNlIHRoYXQgaW5zdGVhZC4KKwogMjAxNC0wMi0wOCAgQW5kcmVh cyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCBDaHJv bWVDbGllbnQ6OmxheW91dFVwZGF0ZWQoKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2lvcy9EaXNwbGF5UmVmcmVzaE1vbml0b3JJT1MubW0gYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9pb3MvRGlzcGxheVJlZnJlc2hNb25pdG9ySU9TLm1t CmluZGV4IDk4MDQzY2EuLmViNzhjZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2lvcy9EaXNwbGF5UmVmcmVzaE1vbml0b3JJT1MubW0KKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaW9zL0Rpc3BsYXlSZWZyZXNoTW9uaXRvcklPUy5t bQpAQCAtNzMsNyArNzMsNyBAQCBzdGF0aWMgZG91YmxlIG1lZGlhVGltZVRvQ3VycmVudFRpbWUo Q0ZUaW1lSW50ZXJ2YWwgdCkKIAogLSAodm9pZCloYW5kbGVEaXNwbGF5TGluazooQ0FEaXNwbGF5 TGluayAqKXNlbmRlcgogewotICAgIEFTU0VSVChXZWJUaHJlYWRJc0N1cnJlbnQoKSk7CisgICAg QVNTRVJUKGlzTWFpblRocmVhZCgpKTsKICAgICBtX21vbml0b3ItPmRpc3BsYXlMaW5rRmlyZWQo c2VuZGVyLnRpbWVzdGFtcCk7CiB9CiAK