128485 2014-02-08 20:32:57 -0800 [ASan] Fix build failures in Tools due to missing $(inherited) values 2014-02-11 12:07:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer aestes ayao commit-queue dfarler jeffrey+webkit mrowe oldest_to_newest 978508 0 ddkilzer 2014-02-08 20:32:57 -0800 When iOS changes were upstreamed or tools were made to build for iOS, the $(inherited) value was lost in OTHER_LDFLAGS in some *.xcconfig files that was required to make the tools build with the clang address sanitizer enabled. 978511 1 223603 ddkilzer 2014-02-08 20:41:34 -0800 Created attachment 223603 Patch v1 979533 2 223603 commit-queue 2014-02-11 12:07:29 -0800 Comment on attachment 223603 Patch v1 Clearing flags on attachment: 223603 Committed r163894: <http://trac.webkit.org/changeset/163894> 979534 3 commit-queue 2014-02-11 12:07:32 -0800 All reviewed patches have been landed. Closing bug. 223603 2014-02-08 20:41:34 -0800 2014-02-11 12:07:29 -0800 Patch v1 bug-128485-20140208204133.patch text/plain 6817 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNzMwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmJkODdlOTkwZTAzNmJiYmMyZjkxZWUxODMyZTc2NWVh ZDhmYjAxMC4uMzIxZDlmNzJjZDkzYzgyYjNlMTk1MzA0NDI5ODJmNjRlMmFmZmExZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDE0LTAyLTA4ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgW0FTYW5dIEZpeCBidWlsZCBmYWlsdXJlcyBpbiBUb29scyBkdWUgdG8gbWlzc2luZyAk KGluaGVyaXRlZCkgdmFsdWVzCisgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzEyODQ4NT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIER1bXBS ZW5kZXJUcmVlL21hYy9Db25maWd1cmF0aW9ucy9EdW1wUmVuZGVyVHJlZS54Y2NvbmZpZzoKKyAg ICAgICAgLSBNb3ZlICQoaW5oZXJpdGVkKSBmcm9tIE9USEVSX0xERkxBR1NfbWFjb3N4IHRvIE9U SEVSX0xERkxBR1MuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvQ29uZmlndXJhdGlv bnMvSW1hZ2VEaWZmLnhjY29uZmlnOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL21hYy9Db25m aWd1cmF0aW9ucy9MYXlvdXRUZXN0SGVscGVyLnhjY29uZmlnOgorICAgICAgICAtIEFkZCAkKGlu aGVyaXRlZCkgdG8gT1RIRVJfTERGTEFHUy4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIv Q29uZmlndXJhdGlvbnMvSW5qZWN0ZWRCdW5kbGUueGNjb25maWc6CisgICAgICAgICogV2ViS2l0 VGVzdFJ1bm5lci9Db25maWd1cmF0aW9ucy9XZWJLaXRUZXN0UnVubmVyLnhjY29uZmlnOgorICAg ICAgICAtIEFkZCAkKGluaGVyaXRlZCkgdG8gT1RIRVJfTERGTEFHUywgb3IgbW92ZSBmcm9tCisg ICAgICAgICAgT1RIRVJfTERGTEFHU19CQVNFIHRvIE9USEVSX0xERkxBR1MuCisgICAgICAgIC0g RXh0cmFjdCAkKE9USEVSX0xERkxBR1NfQkFTRSkgZnJvbSBwbGF0Zm9ybS1zcGVjaWZpYyBzZXR0 aW5ncworICAgICAgICAgIGludG8gT1RIRVJfTERGTEFHUy4KKwogMjAxNC0wMi0wOCAgUmFqYXJh bSBHYXVua2VyICA8emltYmFiYW9AZ21haWwuY29tPgogCiAgICAgICAgIFtHVEtdIEFkZCBzdGRs aWIgaW5jbHVkZSBmaWxlIHRvIGZpeCBJbWFnZURpZmYgYnVpbGQgd2l0aCBsaWJjKysKZGlmZiAt LWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9Db25maWd1cmF0aW9ucy9EdW1wUmVuZGVy VHJlZS54Y2NvbmZpZyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9Db25maWd1cmF0aW9ucy9E dW1wUmVuZGVyVHJlZS54Y2NvbmZpZwppbmRleCAwNjlhMzllYjBiYTlmZjk0Zjk1Nzg5MDQxYjM5 NDk1NmY5NDgzYjM2Li44Njc1Mzc1ODRkODc2MmMzZmQ4OTM5ZGUwZTcyNjM2ZTA3NGVlMTAxIDEw MDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMvQ29uZmlndXJhdGlvbnMvRHVtcFJl bmRlclRyZWUueGNjb25maWcKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0NvbmZpZ3Vy YXRpb25zL0R1bXBSZW5kZXJUcmVlLnhjY29uZmlnCkBAIC0yMyw4ICsyMyw4IEBACiAKICNpbmNs dWRlICJCYXNlVGFyZ2V0LnhjY29uZmlnIgogCi1PVEhFUl9MREZMQUdTID0gJChPVEhFUl9MREZM QUdTXyQoUExBVEZPUk1fTkFNRSkpOwotT1RIRVJfTERGTEFHU19tYWNvc3ggPSAkKGluaGVyaXRl ZCkgLWwkKFdFQktJVF9TWVNURU1fSU5URVJGQUNFX0xJQlJBUlkpIC1sV2ViQ29yZVRlc3RTdXBw b3J0IC1mb3JjZV9sb2FkICQoQlVJTFRfUFJPRFVDVFNfRElSKS9saWJEdW1wUmVuZGVyVHJlZS5h IC1mcmFtZXdvcmsgQ2FyYm9uIC1mcmFtZXdvcmsgQ29jb2EgLWZyYW1ld29yayBKYXZhU2NyaXB0 Q29yZSAtZnJhbWV3b3JrIE9wZW5HTCAtZnJhbWV3b3JrIFdlYktpdDsKK09USEVSX0xERkxBR1Mg PSAkKGluaGVyaXRlZCkgJChPVEhFUl9MREZMQUdTXyQoUExBVEZPUk1fTkFNRSkpOworT1RIRVJf TERGTEFHU19tYWNvc3ggPSAtbCQoV0VCS0lUX1NZU1RFTV9JTlRFUkZBQ0VfTElCUkFSWSkgLWxX ZWJDb3JlVGVzdFN1cHBvcnQgLWZvcmNlX2xvYWQgJChCVUlMVF9QUk9EVUNUU19ESVIpL2xpYkR1 bXBSZW5kZXJUcmVlLmEgLWZyYW1ld29yayBDYXJib24gLWZyYW1ld29yayBDb2NvYSAtZnJhbWV3 b3JrIEphdmFTY3JpcHRDb3JlIC1mcmFtZXdvcmsgT3BlbkdMIC1mcmFtZXdvcmsgV2ViS2l0Owog TERfUlVOUEFUSF9TRUFSQ0hfUEFUSFMgPSAiQGxvYWRlcl9wYXRoLy4iOwogUFJPRFVDVF9OQU1F ID0gRHVtcFJlbmRlclRyZWU7CiBFWENMVURFRF9TT1VSQ0VfRklMRV9OQU1FUyA9ICQoRVhDTFVE RURfU09VUkNFX0ZJTEVfTkFNRVNfJChQTEFURk9STV9OQU1FKSk7CmRpZmYgLS1naXQgYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9tYWMvQ29uZmlndXJhdGlvbnMvSW1hZ2VEaWZmLnhjY29uZmlnIGIv VG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0NvbmZpZ3VyYXRpb25zL0ltYWdlRGlmZi54Y2NvbmZp ZwppbmRleCAzNThhNGMwNDUwNGUwOGRlYzVhZDEyNGQwMzg5OGFmMzRjYmZjYmY0Li43MmM4ZDZj MTE4YzAwZDhmZjRiODZmNmE1Y2FhNjg0MDBkMDQyNTg1IDEwMDY0NAotLS0gYS9Ub29scy9EdW1w UmVuZGVyVHJlZS9tYWMvQ29uZmlndXJhdGlvbnMvSW1hZ2VEaWZmLnhjY29uZmlnCisrKyBiL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL21hYy9Db25maWd1cmF0aW9ucy9JbWFnZURpZmYueGNjb25maWcK QEAgLTI0LDcgKzI0LDcgQEAKICNpbmNsdWRlICJCYXNlVGFyZ2V0LnhjY29uZmlnIgogCiBQUk9E VUNUX05BTUUgPSBJbWFnZURpZmY7Ci1PVEhFUl9MREZMQUdTID0gJChPVEhFUl9MREZMQUdTXyQo UExBVEZPUk1fTkFNRSkpOworT1RIRVJfTERGTEFHUyA9ICQoaW5oZXJpdGVkKSAkKE9USEVSX0xE RkxBR1NfJChQTEFURk9STV9OQU1FKSk7CiBPVEhFUl9MREZMQUdTX21hY29zeCA9IC1mcmFtZXdv cmsgQ2FyYm9uIC1mcmFtZXdvcmsgQ29jb2EgLWZyYW1ld29yayBRdWFydHpDb3JlOwogT1RIRVJf TERGTEFHU19pcGhvbmVvcyA9IC1mcmFtZXdvcmsgQ29yZUZvdW5kYXRpb24gLWZyYW1ld29yayBD b3JlR3JhcGhpY3MgLWZyYW1ld29yayBNb2JpbGVDb3JlU2VydmljZXMgLWZyYW1ld29yayBJbWFn ZUlPOwogT1RIRVJfTERGTEFHU19pcGhvbmVzaW11bGF0b3IgPSAkKE9USEVSX0xERkxBR1NfaXBo b25lb3MpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0NvbmZpZ3VyYXRp b25zL0xheW91dFRlc3RIZWxwZXIueGNjb25maWcgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMv Q29uZmlndXJhdGlvbnMvTGF5b3V0VGVzdEhlbHBlci54Y2NvbmZpZwppbmRleCA4MjE5NzIxYzhk MjQ5ZGI0NmViNWY1M2VlMDY2NjE4MzIwYmJmMmI3Li5iZjFlOWQyZDUyMDNkMzdkZjFiNzIxODZh YTViOGQ3ODg0Mjc2NDBmIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMvQ29u ZmlndXJhdGlvbnMvTGF5b3V0VGVzdEhlbHBlci54Y2NvbmZpZworKysgYi9Ub29scy9EdW1wUmVu ZGVyVHJlZS9tYWMvQ29uZmlndXJhdGlvbnMvTGF5b3V0VGVzdEhlbHBlci54Y2NvbmZpZwpAQCAt MjUsNSArMjUsNSBAQAogCiAjaW5jbHVkZSAiQmFzZVRhcmdldC54Y2NvbmZpZyIKIAotT1RIRVJf TERGTEFHUyA9ICQoT1RIRVJfTERGTEFHU18kKFBMQVRGT1JNX05BTUUpKTsKK09USEVSX0xERkxB R1MgPSAkKGluaGVyaXRlZCkgJChPVEhFUl9MREZMQUdTXyQoUExBVEZPUk1fTkFNRSkpOwogT1RI RVJfTERGTEFHU19tYWNvc3ggPSAtZnJhbWV3b3JrIENhcmJvbiAtZnJhbWV3b3JrIENvY29hIC1m cmFtZXdvcmsgT3BlbkdMIC1mcmFtZXdvcmsgSU9LaXQ7CmRpZmYgLS1naXQgYS9Ub29scy9XZWJL aXRUZXN0UnVubmVyL0NvbmZpZ3VyYXRpb25zL0luamVjdGVkQnVuZGxlLnhjY29uZmlnIGIvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9Db25maWd1cmF0aW9ucy9JbmplY3RlZEJ1bmRsZS54Y2NvbmZp ZwppbmRleCAzZjI4MTk0M2VhNTg5NTY5MmVkZjhhZGJjZDUwZTdkZjQ0ZmU3MzkzLi5lN2U0ZTJl NjYyMzI2ZjM1YWQ4ZTUxOWVlNjQ3NWQzOTkzZDZiOWNhIDEwMDY0NAotLS0gYS9Ub29scy9XZWJL aXRUZXN0UnVubmVyL0NvbmZpZ3VyYXRpb25zL0luamVjdGVkQnVuZGxlLnhjY29uZmlnCisrKyBi L1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvQ29uZmlndXJhdGlvbnMvSW5qZWN0ZWRCdW5kbGUueGNj b25maWcKQEAgLTI5LDExICsyOSwxMSBAQCBQUk9EVUNUX05BTUUgPSBXZWJLaXRUZXN0UnVubmVy SW5qZWN0ZWRCdW5kbGU7CiBJTlNUQUxMX1BBVEggPSAkKFNZU1RFTV9MSUJSQVJZX0RJUikvRnJh bWV3b3Jrcy9XZWJLaXQuZnJhbWV3b3JrL1ZlcnNpb25zL0EvUmVzb3VyY2VzOwogU0tJUF9JTlNU QUxMID0gTk87CiAKLU9USEVSX0xERkxBR1NfQkFTRSA9ICQoaW5oZXJpdGVkKSAtbCQoV0VCS0lU X1NZU1RFTV9JTlRFUkZBQ0VfTElCUkFSWSkgLWZyYW1ld29yayBRdWFydHpDb3JlOwotT1RIRVJf TERGTEFHUyA9ICQoT1RIRVJfTERGTEFHU18kKFBMQVRGT1JNX05BTUUpKTsKLU9USEVSX0xERkxB R1NfaXBob25lb3MgPSAkKE9USEVSX0xERkxBR1NfQkFTRSkgLWZyYW1ld29yayBDRk5ldHdvcmsg LWZyYW1ld29yayBDb3JlRm91bmRhdGlvbiAtZnJhbWV3b3JrIENvcmVHcmFwaGljcyAtZnJhbWV3 b3JrIEZvdW5kYXRpb24gLWZyYW1ld29yayBVSUtpdDsKK09USEVSX0xERkxBR1NfQkFTRSA9IC1s JChXRUJLSVRfU1lTVEVNX0lOVEVSRkFDRV9MSUJSQVJZKSAtZnJhbWV3b3JrIFF1YXJ0ekNvcmU7 CitPVEhFUl9MREZMQUdTID0gJChpbmhlcml0ZWQpICQoT1RIRVJfTERGTEFHU19CQVNFKSAkKE9U SEVSX0xERkxBR1NfJChQTEFURk9STV9OQU1FKSk7CitPVEhFUl9MREZMQUdTX2lwaG9uZW9zID0g LWZyYW1ld29yayBDRk5ldHdvcmsgLWZyYW1ld29yayBDb3JlRm91bmRhdGlvbiAtZnJhbWV3b3Jr IENvcmVHcmFwaGljcyAtZnJhbWV3b3JrIEZvdW5kYXRpb24gLWZyYW1ld29yayBVSUtpdDsKIE9U SEVSX0xERkxBR1NfaXBob25lc2ltdWxhdG9yID0gJChPVEhFUl9MREZMQUdTX2lwaG9uZW9zKTsK LU9USEVSX0xERkxBR1NfbWFjb3N4ID0gJChPVEhFUl9MREZMQUdTX0JBU0UpIC1mcmFtZXdvcmsg Q2FyYm9uIC1mcmFtZXdvcmsgQ29jb2E7CitPVEhFUl9MREZMQUdTX21hY29zeCA9IC1mcmFtZXdv cmsgQ2FyYm9uIC1mcmFtZXdvcmsgQ29jb2E7CiAKIEVYQ0xVREVEX1NPVVJDRV9GSUxFX05BTUVT ID0gJChFWENMVURFRF9TT1VSQ0VfRklMRV9OQU1FU18kKFBMQVRGT1JNX05BTUUpKTsKIEVYQ0xV REVEX1NPVVJDRV9GSUxFX05BTUVTX2lwaG9uZW9zID0gQWNjZXNzaWJpbGl0eUNvbnRyb2xsZXJN YWMubW0gQWNjZXNzaWJpbGl0eVRleHRNYXJrZXJNYWMubW0gQWNjZXNzaWJpbGl0eVVJRWxlbWVu dE1hYy5tbSBBY3RpdmF0ZUZvbnRzLm1tIEluamVjdGVkQnVuZGxlTWFjLm1tIEluamVjdGVkQnVu ZGxlUGFnZU1hYy5tbSBXZWJBcmNoaXZlRHVtcFN1cHBvcnRNYWMubW07CmRpZmYgLS1naXQgYS9U b29scy9XZWJLaXRUZXN0UnVubmVyL0NvbmZpZ3VyYXRpb25zL1dlYktpdFRlc3RSdW5uZXIueGNj b25maWcgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0NvbmZpZ3VyYXRpb25zL1dlYktpdFRlc3RS dW5uZXIueGNjb25maWcKaW5kZXggYzA3YWQyNGQxYTJkZDdlOGU5Y2Q1NWRjYzJmMjliYTNhN2Ji NjNlNS4uNjZlYjAxNmFiZWEwMzI1NjM5Njc1MGQ4ZGExN2RlMjE0ZDY1N2JjOCAxMDA2NDQKLS0t IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9Db25maWd1cmF0aW9ucy9XZWJLaXRUZXN0UnVubmVy LnhjY29uZmlnCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvQ29uZmlndXJhdGlvbnMvV2Vi S2l0VGVzdFJ1bm5lci54Y2NvbmZpZwpAQCAtMjcsMTAgKzI3LDEwIEBAIFBST0RVQ1RfTkFNRSA9 IFdlYktpdFRlc3RSdW5uZXIKIEdDQ19FTkFCTEVfT0JKQ19FWENFUFRJT05TID0gWUVTCiAKIE9U SEVSX0xERkxBR1NfQkFTRSA9IC1sJChXRUJLSVRfU1lTVEVNX0lOVEVSRkFDRV9MSUJSQVJZKSAt ZnJhbWV3b3JrIFdlYktpdDI7Ci1PVEhFUl9MREZMQUdTID0gJChPVEhFUl9MREZMQUdTXyQoUExB VEZPUk1fTkFNRSkpOwotT1RIRVJfTERGTEFHU19pcGhvbmVvcyA9ICQoT1RIRVJfTERGTEFHU19C QVNFKSAtZnJhbWV3b3JrIEphdmFTY3JpcHRDb3JlIC1mcmFtZXdvcmsgQ29yZUdyYXBoaWNzIC1m cmFtZXdvcmsgSW1hZ2VJTyAtZnJhbWV3b3JrIFVJS2l0OworT1RIRVJfTERGTEFHUyA9ICQoaW5o ZXJpdGVkKSAkKE9USEVSX0xERkxBR1NfQkFTRSkgJChPVEhFUl9MREZMQUdTXyQoUExBVEZPUk1f TkFNRSkpOworT1RIRVJfTERGTEFHU19pcGhvbmVvcyA9IC1mcmFtZXdvcmsgSmF2YVNjcmlwdENv cmUgLWZyYW1ld29yayBDb3JlR3JhcGhpY3MgLWZyYW1ld29yayBJbWFnZUlPIC1mcmFtZXdvcmsg VUlLaXQ7CiBPVEhFUl9MREZMQUdTX2lwaG9uZXNpbXVsYXRvciA9ICQoT1RIRVJfTERGTEFHU19p cGhvbmVvcyk7Ci1PVEhFUl9MREZMQUdTX21hY29zeCA9ICQoT1RIRVJfTERGTEFHU19CQVNFKSAt ZnJhbWV3b3JrIENhcmJvbiAtZnJhbWV3b3JrIENvY29hOworT1RIRVJfTERGTEFHU19tYWNvc3gg PSAtZnJhbWV3b3JrIENhcmJvbiAtZnJhbWV3b3JrIENvY29hOwogCiBJTlNUQUxMX1BBVEggPSAk KFNZU1RFTV9MSUJSQVJZX0RJUikvRnJhbWV3b3Jrcy9XZWJLaXQuZnJhbWV3b3JrL1ZlcnNpb25z L0EvUmVzb3VyY2VzOwogU0tJUF9JTlNUQUxMID0gTk87Cg==