128483 2014-02-08 19:39:49 -0800 Simplify single character substrings in JSC 2014-02-09 00:13:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified REOPENED P2 Normal --- 128491 1 andersca andersca commit-queue rniwa oldest_to_newest 978498 0 andersca 2014-02-08 19:39:49 -0800 Simplify single character substrings in JSC 978501 1 223601 andersca 2014-02-08 19:41:40 -0800 Created attachment 223601 Patch 978502 2 223601 kling 2014-02-08 19:43:21 -0800 Comment on attachment 223601 Patch Nice ;D 978503 3 andersca 2014-02-08 19:47:01 -0800 Committed r163737: <http://trac.webkit.org/changeset/163737> 978538 4 rniwa 2014-02-08 23:59:04 -0800 Looks like this patch broke 10 tests: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/3233 978539 5 rniwa 2014-02-09 00:01:48 -0800 e.g. --- /Volumes/Data/slave/mavericks-release-tests-wk1/build/layout-test-results/fast/lists/w3-css3-list-styles-alphabetic-expected.txt +++ /Volumes/Data/slave/mavericks-release-tests-wk1/build/layout-test-results/fast/lists/w3-css3-list-styles-alphabetic-actual.txt @@ -11,82 +11,82 @@ PASS list marker is በ. PASS list marker is ተ. PASS list marker is ነ. -PASS list marker is አ. -PASS list marker is ከ. -PASS list marker is ወ. -PASS list marker is ዐ. -PASS list marker is የ. +FAIL list marker should be በ. Was አ. +FAIL list marker should be ሰ. Was ከ. +FAIL list marker should be ሐ. Was ወ. +FAIL list marker should be ለ. Was ዐ. +FAIL list marker should be ሀ. Was የ. PASS list marker is ደ. PASS list marker is ገ. PASS list marker is ጸ. PASS list marker is ፈ. ethiopic-halehame-aa-et 978542 6 commit-queue 2014-02-09 00:12:00 -0800 Re-opened since this is blocked by bug 128491 978545 7 rniwa 2014-02-09 00:13:16 -0800 I'm going to rollout the patch for now since neither kling nor I can spot the error and this is going to hose EWS if we kept it in trunk. 223601 2014-02-08 19:41:40 -0800 2014-02-08 19:43:21 -0800 Patch bug-128483-20140208194202.patch text/plain 4657 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy MmQxZjQxOGI0ZTMzMTE4MzIwNzYzNjAzYjcyOGE3OTQ2Y2E4MGJkLi5hYTMxZTFkMzA1ZTljNTI2 NjQ2NzFiZWFjYTI5MjRkNjQ2M2Y2OWRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxNC0wMi0wOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgorCisgICAgICAgIFNpbXBsaWZ5IHNpbmdsZSBjaGFyYWN0ZXIgc3Vic3RyaW5ncyBpbiBK U0MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODQ4 MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdpdGgg dGhlIHJlY2VudCB3b3JrIHRvIG1ha2UgU3RyaW5nSW1wbCBvY2N1cHkgbGVzcyBzcGFjZSwgaXQg aXMgYWN0dWFsbHkgbW9yZQorICAgICAgICBlZmZpY2llbnQgdG8gYWxsb2NhdGUgYSBzaW5nbGUg Y2hhcmFjdGVyIHN0cmluZyB0aGF0IGl0IGlzIHRvIHVzZSBjcmVhdGVTdWJzdHJpbmdTaGFyaW5n SW1wbCEKKyAgICAgICAgCisgICAgICAgICogcnVudGltZS9KU1N0cmluZy5oOgorICAgICAgICAo SlNDOjpqc1NpbmdsZUNoYXJhY3RlclN0cmluZyk6CisgICAgICAgIChKU0M6OmpzU2luZ2xlQ2hh cmFjdGVyU3Vic3RyaW5nKToKKyAgICAgICAgKEpTQzo6anNTdHJpbmcpOgorICAgICAgICAoSlND Ojpqc1N1YnN0cmluZzgpOgorICAgICAgICAqIHJ1bnRpbWUvU21hbGxTdHJpbmdzLmNwcDoKKyAg ICAgICAgKEpTQzo6U21hbGxTdHJpbmdzU3RvcmFnZTo6U21hbGxTdHJpbmdzU3RvcmFnZSk6Cisg ICAgICAgIChKU0M6OlNtYWxsU3RyaW5nczo6U21hbGxTdHJpbmdzKToKKwogMjAxNC0wMi0wOCAg TWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIEJhc2Vs aW5lIEpJVCB1c2VzIHRoZSB3cm9uZyB2ZXJzaW9uIG9mIGNoZWNrTWFya1dvcmQgaW4gZW1pdFdy aXRlQmFycmllcgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNT dHJpbmcuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nLmgKaW5kZXgg NGVjODJkODhiMTA1OGM3Nzg2YTFmYTM1MmI2NGEyOTc2MTk4ZTI0Mi4uODFiYTM1YTQ4NWI5ZWQx MmYxNDg0ZWJkZGExNjc4YzBlOGQ0NGNiMCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvSlNTdHJpbmcuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU1N0cmluZy5oCkBAIC0zNTAsNyArMzUwLDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgewog ICAgICAgICBpZiAoYyA8PSBtYXhTaW5nbGVDaGFyYWN0ZXJTdHJpbmcpCiAgICAgICAgICAgICBy ZXR1cm4gdm0tPnNtYWxsU3RyaW5ncy5zaW5nbGVDaGFyYWN0ZXJTdHJpbmcoYyk7Ci0gICAgICAg IHJldHVybiBKU1N0cmluZzo6Y3JlYXRlKCp2bSwgU3RyaW5nKCZjLCAxKS5pbXBsKCkpOworICAg ICAgICByZXR1cm4gSlNTdHJpbmc6OmNyZWF0ZSgqdm0sIFN0cmluZ0ltcGw6OmNyZWF0ZSgmYywg MSkpOwogICAgIH0KIAogICAgIEFMV0FZU19JTkxJTkUgSlNTdHJpbmcqIGpzU2luZ2xlQ2hhcmFj dGVyU3Vic3RyaW5nKEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgU3RyaW5nJiBzLCB1bnNpZ25lZCBv ZmZzZXQpCkBAIC0zNTgsOSArMzU4LDggQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIFZNKiB2 bSA9ICZleGVjLT52bSgpOwogICAgICAgICBBU1NFUlQob2Zmc2V0IDwgc3RhdGljX2Nhc3Q8dW5z aWduZWQ+KHMubGVuZ3RoKCkpKTsKICAgICAgICAgVUNoYXIgYyA9IHMuY2hhcmFjdGVyQXQob2Zm c2V0KTsKLSAgICAgICAgaWYgKGMgPD0gbWF4U2luZ2xlQ2hhcmFjdGVyU3RyaW5nKQotICAgICAg ICAgICAgcmV0dXJuIHZtLT5zbWFsbFN0cmluZ3Muc2luZ2xlQ2hhcmFjdGVyU3RyaW5nKGMpOwot ICAgICAgICByZXR1cm4gSlNTdHJpbmc6OmNyZWF0ZSgqdm0sIFN0cmluZ0ltcGw6OmNyZWF0ZVN1 YnN0cmluZ1NoYXJpbmdJbXBsKHMuaW1wbCgpLCBvZmZzZXQsIDEpKTsKKyAgICAgICAgCisgICAg ICAgIHJldHVybiBqc1NpbmdsZUNoYXJhY3RlclN0cmluZyh2bSwgYyk7CiAgICAgfQogCiAgICAg aW5saW5lIEpTU3RyaW5nKiBqc05vbnRyaXZpYWxTdHJpbmcoVk0qIHZtLCBjb25zdCBTdHJpbmcm IHMpCkBAIC0zOTksOCArMzk4LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgICAgICByZXR1 cm4gdm0tPnNtYWxsU3RyaW5ncy5lbXB0eVN0cmluZygpOwogICAgICAgICBpZiAoc2l6ZSA9PSAx KSB7CiAgICAgICAgICAgICBVQ2hhciBjID0gcy5jaGFyYWN0ZXJBdCgwKTsKLSAgICAgICAgICAg IGlmIChjIDw9IG1heFNpbmdsZUNoYXJhY3RlclN0cmluZykKLSAgICAgICAgICAgICAgICByZXR1 cm4gdm0tPnNtYWxsU3RyaW5ncy5zaW5nbGVDaGFyYWN0ZXJTdHJpbmcoYyk7CisgICAgICAgICAg ICByZXR1cm4ganNTaW5nbGVDaGFyYWN0ZXJTdHJpbmcodm0sIGMpOwogICAgICAgICB9CiAgICAg ICAgIHJldHVybiBKU1N0cmluZzo6Y3JlYXRlKCp2bSwgcy5pbXBsKCkpOwogICAgIH0KQEAgLTQy NSw4ICs0MjMsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgIHJldHVybiB2bS0+c21h bGxTdHJpbmdzLmVtcHR5U3RyaW5nKCk7CiAgICAgICAgIGlmIChsZW5ndGggPT0gMSkgewogICAg ICAgICAgICAgVUNoYXIgYyA9IHMuY2hhcmFjdGVyQXQob2Zmc2V0KTsKLSAgICAgICAgICAgIGlm IChjIDw9IG1heFNpbmdsZUNoYXJhY3RlclN0cmluZykKLSAgICAgICAgICAgICAgICByZXR1cm4g dm0tPnNtYWxsU3RyaW5ncy5zaW5nbGVDaGFyYWN0ZXJTdHJpbmcoYyk7CisgICAgICAgICAgICBy ZXR1cm4ganNTaW5nbGVDaGFyYWN0ZXJTdHJpbmcodm0sIGMpOwogICAgICAgICB9CiAgICAgICAg IHJldHVybiBKU1N0cmluZzo6Y3JlYXRlSGFzT3RoZXJPd25lcigqdm0sIFN0cmluZ0ltcGw6OmNy ZWF0ZVN1YnN0cmluZ1NoYXJpbmdJbXBsOChzLmltcGwoKSwgb2Zmc2V0LCBsZW5ndGgpKTsKICAg ICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TbWFsbFN0cmlu Z3MuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU21hbGxTdHJpbmdzLmNwcApp bmRleCBmODg5N2RmYTlkMGE2OGY2MjA0YThlNDU0OTgyMjI1N2RlMTA4YzZjLi5hNWJiYmY4NzFk MTVjMGZhYTRjMDBiZTBiMjg4YmY5MDRmMDk5NWVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9TbWFsbFN0cmluZ3MuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1NtYWxsU3RyaW5ncy5jcHAKQEAgLTU0LDExICs1NCw5IEBAIHByaXZhdGU6 CiAKIFNtYWxsU3RyaW5nc1N0b3JhZ2U6OlNtYWxsU3RyaW5nc1N0b3JhZ2UoKQogewotICAgIExD aGFyKiBjaGFyYWN0ZXJCdWZmZXIgPSAwOwotICAgIFJlZlB0cjxTdHJpbmdJbXBsPiBiYXNlU3Ry aW5nID0gU3RyaW5nSW1wbDo6Y3JlYXRlVW5pbml0aWFsaXplZChzaW5nbGVDaGFyYWN0ZXJTdHJp bmdDb3VudCwgY2hhcmFjdGVyQnVmZmVyKTsKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwg c2luZ2xlQ2hhcmFjdGVyU3RyaW5nQ291bnQ7ICsraSkgewotICAgICAgICBjaGFyYWN0ZXJCdWZm ZXJbaV0gPSBpOwotICAgICAgICBtX3JlcHNbaV0gPSBTdHJpbmdJbXBsOjpjcmVhdGVTdWJzdHJp bmdTaGFyaW5nSW1wbChiYXNlU3RyaW5nLCBpLCAxKTsKKyAgICAgICAgTENoYXIgY2hhcmFjdGVy ID0gaTsKKyAgICAgICAgbV9yZXBzW2ldID0gU3RyaW5nSW1wbDo6Y3JlYXRlKCZjaGFyYWN0ZXIs IDEpOwogICAgIH0KIH0KIApAQCAtNjgsMTAgKzY2LDEwIEBAIFNtYWxsU3RyaW5nczo6U21hbGxT dHJpbmdzKCkKICAgICBKU0NfQ09NTU9OX1NUUklOR1NfRUFDSF9OQU1FKEpTQ19DT01NT05fU1RS SU5HU19BVFRSSUJVVEVfSU5JVElBTElaRSkKICN1bmRlZiBKU0NfQ09NTU9OX1NUUklOR1NfQVRU UklCVVRFX0lOSVRJQUxJWkUKIHsKLSAgICBDT01QSUxFX0FTU0VSVChzaW5nbGVDaGFyYWN0ZXJT dHJpbmdDb3VudCA9PSBzaXplb2YobV9zaW5nbGVDaGFyYWN0ZXJTdHJpbmdzKSAvIHNpemVvZiht X3NpbmdsZUNoYXJhY3RlclN0cmluZ3NbMF0pLCBJc051bUNoYXJhY3RlcnNDb25zdEluU3luY1dp dGhDbGFzc1VzYWdlKTsKKyAgICBzdGF0aWNfYXNzZXJ0KHNpbmdsZUNoYXJhY3RlclN0cmluZ0Nv dW50ID09IFdURl9BUlJBWV9MRU5HVEgobV9zaW5nbGVDaGFyYWN0ZXJTdHJpbmdzKSwgIiIpOwog CiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IHNpbmdsZUNoYXJhY3RlclN0cmluZ0NvdW50 OyArK2kpCi0gICAgICAgIG1fc2luZ2xlQ2hhcmFjdGVyU3RyaW5nc1tpXSA9IDA7CisgICAgICAg IG1fc2luZ2xlQ2hhcmFjdGVyU3RyaW5nc1tpXSA9IG51bGxwdHI7CiB9CiAKIHZvaWQgU21hbGxT dHJpbmdzOjppbml0aWFsaXplQ29tbW9uU3RyaW5ncyhWTSYgdm0pCg==