128463 2014-02-08 11:46:04 -0800 [GTK] Minibrowser: During text search, make navigation through list of matched words circular 2014-02-10 04:57:38 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpino webkit-unassigned cgarcia commit-queue oldest_to_newest 978398 0 dpino 2014-02-08 11:46:04 -0800 Navigation through the list of matched search results using the 'Up' and 'Down' buttons doesn't work correctly. When the user reaches the last word, pressing the 'Down' button goes back to the search box and all highlighted words are unhighlighted. Pressing 'Down' again goes to the the first word although the matched words keep unhighlighted. The same happens in the opposite case, when reaching the first matched word and pressing 'Up'. Steps to reproduce: 1. In Minibrowser, Press 'Ctrl+F' to open up the search box. 2. Keep pressing button 'Down' until reaching the last matched element. 3. Press 'Down' again. Expected result: Navigation goes back to the first element. All the words keep highlighted. Actual result: Navigation goes back to the search box, the search box background becomes red and all highlighted words are unhighlighted. 978582 1 223625 dpino 2014-02-09 03:27:30 -0800 Created attachment 223625 Patch 978807 2 223625 cgarcia 2014-02-10 03:36:11 -0800 Comment on attachment 223625 Patch Thanks 978809 3 223625 commit-queue 2014-02-10 03:37:27 -0800 Comment on attachment 223625 Patch Rejecting attachment 223625 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 223625, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/6053250067333120 978819 4 223693 dpino 2014-02-10 04:16:11 -0800 Created attachment 223693 Patch 978832 5 223693 commit-queue 2014-02-10 04:57:36 -0800 Comment on attachment 223693 Patch Clearing flags on attachment: 223693 Committed r163778: <http://trac.webkit.org/changeset/163778> 978833 6 commit-queue 2014-02-10 04:57:38 -0800 All reviewed patches have been landed. Closing bug. 223625 2014-02-09 03:27:30 -0800 2014-02-10 04:16:04 -0800 Patch bug-128463-20140209122729.patch text/plain 1641 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNzMzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmJkODdlOTkwZTAzNmJiYmMyZjkxZWUxODMyZTc2NWVh ZDhmYjAxMC4uNzU2ZjQ4ZDU4MTUxMDUwNzgzOTRlMGVkNWUyZjQ0Y2IzNDU3ZTNkYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE0LTAyLTA5ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gTWluaWJyb3dzZXI6IER1cmluZyB0ZXh0IHNlYXJjaCwgbWFrZSBuYXZp Z2F0aW9uIHRocm91Z2ggbGlzdCBvZiBtYXRjaGVkIHdvcmRzIGNpcmN1bGFyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg0NjMKKworICAgICAgICBJ bml0aWFsaXplIHNlYXJjaCBvcHRpb25zIHRvIFdFQktJVF9GSU5EX09QVElPTlNfV1JBUF9BUk9V TkQgdG8gbWFrZSBuYXZpZ2F0aW9uCisgICAgICAgIGNpcmN1bGFyLgorCisgICAgICAgICogTWlu aUJyb3dzZXIvZ3RrL0Jyb3dzZXJTZWFyY2hCYXIuYzoKKyAgICAgICAgKGRvU2VhcmNoKToKKwog MjAxNC0wMi0wOCAgUmFqYXJhbSBHYXVua2VyICA8emltYmFiYW9AZ21haWwuY29tPgogCiAgICAg ICAgIFtHVEtdIEFkZCBzdGRsaWIgaW5jbHVkZSBmaWxlIHRvIGZpeCBJbWFnZURpZmYgYnVpbGQg d2l0aCBsaWJjKysKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyU2Vh cmNoQmFyLmMgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlclNlYXJjaEJhci5jCmluZGV4 IGEyMmI1NGFiNzg2MDllZGEwYThjZDc4OGVhNzdhZWI5OTUzZWViNTEuLjdlN2JmYmQ5ODQzMzZl NThlMGY1NzdhMzM5YTE1NDFmNjUyNTlkY2UgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2Vy L2d0ay9Ccm93c2VyU2VhcmNoQmFyLmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dz ZXJTZWFyY2hCYXIuYwpAQCAtNjMsNyArNjMsNyBAQCBzdGF0aWMgdm9pZCBkb1NlYXJjaChCcm93 c2VyU2VhcmNoQmFyICpzZWFyY2hCYXIpCiAgICAgaWYgKCFndGtfZW50cnlfZ2V0X2ljb25fc3Rv Y2soZW50cnksIEdUS19FTlRSWV9JQ09OX1NFQ09OREFSWSkpCiAgICAgICAgIGd0a19lbnRyeV9z ZXRfaWNvbl9mcm9tX3N0b2NrKGVudHJ5LCBHVEtfRU5UUllfSUNPTl9TRUNPTkRBUlksIEdUS19T VE9DS19DTEVBUik7CiAKLSAgICBXZWJLaXRGaW5kT3B0aW9ucyBvcHRpb25zID0gV0VCS0lUX0ZJ TkRfT1BUSU9OU19OT05FOworICAgIFdlYktpdEZpbmRPcHRpb25zIG9wdGlvbnMgPSBXRUJLSVRf RklORF9PUFRJT05TX1dSQVBfQVJPVU5EOwogICAgIGlmICghZ3RrX2NoZWNrX21lbnVfaXRlbV9n ZXRfYWN0aXZlKEdUS19DSEVDS19NRU5VX0lURU0oc2VhcmNoQmFyLT5jYXNlQ2hlY2tCdXR0b24p KSkKICAgICAgICAgb3B0aW9ucyB8PSBXRUJLSVRfRklORF9PUFRJT05TX0NBU0VfSU5TRU5TSVRJ VkU7CiAgICAgaWYgKGd0a19jaGVja19tZW51X2l0ZW1fZ2V0X2FjdGl2ZShHVEtfQ0hFQ0tfTUVO VV9JVEVNKHNlYXJjaEJhci0+YmVnZ2luaWdXb3JkQ2hlY2tCdXR0b24pKSkK 223693 2014-02-10 04:16:11 -0800 2014-02-10 04:57:36 -0800 Patch bug-128463-20140210131610.patch text/plain 1686 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNzMzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmJkODdlOTkwZTAzNmJiYmMyZjkxZWUxODMyZTc2NWVh ZDhmYjAxMC4uOTYwYTExNThjMjk1NmZlZmNiODFjZjcxYzNlN2ZkNWY4MzYzZTk2MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTAyLTA5ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gTWluaWJyb3dzZXI6IER1cmluZyB0ZXh0IHNlYXJjaCwgbWFrZSBuYXZp Z2F0aW9uIHRocm91Z2ggbGlzdCBvZiBtYXRjaGVkIHdvcmRzIGNpcmN1bGFyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg0NjMKKworICAgICAgICBS ZXZpZXdlZCBieSBDYXJsb3MgR2FyY2lhIENhbXBvcy4KKworICAgICAgICBJbml0aWFsaXplIHNl YXJjaCBvcHRpb25zIHRvIFdFQktJVF9GSU5EX09QVElPTlNfV1JBUF9BUk9VTkQgdG8gbWFrZSBu YXZpZ2F0aW9uCisgICAgICAgIGNpcmN1bGFyLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZ3Rr L0Jyb3dzZXJTZWFyY2hCYXIuYzoKKyAgICAgICAgKGRvU2VhcmNoKToKKwogMjAxNC0wMi0wOCAg UmFqYXJhbSBHYXVua2VyICA8emltYmFiYW9AZ21haWwuY29tPgogCiAgICAgICAgIFtHVEtdIEFk ZCBzdGRsaWIgaW5jbHVkZSBmaWxlIHRvIGZpeCBJbWFnZURpZmYgYnVpbGQgd2l0aCBsaWJjKysK ZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyU2VhcmNoQmFyLmMgYi9U b29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlclNlYXJjaEJhci5jCmluZGV4IGEyMmI1NGFiNzg2 MDllZGEwYThjZDc4OGVhNzdhZWI5OTUzZWViNTEuLjdlN2JmYmQ5ODQzMzZlNThlMGY1NzdhMzM5 YTE1NDFmNjUyNTlkY2UgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2Vy U2VhcmNoQmFyLmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJTZWFyY2hCYXIu YwpAQCAtNjMsNyArNjMsNyBAQCBzdGF0aWMgdm9pZCBkb1NlYXJjaChCcm93c2VyU2VhcmNoQmFy ICpzZWFyY2hCYXIpCiAgICAgaWYgKCFndGtfZW50cnlfZ2V0X2ljb25fc3RvY2soZW50cnksIEdU S19FTlRSWV9JQ09OX1NFQ09OREFSWSkpCiAgICAgICAgIGd0a19lbnRyeV9zZXRfaWNvbl9mcm9t X3N0b2NrKGVudHJ5LCBHVEtfRU5UUllfSUNPTl9TRUNPTkRBUlksIEdUS19TVE9DS19DTEVBUik7 CiAKLSAgICBXZWJLaXRGaW5kT3B0aW9ucyBvcHRpb25zID0gV0VCS0lUX0ZJTkRfT1BUSU9OU19O T05FOworICAgIFdlYktpdEZpbmRPcHRpb25zIG9wdGlvbnMgPSBXRUJLSVRfRklORF9PUFRJT05T X1dSQVBfQVJPVU5EOwogICAgIGlmICghZ3RrX2NoZWNrX21lbnVfaXRlbV9nZXRfYWN0aXZlKEdU S19DSEVDS19NRU5VX0lURU0oc2VhcmNoQmFyLT5jYXNlQ2hlY2tCdXR0b24pKSkKICAgICAgICAg b3B0aW9ucyB8PSBXRUJLSVRfRklORF9PUFRJT05TX0NBU0VfSU5TRU5TSVRJVkU7CiAgICAgaWYg KGd0a19jaGVja19tZW51X2l0ZW1fZ2V0X2FjdGl2ZShHVEtfQ0hFQ0tfTUVOVV9JVEVNKHNlYXJj aEJhci0+YmVnZ2luaWdXb3JkQ2hlY2tCdXR0b24pKSkK