128457 2014-02-08 10:17:49 -0800 Stop using getCharactersWithUpconvert in JavaScriptCore 2014-02-08 15:26:41 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue darin oldest_to_newest 978384 0 andersca 2014-02-08 10:17:49 -0800 Stop using getCharactersWithUpconvert in JavaScriptCore 978385 1 223570 andersca 2014-02-08 10:19:47 -0800 Created attachment 223570 Patch 978408 2 223570 kling 2014-02-08 12:43:21 -0800 Comment on attachment 223570 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223570&action=review Nice! r=me > Source/WTF/wtf/text/StringView.h:141 > + if (is8Bit()) > + return WTF::find(characters8(), length(), character, start); I wonder if it would be useful to have an early return here if 'character' is outside the LChar range. NABD. 978414 3 223570 ggaren 2014-02-08 13:11:51 -0800 Comment on attachment 223570 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223570&action=review > Source/JavaScriptCore/ChangeLog:9 > + if the source or replacement strings area 16-bit. "are" 978447 4 223570 commit-queue 2014-02-08 15:26:39 -0800 Comment on attachment 223570 Patch Clearing flags on attachment: 223570 Committed r163727: <http://trac.webkit.org/changeset/163727> 978448 5 commit-queue 2014-02-08 15:26:41 -0800 All reviewed patches have been landed. Closing bug. 223570 2014-02-08 10:19:47 -0800 2014-02-08 15:26:38 -0800 Patch bug-128457-20140208102007.patch text/plain 6644 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNzEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 MzEwNmU5ODU1YzM1YmViYjVmNTNiMmJhZWRmMTAzZjExYmU5YzUyLi4xOTY1OWYzYmZkYjg0YTRj MjRjYWFkOWE2MDZjZTIzMTc5MjAyZDgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNC0wMi0wOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgorCisgICAgICAgIFN0b3AgdXNpbmcgZ2V0Q2hhcmFjdGVyc1dpdGhVcGNvbnZlcnQgaW4g SmF2YVNjcmlwdENvcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyODQ1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIENoYW5nZSBzdWJzdGl0dXRlQmFja3JlZmVyZW5jZXNTbG93IHRvIHRha2UgU3RyaW5n Vmlld3MgYW5kIHVzZSBhIFN0cmluZ0J1aWxkZXIgaW5zdGVhZCBvZiB1cGNvbnZlcnRpbmcKKyAg ICAgICAgaWYgdGhlIHNvdXJjZSBvciByZXBsYWNlbWVudCBzdHJpbmdzIGFyZWEgMTYtYml0Lgor CisgICAgICAgICogcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwOgorICAgICAgICAoSlNDOjpz dWJzdGl0dXRlQmFja3JlZmVyZW5jZXNTbG93KToKKyAgICAgICAgKEpTQzo6c3Vic3RpdHV0ZUJh Y2tyZWZlcmVuY2VzKToKKwogMjAxNC0wMi0wOCAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29t PgogCiAgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjg0NTI+IERvbid0IGR1cGxpY2F0 ZSB0aGUgbGlzdCBvZiBpbnB1dCBmaWxlcyBmb3IgcG9zdHByb2Nlc3MtaGVhZGVycy5zaApkaWZm IC0tZ2l0IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRl eCBkMWJjODI0MTk2N2FlMzk2YWJjMmI4ODU4NzRiNTI2MWUwMmI5MmY4Li5jMjIxMzUwODE4OTAw YTUwNGZjYTdlM2M1OWU1ZWE0OGYzYmZhMjhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAy LTA4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgU3Rv cCB1c2luZyBnZXRDaGFyYWN0ZXJzV2l0aFVwY29udmVydCBpbiBKYXZhU2NyaXB0Q29yZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4NDU3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvdGV4dC9T dHJpbmdCdWlsZGVyLmg6CisgICAgICAgIChXVEY6OlN0cmluZ0J1aWxkZXI6OmFwcGVuZCk6Cisg ICAgICAgIEFkZCBhIG5ldyBvdmVybG9hZCB0aGF0IHRha2VzIGEgU3RyaW5nVmlldy4KKworICAg ICAgICAqIHd0Zi90ZXh0L1N0cmluZ1ZpZXcuaDoKKyAgICAgICAgKFdURjo6U3RyaW5nVmlldzo6 ZmluZCk6CisgICAgICAgIEFkZCBuZXcgZmluZCBtZW1iZXIgZnVuY3Rpb24uCisKIDIwMTQtMDIt MDggIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIENoYW5nZSBUZXh0 SXRlcmF0b3IgdG8gdXNlIFN0cmluZ1ZpZXcsIHByZXBhcmluZyB0byB3ZWFuIGl0IGZyb20gZGVw cmVjYXRlZENoYXJhY3RlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9T dHJpbmdQcm90b3R5cGUuY3BwCmluZGV4IGVmY2M0MGQ2NjczODdkZjA5NTU4MzUyODJmYTczYzdj MTBjNmYzYTIuLmJmMGFkNzQ3YTk4OTA0MzlmNTVlMWMyMDQyOWRhNzE5ZGE5NjU2NGEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcApA QCAtMTU3LDEwICsxNTcsOSBAQCBzdGF0aWMgaW5saW5lIEpTU3RyaW5nKiBqc1N0cmluZ1dpdGhS ZXVzZShFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgb3JpZ2luYWxWYWx1ZQogICAgIHJldHVybiBq c1N0cmluZyhleGVjLCBzdHJpbmcpOwogfQogCi10ZW1wbGF0ZSA8dHlwZW5hbWUgQ2hhclR5cGU+ Ci1zdGF0aWMgTkVWRVJfSU5MSU5FIFN0cmluZyBzdWJzdGl0dXRlQmFja3JlZmVyZW5jZXNTbG93 KGNvbnN0IFN0cmluZyYgcmVwbGFjZW1lbnQsIGNvbnN0IFN0cmluZyYgc291cmNlLCBjb25zdCBp bnQqIG92ZWN0b3IsIFJlZ0V4cCogcmVnLCBzaXplX3QgaSkKK3N0YXRpYyBORVZFUl9JTkxJTkUg U3RyaW5nIHN1YnN0aXR1dGVCYWNrcmVmZXJlbmNlc1Nsb3coU3RyaW5nVmlldyByZXBsYWNlbWVu dCwgU3RyaW5nVmlldyBzb3VyY2UsIGNvbnN0IGludCogb3ZlY3RvciwgUmVnRXhwKiByZWcsIHNp emVfdCBpKQogewotICAgIFZlY3RvcjxDaGFyVHlwZT4gc3Vic3RpdHV0ZWRSZXBsYWNlbWVudDsK KyAgICBTdHJpbmdCdWlsZGVyIHN1YnN0aXR1dGVkUmVwbGFjZW1lbnQ7CiAgICAgaW50IG9mZnNl dCA9IDA7CiAgICAgZG8gewogICAgICAgICBpZiAoaSArIDEgPT0gcmVwbGFjZW1lbnQubGVuZ3Ro KCkpCkBAIC0xNzAsNyArMTY5LDcgQEAgc3RhdGljIE5FVkVSX0lOTElORSBTdHJpbmcgc3Vic3Rp dHV0ZUJhY2tyZWZlcmVuY2VzU2xvdyhjb25zdCBTdHJpbmcmIHJlcGxhY2VtZW4KICAgICAgICAg aWYgKHJlZiA9PSAnJCcpIHsKICAgICAgICAgICAgIC8vICIkJCIgLT4gIiQiCiAgICAgICAgICAg ICArK2k7Ci0gICAgICAgICAgICBzdWJzdGl0dXRlZFJlcGxhY2VtZW50LmFwcGVuZChyZXBsYWNl bWVudC5nZXRDaGFyYWN0ZXJzV2l0aFVwY29udmVydDxDaGFyVHlwZT4oKSArIG9mZnNldCwgaSAt IG9mZnNldCk7CisgICAgICAgICAgICBzdWJzdGl0dXRlZFJlcGxhY2VtZW50LmFwcGVuZChyZXBs YWNlbWVudC5zdWJzdHJpbmcob2Zmc2V0LCBpIC0gb2Zmc2V0KSk7CiAgICAgICAgICAgICBvZmZz ZXQgPSBpICsgMTsKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICB9CkBAIC0yMTAsMjgg KzIwOSwyNSBAQCBzdGF0aWMgTkVWRVJfSU5MSU5FIFN0cmluZyBzdWJzdGl0dXRlQmFja3JlZmVy ZW5jZXNTbG93KGNvbnN0IFN0cmluZyYgcmVwbGFjZW1lbgogICAgICAgICAgICAgY29udGludWU7 CiAKICAgICAgICAgaWYgKGkgLSBvZmZzZXQpCi0gICAgICAgICAgICBzdWJzdGl0dXRlZFJlcGxh Y2VtZW50LmFwcGVuZChyZXBsYWNlbWVudC5nZXRDaGFyYWN0ZXJzV2l0aFVwY29udmVydDxDaGFy VHlwZT4oKSArIG9mZnNldCwgaSAtIG9mZnNldCk7CisgICAgICAgICAgICBzdWJzdGl0dXRlZFJl cGxhY2VtZW50LmFwcGVuZChyZXBsYWNlbWVudC5zdWJzdHJpbmcob2Zmc2V0LCBpIC0gb2Zmc2V0 KSk7CiAgICAgICAgIGkgKz0gMSArIGFkdmFuY2U7CiAgICAgICAgIG9mZnNldCA9IGkgKyAxOwog ICAgICAgICBpZiAoYmFja3JlZlN0YXJ0ID49IDApCi0gICAgICAgICAgICBzdWJzdGl0dXRlZFJl cGxhY2VtZW50LmFwcGVuZChzb3VyY2UuZ2V0Q2hhcmFjdGVyc1dpdGhVcGNvbnZlcnQ8Q2hhclR5 cGU+KCkgKyBiYWNrcmVmU3RhcnQsIGJhY2tyZWZMZW5ndGgpOworICAgICAgICAgICAgc3Vic3Rp dHV0ZWRSZXBsYWNlbWVudC5hcHBlbmQoc291cmNlLnN1YnN0cmluZyhiYWNrcmVmU3RhcnQsIGJh Y2tyZWZMZW5ndGgpKTsKICAgICB9IHdoaWxlICgoaSA9IHJlcGxhY2VtZW50LmZpbmQoJyQnLCBp ICsgMSkpICE9IG5vdEZvdW5kKTsKIAogICAgIGlmIChyZXBsYWNlbWVudC5sZW5ndGgoKSAtIG9m ZnNldCkKLSAgICAgICAgc3Vic3RpdHV0ZWRSZXBsYWNlbWVudC5hcHBlbmQocmVwbGFjZW1lbnQu Z2V0Q2hhcmFjdGVyc1dpdGhVcGNvbnZlcnQ8Q2hhclR5cGU+KCkgKyBvZmZzZXQsIHJlcGxhY2Vt ZW50Lmxlbmd0aCgpIC0gb2Zmc2V0KTsKKyAgICAgICAgc3Vic3RpdHV0ZWRSZXBsYWNlbWVudC5h cHBlbmQocmVwbGFjZW1lbnQuc3Vic3RyaW5nKG9mZnNldCkpOwogCi0gICAgc3Vic3RpdHV0ZWRS ZXBsYWNlbWVudC5zaHJpbmtUb0ZpdCgpOwotICAgIHJldHVybiBTdHJpbmc6OmFkb3B0KHN1YnN0 aXR1dGVkUmVwbGFjZW1lbnQpOworICAgIHJldHVybiBzdWJzdGl0dXRlZFJlcGxhY2VtZW50LnRv U3RyaW5nKCk7CiB9CiAKLXN0YXRpYyBpbmxpbmUgU3RyaW5nIHN1YnN0aXR1dGVCYWNrcmVmZXJl bmNlcyhjb25zdCBTdHJpbmcmIHJlcGxhY2VtZW50LCBjb25zdCBTdHJpbmcmIHNvdXJjZSwgY29u c3QgaW50KiBvdmVjdG9yLCBSZWdFeHAqIHJlZykKK3N0YXRpYyBpbmxpbmUgU3RyaW5nIHN1YnN0 aXR1dGVCYWNrcmVmZXJlbmNlcyhjb25zdCBTdHJpbmcmIHJlcGxhY2VtZW50LCBTdHJpbmdWaWV3 IHNvdXJjZSwgY29uc3QgaW50KiBvdmVjdG9yLCBSZWdFeHAqIHJlZykKIHsKICAgICBzaXplX3Qg aSA9IHJlcGxhY2VtZW50LmZpbmQoJyQnKTsKLSAgICBpZiAoVU5MSUtFTFkoaSAhPSBub3RGb3Vu ZCkpIHsKLSAgICAgICAgaWYgKHJlcGxhY2VtZW50LmlzOEJpdCgpICYmIHNvdXJjZS5pczhCaXQo KSkKLSAgICAgICAgICAgIHJldHVybiBzdWJzdGl0dXRlQmFja3JlZmVyZW5jZXNTbG93PExDaGFy PihyZXBsYWNlbWVudCwgc291cmNlLCBvdmVjdG9yLCByZWcsIGkpOwotICAgICAgICByZXR1cm4g c3Vic3RpdHV0ZUJhY2tyZWZlcmVuY2VzU2xvdzxVQ2hhcj4ocmVwbGFjZW1lbnQsIHNvdXJjZSwg b3ZlY3RvciwgcmVnLCBpKTsKLSAgICB9CisgICAgaWYgKFVOTElLRUxZKGkgIT0gbm90Rm91bmQp KQorICAgICAgICByZXR1cm4gc3Vic3RpdHV0ZUJhY2tyZWZlcmVuY2VzU2xvdyhyZXBsYWNlbWVu dCwgc291cmNlLCBvdmVjdG9yLCByZWcsIGkpOworCiAgICAgcmV0dXJuIHJlcGxhY2VtZW50Owog fQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuaCBiL1Nv dXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQnVpbGRlci5oCmluZGV4IDU2ZjY5OTRkNjgzNjQ2ZDBm NTQ3MzllY2EwYmU1ZGI0YjUxYjdlOGYuLjczOTk4ODUzNzA3OWEyYmUxOTAyZTQ2YmU5ZmQwNTU1 YTRmYWRjZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQnVpbGRlci5o CisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQnVpbGRlci5oCkBAIC0yOCw2ICsyOCw3 IEBACiAjZGVmaW5lIFN0cmluZ0J1aWxkZXJfaAogCiAjaW5jbHVkZSA8d3RmL3RleHQvQXRvbWlj U3RyaW5nLmg+CisjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nVmlldy5oPgogI2luY2x1ZGUgPHd0 Zi90ZXh0L1dURlN0cmluZy5oPgogCiBuYW1lc3BhY2UgV1RGIHsKQEAgLTg5LDYgKzkwLDE0IEBA IHB1YmxpYzoKICAgICAgICAgICAgIGFwcGVuZChvdGhlci5jaGFyYWN0ZXJzMTYoKSwgb3RoZXIu bV9sZW5ndGgpOwogICAgIH0KIAorICAgIHZvaWQgYXBwZW5kKFN0cmluZ1ZpZXcgc3RyaW5nVmll dykKKyAgICB7CisgICAgICAgIGlmIChzdHJpbmdWaWV3LmlzOEJpdCgpKQorICAgICAgICAgICAg YXBwZW5kKHN0cmluZ1ZpZXcuY2hhcmFjdGVyczgoKSwgc3RyaW5nVmlldy5sZW5ndGgoKSk7Cisg ICAgICAgIGVsc2UKKyAgICAgICAgICAgIGFwcGVuZChzdHJpbmdWaWV3LmNoYXJhY3RlcnMxNigp LCBzdHJpbmdWaWV3Lmxlbmd0aCgpKTsKKyAgICB9CisgICAgCiAgICAgdm9pZCBhcHBlbmQoY29u c3QgU3RyaW5nJiBzdHJpbmcsIHVuc2lnbmVkIG9mZnNldCwgdW5zaWduZWQgbGVuZ3RoKQogICAg IHsKICAgICAgICAgaWYgKCFzdHJpbmcubGVuZ3RoKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RG L3d0Zi90ZXh0L1N0cmluZ1ZpZXcuaCBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nVmlldy5o CmluZGV4IDA2ODk4OWZmMzM2MDZiZWIzMzkyMTYxNmM5NWZiMjJhMTFhODI0NTQuLjUyNTMzOWE4 ODMyYTRmNTlhYTY3NDVkZjliNmU2Nzc3ZDcyODQ2YWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv d3RmL3RleHQvU3RyaW5nVmlldy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nVmll dy5oCkBAIC0xMzUsNiArMTM1LDEzIEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIGNoYXJhY3Rl cnMxNigpW2luZGV4XTsKICAgICB9CiAKKyAgICBzaXplX3QgZmluZChVQ2hhciBjaGFyYWN0ZXIs IHVuc2lnbmVkIHN0YXJ0ID0gMCkgY29uc3QKKyAgICB7CisgICAgICAgIGlmIChpczhCaXQoKSkK KyAgICAgICAgICAgIHJldHVybiBXVEY6OmZpbmQoY2hhcmFjdGVyczgoKSwgbGVuZ3RoKCksIGNo YXJhY3Rlciwgc3RhcnQpOworICAgICAgICByZXR1cm4gV1RGOjpmaW5kKGNoYXJhY3RlcnMxNigp LCBsZW5ndGgoKSwgY2hhcmFjdGVyLCBzdGFydCk7CisgICAgfQorCiAjaWYgVVNFKENGKQogICAg IC8vIFRoaXMgZnVuY3Rpb24gY29udmVydHMgbnVsbCBzdHJpbmdzIHRvIGVtcHR5IHN0cmluZ3Mu CiAgICAgV1RGX0VYUE9SVF9TVFJJTkdfQVBJIFJldGFpblB0cjxDRlN0cmluZ1JlZj4gY3JlYXRl Q0ZTdHJpbmdXaXRob3V0Q29weWluZygpIGNvbnN0Owo=