128454 2014-02-08 07:32:26 -0800 ImageDiff compile fails when compiled with libc++ 2014-02-08 08:10:00 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED P2 Minor --- 1 zimbabao webkit-unassigned commit-queue zan oldest_to_newest 978365 0 zimbabao 2014-02-08 07:32:26 -0800 repro steps: Compile webkit using libc++. Observation: Following compile errors. Resolution: include cstdlib in ImageDiff.cpp. WebKit/Tools/ImageDiff/gtk/ImageDiff.cpp:103:61: error: use of undeclared identifier 'malloc'; did you mean 'g_malloc'? unsigned char* diffBuffer = static_cast<unsigned char*>(malloc(width * height)); ^~~~~~ g_malloc webkit_deps/include/glib-2.0/glib/gmem.h:78:10: note: 'g_malloc' declared here gpointer g_malloc (gsize n_bytes) G_GNUC_MALLOC G_GNUC_ALLOC_SIZE(1); ^ WebKit/Tools/ImageDiff/gtk/ImageDiff.cpp:147:5: error: use of undeclared identifier 'free' free(diffBuffer); ^ WebKit/Tools/ImageDiff/gtk/ImageDiff.cpp:207:30: error: use of undeclared identifier 'strtol' long imageSize = strtol(tokens[1], 0, 10); ^ 3 errors generated. 978366 1 223567 zimbabao 2014-02-08 07:38:09 -0800 Created attachment 223567 Patch 978368 2 223567 commit-queue 2014-02-08 08:09:57 -0800 Comment on attachment 223567 Patch Clearing flags on attachment: 223567 Committed r163711: <http://trac.webkit.org/changeset/163711> 978369 3 commit-queue 2014-02-08 08:10:00 -0800 All reviewed patches have been landed. Closing bug. 223567 2014-02-08 07:38:09 -0800 2014-02-08 08:09:57 -0800 Patch bug-128454-20140208210807.patch text/plain 993 zimbabao U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNjI1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjQ3NzFiN2E2ODgyZjY1NmE2NDZkZmM0Nzg0OWMzY2Jm ZDJjYjM0ZC4uMDNlZTA5NDc4YTZkZTc2ODBlZTkyOTU3ODJkNmJiYTdkOTY4ZTllYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE0LTAyLTA4ICBSYWphcmFtIEdhdW5rZXIgIDx6aW1iYWJhb0BnbWFpbC5jb20+CisK KyAgICAgICAgW0dUS10gQWRkIHN0ZGxpYiBpbmNsdWRlIGZpbGUgdG8gZml4IEltYWdlRGlmZiBi dWlsZCB3aXRoIGxpYmMrKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTI4NDU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBJbWFnZURpZmYvZ3RrL0ltYWdlRGlmZi5jcHA6CisKIDIwMTQtMDItMDcgIE1h bnVlbCBSZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10g RGlzYWJsZSBndGstZG9jIGluIEVXUwpkaWZmIC0tZ2l0IGEvVG9vbHMvSW1hZ2VEaWZmL2d0ay9J bWFnZURpZmYuY3BwIGIvVG9vbHMvSW1hZ2VEaWZmL2d0ay9JbWFnZURpZmYuY3BwCmluZGV4IDJj YjlmM2JjZTVhN2U2MjJhMzY0Y2I3YWU5ZTE1MWViOTZkZDZkYzYuLjgwOTAxMTY4NjMwY2U3OTE4 NTIxYTM1Y2FjNWI2MzE4OGUyMGJlMGQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0ltYWdlRGlmZi9ndGsv SW1hZ2VEaWZmLmNwcAorKysgYi9Ub29scy9JbWFnZURpZmYvZ3RrL0ltYWdlRGlmZi5jcHAKQEAg LTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlIDxhbGdvcml0aG0+CiAjaW5jbHVkZSA8Y21hdGg+CiAj aW5jbHVkZSA8Y3N0ZGlvPgorI2luY2x1ZGUgPGNzdGRsaWI+CiAjaW5jbHVkZSA8Y3N0cmluZz4K ICNpbmNsdWRlIDxnZGsvZ2RrLmg+CiAK