128449 2014-02-07 23:50:25 -0800 [GTK] Build break in WebKitWebViewBase.cpp::webkitWebViewBaseCreateWebPage 2014-02-08 01:21:51 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 piotr.grad webkit-unassigned berto cgarcia commit-queue gustavo mrobinson oldest_to_newest 978312 0 piotr.grad 2014-02-07 23:50:25 -0800 context->createWebPage is called with inproper parameter 978314 1 223556 piotr.grad 2014-02-07 23:52:31 -0800 Created attachment 223556 Patch 978316 2 commit-queue 2014-02-07 23:54:18 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 978317 3 223557 piotr.grad 2014-02-07 23:54:52 -0800 Created attachment 223557 Patch 978318 4 223557 cgarcia 2014-02-07 23:58:50 -0800 Comment on attachment 223557 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223557&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:957 > + webPageConfiguration.relatedPage = webkitWebViewBaseGetPage(webkitWebViewBase); This is not correct, you are using the page you are creating as the related page. You should not initialize the related page (it's already null at this point), is currently unimplemented in gtk+ port. 978336 5 223559 piotr.grad 2014-02-08 00:25:57 -0800 Created attachment 223559 Patch 978337 6 223559 cgarcia 2014-02-08 00:28:27 -0800 Comment on attachment 223559 Patch Thank you! 978339 7 223559 commit-queue 2014-02-08 00:31:11 -0800 Comment on attachment 223559 Patch Rejecting attachment 223559 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 223559, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebKit2/ChangeLog is not at the top of the file. Full output: http://webkit-queues.appspot.com/results/6059916125011968 978341 8 223559 cgarcia 2014-02-08 00:34:23 -0800 Comment on attachment 223559 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223559&action=review > Source/WebKit2/ChangeLog:3 > 2014-02-07 Piotr Grad <p.grad@samsung.com> > > +2014-02-07 Piotr Grad <p.grad@samsung.com> Right, this is wrong > Source/WebKit2/ChangeLog:15 > + > [GTK] Build break in WebKitSettings The date and author should be here. Please fix the changelog :-) 978346 9 223561 piotr.grad 2014-02-08 00:44:51 -0800 Created attachment 223561 Patch 978351 10 223561 commit-queue 2014-02-08 01:21:49 -0800 Comment on attachment 223561 Patch Clearing flags on attachment: 223561 Committed r163708: <http://trac.webkit.org/changeset/163708> 978352 11 commit-queue 2014-02-08 01:21:51 -0800 All reviewed patches have been landed. Closing bug. 223556 2014-02-07 23:52:31 -0800 2014-02-07 23:54:52 -0800 Patch patch.txt text/plain 1597 piotr.grad ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlY2ZiNGM2Li43YjliNTM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTQtMDItMDcgIFBpb3RyIEdyYWQgIDxwLmdyYWRAc2Ftc3VuZy5jb20+CiAKKyAgICAg ICAgW0dUS10gQnVpbGQgYnJlYWsgaW4gV2ViS2l0V2ViVmlld0Jhc2UuY3BwOjp3ZWJraXRXZWJW aWV3QmFzZUNyZWF0ZVdlYlBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyODQ0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFBhcmFtZXRlciBwYXNzZWQgdG8gY29udGV4dC0+Y3JlYXRlV2ViUGFnZSB3 YXMgaW5wcm9wZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3 QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZUNyZWF0ZVdlYlBhZ2UpOgorCisy MDE0LTAyLTA3ICBQaW90ciBHcmFkICA8cC5ncmFkQHNhbXN1bmcuY29tPgorCiAgICAgICAgIFtH VEtdIEJ1aWxkIGJyZWFrIGluIFdlYktpdFNldHRpbmdzCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg0NDYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCmluZGV4IDgzZTQy YWMuLjZlY2IwZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdFdlYlZpZXdCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKQEAgLTk1Miw3ICs5NTIsMTAgQEAgdm9pZCB3ZWJr aXRXZWJWaWV3QmFzZUNyZWF0ZVdlYlBhZ2UoV2ViS2l0V2ViVmlld0Jhc2UqIHdlYmtpdFdlYlZp ZXdCYXNlLCBXZWJDb24KIHsKICAgICBXZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUqIHByaXYgPSB3 ZWJraXRXZWJWaWV3QmFzZS0+cHJpdjsKIAotICAgIHByaXYtPnBhZ2VQcm94eSA9IGNvbnRleHQt PmNyZWF0ZVdlYlBhZ2UoKnByaXYtPnBhZ2VDbGllbnQsIHBhZ2VHcm91cCk7CisgICAgV2ViUGFn ZUNvbmZpZ3VyYXRpb24gd2ViUGFnZUNvbmZpZ3VyYXRpb247CisgICAgd2ViUGFnZUNvbmZpZ3Vy YXRpb24ucGFnZUdyb3VwID0gcGFnZUdyb3VwOworICAgIHdlYlBhZ2VDb25maWd1cmF0aW9uLnJl bGF0ZWRQYWdlID0gd2Via2l0V2ViVmlld0Jhc2VHZXRQYWdlKHdlYmtpdFdlYlZpZXdCYXNlKTsK KyAgICBwcml2LT5wYWdlUHJveHkgPSBjb250ZXh0LT5jcmVhdGVXZWJQYWdlKCpwcml2LT5wYWdl Q2xpZW50LCBzdGQ6Om1vdmUod2ViUGFnZUNvbmZpZ3VyYXRpb24pKTsKICAgICBwcml2LT5wYWdl UHJveHktPmluaXRpYWxpemVXZWJQYWdlKCk7CiAKICNpZiBVU0UoVEVYVFVSRV9NQVBQRVJfR0wp Cg== 223557 2014-02-07 23:54:52 -0800 2014-02-08 00:25:57 -0800 Patch patch.txt text/plain 1597 piotr.grad ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlY2ZiNGM2Li43YjliNTM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTQtMDItMDcgIFBpb3RyIEdyYWQgIDxwLmdyYWRAc2Ftc3VuZy5jb20+CiAKKzIwMTQt MDItMDcgIFBpb3RyIEdyYWQgIDxwLmdyYWRAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0dUS10g QnVpbGQgYnJlYWsgaW4gV2ViS2l0V2ViVmlld0Jhc2UuY3BwOjp3ZWJraXRXZWJWaWV3QmFzZUNy ZWF0ZVdlYlBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyODQ0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFBhcmFtZXRlciBwYXNzZWQgdG8gY29udGV4dC0+Y3JlYXRlV2ViUGFnZSB3YXMgaW5wcm9w ZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6 CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZUNyZWF0ZVdlYlBhZ2UpOgorCiAgICAgICAgIFtH VEtdIEJ1aWxkIGJyZWFrIGluIFdlYktpdFNldHRpbmdzCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg0NDYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCmluZGV4IDgzZTQy YWMuLjZlY2IwZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdFdlYlZpZXdCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKQEAgLTk1Miw3ICs5NTIsMTAgQEAgdm9pZCB3ZWJr aXRXZWJWaWV3QmFzZUNyZWF0ZVdlYlBhZ2UoV2ViS2l0V2ViVmlld0Jhc2UqIHdlYmtpdFdlYlZp ZXdCYXNlLCBXZWJDb24KIHsKICAgICBXZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUqIHByaXYgPSB3 ZWJraXRXZWJWaWV3QmFzZS0+cHJpdjsKIAotICAgIHByaXYtPnBhZ2VQcm94eSA9IGNvbnRleHQt PmNyZWF0ZVdlYlBhZ2UoKnByaXYtPnBhZ2VDbGllbnQsIHBhZ2VHcm91cCk7CisgICAgV2ViUGFn ZUNvbmZpZ3VyYXRpb24gd2ViUGFnZUNvbmZpZ3VyYXRpb247CisgICAgd2ViUGFnZUNvbmZpZ3Vy YXRpb24ucGFnZUdyb3VwID0gcGFnZUdyb3VwOworICAgIHdlYlBhZ2VDb25maWd1cmF0aW9uLnJl bGF0ZWRQYWdlID0gd2Via2l0V2ViVmlld0Jhc2VHZXRQYWdlKHdlYmtpdFdlYlZpZXdCYXNlKTsK KyAgICBwcml2LT5wYWdlUHJveHkgPSBjb250ZXh0LT5jcmVhdGVXZWJQYWdlKCpwcml2LT5wYWdl Q2xpZW50LCBzdGQ6Om1vdmUod2ViUGFnZUNvbmZpZ3VyYXRpb24pKTsKICAgICBwcml2LT5wYWdl UHJveHktPmluaXRpYWxpemVXZWJQYWdlKCk7CiAKICNpZiBVU0UoVEVYVFVSRV9NQVBQRVJfR0wp Cg== 223559 2014-02-08 00:25:57 -0800 2014-02-08 00:44:51 -0800 Patch patch.txt text/plain 1511 piotr.grad ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlY2ZiNGM2Li43YjliNTM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTQtMDItMDcgIFBpb3RyIEdyYWQgIDxwLmdyYWRAc2Ftc3VuZy5jb20+CiAKKzIwMTQt MDItMDcgIFBpb3RyIEdyYWQgIDxwLmdyYWRAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0dUS10g QnVpbGQgYnJlYWsgaW4gV2ViS2l0V2ViVmlld0Jhc2UuY3BwOjp3ZWJraXRXZWJWaWV3QmFzZUNy ZWF0ZVdlYlBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyODQ0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFBhcmFtZXRlciBwYXNzZWQgdG8gY29udGV4dC0+Y3JlYXRlV2ViUGFnZSB3YXMgaW5wcm9w ZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6 CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZUNyZWF0ZVdlYlBhZ2UpOgorCiAgICAgICAgIFtH VEtdIEJ1aWxkIGJyZWFrIGluIFdlYktpdFNldHRpbmdzCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg0NDYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCmluZGV4IDgzZTQy YWMuLjliOTZmMGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdFdlYlZpZXdCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKQEAgLTk1Miw3ICs5NTIsOSBAQCB2b2lkIHdlYmtp dFdlYlZpZXdCYXNlQ3JlYXRlV2ViUGFnZShXZWJLaXRXZWJWaWV3QmFzZSogd2Via2l0V2ViVmll d0Jhc2UsIFdlYkNvbgogewogICAgIFdlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZSogcHJpdiA9IHdl YmtpdFdlYlZpZXdCYXNlLT5wcml2OwogCi0gICAgcHJpdi0+cGFnZVByb3h5ID0gY29udGV4dC0+ Y3JlYXRlV2ViUGFnZSgqcHJpdi0+cGFnZUNsaWVudCwgcGFnZUdyb3VwKTsKKyAgICBXZWJQYWdl Q29uZmlndXJhdGlvbiB3ZWJQYWdlQ29uZmlndXJhdGlvbjsKKyAgICB3ZWJQYWdlQ29uZmlndXJh dGlvbi5wYWdlR3JvdXAgPSBwYWdlR3JvdXA7CisgICAgcHJpdi0+cGFnZVByb3h5ID0gY29udGV4 dC0+Y3JlYXRlV2ViUGFnZSgqcHJpdi0+cGFnZUNsaWVudCwgc3RkOjptb3ZlKHdlYlBhZ2VDb25m aWd1cmF0aW9uKSk7CiAgICAgcHJpdi0+cGFnZVByb3h5LT5pbml0aWFsaXplV2ViUGFnZSgpOwog CiAjaWYgVVNFKFRFWFRVUkVfTUFQUEVSX0dMKQo= 223561 2014-02-08 00:44:51 -0800 2014-02-08 01:21:49 -0800 Patch patch.txt text/plain 1511 piotr.grad ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlY2ZiNGM2Li43YjliNTM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTQtMDItMDcgIFBpb3RyIEdyYWQgIDxwLmdyYWRAc2Ftc3VuZy5jb20+CiAKKyAgICAg ICAgW0dUS10gQnVpbGQgYnJlYWsgaW4gV2ViS2l0V2ViVmlld0Jhc2UuY3BwOjp3ZWJraXRXZWJW aWV3QmFzZUNyZWF0ZVdlYlBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyODQ0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFBhcmFtZXRlciBwYXNzZWQgdG8gY29udGV4dC0+Y3JlYXRlV2ViUGFnZSB3 YXMgaW5wcm9wZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3 QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZUNyZWF0ZVdlYlBhZ2UpOgorCisy MDE0LTAyLTA3ICBQaW90ciBHcmFkICA8cC5ncmFkQHNhbXN1bmcuY29tPgorCiAgICAgICAgIFtH VEtdIEJ1aWxkIGJyZWFrIGluIFdlYktpdFNldHRpbmdzCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg0NDYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCmluZGV4IDgzZTQy YWMuLjliOTZmMGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdFdlYlZpZXdCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKQEAgLTk1Miw3ICs5NTIsOSBAQCB2b2lkIHdlYmtp dFdlYlZpZXdCYXNlQ3JlYXRlV2ViUGFnZShXZWJLaXRXZWJWaWV3QmFzZSogd2Via2l0V2ViVmll d0Jhc2UsIFdlYkNvbgogewogICAgIFdlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZSogcHJpdiA9IHdl YmtpdFdlYlZpZXdCYXNlLT5wcml2OwogCi0gICAgcHJpdi0+cGFnZVByb3h5ID0gY29udGV4dC0+ Y3JlYXRlV2ViUGFnZSgqcHJpdi0+cGFnZUNsaWVudCwgcGFnZUdyb3VwKTsKKyAgICBXZWJQYWdl Q29uZmlndXJhdGlvbiB3ZWJQYWdlQ29uZmlndXJhdGlvbjsKKyAgICB3ZWJQYWdlQ29uZmlndXJh dGlvbi5wYWdlR3JvdXAgPSBwYWdlR3JvdXA7CisgICAgcHJpdi0+cGFnZVByb3h5ID0gY29udGV4 dC0+Y3JlYXRlV2ViUGFnZSgqcHJpdi0+cGFnZUNsaWVudCwgc3RkOjptb3ZlKHdlYlBhZ2VDb25m aWd1cmF0aW9uKSk7CiAgICAgcHJpdi0+cGFnZVByb3h5LT5pbml0aWFsaXplV2ViUGFnZSgpOwog CiAjaWYgVVNFKFRFWFRVUkVfTUFQUEVSX0dMKQo=