128443 2014-02-07 22:26:36 -0800 Don't throw away code if there is code on the worklists 2014-02-07 23:03:29 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 128291 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg mmirman msaboff nrotem oliver sam zalan oldest_to_newest 978289 0 fpizlo 2014-02-07 22:26:36 -0800 Patch forthcoming. 978291 1 223551 fpizlo 2014-02-07 22:28:15 -0800 Created attachment 223551 the patch 978297 2 223551 joepeck 2014-02-07 22:35:41 -0800 Comment on attachment 223551 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=223551&action=review r=me > Source/JavaScriptCore/dfg/DFGWorklist.h:73 > + bool isActive() { return !!m_plans.size(); } Nit: const 978306 3 fpizlo 2014-02-07 22:51:33 -0800 Landed in http://trac.webkit.org/changeset/163695 978307 4 223551 ggaren 2014-02-07 23:03:00 -0800 Comment on attachment 223551 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=223551&action=review > Source/JavaScriptCore/heap/Heap.cpp:738 > + // If we have things on any worklist, then don't delete code. This is kind of > + // a weird heuristic. It's definitely not safe to throw away code that is on > + // the worklist. But this change was made in a hurry so we just avoid throwing What about when we throw away code to enable the debugger? 978308 5 fpizlo 2014-02-07 23:03:29 -0800 (In reply to comment #4) > (From update of attachment 223551 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223551&action=review > > > Source/JavaScriptCore/heap/Heap.cpp:738 > > + // If we have things on any worklist, then don't delete code. This is kind of > > + // a weird heuristic. It's definitely not safe to throw away code that is on > > + // the worklist. But this change was made in a hurry so we just avoid throwing > > What about when we throw away code to enable the debugger? That's a different code path. That code path first waits for the worklist to finish. 223551 2014-02-07 22:28:15 -0800 2014-02-07 23:03:00 -0800 the patch blah.patch text/plain 2888 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYzNjk0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE0LTAyLTA3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RG9uJ3QgdGhyb3cgYXdheSBjb2RlIGlmIHRoZXJlIGlzIGNvZGUgb24gdGhlIHdvcmtsaXN0cwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4NDQzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBJ ZiB3ZSB0aHJvdyBhd2F5IGNvbXBpbGVkIGNvZGUgYW5kIHRoZXJlIGlzIGNvZGUgY3VycmVudGx5 IGJlaW5nIEpJVGVkIHRoZW4gdGhlIEpJVAorICAgICAgICB3aWxsIGdldCBjb25mdXNlZCBhZnRl ciBpdCByZXN1bWVzOiBpdCB3aWxsIHNlZSBhIGNvZGUgYmxvY2sgdGhhdCBoYWQgY2xhaW1lZCB0 byBiZWxvbmcKKyAgICAgICAgdG8gYW4gZXhlY3V0YWJsZSBleGNlcHQgdGhhdCBpdCBkb2Vzbid0 IGJlbG9uZyB0byBhbnkgZXhlY3V0YWJsZXMgYW55bW9yZS4KKworICAgICAgICAqIGRmZy9ERkdX b3JrbGlzdC5oOgorICAgICAgICAoSlNDOjpERkc6OldvcmtsaXN0Ojppc0FjdGl2ZSk6CisgICAg ICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGVhcDo6ZGVsZXRlQWxsQ29tcGls ZWRDb2RlKToKKwogMjAxNC0wMi0wNyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgog CiAgICAgICAgIEdDIHNob3VsZCBzYWZlcG9pbnQgdGhlIERGRyB3b3JrbGlzdCBpbiBhIHNtYXJ0 ZXIgd2F5IHJhdGhlciB0aGFuIGp1c3Qgd2FpdGluZyBmb3IgZXZlcnl0aGluZyB0byBjb21wbGV0 ZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdXb3JrbGlzdC5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHV29ya2xpc3QuaAkocmV2aXNpb24g MTYzNjk0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdXb3JrbGlzdC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC03MCw2ICs3MCw4IEBAIHB1YmxpYzoKICAgICB2b2lkIHN1c3BlbmRBbGxU aHJlYWRzKCk7CiAgICAgdm9pZCByZXN1bWVBbGxUaHJlYWRzKCk7CiAgICAgCisgICAgYm9vbCBp c0FjdGl2ZSgpIHsgcmV0dXJuICEhbV9wbGFucy5zaXplKCk7IH0KKyAgICAKICAgICB2b2lkIHZp c2l0Q2hpbGRyZW4oU2xvdFZpc2l0b3ImLCBDb2RlQmxvY2tTZXQmKTsgLy8gT25seSBjYWxsZWQg b24gdGhlIG1haW4gdGhyZWFkIGFmdGVyIHN1c3BlbmRpbmcgYWxsIHRocmVhZHMuCiAgICAgCiAg ICAgdm9pZCBkdW1wKFByaW50U3RyZWFtJikgY29uc3Q7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaGVhcC9IZWFwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9IZWFwLmNwcAkocmV2aXNpb24gMTYzNjk0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvSGVhcC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTczMiw2ICs3MzIsMjIgQEAgdm9pZCBI ZWFwOjpkZWxldGVBbGxDb21waWxlZENvZGUoKQogICAgIC8vIHVwIGRlbGV0aW5nIGNvZGUgdGhh dCBpcyBsaXZlIG9uIHRoZSBzdGFjay4KICAgICBpZiAobV92bS0+ZW50cnlTY29wZSkKICAgICAg ICAgcmV0dXJuOworICAgIAorICAgIC8vIElmIHdlIGhhdmUgdGhpbmdzIG9uIGFueSB3b3JrbGlz dCwgdGhlbiBkb24ndCBkZWxldGUgY29kZS4gVGhpcyBpcyBraW5kIG9mCisgICAgLy8gYSB3ZWly ZCBoZXVyaXN0aWMuIEl0J3MgZGVmaW5pdGVseSBub3Qgc2FmZSB0byB0aHJvdyBhd2F5IGNvZGUg dGhhdCBpcyBvbgorICAgIC8vIHRoZSB3b3JrbGlzdC4gQnV0IHRoaXMgY2hhbmdlIHdhcyBtYWRl IGluIGEgaHVycnkgc28gd2UganVzdCBhdm9pZCB0aHJvd2luZworICAgIC8vIGF3YXkgYW55IGNv ZGUgaWYgdGhlcmUgaXMgYW55IGNvZGUgb24gYW55IHdvcmtsaXN0LiBJIHN1c3BlY3QgdGhhdCB0 aGlzCisgICAgLy8gbWlnaHQgbm90IGFjdHVhbGx5IGJlIHRvbyBkdW1iOiBpZiB0aGVyZSBpcyBj b2RlIG9uIHdvcmtsaXN0cyB0aGVuIHRoYXQKKyAgICAvLyBtZWFucyB0aGF0IHdlIGFyZSBydW5u aW5nIHNvbWUgaG90IEpTIGNvZGUgcmlnaHQgbm93LiBNYXliZSBjYXVzaW5nCisgICAgLy8gcmVj b21waWxhdGlvbnMgaXNuJ3QgYSBnb29kIGlkZWEuCisjaWYgRU5BQkxFKERGR19KSVQpCisgICAg Zm9yICh1bnNpZ25lZCBpID0gREZHOjpudW1iZXJPZldvcmtsaXN0cygpOyBpLS07KSB7CisgICAg ICAgIGlmIChERkc6OldvcmtsaXN0KiB3b3JrbGlzdCA9IERGRzo6d29ya2xpc3RGb3JJbmRleE9y TnVsbChpKSkgeworICAgICAgICAgICAgaWYgKHdvcmtsaXN0LT5pc0FjdGl2ZSgpKQorICAgICAg ICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorICAgIH0KKyNlbmRpZiAvLyBFTkFCTEUoREZH X0pJVCkKIAogICAgIGZvciAoRXhlY3V0YWJsZUJhc2UqIGN1cnJlbnQgPSBtX2NvbXBpbGVkQ29k ZS5oZWFkKCk7IGN1cnJlbnQ7IGN1cnJlbnQgPSBjdXJyZW50LT5uZXh0KCkpIHsKICAgICAgICAg aWYgKCFjdXJyZW50LT5pc0Z1bmN0aW9uRXhlY3V0YWJsZSgpKQo=