128437 2014-02-07 20:26:19 -0800 [ASan] Use new/delete in PODFreeListArena 2014-02-07 21:28:12 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer andersca ayao commit-queue dfarler ggaren jeffrey+webkit kling oliver sam oldest_to_newest 978265 0 ddkilzer 2014-02-07 20:26:19 -0800 The PODFreeListArena class doesn't actually deallocate objects when they're freed, so address sanitizer builds of WebKit won't catch use-after-free issues with objects that use it. 978268 1 223542 ddkilzer 2014-02-07 20:45:48 -0800 Created attachment 223542 Patch v1 978278 2 223542 commit-queue 2014-02-07 21:28:10 -0800 Comment on attachment 223542 Patch v1 Clearing flags on attachment: 223542 Committed r163693: <http://trac.webkit.org/changeset/163693> 978279 3 commit-queue 2014-02-07 21:28:12 -0800 All reviewed patches have been landed. Closing bug. 223542 2014-02-07 20:45:48 -0800 2014-02-07 21:28:10 -0800 Patch v1 bug-128437-20140207204547.patch text/plain 1971 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWE5OGE5MDM0N2YzMzg1 MDc3ODIxZWQ0OGVjM2ZlZTE0NDI5MjJhZC4uMjY0ZTA3Nzc1YjMzOWQwYmVmZDc5MGY4ZGFiNGU2 MTllMDkyOTE0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAyLTA3ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgW0FTYW5dIFVzZSBuZXcv ZGVsZXRlIGluIFBPREZyZWVMaXN0QXJlbmEKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2Iv MTI4NDM3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogcGxhdGZvcm0vUE9ERnJlZUxpc3RBcmVuYS5oOgorICAgICAgICAoV2ViQ29yZTo6UE9ERnJl ZUxpc3RBcmVuYTo6YWxsb2NhdGVPYmplY3QpOiBVc2UgbmV3IHdoZW4KKyAgICAgICAgQUREUkVT U19TQU5JVElaRVIgaXMgZGVmaW5lZC4KKyAgICAgICAgKFdlYkNvcmU6OlBPREZyZWVMaXN0QXJl bmE6OmZyZWVPYmplY3QpOiBVc2UgZGVsZXRlIHdoZW4KKyAgICAgICAgQUREUkVTU19TQU5JVEla RVIgaXMgZGVmaW5lZC4KKwogMjAxNC0wMi0wNiAgSmVyZW15IEpvbmVzICA8amVyZW15akBhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIEFWS2l0IGZ1bGxzY3JlZW4gdG8gV2Vi S2l0MgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUE9ERnJlZUxpc3RBcmVu YS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUE9ERnJlZUxpc3RBcmVuYS5oCmluZGV4IGRl ZTFhMTkwZTBlMzlhNGE0OThkZmMwY2I5M2Q0MWU2MGU1YjgxODcuLjliODMxNWZmMTk3NDNlNDhj ZTI0MWNlNGNhNTk2YzZhYzA3Y2M3ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL1BPREZyZWVMaXN0QXJlbmEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9QT0RG cmVlTGlzdEFyZW5hLmgKQEAgLTQwLDYgKzQwLDkgQEAgcHVibGljOgogCiAgICAgdGVtcGxhdGU8 Y2xhc3MgQXJndW1lbnQxVHlwZT4gVCogYWxsb2NhdGVPYmplY3QoY29uc3QgQXJndW1lbnQxVHlw ZSYgYXJndW1lbnQxKQogICAgIHsKKyNpZiBkZWZpbmVkKEFERFJFU1NfU0FOSVRJWkVSKQorICAg ICAgICByZXR1cm4gbmV3IFQoYXJndW1lbnQxKTsKKyNlbHNlCiAgICAgICAgIHNpemVfdCByb3Vu ZGVkU2l6ZSA9IHJvdW5kVXAoc2l6ZW9mKFQpLCBtaW5BbGlnbm1lbnQ8VD4oKSk7CiAgICAgICAg IHZvaWQqIHB0ciA9IGFsbG9jYXRlKHJvdW5kZWRTaXplKTsKICAgICAgICAgaWYgKHB0cikgewpA QCAtNDcsMTUgKzUwLDIwIEBAIHB1YmxpYzoKICAgICAgICAgICAgIG5ldyhwdHIpIFQoYXJndW1l bnQxKTsKICAgICAgICAgfQogICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8VCo+KHB0cik7Cisj ZW5kaWYKICAgICB9CiAKICAgICB2b2lkIGZyZWVPYmplY3QoVCogcHRyKQogICAgIHsKKyNpZiBk ZWZpbmVkKEFERFJFU1NfU0FOSVRJWkVSKQorICAgICAgICBkZWxldGUgcHRyOworI2Vsc2UKICAg ICAgICAgZm9yICh0eXBlbmFtZSBWZWN0b3I8T3duUHRyPEZyZWVMaXN0Q2h1bms+Pjo6Y29uc3Rf aXRlcmF0b3IgaXQgPSBtX2NodW5rcy5iZWdpbigpLCBlbmQgPSBtX2NodW5rcy5lbmQoKTsgaXQg IT0gZW5kOyArK2l0KSB7CiAgICAgICAgICAgICBGcmVlTGlzdENodW5rKiBjaHVuayA9IHN0YXRp Y19jYXN0PEZyZWVMaXN0Q2h1bmsqPihpdC0+Z2V0KCkpOwogICAgICAgICAgICAgaWYgKGNodW5r LT5jb250YWlucyhwdHIpKQogICAgICAgICAgICAgICAgIGNodW5rLT5mcmVlKHB0cik7CiAgICAg ICAgIH0KKyNlbmRpZgogICAgIH0KIAogcHJpdmF0ZToK