128424 2014-02-07 17:31:33 -0800 iOS port needs to clear VM::stackPointerAtVMEntry when it drops locks. 2014-02-07 18:03:00 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren mhahnenberg mmirman msaboff oliver oldest_to_newest 978200 0 mark.lam 2014-02-07 17:31:33 -0800 Patch coming. 978201 1 223525 mark.lam 2014-02-07 17:39:05 -0800 Created attachment 223525 the patch. 978202 2 223525 mark.lam 2014-02-07 17:39:46 -0800 Comment on attachment 223525 the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=223525&action=review > Source/JavaScriptCore/ChangeLog:9 > + in that it (iOS) does clear m_vm->stackPointerAtVMEntry nor reset the typo: "does" ==> "does not" 978203 3 223525 ggaren 2014-02-07 17:41:36 -0800 Comment on attachment 223525 the patch. r=me 978216 4 mark.lam 2014-02-07 17:57:09 -0800 Thanks. Landed in r163672: <http://trac.webkit.org/r163672>. 978219 5 mark.lam 2014-02-07 18:03:00 -0800 ref: <rdar://problem/16008492> 223525 2014-02-07 17:39:05 -0800 2014-02-07 17:41:36 -0800 the patch. bug-128424.patch text/plain 1959 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYzNjY5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE0LTAyLTA3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBp T1MgcG9ydCBuZWVkcyB0byBjbGVhciBWTTo6c3RhY2tQb2ludGVyQXRWTUVudHJ5IHdoZW4gaXQg ZHJvcHMgbG9ja3MuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjg0MjQ+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGlPUyBjb2Rl IHBhdGggZm9yIGRyb3BwaW5nIGxvY2tzIGRpZmZlciBmcm9tIHRoZSBub24taU9TIGNvZGUgcGF0 aAorICAgICAgICBpbiB0aGF0IGl0IChpT1MpIGRvZXMgY2xlYXIgbV92bS0+c3RhY2tQb2ludGVy QXRWTUVudHJ5IG5vciByZXNldCB0aGUKKyAgICAgICAgVk0gc3RhY2sgbGltaXQuIFRoaXMgaXMg bm93IGZpeGVkIGJ5IGNvcHlpbmcgdGhhdCBzbmlwcGl0IGZyb20KKyAgICAgICAgSlNMb2NrOjp1 bmxvY2soKS4KKworICAgICAgICAqIHJ1bnRpbWUvSlNMb2NrLmNwcDoKKyAgICAgICAgKEpTQzo6 SlNMb2NrOjpkcm9wQWxsTG9ja3MpOgorICAgICAgICAoSlNDOjpKU0xvY2s6OmRyb3BBbGxMb2Nr c1VuY29uZGl0aW9uYWxseSk6CisKIDIwMTQtMDItMDcgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBw bGUuY29tPgogCiAgICAgICAgIFJlbW92ZWQgc3VwZXJmbG91cyBKU0xvY2s6OmVudHJ5U3RhY2tQ b2ludGVyIGZpZWxkLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNMb2Nr LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0xvY2su Y3BwCShyZXZpc2lvbiAxNjM2NjUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U0xvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjUsNiArMjI1LDEwIEBAIHVuc2lnbmVkIEpT TG9jazo6ZHJvcEFsbExvY2tzKFNwaW5Mb2NrJiAKICAgICAvLyBtX2xvY2tEcm9wRGVwdGggaXMg b25seSBpbmNyZW1lbnRlZCBpZiBhbnkgbG9ja3Mgd2VyZSBkcm9wcGVkLgogICAgICsrbV9sb2Nr RHJvcERlcHRoOwogICAgIG1fbG9ja0NvdW50ID0gMDsKKyAgICBpZiAobV92bSkgeworICAgICAg ICBtX3ZtLT5zdGFja1BvaW50ZXJBdFZNRW50cnkgPSBudWxscHRyOworICAgICAgICBtX3ZtLT51 cGRhdGVTdGFja0xpbWl0V2l0aFJlc2VydmVkWm9uZVNpemUod3RmVGhyZWFkRGF0YSgpLnNhdmVk UmVzZXJ2ZWRab25lU2l6ZSgpKTsKKyAgICB9CiAgICAgbV9sb2NrLnVubG9jaygpOwogICAgIHJl dHVybiBsb2NrQ291bnQ7CiAjZWxzZQpAQCAtMjQ4LDYgKzI1MiwxMCBAQCB1bnNpZ25lZCBKU0xv Y2s6OmRyb3BBbGxMb2Nrc1VuY29uZGl0aW9uCiAgICAgLy8gbV9sb2NrRHJvcERlcHRoIGlzIG9u bHkgaW5jcmVtZW50ZWQgaWYgYW55IGxvY2tzIHdlcmUgZHJvcHBlZC4KICAgICArK21fbG9ja0Ry b3BEZXB0aDsKICAgICBtX2xvY2tDb3VudCA9IDA7CisgICAgaWYgKG1fdm0pIHsKKyAgICAgICAg bV92bS0+c3RhY2tQb2ludGVyQXRWTUVudHJ5ID0gbnVsbHB0cjsKKyAgICAgICAgbV92bS0+dXBk YXRlU3RhY2tMaW1pdFdpdGhSZXNlcnZlZFpvbmVTaXplKHd0ZlRocmVhZERhdGEoKS5zYXZlZFJl c2VydmVkWm9uZVNpemUoKSk7CisgICAgfQogICAgIG1fbG9jay51bmxvY2soKTsKICAgICByZXR1 cm4gbG9ja0NvdW50OwogI2Vsc2UK