128410 2014-02-07 16:11:23 -0800 Add API for accessing session ephemerality from a page bundle 2014-02-10 10:54:45 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhock mhock ap commit-queue oldest_to_newest 978117 0 mhock 2014-02-07 16:11:23 -0800 Add API for accessing session from a page or bundle. 978121 1 223510 mhock 2014-02-07 16:17:07 -0800 Created attachment 223510 patch 978162 2 223510 ap 2014-02-07 16:57:42 -0800 Comment on attachment 223510 patch View in context: https://bugs.webkit.org/attachment.cgi?id=223510&action=review I think that it is tricky to expose a session API when we don't really track sessions internally yet. I would suggest not doing anything in UIProcess API, and exposing WKBundlePageIsUsingEphemeralSession in bundle API. > Source/WebKit2/UIProcess/API/C/WKPage.cpp:1496 > + return toAPI(session.release().leakRef()); An API function that returns something that should be released should have "create" or "copy" in the name, not "get". This one would be "WKPageCopySession" (but note the above, let's not add it yet). > Source/WebKit2/UIProcess/APISession.h:39 > + static PassRefPtr<Session> fromID(uint64_t sessionID); This looks like something SessionTracker would be responsible for, not Session itself. > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:548 > + RefPtr<API::Session> session = API::Session::fromID(toImpl(pageRef)->sessionID()); UI process API and bundle API are different. APISession.h file is in UIProcess directory, so it cannot be used here. You have this header indirectly included via WKSharedAPICast.h. But it shouldn't be there, as WKSession.h itself is in UIProcess. The include should be in WKAPICast.h instead. 978193 3 223523 mhock 2014-02-07 17:23:22 -0800 Created attachment 223523 expose just the bool from bundle 978354 4 223523 ap 2014-02-08 02:24:02 -0800 Comment on attachment 223523 expose just the bool from bundle View in context: https://bugs.webkit.org/attachment.cgi?id=223523&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2110 > +bool WebPage::isEphemeral() const Why not use the same name, isUsingEphemeralSession()? "Page is ephemeral" is not a concept we have. 978944 5 223722 mhock 2014-02-10 10:10:22 -0800 Created attachment 223722 rename method 978964 6 223722 commit-queue 2014-02-10 10:54:43 -0800 Comment on attachment 223722 rename method Clearing flags on attachment: 223722 Committed r163800: <http://trac.webkit.org/changeset/163800> 978965 7 commit-queue 2014-02-10 10:54:45 -0800 All reviewed patches have been landed. Closing bug. 223510 2014-02-07 16:17:07 -0800 2014-02-07 17:23:22 -0800 patch sessionaccess.01.diff text/plain 5063 mhock ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmOTQyMmE0Li42NjU0ZjY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTQtMDItMDcgIE1hcnRpbiBIb2NrICA8bWhvY2tAYXBwbGUuY29tPgorCisgICAgICAg IEFkZCBBUEkgZm9yIGFjY2Vzc2luZyBzZXNzaW9uIGZyb20gYSBwYWdlIG9yIGJ1bmRsZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4NDEwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL0MvV0tQYWdlLmNwcDoKKyAgICAgICAgKFdLUGFnZUdldFNlc3Npb24pOgorICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJU2Vzc2lv bi5jcHA6CisgICAgICAgIChBUEk6OlNlc3Npb246OmZyb21JRCk6CisgICAgICAgICogVUlQcm9j ZXNzL0FQSVNlc3Npb24uaDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQ SS9jL1dLQnVuZGxlUGFnZS5jcHA6CisgICAgICAgIChXS0J1bmRsZVBhZ2VHZXRTZXNzaW9uKToK KyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5o OgorCiAyMDE0LTAyLTA3ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNv bT4KIAogICAgICAgICBTaG91bGQgcmVwb3J0IHVzZXIgaW5wdXQgdG8gUGFnZVRocm90dGxlcgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcAppbmRleCBhOTYwODJmLi4x YjY3ZDUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdl LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcApAQCAt MTQ5MCw2ICsxNDkwLDEyIEBAIHZvaWQgV0tQYWdlU2V0U2Vzc2lvbihXS1BhZ2VSZWYgcGFnZVJl ZiwgV0tTZXNzaW9uUmVmIHNlc3Npb24pCiAgICAgdG9JbXBsKHBhZ2VSZWYpLT5zZXRTZXNzaW9u KCp0b0ltcGwoc2Vzc2lvbikpOwogfQogCitXS1Nlc3Npb25SZWYgV0tQYWdlR2V0U2Vzc2lvbihX S1BhZ2VSZWYgcGFnZVJlZikKK3sKKyAgICBSZWZQdHI8QVBJOjpTZXNzaW9uPiBzZXNzaW9uID0g QVBJOjpTZXNzaW9uOjpmcm9tSUQodG9JbXBsKHBhZ2VSZWYpLT5zZXNzaW9uSUQoKSk7CisgICAg cmV0dXJuIHRvQVBJKHNlc3Npb24ucmVsZWFzZSgpLmxlYWtSZWYoKSk7Cit9CisKIHZvaWQgV0tQ YWdlUnVuSmF2YVNjcmlwdEluTWFpbkZyYW1lKFdLUGFnZVJlZiBwYWdlUmVmLCBXS1N0cmluZ1Jl ZiBzY3JpcHRSZWYsIHZvaWQqIGNvbnRleHQsIFdLUGFnZVJ1bkphdmFTY3JpcHRGdW5jdGlvbiBj YWxsYmFjaykKIHsKICAgICB0b0ltcGwocGFnZVJlZiktPnJ1bkphdmFTY3JpcHRJbk1haW5GcmFt ZSh0b0ltcGwoc2NyaXB0UmVmKS0+c3RyaW5nKCksIFNjcmlwdFZhbHVlQ2FsbGJhY2s6OmNyZWF0 ZShjb250ZXh0LCBjYWxsYmFjaykpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9DL1dLUGFnZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFn ZS5oCmluZGV4IDIxNmE4ZmYuLmRjNDEyNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvQy9XS1BhZ2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0MvV0tQYWdlLmgKQEAgLTIwMyw2ICsyMDMsNyBAQCBXS19FWFBPUlQgdm9pZCBXS1BhZ2VTZXRQ YWdlUG9saWN5Q2xpZW50KFdLUGFnZVJlZiBwYWdlLCBjb25zdCBXS1BhZ2VQb2xpY3lDbGllbgog V0tfRVhQT1JUIHZvaWQgV0tQYWdlU2V0UGFnZVVJQ2xpZW50KFdLUGFnZVJlZiBwYWdlLCBjb25z dCBXS1BhZ2VVSUNsaWVudEJhc2UqIGNsaWVudCk7CiAKIFdLX0VYUE9SVCB2b2lkIFdLUGFnZVNl dFNlc3Npb24oV0tQYWdlUmVmIHBhZ2UsIFdLU2Vzc2lvblJlZiBzZXNzaW9uKTsKK1dLX0VYUE9S VCBXS1Nlc3Npb25SZWYgV0tQYWdlR2V0U2Vzc2lvbihXS1BhZ2VSZWYgcGFnZSk7CiAKIHR5cGVk ZWYgdm9pZCAoKldLUGFnZVJ1bkphdmFTY3JpcHRGdW5jdGlvbikoV0tTZXJpYWxpemVkU2NyaXB0 VmFsdWVSZWYsIFdLRXJyb3JSZWYsIHZvaWQqKTsKIFdLX0VYUE9SVCB2b2lkIFdLUGFnZVJ1bkph dmFTY3JpcHRJbk1haW5GcmFtZShXS1BhZ2VSZWYgcGFnZSwgV0tTdHJpbmdSZWYgc2NyaXB0LCB2 b2lkKiBjb250ZXh0LCBXS1BhZ2VSdW5KYXZhU2NyaXB0RnVuY3Rpb24gZnVuY3Rpb24pOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSVNlc3Npb24uY3BwIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSVNlc3Npb24uY3BwCmluZGV4IGMyYTI2MTUuLjRmMTMyYzgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUElTZXNzaW9uLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJU2Vzc2lvbi5jcHAKQEAgLTczLDYgKzczLDEx IEBAIFBhc3NSZWZQdHI8U2Vzc2lvbj4gU2Vzc2lvbjo6Y3JlYXRlKGJvb2wgaXNFcGhlbWVyYWwp CiAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBTZXNzaW9uKGlzRXBoZW1lcmFsKSk7CiB9CiAKK1Bh c3NSZWZQdHI8U2Vzc2lvbj4gU2Vzc2lvbjo6ZnJvbUlEKHVpbnQ2NF90IHNlc3Npb25JRCkKK3sK KyAgICByZXR1cm4gYWRvcHRSZWYobmV3IFNlc3Npb24oV2ViS2l0OjpTZXNzaW9uVHJhY2tlcjo6 aXNFcGhlbWVyYWxJRChzZXNzaW9uSUQpLCBzZXNzaW9uSUQpKTsKK30KKwogYm9vbCBTZXNzaW9u Ojppc0VwaGVtZXJhbCgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIG1faXNFcGhlbWVyYWw7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJU2Vzc2lvbi5oIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSVNlc3Npb24uaAppbmRleCBiZDYwNGIyLi42NTFhODY5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJU2Vzc2lvbi5oCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUElTZXNzaW9uLmgKQEAgLTM2LDYgKzM2LDcgQEAgY2xhc3Mg U2Vzc2lvbiA6IHB1YmxpYyBBUEk6Ok9iamVjdEltcGw8QVBJOjpPYmplY3Q6OlR5cGU6OlNlc3Np b24+IHsKIHB1YmxpYzoKICAgICAvLyBGSVhNRTogV2UgY2FuIGNyZWF0ZSBzZXNzaW9ucyBvbiBk ZW1hbmQsIGJlY2F1c2Ugd2UgaGFyZGNvZGUgdGhlIGZhY3QgdGhhdCBhbGwgc2Vzc2lvbnMgYnV0 IHRoZSBkZWZhdWx0IG9uZSBhcmUgZXBoZW1lcmFsLiBXZSdsbCBuZWVkIHRvIGNyZWF0ZSB0aGVt IGV4cGxpY2l0bHkgb25jZSBzZXNzaW9ucyBoYXZlIG1vcmUgY29uZmlndXJhdGlvbiBvcHRpb25z LgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPFNlc3Npb24+IGNyZWF0ZShib29sIGlzRXBoZW1lcmFs KTsKKyAgICBzdGF0aWMgUGFzc1JlZlB0cjxTZXNzaW9uPiBmcm9tSUQodWludDY0X3Qgc2Vzc2lv bklEKTsKICAgICBzdGF0aWMgU2Vzc2lvbiYgZGVmYXVsdFNlc3Npb24oKTsKICAgICBzdGF0aWMg U2Vzc2lvbiYgbGVnYWN5UHJpdmF0ZVNlc3Npb24oKTsKICAgICBib29sIGlzRXBoZW1lcmFsKCkg Y29uc3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVu ZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0lu amVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5jcHAKaW5kZXggYTdhNDg1NS4uMTQ5MTIx YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9B UEkvYy9XS0J1bmRsZVBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5q ZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlLmNwcApAQCAtNTQyLDMgKzU0Miw5IEBAIHZv aWQgV0tCdW5kbGVQYWdlU3RvcEV4dGVuZGluZ0luY3JlbWVudGFsUmVuZGVyaW5nU3VwcHJlc3Np b24oV0tCdW5kbGVQYWdlUmVmIHBhCiB7CiAgICAgdG9JbXBsKHBhZ2VSZWYpLT5zdG9wRXh0ZW5k aW5nSW5jcmVtZW50YWxSZW5kZXJpbmdTdXBwcmVzc2lvbih0b2tlbik7CiB9CisKK1dLU2Vzc2lv blJlZiBXS0J1bmRsZVBhZ2VHZXRTZXNzaW9uKFdLQnVuZGxlUGFnZVJlZiBwYWdlUmVmKQorewor ICAgIFJlZlB0cjxBUEk6OlNlc3Npb24+IHNlc3Npb24gPSBBUEk6OlNlc3Npb246OmZyb21JRCh0 b0ltcGwocGFnZVJlZiktPnNlc3Npb25JRCgpKTsKKyAgICByZXR1cm4gdG9BUEkoc2Vzc2lvbi5y ZWxlYXNlKCkubGVha1JlZigpKTsKK30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlLmggYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5oCmluZGV4IDZj M2FjMmEuLjhiMGYwM2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5q ZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuaApAQCAtMTA3LDYgKzEw Nyw4IEBAIFdLX0VYUE9SVCB2b2lkIFdLQnVuZGxlUGFnZUxpc3RlbkZvckxheW91dE1pbGVzdG9u ZXMoV0tCdW5kbGVQYWdlUmVmIHBhZ2UsIFdLTGF5CiAKIFdLX0VYUE9SVCBXS0J1bmRsZUluc3Bl Y3RvclJlZiBXS0J1bmRsZVBhZ2VHZXRJbnNwZWN0b3IoV0tCdW5kbGVQYWdlUmVmIHBhZ2UpOwog CitXS19FWFBPUlQgV0tTZXNzaW9uUmVmIFdLQnVuZGxlUGFnZUdldFNlc3Npb24oV0tCdW5kbGVQ YWdlUmVmIHBhZ2UpOworCiAjaWZkZWYgX19jcGx1c3BsdXMKIH0KICNlbmRpZgo= 223523 2014-02-07 17:23:22 -0800 2014-02-10 10:10:22 -0800 expose just the bool from bundle sessionaccess.02.diff text/plain 3139 mhock ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmOTQyMmE0Li4yMTEyZGRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMDItMDcgIE1hcnRpbiBIb2NrICA8bWhvY2tAYXBwbGUuY29tPgorCisgICAgICAg IEFkZCBBUEkgZm9yIGFjY2Vzc2luZyBzZXNzaW9uIGVwaGVtZXJhbGl0eSBmcm9tIGEgcGFnZSBi dW5kbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy ODQxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog V2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuY3BwOgorICAgICAg ICAoV0tCdW5kbGVQYWdlSXNVc2luZ0VwaGVtZXJhbFNlc3Npb24pOgorICAgICAgICAqIFdlYlBy b2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlLmg6CisgICAgICAgICogV2Vi UHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpp c0VwaGVtZXJhbCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaDoKKwog MjAxNC0wMi0wNyAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAK ICAgICAgICAgU2hvdWxkIHJlcG9ydCB1c2VyIGlucHV0IHRvIFBhZ2VUaHJvdHRsZXIKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tC dW5kbGVQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUv QVBJL2MvV0tCdW5kbGVQYWdlLmNwcAppbmRleCBhN2E0ODU1Li44MDc2YjVhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxl UGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9B UEkvYy9XS0J1bmRsZVBhZ2UuY3BwCkBAIC01NDIsMyArNTQyLDggQEAgdm9pZCBXS0J1bmRsZVBh Z2VTdG9wRXh0ZW5kaW5nSW5jcmVtZW50YWxSZW5kZXJpbmdTdXBwcmVzc2lvbihXS0J1bmRsZVBh Z2VSZWYgcGEKIHsKICAgICB0b0ltcGwocGFnZVJlZiktPnN0b3BFeHRlbmRpbmdJbmNyZW1lbnRh bFJlbmRlcmluZ1N1cHByZXNzaW9uKHRva2VuKTsKIH0KKworYm9vbCBXS0J1bmRsZVBhZ2VJc1Vz aW5nRXBoZW1lcmFsU2Vzc2lvbihXS0J1bmRsZVBhZ2VSZWYgcGFnZVJlZikKK3sKKyAgICByZXR1 cm4gdG9JbXBsKHBhZ2VSZWYpLT5pc0VwaGVtZXJhbCgpOworfQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuaCBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQ YWdlLmgKaW5kZXggNmMzYWMyYS4uMDc2YmE4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5o CkBAIC0xMDcsNiArMTA3LDggQEAgV0tfRVhQT1JUIHZvaWQgV0tCdW5kbGVQYWdlTGlzdGVuRm9y TGF5b3V0TWlsZXN0b25lcyhXS0J1bmRsZVBhZ2VSZWYgcGFnZSwgV0tMYXkKIAogV0tfRVhQT1JU IFdLQnVuZGxlSW5zcGVjdG9yUmVmIFdLQnVuZGxlUGFnZUdldEluc3BlY3RvcihXS0J1bmRsZVBh Z2VSZWYgcGFnZSk7CiAKK1dLX0VYUE9SVCBib29sIFdLQnVuZGxlUGFnZUlzVXNpbmdFcGhlbWVy YWxTZXNzaW9uKFdLQnVuZGxlUGFnZVJlZiBwYWdlKTsKKwogI2lmZGVmIF9fY3BsdXNwbHVzCiB9 CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9X ZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNw cAppbmRleCBiMGVhMjJiLi5hMWJjMzNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC0yMTA3LDYgKzIxMDcsMTEgQEAgdWludDY0X3QgV2Vi UGFnZTo6c2Vzc2lvbklEKCkgY29uc3QKICAgICByZXR1cm4gbV9wYWdlLT5zZXR0aW5ncygpLnBy aXZhdGVCcm93c2luZ0VuYWJsZWQoKSA/IFNlc3Npb25UcmFja2VyOjpsZWdhY3lQcml2YXRlU2Vz c2lvbklEIDogU2Vzc2lvblRyYWNrZXI6OmRlZmF1bHRTZXNzaW9uSUQ7CiB9CiAKK2Jvb2wgV2Vi UGFnZTo6aXNFcGhlbWVyYWwoKSBjb25zdAoreworICAgIHJldHVybiBTZXNzaW9uVHJhY2tlcjo6 aXNFcGhlbWVyYWxJRChzZXNzaW9uSUQoKSk7Cit9CisKIHZvaWQgV2ViUGFnZTo6c2V0U2Vzc2lv bklEKHVpbnQ2NF90IHNlc3Npb25JRCkKIHsKICAgICBtX3Nlc3Npb25JRCA9IHNlc3Npb25JRDsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCmluZGV4IDIxNzhh MjguLmEyNzZkNTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9XZWJQYWdlLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuaApAQCAtMTgzLDYgKzE4Myw3IEBAIHB1YmxpYzoKICAgICBXZWJDb3JlOjpQYWdlKiBjb3Jl UGFnZSgpIGNvbnN0IHsgcmV0dXJuIG1fcGFnZS5nZXQoKTsgfQogICAgIHVpbnQ2NF90IHBhZ2VJ RCgpIGNvbnN0IHsgcmV0dXJuIG1fcGFnZUlEOyB9CiAgICAgdWludDY0X3Qgc2Vzc2lvbklEKCkg Y29uc3Q7CisgICAgYm9vbCBpc0VwaGVtZXJhbCgpIGNvbnN0OwogICAgIHZvaWQgc2V0U2Vzc2lv bklEKHVpbnQ2NF90KTsKIAogICAgIHZvaWQgc2V0U2l6ZShjb25zdCBXZWJDb3JlOjpJbnRTaXpl Jik7Cg== 223722 2014-02-10 10:10:22 -0800 2014-02-10 10:54:43 -0800 rename method sessionaccess.03.diff text/plain 3218 mhock ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1YWI0OTZhLi5hMGQwNDBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMDItMTAgIE1hcnRpbiBIb2NrICA8bWhvY2tAYXBwbGUuY29tPgorCisgICAgICAg IEFkZCBBUEkgZm9yIGFjY2Vzc2luZyBzZXNzaW9uIGVwaGVtZXJhbGl0eSBmcm9tIGEgcGFnZSBi dW5kbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy ODQxMAorCisgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCisKKyAgICAg ICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5jcHA6Cisg ICAgICAgIChXS0J1bmRsZVBhZ2VJc1VzaW5nRXBoZW1lcmFsU2Vzc2lvbik6CisgICAgICAgICog V2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuaDoKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBh Z2U6OmlzVXNpbmdFcGhlbWVyYWxTZXNzaW9uKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBh Z2UvV2ViUGFnZS5oOgorCiAyMDE0LTAyLTEwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CiAKICAgICAgICAgSlNDIGVudmlyb25tZW50IHZhcmlhYmxlcyBzaG91bGQgb3ZlcnJpZGUg b3RoZXIgbWVjaGFuaXNtcyBmb3Igc2V0dGluZyBvcHRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxl UGFnZS5jcHAKaW5kZXggYTdhNDg1NS4uNWMzMjJkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQ YWdlLmNwcApAQCAtNTQyLDMgKzU0Miw4IEBAIHZvaWQgV0tCdW5kbGVQYWdlU3RvcEV4dGVuZGlu Z0luY3JlbWVudGFsUmVuZGVyaW5nU3VwcHJlc3Npb24oV0tCdW5kbGVQYWdlUmVmIHBhCiB7CiAg ICAgdG9JbXBsKHBhZ2VSZWYpLT5zdG9wRXh0ZW5kaW5nSW5jcmVtZW50YWxSZW5kZXJpbmdTdXBw cmVzc2lvbih0b2tlbik7CiB9CisKK2Jvb2wgV0tCdW5kbGVQYWdlSXNVc2luZ0VwaGVtZXJhbFNl c3Npb24oV0tCdW5kbGVQYWdlUmVmIHBhZ2VSZWYpCit7CisgICAgcmV0dXJuIHRvSW1wbChwYWdl UmVmKS0+aXNVc2luZ0VwaGVtZXJhbFNlc3Npb24oKTsKK30KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlLmggYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFn ZS5oCmluZGV4IDZjM2FjMmEuLjA3NmJhOGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlLmgKKysrIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuaApA QCAtMTA3LDYgKzEwNyw4IEBAIFdLX0VYUE9SVCB2b2lkIFdLQnVuZGxlUGFnZUxpc3RlbkZvckxh eW91dE1pbGVzdG9uZXMoV0tCdW5kbGVQYWdlUmVmIHBhZ2UsIFdLTGF5CiAKIFdLX0VYUE9SVCBX S0J1bmRsZUluc3BlY3RvclJlZiBXS0J1bmRsZVBhZ2VHZXRJbnNwZWN0b3IoV0tCdW5kbGVQYWdl UmVmIHBhZ2UpOwogCitXS19FWFBPUlQgYm9vbCBXS0J1bmRsZVBhZ2VJc1VzaW5nRXBoZW1lcmFs U2Vzc2lvbihXS0J1bmRsZVBhZ2VSZWYgcGFnZSk7CisKICNpZmRlZiBfX2NwbHVzcGx1cwogfQog I2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAK aW5kZXggYzY4MjEzNC4uNzg0N2RiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJQYWdlLmNwcApAQCAtMjEwMiw2ICsyMTAyLDExIEBAIHVpbnQ2NF90IFdlYlBh Z2U6OnNlc3Npb25JRCgpIGNvbnN0CiAgICAgcmV0dXJuIG1fcGFnZS0+c2V0dGluZ3MoKS5wcml2 YXRlQnJvd3NpbmdFbmFibGVkKCkgPyBTZXNzaW9uVHJhY2tlcjo6bGVnYWN5UHJpdmF0ZVNlc3Np b25JRCA6IFNlc3Npb25UcmFja2VyOjpkZWZhdWx0U2Vzc2lvbklEOwogfQogCitib29sIFdlYlBh Z2U6OmlzVXNpbmdFcGhlbWVyYWxTZXNzaW9uKCkgY29uc3QKK3sKKyAgICByZXR1cm4gU2Vzc2lv blRyYWNrZXI6OmlzRXBoZW1lcmFsSUQoc2Vzc2lvbklEKCkpOworfQorCiB2b2lkIFdlYlBhZ2U6 OnNldFNlc3Npb25JRCh1aW50NjRfdCBzZXNzaW9uSUQpCiB7CiAgICAgbV9zZXNzaW9uSUQgPSBz ZXNzaW9uSUQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv V2ViUGFnZS5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaApp bmRleCBhMGE0NTZlLi4zZmJmZmEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmgKQEAgLTE4Myw2ICsxODMsNyBAQCBwdWJsaWM6CiAgICAgV2ViQ29yZTo6 UGFnZSogY29yZVBhZ2UoKSBjb25zdCB7IHJldHVybiBtX3BhZ2UuZ2V0KCk7IH0KICAgICB1aW50 NjRfdCBwYWdlSUQoKSBjb25zdCB7IHJldHVybiBtX3BhZ2VJRDsgfQogICAgIHVpbnQ2NF90IHNl c3Npb25JRCgpIGNvbnN0OworICAgIGJvb2wgaXNVc2luZ0VwaGVtZXJhbFNlc3Npb24oKSBjb25z dDsKICAgICB2b2lkIHNldFNlc3Npb25JRCh1aW50NjRfdCk7CiAKICAgICB2b2lkIHNldFNpemUo Y29uc3QgV2ViQ29yZTo6SW50U2l6ZSYpOwo=