12841 2007-02-21 04:29:36 -0800 Crash on ARM due to mis-alignment 2007-02-22 08:11:01 -0800 1 1 1 Unclassified WebKit New Bugs 420+ Other Linux RESOLVED FIXED P2 Normal --- 1 public webkit-unassigned kkowalczyk oldest_to_newest 22415 0 public 2007-02-21 04:29:36 -0800 ARM has stricter alignment rules than many other architectures. In this case, pageheap_memory is being declared as a char array, so it is not aligned by the compiler. It is later used as TCMalloc_PageHeap*, which does require alignment. When building under ARM, this patch tells the compiler to stricly align pageheap_memory so that pageheap_memory can be used as TCMalloc_PageHeap*. It does not affect other platforms. 22416 1 13292 public 2007-02-21 04:30:54 -0800 Created attachment 13292 Fix ARM crash due to mis-alignment 22331 2 13292 darin 2007-02-21 17:21:09 -0800 Comment on attachment 13292 Fix ARM crash due to mis-alignment I think there's a more-portable way to solve this problem. We could make pageheap_memory be an array of pointers instead of an array of char. That would ive us the alignment we need to store pointers in it. static void* pageheap_memory[(sizeof(TCMalloc_PageHeap) + sizeof(void*) - 1) / sizeof(void*)]; What do you think? 22315 3 mjs 2007-02-22 00:15:30 -0800 I agree with Darin. I think it is better to enforce the alignment in a portable way, by making the array be a pointer array or the like. 22318 4 13312 public 2007-02-22 00:48:00 -0800 Created attachment 13312 Fix ARM crash due to mis-alignment - rev2 22319 5 public 2007-02-22 00:50:34 -0800 Sounds good to me. I've attached a modified patch with Darin's suggestion. 22289 6 13312 mjs 2007-02-22 02:26:04 -0800 Comment on attachment 13312 Fix ARM crash due to mis-alignment - rev2 r=me 22272 7 sam 2007-02-22 08:11:01 -0800 Landed in r19791. 13292 2007-02-21 04:30:54 -0800 2007-02-22 00:45:39 -0800 Fix ARM crash due to mis-alignment patch text/plain 1510 public SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NzY5KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDctMDItMjEgIE9zY2FyIEN3 YWpiYXVtICA8cHVibGljQG9zY2FyYy5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ CisKKyAgICAgICAgRml4IEFSTS1zcGVjaWZpYyBhbGlnbm1lbnQgcHJvYmxlbSBpbiBGYXN0TWFs bG9jCisKKyAgICAgICAgKiB3dGYvRmFzdE1hbGxvYy5jcHA6CisgICAgICAgIGNvbXBpbGVyIGRp cmVjdGl2ZSB0byBmb3JjZSBhbGlnbm1lbnQgd2hlbiBidWlsZGluZyBmb3IgQVJNCisKIDIwMDct MDItMjAgIFphY2sgUnVzaW4gIDx6cnVzaW5AdHJvbGx0ZWNoLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBMYXJzCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvRmFzdE1hbGxvYy5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwCShyZXZpc2lvbiAx OTc2OSkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTU1LDYgKzE1NSwxMiBAQCBuYW1lc3BhY2UgV1RGIHsKICNkZWZpbmUgTExVICAgImxs dSIgICAgICAgICAgICAgIC8vIGhvcGUgZm9yIHRoZSBiZXN0CiAjZW5kaWYKIAorI2lmIENPTVBJ TEVSKEdDQykgJiYgUExBVEZPUk0oQVJNKQorI2RlZmluZSBBTElHTl9BUlJBWSAgX19hdHRyaWJ1 dGVfXyAoKGFsaWduZWQoNCkpKQorI2Vsc2UKKyNkZWZpbmUgQUxJR05fQVJSQVkKKyNlbmRpZgor CiAvLy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0KIC8vIENvbmZpZ3VyYXRpb24KIC8vLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpAQCAtMTExMyw3 ICsxMTE5LDcgQEAgc3RhdGljIFRDTWFsbG9jX0NlbnRyYWxfRnJlZUxpc3RQYWRkZWQgYwogCiAv LyBQYWdlLWxldmVsIGFsbG9jYXRvcgogc3RhdGljIFNwaW5Mb2NrIHBhZ2VoZWFwX2xvY2sgPSBT UElOTE9DS19JTklUSUFMSVpFUjsKLXN0YXRpYyBjaGFyIHBhZ2VoZWFwX21lbW9yeVtzaXplb2Yo VENNYWxsb2NfUGFnZUhlYXApXTsKK3N0YXRpYyBjaGFyIHBhZ2VoZWFwX21lbW9yeVtzaXplb2Yo VENNYWxsb2NfUGFnZUhlYXApXSBBTElHTl9BUlJBWSA7CiBzdGF0aWMgYm9vbCBwaGluaXRlZCA9 IGZhbHNlOwogCiAvLyBBdm9pZCBleHRyYSBsZXZlbCBvZiBpbmRpcmVjdGlvbiBieSBtYWtpbmcg InBhZ2VoZWFwIiBiZSBqdXN0IGFuIGFsaWFzCg== 13312 2007-02-22 00:48:00 -0800 2007-02-22 02:26:04 -0800 Fix ARM crash due to mis-alignment - rev2 patch text/plain 1193 public SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5Nzg4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMDItMjIgIE9zY2FyIEN3 YWpiYXVtICA8cHVibGljQG9zY2FyYy5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ CisKKyAgICAgICAgRml4IEFSTS1zcGVjaWZpYyBhbGlnbm1lbnQgcHJvYmxlbSBpbiBGYXN0TWFs bG9jCisKKyAgICAgICAgKiB3dGYvRmFzdE1hbGxvYy5jcHA6CisgICAgICAgIE1vZGlmeSBob3cg cGFnZWhlYXBfbWVtb3J5IGlzIGRlY2xhcmVkIHRvIGVuc3VyZSBwcm9wZXIgYWxpZ25tZW50Cisg ICAgICAgIG9uIGFyY2hpdGVjdHVyZXMgc3VjaCBhcyBBUk0KKwogMjAwNy0wMi0yMCAgWmFjayBS dXNpbiAgPHpydXNpbkB0cm9sbHRlY2guY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IExhcnMK SW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK YXZhU2NyaXB0Q29yZS93dGYvRmFzdE1hbGxvYy5jcHAJKHJldmlzaW9uIDE5Nzg4KQorKysgSmF2 YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTEzLDcg KzExMTMsNyBAQCBzdGF0aWMgVENNYWxsb2NfQ2VudHJhbF9GcmVlTGlzdFBhZGRlZCBjCiAKIC8v IFBhZ2UtbGV2ZWwgYWxsb2NhdG9yCiBzdGF0aWMgU3BpbkxvY2sgcGFnZWhlYXBfbG9jayA9IFNQ SU5MT0NLX0lOSVRJQUxJWkVSOwotc3RhdGljIGNoYXIgcGFnZWhlYXBfbWVtb3J5W3NpemVvZihU Q01hbGxvY19QYWdlSGVhcCldOworc3RhdGljIHZvaWQqIHBhZ2VoZWFwX21lbW9yeVsoc2l6ZW9m KFRDTWFsbG9jX1BhZ2VIZWFwKSArIHNpemVvZih2b2lkKikgLSAxKSAvIHNpemVvZih2b2lkKild Owogc3RhdGljIGJvb2wgcGhpbml0ZWQgPSBmYWxzZTsKIAogLy8gQXZvaWQgZXh0cmEgbGV2ZWwg b2YgaW5kaXJlY3Rpb24gYnkgbWFraW5nICJwYWdlaGVhcCIgYmUganVzdCBhbiBhbGlhcwo=