128396 2014-02-07 14:00:52 -0800 [iOS][WK2] Add empty definition for an API allowing clients to define obscured edges over the scrollview 2014-02-10 13:52:42 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin andersca commit-queue ian mitz simon.fraser oldest_to_newest 978029 0 benjamin 2014-02-07 14:00:52 -0800 [iOS][WK2] Add empty definition for an API allowing clients to define obscured edges over the scrollview 978030 1 223494 benjamin 2014-02-07 14:01:56 -0800 Created attachment 223494 Patch 978033 2 commit-queue 2014-02-07 14:04:35 -0800 Attachment 223494 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:48: Missing spaces around = [whitespace/operators] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:40: Missing spaces around = [whitespace/operators] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 978038 3 223494 ian 2014-02-07 14:08:46 -0800 Comment on attachment 223494 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223494&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:48 > +@property (nonatomic, setter=_setObscuredInset:) UIEdgeInsets _obscuredInset; I think the usual UIKit style for private properties is to omit the underscore from the property name and define both setter=_setProperty: and getter=_property. > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:374 > +- (UIEdgeInsets)_obscuredInset > +{ > + return _obscuredInset; > +} If we don't define this method, the compiler should autosynthesize it and the ivar for us. 978043 4 andersca 2014-02-07 14:14:07 -0800 (In reply to comment #3) > (From update of attachment 223494 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223494&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:48 > > +@property (nonatomic, setter=_setObscuredInset:) UIEdgeInsets _obscuredInset; > > I think the usual UIKit style for private properties is to omit the underscore from the property name and define both setter=_setProperty: and getter=_property. We've decided against doing that for properties. If we decide to make a private property public with slightly different semantics we don't want clients to break. 978066 5 223494 simon.fraser 2014-02-07 14:32:06 -0800 Comment on attachment 223494 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223494&action=review > Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:276 > +- (void)_commitObscuredInset > +{ > +} Not sure why committing is separate from setting. 978074 6 223494 simon.fraser 2014-02-07 14:45:25 -0800 Comment on attachment 223494 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223494&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:376 > +- (void)_setObscuredInset:(UIEdgeInsets)obscuredInset _setObscuredInsets > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:385 > +- (void)_commitObscuredInset Need a better name for this, or use a flag on -_setObscuredInsets: 978077 7 223494 ian 2014-02-07 14:49:17 -0800 Comment on attachment 223494 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223494&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:51 > +// Inform the web content that the unobscured area has reached a stable state. > +- (void)_commitObscuredInset; Ben and I discussed this, and we think it makes sense to have a pair of methods: - (void)beginInteractiveObscuredInsetChange; - (void)endInteractiveObscuredInsetChange; When every begin call has been balanced by an end call, we'll inform the web content of the change. 978095 8 223502 benjamin 2014-02-07 15:19:14 -0800 Created attachment 223502 Patch 978097 9 commit-queue 2014-02-07 15:20:51 -0800 Attachment 223502 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:48: Missing spaces around = [whitespace/operators] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:40: Missing spaces around = [whitespace/operators] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 979036 10 223502 benjamin 2014-02-10 13:52:40 -0800 Comment on attachment 223502 Patch Clearing flags on attachment: 223502 Committed r163814: <http://trac.webkit.org/changeset/163814> 979037 11 benjamin 2014-02-10 13:52:42 -0800 All reviewed patches have been landed. Closing bug. 223494 2014-02-07 14:01:56 -0800 2014-02-07 15:19:12 -0800 Patch bug-128396-20140207140156.patch text/plain 4819 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDhiMDRkMjczOWFmZGQz M2RjNTA2NGY3YTZiZWI4MWM4ZjAwZTJjYS4uYThlYmMxYmQwNGRiMWEwZDIxMjZiYzIwZWJkZGMx NGNiMzczMWFhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTAyLTA3ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdW1dLMl0g QWRkIGVtcHR5IGRlZmluaXRpb24gZm9yIGFuIEFQSSBhbGxvd2luZyBjbGllbnRzIHRvIGRlZmlu ZSBvYnNjdXJlZCBlZGdlcyBvdmVyIHRoZSBzY3JvbGx2aWV3CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgzOTYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPYnNjdXJlZEluc2V0IGRlZmluZXMgdGhlIGFy ZWEgb2YgdGhlIHNjcm9sbHZpZXcgdW51c2FibGUgZm9yIHBvc2l0aW9uaW5nIGNvbnRlbnQuCisg ICAgICAgIFRoZSBBUEkgaXMgdW51c2VkIGluIHRoaXMgcGF0Y2guCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL0NvY29hL1dLVmlld1ByaXZhdGUuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9vYnNjdXJlZEluc2V0 XSk6CisgICAgICAgICgtW1dLV2ViVmlldyBfc2V0T2JzY3VyZWRJbnNldDpdKToKKyAgICAgICAg KC1bV0tXZWJWaWV3IF9jb21taXRPYnNjdXJlZEluc2V0XSk6CisgICAgICAgICogVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9p b3MvV0tWaWV3SU9TLm1tOgorICAgICAgICAoLVtXS1ZpZXcgX29ic2N1cmVkSW5zZXRdKToKKyAg ICAgICAgKC1bV0tWaWV3IF9zZXRPYnNjdXJlZEluc2V0Ol0pOgorICAgICAgICAoLVtXS1ZpZXcg X2NvbW1pdE9ic2N1cmVkSW5zZXRdKToKKwogMjAxNC0wMi0wNyAgVGltIEhvcnRvbiAgPHRpbW90 aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgVmlld0dlc3R1cmVDb250cm9s bGVyLm1tIHRvIFZpZXdHZXN0dXJlQ29udHJvbGxlck1hYy5tbQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ZpZXdQcml2YXRlLmggYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVmlld1ByaXZhdGUuaAppbmRleCAwNWY2MmI3M2M0 ZjUzNzliOGVmOWFlYWVjYTBlYzU2NmNjYmEwNmJjLi5hZmY0NjY4YzgyYWFkNjY3MTBmZWNlMzBl ZmViZWE3YTZlN2UxYzc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLVmlld1ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLVmlld1ByaXZhdGUuaApAQCAtNDQsNiArNDQsMTIgQEAKIAogQHByb3BlcnR5IChu b25hdG9taWMpIENHU2l6ZSBtaW5pbXVtTGF5b3V0U2l6ZU92ZXJyaWRlOwogCisvLyBEZWZpbmUg dGhlIGluc2V0IG9mIHRoZSBzY3JvbGx2aWV3IHVudXNhYmxlIGJ5IHRoZSB3ZWIgcGFnZS4KK0Bw cm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3NldE9ic2N1cmVkSW5zZXQ6KSBVSUVkZ2VJbnNl dHMgX29ic2N1cmVkSW5zZXQ7CisKKy8vIEluZm9ybSB0aGUgd2ViIGNvbnRlbnQgdGhhdCB0aGUg dW5vYnNjdXJlZCBhcmVhIGhhcyByZWFjaGVkIGEgc3RhYmxlIHN0YXRlLgorLSAodm9pZClfY29t bWl0T2JzY3VyZWRJbnNldDsKKwogI2Vsc2UKIAogLSAoTlNQcmludE9wZXJhdGlvbiAqKXByaW50 T3BlcmF0aW9uV2l0aFByaW50SW5mbzooTlNQcmludEluZm8gKilwcmludEluZm8gZm9yRnJhbWU6 KFdLRnJhbWVSZWYpZnJhbWVSZWY7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Q29jb2EvV0tXZWJWaWV3Lm1tCmluZGV4IDNjMTE3YTY0MjUwNTliNDMwMDYzZWYxMjRmMmUwMjEx ZWU3MGY5OTkuLjBkMmFiMzM2NDI3M2NlZjg5YWQxMzU2YjViZTNiOTc2M2Q4ZmU4YTEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCkBAIC02 NSw2ICs2NSw4IEBACiAgICAgQk9PTCBfaXNXYWl0aW5nRm9yTmV3TGF5ZXJUcmVlQWZ0ZXJEaWRD b21taXRMb2FkOwogICAgIEJPT0wgX2hhc1N0YXRpY01pbmltdW1MYXlvdXRTaXplOwogICAgIENH U2l6ZSBfbWluaW11bUxheW91dFNpemVPdmVycmlkZTsKKworICAgIFVJRWRnZUluc2V0cyBfb2Jz Y3VyZWRJbnNldDsKICNlbmRpZgogI2lmIFBMQVRGT1JNKE1BQykgJiYgIVBMQVRGT1JNKElPUykK ICAgICBSZXRhaW5QdHI8V0tWaWV3PiBfd2tWaWV3OwpAQCAtMzY2LDYgKzM2OCwyNCBAQAogICAg IFtfY29udGVudFZpZXcgc2V0TWluaW11bUxheW91dFNpemU6bWluaW11bUxheW91dFNpemVPdmVy cmlkZV07CiB9CiAKKy0gKFVJRWRnZUluc2V0cylfb2JzY3VyZWRJbnNldAoreworICAgIHJldHVy biBfb2JzY3VyZWRJbnNldDsKK30KKworLSAodm9pZClfc2V0T2JzY3VyZWRJbnNldDooVUlFZGdl SW5zZXRzKW9ic2N1cmVkSW5zZXQKK3sKKyAgICBBU1NFUlQob2JzY3VyZWRJbnNldC50b3AgPj0g MCk7CisgICAgQVNTRVJUKG9ic2N1cmVkSW5zZXQubGVmdCA+PSAwKTsKKyAgICBBU1NFUlQob2Jz Y3VyZWRJbnNldC5ib3R0b20gPj0gMCk7CisgICAgQVNTRVJUKG9ic2N1cmVkSW5zZXQucmlnaHQg Pj0gMCk7CisgICAgX29ic2N1cmVkSW5zZXQgPSBvYnNjdXJlZEluc2V0OworfQorCistICh2b2lk KV9jb21taXRPYnNjdXJlZEluc2V0Cit7Cit9CisKICNlbmRpZgogCiBAZW5kCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oCmlu ZGV4IDY4YzgzNzVhNjQyZTRkMDAwZDg1NjdjMDVkYmVhNGU1ZjE5MTIwZjQuLmEwMjAzNzQ0Yzlm NzVmZDAwYzUwOTlkOWEwZDViYzY3OWQ5YzYyNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oCkBAIC0zNSw2ICszNSwx MiBAQAogCiAjaWYgVEFSR0VUX09TX0lQSE9ORQogQHByb3BlcnR5IChub25hdG9taWMsIHNldHRl cj1fc2V0TWluaW11bUxheW91dFNpemVPdmVycmlkZTopIENHU2l6ZSBfbWluaW11bUxheW91dFNp emVPdmVycmlkZTsKKworLy8gRGVmaW5lIHRoZSBpbnNldCBvZiB0aGUgc2Nyb2xsdmlldyB1bnVz YWJsZSBieSB0aGUgd2ViIHBhZ2UuCitAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9zZXRP YnNjdXJlZEluc2V0OikgVUlFZGdlSW5zZXRzIF9vYnNjdXJlZEluc2V0OworCisvLyBJbmZvcm0g dGhlIHdlYiBjb250ZW50IHRoYXQgdGhlIHVub2JzY3VyZWQgYXJlYSBoYXMgcmVhY2hlZCBhIHN0 YWJsZSBzdGF0ZS4KKy0gKHZvaWQpX2NvbW1pdE9ic2N1cmVkSW5zZXQ7CiAjZW5kaWYKIAogQGVu ZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9pb3MvV0tWaWV3SU9T Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9pb3MvV0tWaWV3SU9TLm1tCmluZGV4 IGY3NWZhNmZmNjRhMWUyMDVlMWIxMTc0YjRlODgxYmYwNGM1MzZkM2YuLjVmMjFlYjA4NmE2MzQ3 ZGYyNjdmYzEzZGViN2FhYWI1NWEzN2MzYTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvaW9zL1dLVmlld0lPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2lvcy9XS1ZpZXdJT1MubW0KQEAgLTQ2LDYgKzQ2LDggQEAKICAgICBCT09MIF9pc1dh aXRpbmdGb3JOZXdMYXllclRyZWVBZnRlckRpZENvbW1pdExvYWQ7CiAgICAgQk9PTCBfaGFzU3Rh dGljTWluaW11bUxheW91dFNpemU7CiAgICAgQ0dTaXplIF9taW5pbXVtTGF5b3V0U2l6ZU92ZXJy aWRlOworCisgICAgVUlFZGdlSW5zZXRzIF9vYnNjdXJlZEluc2V0OwogfQogCiAtIChpZClpbml0 V2l0aENvZGVyOihOU0NvZGVyICopY29kZXIKQEAgLTI1NSw0ICsyNTcsMjIgQEAKICAgICBbX2Nv bnRlbnRWaWV3IHNldE1pbmltdW1MYXlvdXRTaXplOm1pbmltdW1MYXlvdXRTaXplT3ZlcnJpZGVd OwogfQogCistIChVSUVkZ2VJbnNldHMpX29ic2N1cmVkSW5zZXQKK3sKKyAgICByZXR1cm4gX29i c2N1cmVkSW5zZXQ7Cit9CisKKy0gKHZvaWQpX3NldE9ic2N1cmVkSW5zZXQ6KFVJRWRnZUluc2V0 cylvYnNjdXJlZEluc2V0Cit7CisgICAgQVNTRVJUKG9ic2N1cmVkSW5zZXQudG9wID49IDApOwor ICAgIEFTU0VSVChvYnNjdXJlZEluc2V0LmxlZnQgPj0gMCk7CisgICAgQVNTRVJUKG9ic2N1cmVk SW5zZXQuYm90dG9tID49IDApOworICAgIEFTU0VSVChvYnNjdXJlZEluc2V0LnJpZ2h0ID49IDAp OworICAgIF9vYnNjdXJlZEluc2V0ID0gb2JzY3VyZWRJbnNldDsKK30KKworLSAodm9pZClfY29t bWl0T2JzY3VyZWRJbnNldAoreworfQorCiBAZW5kCg== 223502 2014-02-07 15:19:14 -0800 2014-02-10 13:52:39 -0800 Patch bug-128396-20140207151914.patch text/plain 5514 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzM3OTFhMDYyODBjYjFl NTM3ZDM2ZDdhN2NiYzVlZGM1NDQ1Y2IwNi4uYTAzYTkwYzFhMmE0ZjExNjQ5YzUwNjc0NDQ1NzI3 NDAyNTkzOWVhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE0LTAyLTA3ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCisgICAgICAgIFtpT1NdW1dLMl0g QWRkIGVtcHR5IGRlZmluaXRpb24gZm9yIGFuIEFQSSBhbGxvd2luZyBjbGllbnRzIHRvIGRlZmlu ZSBvYnNjdXJlZCBlZGdlcyBvdmVyIHRoZSBzY3JvbGx2aWV3CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgzOTYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPYnNjdXJlZEluc2V0IGRlZmluZXMgdGhlIGFy ZWEgb2YgdGhlIHNjcm9sbHZpZXcgdW51c2FibGUgZm9yIHBvc2l0aW9uaW5nIGNvbnRlbnQuCisg ICAgICAgIFRoZSBBUEkgaXMgdW51c2VkIGluIHRoaXMgcGF0Y2guCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL0NvY29hL1dLVmlld1ByaXZhdGUuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9vYnNjdXJlZEluc2V0 XSk6CisgICAgICAgICgtW1dLV2ViVmlldyBfc2V0T2JzY3VyZWRJbnNldDpdKToKKyAgICAgICAg KC1bV0tXZWJWaWV3IF9jb21taXRPYnNjdXJlZEluc2V0XSk6CisgICAgICAgICogVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9p b3MvV0tWaWV3SU9TLm1tOgorICAgICAgICAoLVtXS1ZpZXcgX29ic2N1cmVkSW5zZXRdKToKKyAg ICAgICAgKC1bV0tWaWV3IF9zZXRPYnNjdXJlZEluc2V0Ol0pOgorICAgICAgICAoLVtXS1ZpZXcg X2NvbW1pdE9ic2N1cmVkSW5zZXRdKToKKworMjAxNC0wMi0wNyAgQmVuamFtaW4gUG91bGFpbiAg PGJwb3VsYWluQGFwcGxlLmNvbT4KKwogICAgICAgICBbV0syXSBGaXRsZXIgdG91Y2ggZXZlbnRz IG9ubHkgYmFzZWQgb24gdG91Y2ggc3RhcnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyODM1NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL0NvY29hL1dLVmlld1ByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQ29jb2EvV0tWaWV3UHJpdmF0ZS5oCmluZGV4IDA1ZjYyYjczYzRmNTM3OWI4ZWY5 YWVhZWNhMGVjNTY2Y2NiYTA2YmMuLjM1ZGYwZDBkZjYzMjgzYjEyMWUyMDdlNDBiZWQ2ODk5NmZm YWUwODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tW aWV3UHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tW aWV3UHJpdmF0ZS5oCkBAIC00NCw2ICs0NCwxMiBAQAogCiBAcHJvcGVydHkgKG5vbmF0b21pYykg Q0dTaXplIG1pbmltdW1MYXlvdXRTaXplT3ZlcnJpZGU7CiAKKy8vIERlZmluZSB0aGUgaW5zZXQg b2YgdGhlIHNjcm9sbHZpZXcgdW51c2FibGUgYnkgdGhlIHdlYiBwYWdlLgorQHByb3BlcnR5IChu b25hdG9taWMsIHNldHRlcj1fc2V0T2JzY3VyZWRJbnNldHM6KSBVSUVkZ2VJbnNldHMgX29ic2N1 cmVkSW5zZXRzOworCistICh2b2lkKV9iZWdpbkludGVyYWN0aXZlT2JzY3VyZWRJbnNldHNDaGFu Z2U7CistICh2b2lkKV9lbmRJbnRlcmFjdGl2ZU9ic2N1cmVkSW5zZXRzQ2hhbmdlOworCiAjZWxz ZQogCiAtIChOU1ByaW50T3BlcmF0aW9uICopcHJpbnRPcGVyYXRpb25XaXRoUHJpbnRJbmZvOihO U1ByaW50SW5mbyAqKXByaW50SW5mbyBmb3JGcmFtZTooV0tGcmFtZVJlZilmcmFtZVJlZjsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1t IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KaW5kZXgg M2MxMTdhNjQyNTA1OWI0MzAwNjNlZjEyNGYyZTAyMTFlZTcwZjk5OS4uYWVkZjg2ODQ0ZWZhYjcy ODM3ZjEzNTExMWYxMjBjNDkyYjkyODJlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KQEAgLTY1LDYgKzY1LDkgQEAKICAgICBCT09MIF9p c1dhaXRpbmdGb3JOZXdMYXllclRyZWVBZnRlckRpZENvbW1pdExvYWQ7CiAgICAgQk9PTCBfaGFz U3RhdGljTWluaW11bUxheW91dFNpemU7CiAgICAgQ0dTaXplIF9taW5pbXVtTGF5b3V0U2l6ZU92 ZXJyaWRlOworCisgICAgVUlFZGdlSW5zZXRzIF9vYnNjdXJlZEluc2V0czsKKyAgICBib29sIF9p c0NoYW5naW5nT2JzY3VyZWRJbnNldHNJbnRlcmFjdGl2ZWx5OwogI2VuZGlmCiAjaWYgUExBVEZP Uk0oTUFDKSAmJiAhUExBVEZPUk0oSU9TKQogICAgIFJldGFpblB0cjxXS1ZpZXc+IF93a1ZpZXc7 CkBAIC0zNjYsNiArMzY5LDMyIEBACiAgICAgW19jb250ZW50VmlldyBzZXRNaW5pbXVtTGF5b3V0 U2l6ZTptaW5pbXVtTGF5b3V0U2l6ZU92ZXJyaWRlXTsKIH0KIAorLSAoVUlFZGdlSW5zZXRzKV9v YnNjdXJlZEluc2V0cworeworICAgIHJldHVybiBfb2JzY3VyZWRJbnNldHM7Cit9CisKKy0gKHZv aWQpX3NldE9ic2N1cmVkSW5zZXRzOihVSUVkZ2VJbnNldHMpb2JzY3VyZWRJbnNldHMKK3sKKyAg ICBBU1NFUlQob2JzY3VyZWRJbnNldHMudG9wID49IDApOworICAgIEFTU0VSVChvYnNjdXJlZElu c2V0cy5sZWZ0ID49IDApOworICAgIEFTU0VSVChvYnNjdXJlZEluc2V0cy5ib3R0b20gPj0gMCk7 CisgICAgQVNTRVJUKG9ic2N1cmVkSW5zZXRzLnJpZ2h0ID49IDApOworICAgIF9vYnNjdXJlZElu c2V0cyA9IG9ic2N1cmVkSW5zZXRzOworfQorCistICh2b2lkKV9iZWdpbkludGVyYWN0aXZlT2Jz Y3VyZWRJbnNldHNDaGFuZ2UKK3sKKyAgICBBU1NFUlQoIV9pc0NoYW5naW5nT2JzY3VyZWRJbnNl dHNJbnRlcmFjdGl2ZWx5KTsKKyAgICBfaXNDaGFuZ2luZ09ic2N1cmVkSW5zZXRzSW50ZXJhY3Rp dmVseSA9IFlFUzsKK30KKworLSAodm9pZClfZW5kSW50ZXJhY3RpdmVPYnNjdXJlZEluc2V0c0No YW5nZQoreworICAgIEFTU0VSVChfaXNDaGFuZ2luZ09ic2N1cmVkSW5zZXRzSW50ZXJhY3RpdmVs eSk7CisgICAgX2lzQ2hhbmdpbmdPYnNjdXJlZEluc2V0c0ludGVyYWN0aXZlbHkgPSBOTzsKK30K KwogI2VuZGlmCiAKIEBlbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmgKaW5kZXggNjhjODM3NWE2NDJlNGQwMDBkODU2N2Mw NWRiZWE0ZTVmMTkxMjBmNC4uODI3OGExMGUwODc3YmQ4ZTUyNjE1MDY4MjhlZWI4ZTczZGI4OWQ1 ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZp ZXdQcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dl YlZpZXdQcml2YXRlLmgKQEAgLTM1LDYgKzM1LDEyIEBACiAKICNpZiBUQVJHRVRfT1NfSVBIT05F CiBAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9zZXRNaW5pbXVtTGF5b3V0U2l6ZU92ZXJy aWRlOikgQ0dTaXplIF9taW5pbXVtTGF5b3V0U2l6ZU92ZXJyaWRlOworCisvLyBEZWZpbmUgdGhl IGluc2V0IG9mIHRoZSBzY3JvbGx2aWV3IHVudXNhYmxlIGJ5IHRoZSB3ZWIgcGFnZS4KK0Bwcm9w ZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3NldE9ic2N1cmVkSW5zZXRzOikgVUlFZGdlSW5zZXRz IF9vYnNjdXJlZEluc2V0czsKKworLSAodm9pZClfYmVnaW5JbnRlcmFjdGl2ZU9ic2N1cmVkSW5z ZXRzQ2hhbmdlOworLSAodm9pZClfZW5kSW50ZXJhY3RpdmVPYnNjdXJlZEluc2V0c0NoYW5nZTsK ICNlbmRpZgogCiBAZW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2lvcy9XS1ZpZXdJT1MubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2lvcy9XS1Zp ZXdJT1MubW0KaW5kZXggZjc1ZmE2ZmY2NGExZTIwNWUxYjExNzRiNGU4ODFiZjA0YzUzNmQzZi4u YTlhOGIwMmViMjk5NzY5MmJjYjFlMjg1Njc4ZTZiNmMwOWQxYzMwNiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9pb3MvV0tWaWV3SU9TLm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvaW9zL1dLVmlld0lPUy5tbQpAQCAtNDYsNiArNDYsOSBAQAog ICAgIEJPT0wgX2lzV2FpdGluZ0Zvck5ld0xheWVyVHJlZUFmdGVyRGlkQ29tbWl0TG9hZDsKICAg ICBCT09MIF9oYXNTdGF0aWNNaW5pbXVtTGF5b3V0U2l6ZTsKICAgICBDR1NpemUgX21pbmltdW1M YXlvdXRTaXplT3ZlcnJpZGU7CisKKyAgICBVSUVkZ2VJbnNldHMgX29ic2N1cmVkSW5zZXRzOwor ICAgIGJvb2wgX2lzQ2hhbmdpbmdPYnNjdXJlZEluc2V0c0ludGVyYWN0aXZlbHk7CiB9CiAKIC0g KGlkKWluaXRXaXRoQ29kZXI6KE5TQ29kZXIgKiljb2RlcgpAQCAtMjU1LDQgKzI1OCwzMCBAQAog ICAgIFtfY29udGVudFZpZXcgc2V0TWluaW11bUxheW91dFNpemU6bWluaW11bUxheW91dFNpemVP dmVycmlkZV07CiB9CiAKKy0gKFVJRWRnZUluc2V0cylfb2JzY3VyZWRJbnNldHMKK3sKKyAgICBy ZXR1cm4gX29ic2N1cmVkSW5zZXRzOworfQorCistICh2b2lkKV9zZXRPYnNjdXJlZEluc2V0czoo VUlFZGdlSW5zZXRzKW9ic2N1cmVkSW5zZXRzCit7CisgICAgQVNTRVJUKG9ic2N1cmVkSW5zZXRz LnRvcCA+PSAwKTsKKyAgICBBU1NFUlQob2JzY3VyZWRJbnNldHMubGVmdCA+PSAwKTsKKyAgICBB U1NFUlQob2JzY3VyZWRJbnNldHMuYm90dG9tID49IDApOworICAgIEFTU0VSVChvYnNjdXJlZElu c2V0cy5yaWdodCA+PSAwKTsKKyAgICBfb2JzY3VyZWRJbnNldHMgPSBvYnNjdXJlZEluc2V0czsK K30KKworLSAodm9pZClfYmVnaW5JbnRlcmFjdGl2ZU9ic2N1cmVkSW5zZXRzQ2hhbmdlCit7Cisg ICAgQVNTRVJUKCFfaXNDaGFuZ2luZ09ic2N1cmVkSW5zZXRzSW50ZXJhY3RpdmVseSk7CisgICAg X2lzQ2hhbmdpbmdPYnNjdXJlZEluc2V0c0ludGVyYWN0aXZlbHkgPSBZRVM7Cit9CisKKy0gKHZv aWQpX2VuZEludGVyYWN0aXZlT2JzY3VyZWRJbnNldHNDaGFuZ2UKK3sKKyAgICBBU1NFUlQoX2lz Q2hhbmdpbmdPYnNjdXJlZEluc2V0c0ludGVyYWN0aXZlbHkpOworICAgIF9pc0NoYW5naW5nT2Jz Y3VyZWRJbnNldHNJbnRlcmFjdGl2ZWx5ID0gTk87Cit9CisKIEBlbmQK