128390 2014-02-07 13:11:18 -0800 WebGL doesn't update with remotely hosted layers 2014-02-07 14:07:57 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino simon.fraser thorton oldest_to_newest 977997 0 dino 2014-02-07 13:11:18 -0800 WebGL doesn't push frames when attached to a remote layer host. 977998 1 dino 2014-02-07 13:12:24 -0800 <rdar://problem/15260182> 978003 2 223489 dino 2014-02-07 13:19:37 -0800 Created attachment 223489 Patch 978011 3 223489 simon.fraser 2014-02-07 13:33:28 -0800 Comment on attachment 223489 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223489&action=review > Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:51 > + bool m_providesContents; You forgot to initialize this in the ctor. > Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:62 > + m_providesContents = [customLayer isKindOfClass:[WebGLLayer class]]; I think you could do this with the classname without pulling in WebGLLayer.h 978013 4 223489 dino 2014-02-07 13:37:20 -0800 Comment on attachment 223489 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223489&action=review >> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:51 >> + bool m_providesContents; > > You forgot to initialize this in the ctor. It's initalised in the ctor body. >> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:62 >> + m_providesContents = [customLayer isKindOfClass:[WebGLLayer class]]; > > I think you could do this with the classname without pulling in WebGLLayer.h Yeah, I'm now trying to get there via GraphicsLayer 978037 5 dino 2014-02-07 14:07:57 -0800 Committed r163646: <http://trac.webkit.org/changeset/163646> 223489 2014-02-07 13:19:37 -0800 2014-02-07 13:37:20 -0800 Patch bug-128390-20140207131937.patch text/plain 6143 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDAxYWNjNjQwN2RiMDll MzZjNGNjNTA4OGUzN2Y0YTg5NWZiMWRkZS4uYzMxNmQyYzRmN2QxYTJlMTljMTlhODk0ZTgzMmU4 OGIzZmRkMzAyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAyLTA3ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJHTCBkb2Vzbid0IHVwZGF0 ZSB3aXRoIHJlbW90ZWx5IGhvc3RlZCBsYXllcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODM5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEV4cG9ydCBXZWJHTExheWVyIGZyb20gV2ViQ29yZS4KKwor ICAgICAgICAqIFdlYkNvcmUuZXhwLmluOgorICAgICAgICAqIFdlYkNvcmUueGNvZGVwcm9qL3By b2plY3QucGJ4cHJvajoKKwogMjAxNC0wMi0wNSAgSGFucyBNdWxsZXIgIDxobXVsbGVyQGFkb2Jl LmNvbT4KIAogICAgICAgICBbQ1NTIFNoYXBlc10gRHluYW1pY2FsbHkgY3JlYXRlZCBlbGVtZW50 IHdpdGggaW1hZ2UgdmFsdWVkIHNoYXBlLW91dHNpZGUgZG9lc24ndCB1cGRhdGUgYXV0b21hdGlj YWxseQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCmluZGV4IDIzYmMyN2MyNmYwNTEzNjNiYWNhOTc1Nzc1ZmJmMTY4YWQyMmYw MTEuLmJkNTk5MjkxNmQ0MGI3NjNmMjRkN2U0NmUyZmQxYTE3MzY4YmJmZjMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cK QEAgLTEsMyArMSwyMCBAQAorMjAxNC0wMi0wNyAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5j b20+CisKKyAgICAgICAgV2ViR0wgZG9lc24ndCB1cGRhdGUgd2l0aCByZW1vdGVseSBob3N0ZWQg bGF5ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjgzOTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQ bGF0Zm9ybUNBTGF5ZXJSZW1vdGUgd2FzIGludGVyY2VwdGluZyB0aGUgc2V0TmVlZHNEaXNwbGF5 IGNhbGxzIHRvCisgICAgICAgIFdlYkdMIGxheWVycywgYW5kIHRodXMgY2F1c2luZyB0aGVtIHRv IG5vdCBkcmF3LiBGaXggdGhpcyBieSBhZGRpbmcgYW4KKyAgICAgICAgb3ZlcnJpZGUgaW4gUGxh dGZvcm1DQUxheWVyUmVtb3RlQ3VzdG9tIHRvIGNoZWNrIGlmIGl0IGlzIGEgV2ViR0xMYXllcgor ICAgICAgICBhbmQgY2FsbCBzZXROZWVkc0Rpc3BsYXkgZGlyZWN0bHkuCisKKyAgICAgICAgKiBX ZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1BsYXRmb3JtQ0FMYXllclJlbW90ZUN1c3RvbS5oOgorICAg ICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUGxhdGZvcm1DQUxheWVyUmVtb3RlQ3VzdG9t Lm1tOgorICAgICAgICAoUGxhdGZvcm1DQUxheWVyUmVtb3RlQ3VzdG9tOjpQbGF0Zm9ybUNBTGF5 ZXJSZW1vdGVDdXN0b20pOgorICAgICAgICAoUGxhdGZvcm1DQUxheWVyUmVtb3RlQ3VzdG9tOjpz ZXROZWVkc0Rpc3BsYXkpOgorCiAyMDE0LTAyLTA1ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBw bGUuY29tPgogCiAgICAgICAgIFtXSzJdIFtpT1NdIE5vIHZpZGVvIG9uIGVtYmVkZGVkIFlvdVR1 YmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluIGIvU291cmNlL1dl YkNvcmUvV2ViQ29yZS5leHAuaW4KaW5kZXggNWRlZmJiNGE5YzQ0ZGViNjIxZmI1ZDc1MmVkNzk3 NzQ3MjE5OGNjNy4uNmQxNDI5ZjQxMTYyZWZmOTI3MWRhMzRlZTk4MzVlNjkxODU2NGRlZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KKysrIGIvU291cmNlL1dlYkNv cmUvV2ViQ29yZS5leHAuaW4KQEAgLTM1LDYgKzM1LDcgQEAKIC5vYmpjX2NsYXNzX25hbWVfRE9N VGV4dEV2ZW50CiAub2JqY19jbGFzc19uYW1lX0RPTVVJRXZlbnQKIC5vYmpjX2NsYXNzX25hbWVf RE9NV2hlZWxFdmVudAorLm9iamNfY2xhc3NfbmFtZV9XZWJHTExheWVyCiAub2JqY19jbGFzc19u YW1lX1dlYlNjcmlwdE9iamVjdAogLm9iamNfY2xhc3NfbmFtZV9XZWJTY3JpcHRPYmplY3RQcml2 YXRlCiAub2JqY19jbGFzc19uYW1lX1dlYlVuZGVmaW5lZApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qIGIvU291cmNlL1dlYkNvcmUv V2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IGY5YTYxZDU3YjRkZWY3NTA3 MWNlY2RlNDZlZDI4ZTkzNWJjYmZhMmQuLjAyNmY3ZDc5YzlmM2Y5ODVkN2Q2NzBiNzFiMzU4Yzhm MmY0MGRlY2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3By b2plY3QucGJ4cHJvagorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9q ZWN0LnBieHByb2oKQEAgLTE2NTQsNyArMTY1NCw3IEBACiAJCTQ5RUVEMTUwMTA1MTk3MUEwMDA5 OUZBQiAvKiBKU0NhbnZhc1JlbmRlcmluZ0NvbnRleHRDdXN0b20uY3BwIGluIFNvdXJjZXMgKi8g PSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gNDlFRUQxNEQxMDUxOTcxQTAwMDk5RkFC IC8qIEpTQ2FudmFzUmVuZGVyaW5nQ29udGV4dEN1c3RvbS5jcHAgKi87IH07CiAJCTQ5RkM3QTUw MTQ0NEFGNUYwMEE1RDg2NCAvKiBEaXNwbGF5UmVmcmVzaE1vbml0b3IuY3BwIGluIFNvdXJjZXMg Ki8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gNDlGQzdBNEYxNDQ0QUY1RjAwQTVE ODY0IC8qIERpc3BsYXlSZWZyZXNoTW9uaXRvci5jcHAgKi87IH07CiAJCTQ5RkZCRjFEMTFDODU1 MEUwMDZBNzExOCAvKiBHcmFwaGljc0NvbnRleHQzRE1hYy5tbSBpbiBTb3VyY2VzICovID0ge2lz YSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDQ5RkZCRjFDMTFDODU1MEUwMDZBNzExOCAvKiBH cmFwaGljc0NvbnRleHQzRE1hYy5tbSAqLzsgfTsKLQkJNDlGRkJGM0YxMUM5M0VFMzAwNkE3MTE4 IC8qIFdlYkdMTGF5ZXIuaCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmls ZVJlZiA9IDQ5RkZCRjNEMTFDOTNFRTMwMDZBNzExOCAvKiBXZWJHTExheWVyLmggKi87IH07CisJ CTQ5RkZCRjNGMTFDOTNFRTMwMDZBNzExOCAvKiBXZWJHTExheWVyLmggaW4gSGVhZGVycyAqLyA9 IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA0OUZGQkYzRDExQzkzRUUzMDA2QTcxMTgg LyogV2ViR0xMYXllci5oICovOyBzZXR0aW5ncyA9IHtBVFRSSUJVVEVTID0gKFB1YmxpYywgKTsg fTsgfTsKIAkJNDlGRkJGNDAxMUM5M0VFMzAwNkE3MTE4IC8qIFdlYkdMTGF5ZXIubW0gaW4gU291 cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA0OUZGQkYzRTExQzkzRUUz MDA2QTcxMTggLyogV2ViR0xMYXllci5tbSAqLzsgfTsKIAkJNEEwREEyRkUxMjlCMjQxOTAwQUI2 MUUxIC8qIEZvcm1Bc3NvY2lhdGVkRWxlbWVudC5jcHAgaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQ QlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA0QTBEQTJGQzEyOUIyNDE5MDBBQjYxRTEgLyogRm9ybUFz c29jaWF0ZWRFbGVtZW50LmNwcCAqLzsgfTsKIAkJNEEwREEyRkYxMjlCMjQxOTAwQUI2MUUxIC8q IEZvcm1Bc3NvY2lhdGVkRWxlbWVudC5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRG aWxlOyBmaWxlUmVmID0gNEEwREEyRkQxMjlCMjQxOTAwQUI2MUUxIC8qIEZvcm1Bc3NvY2lhdGVk RWxlbWVudC5oICovOyBzZXR0aW5ncyA9IHtBVFRSSUJVVEVTID0gKFByaXZhdGUsICk7IH07IH07 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1BsYXRm b3JtQ0FMYXllclJlbW90ZUN1c3RvbS5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL21hYy9QbGF0Zm9ybUNBTGF5ZXJSZW1vdGVDdXN0b20uaAppbmRleCAzMzJiNzIwZmVhMGVi YmE1MTJjZDhjNTgwMTg1YzI2Y2VlYjJlMzZlLi5lNjliNTY5ZGEyODgwMTc4ZmE2ZThlMjBkZWY4 NTM0OTg5YTRhNTI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvbWFjL1BsYXRmb3JtQ0FMYXllclJlbW90ZUN1c3RvbS5oCisrKyBiL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUGxhdGZvcm1DQUxheWVyUmVtb3RlQ3VzdG9tLmgKQEAg LTQxLDExICs0MSwxNCBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIHVpbnQzMl90IGhvc3RpbmdD b250ZXh0SUQoKSBvdmVycmlkZTsKIAorICAgIHZpcnR1YWwgdm9pZCBzZXROZWVkc0Rpc3BsYXko Y29uc3QgV2ViQ29yZTo6RmxvYXRSZWN0KiBkaXJ0eVJlY3QgPSAwKSBvdmVycmlkZTsKKwogcHJp dmF0ZToKICAgICBQbGF0Zm9ybUNBTGF5ZXJSZW1vdGVDdXN0b20oUGxhdGZvcm1MYXllciosIFdl YkNvcmU6OlBsYXRmb3JtQ0FMYXllckNsaWVudCogb3duZXIsIFJlbW90ZUxheWVyVHJlZUNvbnRl eHQqKTsKIAogICAgIHN0ZDo6dW5pcXVlX3B0cjxMYXllckhvc3RpbmdDb250ZXh0PiBtX2xheWVy SG9zdGluZ0NvbnRleHQ7CiAgICAgUmV0YWluUHRyPFBsYXRmb3JtTGF5ZXI+IG1fcGxhdGZvcm1M YXllcjsKKyAgICBib29sIG1fcHJvdmlkZXNDb250ZW50czsKIH07CiAKIH0gLy8gbmFtZXNwYWNl IFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21h Yy9QbGF0Zm9ybUNBTGF5ZXJSZW1vdGVDdXN0b20ubW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvbWFjL1BsYXRmb3JtQ0FMYXllclJlbW90ZUN1c3RvbS5tbQppbmRleCA5NWEx ZGRhMTE0MTlmNTBkYTRiMjJiZmY1MDc0NmQ2NzFjOGI3NTY0Li5lYmM1MTg0OGRiZGRhMmM0ZWZh NTkzZDIyYzlhMThmMGI5YjY3Zjc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvbWFjL1BsYXRmb3JtQ0FMYXllclJlbW90ZUN1c3RvbS5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1BsYXRmb3JtQ0FMYXllclJlbW90ZUN1 c3RvbS5tbQpAQCAtMzQsNiArMzQsNyBAQAogI2ltcG9ydCA8V2ViQ29yZS9QbGF0Zm9ybUNBTGF5 ZXJNYWMuaD4KICNpbXBvcnQgPFdlYkNvcmUvU29mdExpbmtpbmcuaD4KICNpbXBvcnQgPFdlYkNv cmUvV2ViQ29yZUNBTGF5ZXJFeHRyYXMuaD4KKyNpbXBvcnQgPFdlYkNvcmUvV2ViR0xMYXllci5o PgogI2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgogCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsK QEAgLTU3LDYgKzU4LDggQEAgUGxhdGZvcm1DQUxheWVyUmVtb3RlQ3VzdG9tOjpQbGF0Zm9ybUNB TGF5ZXJSZW1vdGVDdXN0b20oUGxhdGZvcm1MYXllciogY3VzdG9tTGEKIAogICAgIG1fcGxhdGZv cm1MYXllciA9IGN1c3RvbUxheWVyOwogICAgIFtjdXN0b21MYXllciB3ZWJfZGlzYWJsZUFsbEFj dGlvbnNdOworCisgICAgbV9wcm92aWRlc0NvbnRlbnRzID0gW2N1c3RvbUxheWVyIGlzS2luZE9m Q2xhc3M6W1dlYkdMTGF5ZXIgY2xhc3NdXTsKIH0KIAogUGxhdGZvcm1DQUxheWVyUmVtb3RlQ3Vz dG9tOjp+UGxhdGZvcm1DQUxheWVyUmVtb3RlQ3VzdG9tKCkKQEAgLTY3LDMgKzcwLDExIEBAIHVp bnQzMl90IFBsYXRmb3JtQ0FMYXllclJlbW90ZUN1c3RvbTo6aG9zdGluZ0NvbnRleHRJRCgpCiB7 CiAgICAgcmV0dXJuIG1fbGF5ZXJIb3N0aW5nQ29udGV4dC0+Y29udGV4dElEKCk7CiB9CisKK3Zv aWQgUGxhdGZvcm1DQUxheWVyUmVtb3RlQ3VzdG9tOjpzZXROZWVkc0Rpc3BsYXkoY29uc3QgRmxv YXRSZWN0KiByZWN0KQoreworICAgIGlmIChtX3Byb3ZpZGVzQ29udGVudHMpCisgICAgICAgIFtt X3BsYXRmb3JtTGF5ZXIgc2V0TmVlZHNEaXNwbGF5XTsKKyAgICBlbHNlCisgICAgICAgIFBsYXRm b3JtQ0FMYXllclJlbW90ZTo6c2V0TmVlZHNEaXNwbGF5KHJlY3QpOworfQo=