<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>128385</bug_id>
          
          <creation_ts>2014-02-07 11:34:11 -0800</creation_ts>
          <short_desc>Copying a WebPreferences object should be done through a member function</short_desc>
          <delta_ts>2014-02-07 11:38:30 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Anders Carlsson">andersca</reporter>
          <assigned_to name="Anders Carlsson">andersca</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>977949</commentid>
    <comment_count>0</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-02-07 11:34:11 -0800</bug_when>
    <thetext>Copying a WebPreferences object should be done through a member function</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>977950</commentid>
    <comment_count>1</comment_count>
      <attachid>223476</attachid>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-02-07 11:34:25 -0800</bug_when>
    <thetext>Created attachment 223476
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>977953</commentid>
    <comment_count>2</comment_count>
      <attachid>223476</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2014-02-07 11:36:13 -0800</bug_when>
    <thetext>Comment on attachment 223476
Patch

k</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>977956</commentid>
    <comment_count>3</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-02-07 11:38:30 -0800</bug_when>
    <thetext>Committed r163636: &lt;http://trac.webkit.org/changeset/163636&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>223476</attachid>
            <date>2014-02-07 11:34:25 -0800</date>
            <delta_ts>2014-02-07 11:36:12 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-128385-20140207113425.patch</filename>
            <type>text/plain</type>
            <size>2958</size>
            <attacher name="Anders Carlsson">andersca</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDIzNTIwMTQ1YWM4ZmM2
MTQxYmQ4NTRhYmFiMDZlOTg1MzEwMTUzNC4uOGQwZWIwOTVkMzg3OGMxMTA3ZTMyM2M3N2M1YWM5
NzUyNGE1NjVkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE0LTAyLTA3ICBBbmRl
cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgQ29weWluZyBhIFdl
YlByZWZlcmVuY2VzIG9iamVjdCBzaG91bGQgYmUgZG9uZSB0aHJvdWdoIGEgbWVtYmVyIGZ1bmN0
aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgz
ODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJ
UHJvY2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzLmNwcDoKKyAgICAgICAgKFdLUHJlZmVyZW5jZXND
cmVhdGVDb3B5KToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJlZmVyZW5jZXMuY3BwOgorICAg
ICAgICAoV2ViS2l0OjpXZWJQcmVmZXJlbmNlczo6Y29weSk6CisgICAgICAgICogVUlQcm9jZXNz
L1dlYlByZWZlcmVuY2VzLmg6CisKKzIwMTQtMDItMDcgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVy
c2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWJQYWdlR3JvdXA6OnNldFByZWZlcmVuY2VzIHNo
b3VsZCBzZXQgdGhlIHByZWZlcmVuY2VzIG9uIGFsbCBwYWdlcyBpbiB0aGUgZ3JvdXAKICAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODM4MwogCmRpZmYg
LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJlbmNlcy5jcHAg
Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJlbmNlcy5jcHAKaW5kZXgg
ZTk4OTI1NWM4NDkwM2RjOGQ1ZjZmMTZkN2QyYTg5OWRkMjkxYzVkYi4uYjI0NTQwMmMzZGI4MDE3
NzlmNzVjODRiYmE1ZDgzZTNiZmZjODc5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ
cm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv
Y2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzLmNwcApAQCAtNTUsNyArNTUsNyBAQCBXS1ByZWZlcmVu
Y2VzUmVmIFdLUHJlZmVyZW5jZXNDcmVhdGVXaXRoSWRlbnRpZmllcihXS1N0cmluZ1JlZiBpZGVu
dGlmaWVyUmVmKQogCiBXS1ByZWZlcmVuY2VzUmVmIFdLUHJlZmVyZW5jZXNDcmVhdGVDb3B5KFdL
UHJlZmVyZW5jZXNSZWYgcHJlZmVyZW5jZXNSZWYpCiB7Ci0gICAgUmVmUHRyPFdlYlByZWZlcmVu
Y2VzPiBwcmVmZXJlbmNlcyA9IFdlYlByZWZlcmVuY2VzOjpjcmVhdGUoKnRvSW1wbChwcmVmZXJl
bmNlc1JlZikpOworICAgIFJlZlB0cjxXZWJQcmVmZXJlbmNlcz4gcHJlZmVyZW5jZXMgPSB0b0lt
cGwocHJlZmVyZW5jZXNSZWYpLT5jb3B5KCk7CiAgICAgcmV0dXJuIHRvQVBJKHByZWZlcmVuY2Vz
LnJlbGVhc2UoKS5sZWFrUmVmKCkpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V
SVByb2Nlc3MvV2ViUHJlZmVyZW5jZXMuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dl
YlByZWZlcmVuY2VzLmNwcAppbmRleCBhNGM0Yjc5NmFmMzU5ZjQxMWEyMzZmMzA0MjkwN2ZkZjI0
NGIyOGI1Li4zMDc2MjI0ZTRkMzliMjAwYTJlMTNhZmI1OTM2NWVjZjEwZjM0NzA3IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJlZmVyZW5jZXMuY3BwCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcmVmZXJlbmNlcy5jcHAKQEAgLTU4LDYgKzU4LDEx
IEBAIFdlYlByZWZlcmVuY2VzOjp+V2ViUHJlZmVyZW5jZXMoKQogICAgIEFTU0VSVChtX3BhZ2VH
cm91cHMuaXNFbXB0eSgpKTsKIH0KIAorUGFzc1JlZlB0cjxXZWJQcmVmZXJlbmNlcz4gV2ViUHJl
ZmVyZW5jZXM6OmNvcHkoKSBjb25zdAoreworICAgIHJldHVybiBhZG9wdFJlZihuZXcgV2ViUHJl
ZmVyZW5jZXMoKnRoaXMpKTsKK30KKwogdm9pZCBXZWJQcmVmZXJlbmNlczo6YWRkUGFnZUdyb3Vw
KFdlYlBhZ2VHcm91cCogcGFnZUdyb3VwKQogewogICAgIGJvb2wgZGlkQWRkUGFnZUdyb3VwID0g
bV9wYWdlR3JvdXBzLmFkZChwYWdlR3JvdXApLmlzTmV3RW50cnk7CmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJlZmVyZW5jZXMuaCBiL1NvdXJjZS9XZWJLaXQyL1VJ
UHJvY2Vzcy9XZWJQcmVmZXJlbmNlcy5oCmluZGV4IDcyNWQ2MTEzZDMxOTgyZmFlNWY5YzM5N2Vi
ZjNhM2EwOWY1ZTQ4MDkuLjViYWVlYmMwMDQwYWExZjFiNmUxOTQwYTUzZTIzNTFmMDA3ZTJiMGYg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcmVmZXJlbmNlcy5oCisr
KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcmVmZXJlbmNlcy5oCkBAIC01MiwxMyAr
NTIsMTAgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFdlYlByZWZlcmVu
Y2VzKGlkZW50aWZpZXIpKTsKICAgICB9CiAKLSAgICBzdGF0aWMgUGFzc1JlZlB0cjxXZWJQcmVm
ZXJlbmNlcz4gY3JlYXRlKGNvbnN0IFdlYlByZWZlcmVuY2VzJiBvdGhlcikKLSAgICB7Ci0gICAg
ICAgIHJldHVybiBhZG9wdFJlZihuZXcgV2ViUHJlZmVyZW5jZXMob3RoZXIpKTsKLSAgICB9Ci0K
ICAgICB2aXJ0dWFsIH5XZWJQcmVmZXJlbmNlcygpOwogCisgICAgUGFzc1JlZlB0cjxXZWJQcmVm
ZXJlbmNlcz4gY29weSgpIGNvbnN0OworCiAgICAgdm9pZCBhZGRQYWdlR3JvdXAoV2ViUGFnZUdy
b3VwKik7CiAgICAgdm9pZCByZW1vdmVQYWdlR3JvdXAoV2ViUGFnZUdyb3VwKik7CiAK
</data>
<flag name="review"
          id="247512"
          type_id="1"
          status="+"
          setter="kling"
    />
          </attachment>
      

    </bug>

</bugzilla>