128384 2014-02-07 11:12:08 -0800 [iOS] Eliminate race between XPC connection queue and Notification queue 2014-02-07 14:26:07 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue ddkilzer ggaren joepeck timothy oldest_to_newest 977922 0 joepeck 2014-02-07 11:12:08 -0800 Radar: <rdar://problem/16009483> * STEPS TO REPRODUCE 1. Launch Remote Debugger 2. Launch MobileSafari 3. Suspend MobileSafari 4. Close Remote Debugger 5. Launch Remote Debugger 6. Launch MobileSafari => at either step (5) or (6) the suspended -> resumed MobileSafari should have responded to the "com.apple.webinspectord.available" notification and re-connected to webinspectord. However, it did not. This is a race between the notification handler on a generic global queue and the xpc failed notification being handled on the XPC connection queue. Sharing a queue gives us the correct deterministic ordering. 977923 1 223475 joepeck 2014-02-07 11:14:21 -0800 Created attachment 223475 [PATCH] Proposed Fix 978053 2 223475 commit-queue 2014-02-07 14:26:05 -0800 Comment on attachment 223475 [PATCH] Proposed Fix Clearing flags on attachment: 223475 Committed r163648: <http://trac.webkit.org/changeset/163648> 978054 3 commit-queue 2014-02-07 14:26:07 -0800 All reviewed patches have been landed. Closing bug. 223475 2014-02-07 11:14:21 -0800 2014-02-07 14:26:05 -0800 [PATCH] Proposed Fix xpc.patch text/plain 5587 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGMyN2U4ODEuLjIzMDkwMTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE0LTAyLTA3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gRWxpbWluYXRlIHJhY2Ug YmV0d2VlbiBYUEMgY29ubmVjdGlvbiBxdWV1ZSBhbmQgTm90aWZpY2F0aW9uIHF1ZXVlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgzODQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9y ZW1vdGUvUmVtb3RlSW5zcGVjdG9yLmg6CisgICAgICAgICogaW5zcGVjdG9yL3JlbW90ZS9SZW1v dGVJbnNwZWN0b3IubW06CisgICAgICAgIChJbnNwZWN0b3I6OlJlbW90ZUluc3BlY3Rvcjo6UmVt b3RlSW5zcGVjdG9yKToKKyAgICAgICAgKEluc3BlY3Rvcjo6UmVtb3RlSW5zcGVjdG9yOjpzdGFy dCk6CisgICAgICAgIChJbnNwZWN0b3I6OlJlbW90ZUluc3BlY3Rvcjo6c2V0dXBYUENDb25uZWN0 aW9uSWZOZWVkZWQpOgorICAgICAgICBDcmVhdGUgdGhlIHF1ZXVlIHRvIHVzZSBmb3IgUmVtb3Rl SW5zcGVjdG9yIHhwYyBjb25uZWN0aW9uCisgICAgICAgIG1hbmFnZW1lbnQgYW5kIHRoZSBjb25u ZWN0aW9uIGl0c2VsZi4KKworICAgICAgICAqIGluc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVj dG9yWFBDQ29ubmVjdGlvbi5oOgorICAgICAgICAqIGluc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5z cGVjdG9yWFBDQ29ubmVjdGlvbi5tbToKKyAgICAgICAgKEluc3BlY3Rvcjo6UmVtb3RlSW5zcGVj dG9yWFBDQ29ubmVjdGlvbjo6UmVtb3RlSW5zcGVjdG9yWFBDQ29ubmVjdGlvbik6CisgICAgICAg IFVzZSB0aGUgcGFzc2VkIGluIHF1ZXVlIGluc3RlYWQgb2YgY3JlYXRpbmcgb25lIGZvciBpdHNl bGYuCisKIDIwMTQtMDItMDYgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAK ICAgICAgICAgV29ya2Fyb3VuZCBSRUdSRVNTSU9OKHIxNjMxOTUtcjE2MzIyNyk6IENyYXNoIGJl bmVhdGggTlNFcnJvclVzZXJJbmZvRnJvbUpTRXhjZXB0aW9uIHdoZW4gaW5zdGFsbGluZyBBcHBs ZUludGVybmFsLm1wa2cKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0 b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rvci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLmgKaW5kZXggYmFhZGI0Ny4uNGYzZjRlNiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5z cGVjdG9yLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVt b3RlSW5zcGVjdG9yLmgKQEAgLTk1LDYgKzk1LDcgQEAgcHJpdmF0ZToKICAgICBIYXNoTWFwPHVu c2lnbmVkLCBzdGQ6OnBhaXI8UmVtb3RlSW5zcGVjdG9yRGVidWdnYWJsZSosIFJlbW90ZUluc3Bl Y3RvckRlYnVnZ2FibGVJbmZvPj4gbV9kZWJ1Z2dhYmxlTWFwOwogICAgIEhhc2hNYXA8dW5zaWdu ZWQsIFJlZlB0cjxSZW1vdGVJbnNwZWN0b3JEZWJ1Z2dhYmxlQ29ubmVjdGlvbj4+IG1fY29ubmVj dGlvbk1hcDsKICAgICBSZWZQdHI8UmVtb3RlSW5zcGVjdG9yWFBDQ29ubmVjdGlvbj4gbV94cGND b25uZWN0aW9uOworICAgIGRpc3BhdGNoX3F1ZXVlX3QgbV94cGNRdWV1ZTsKICAgICB1bnNpZ25l ZCBtX25leHRBdmFpbGFibGVJZGVudGlmaWVyOwogICAgIGludCBtX25vdGlmeVRva2VuOwogICAg IGJvb2wgbV9lbmFibGVkOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLm1tIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2lu c3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLm1tCmluZGV4IDY4MzFlZmQuLjE1M2RkMmUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90 ZUluc3BlY3Rvci5tbQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90 ZS9SZW1vdGVJbnNwZWN0b3IubW0KQEAgLTgwLDcgKzgwLDggQEAgUmVtb3RlSW5zcGVjdG9yJiBS ZW1vdGVJbnNwZWN0b3I6OnNoYXJlZCgpCiB9CiAKIFJlbW90ZUluc3BlY3Rvcjo6UmVtb3RlSW5z cGVjdG9yKCkKLSAgICA6IG1fbmV4dEF2YWlsYWJsZUlkZW50aWZpZXIoMSkKKyAgICA6IG1feHBj UXVldWUoZGlzcGF0Y2hfcXVldWVfY3JlYXRlKCJjb20uYXBwbGUuSmF2YVNjcmlwdENvcmUucmVt b3RlLWluc3BlY3Rvci14cGMiLCBESVNQQVRDSF9RVUVVRV9TRVJJQUwpKQorICAgICwgbV9uZXh0 QXZhaWxhYmxlSWRlbnRpZmllcigxKQogICAgICwgbV9ub3RpZnlUb2tlbigwKQogICAgICwgbV9l bmFibGVkKGZhbHNlKQogICAgICwgbV9oYXNBY3RpdmVEZWJ1Z1Nlc3Npb24oZmFsc2UpCkBAIC0x NzIsNyArMTczLDcgQEAgdm9pZCBSZW1vdGVJbnNwZWN0b3I6OnN0YXJ0KCkKIAogICAgIG1fZW5h YmxlZCA9IHRydWU7CiAKLSAgICBub3RpZnlfcmVnaXN0ZXJfZGlzcGF0Y2goV0lSU2VydmljZUF2 YWlsYWJsZU5vdGlmaWNhdGlvbiwgJm1fbm90aWZ5VG9rZW4sIGRpc3BhdGNoX2dldF9nbG9iYWxf cXVldWUoRElTUEFUQ0hfUVVFVUVfUFJJT1JJVFlfREVGQVVMVCwgMCksIF4oaW50KSB7CisgICAg bm90aWZ5X3JlZ2lzdGVyX2Rpc3BhdGNoKFdJUlNlcnZpY2VBdmFpbGFibGVOb3RpZmljYXRpb24s ICZtX25vdGlmeVRva2VuLCBtX3hwY1F1ZXVlLCBeKGludCkgewogICAgICAgICBSZW1vdGVJbnNw ZWN0b3I6OnNoYXJlZCgpLnNldHVwWFBDQ29ubmVjdGlvbklmTmVlZGVkKCk7CiAgICAgfSk7CiAK QEAgLTIxMSwxMSArMjEyLDExIEBAIHZvaWQgUmVtb3RlSW5zcGVjdG9yOjpzZXR1cFhQQ0Nvbm5l Y3Rpb25JZk5lZWRlZCgpCiAgICAgaWYgKG1feHBjQ29ubmVjdGlvbikKICAgICAgICAgcmV0dXJu OwogCi0gICAgeHBjX2Nvbm5lY3Rpb25fdCBjb25uZWN0aW9uID0geHBjX2Nvbm5lY3Rpb25fY3Jl YXRlX21hY2hfc2VydmljZShXSVJYUENNYWNoUG9ydE5hbWUsIGRpc3BhdGNoX2dldF9tYWluX3F1 ZXVlKCksIDApOworICAgIHhwY19jb25uZWN0aW9uX3QgY29ubmVjdGlvbiA9IHhwY19jb25uZWN0 aW9uX2NyZWF0ZV9tYWNoX3NlcnZpY2UoV0lSWFBDTWFjaFBvcnROYW1lLCBtX3hwY1F1ZXVlLCAw KTsKICAgICBpZiAoIWNvbm5lY3Rpb24pCiAgICAgICAgIHJldHVybjsKIAotICAgIG1feHBjQ29u bmVjdGlvbiA9IGFkb3B0UmVmKG5ldyBSZW1vdGVJbnNwZWN0b3JYUENDb25uZWN0aW9uKGNvbm5l Y3Rpb24sIHRoaXMpKTsKKyAgICBtX3hwY0Nvbm5lY3Rpb24gPSBhZG9wdFJlZihuZXcgUmVtb3Rl SW5zcGVjdG9yWFBDQ29ubmVjdGlvbihjb25uZWN0aW9uLCBtX3hwY1F1ZXVlLCB0aGlzKSk7CiAg ICAgbV94cGNDb25uZWN0aW9uLT5zZW5kTWVzc2FnZShAInN5biIsIG5pbCk7IC8vIFNlbmQgYSBz aW1wbGUgbWVzc2FnZSB0byBpbml0aWFsaXplIHRoZSBYUEMgY29ubmVjdGlvbi4KICAgICB4cGNf cmVsZWFzZShjb25uZWN0aW9uKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yWFBDQ29ubmVjdGlvbi5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yWFBDQ29ubmVj dGlvbi5oCmluZGV4IDMzZTVjMGIuLjEwOTk1OTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3RvclhQQ0Nvbm5lY3Rpb24uaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0 b3JYUENDb25uZWN0aW9uLmgKQEAgLTQ3LDcgKzQ3LDcgQEAgcHVibGljOgogICAgICAgICB2aXJ0 dWFsIHZvaWQgeHBjQ29ubmVjdGlvblVuaGFuZGxlZE1lc3NhZ2UoUmVtb3RlSW5zcGVjdG9yWFBD Q29ubmVjdGlvbiosIHhwY19vYmplY3RfdCkgPSAwOwogICAgIH07CiAKLSAgICBSZW1vdGVJbnNw ZWN0b3JYUENDb25uZWN0aW9uKHhwY19jb25uZWN0aW9uX3QsIENsaWVudCopOworICAgIFJlbW90 ZUluc3BlY3RvclhQQ0Nvbm5lY3Rpb24oeHBjX2Nvbm5lY3Rpb25fdCwgZGlzcGF0Y2hfcXVldWVf dCwgQ2xpZW50Kik7CiAgICAgdmlydHVhbCB+UmVtb3RlSW5zcGVjdG9yWFBDQ29ubmVjdGlvbigp OwogCiAgICAgdm9pZCBjbG9zZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yWFBDQ29ubmVjdGlvbi5tbSBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3RvclhQQ0Nvbm5l Y3Rpb24ubW0KaW5kZXggNjc0YWI5Yy4uM2NhOWVlOCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yWFBDQ29ubmVjdGlvbi5t bQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNw ZWN0b3JYUENDb25uZWN0aW9uLm1tCkBAIC00NSwxMiArNDUsMTQgQEAgbmFtZXNwYWNlIEluc3Bl Y3RvciB7CiAjZGVmaW5lIFJlbW90ZUluc3BlY3RvclhQQ0Nvbm5lY3Rpb25Vc2VySW5mb0tleSBA InVzZXJJbmZvIgogI2RlZmluZSBSZW1vdGVJbnNwZWN0b3JYUENDb25uZWN0aW9uU2VyaWFsaXpl ZE1lc3NhZ2VLZXkgIm1zZ0RhdGEiCiAKLVJlbW90ZUluc3BlY3RvclhQQ0Nvbm5lY3Rpb246OlJl bW90ZUluc3BlY3RvclhQQ0Nvbm5lY3Rpb24oeHBjX2Nvbm5lY3Rpb25fdCBjb25uZWN0aW9uLCBD bGllbnQqIGNsaWVudCkKK1JlbW90ZUluc3BlY3RvclhQQ0Nvbm5lY3Rpb246OlJlbW90ZUluc3Bl Y3RvclhQQ0Nvbm5lY3Rpb24oeHBjX2Nvbm5lY3Rpb25fdCBjb25uZWN0aW9uLCBkaXNwYXRjaF9x dWV1ZV90IHF1ZXVlLCBDbGllbnQqIGNsaWVudCkKICAgICA6IG1fY29ubmVjdGlvbihjb25uZWN0 aW9uKQotICAgICwgbV9xdWV1ZShkaXNwYXRjaF9xdWV1ZV9jcmVhdGUoImNvbS5hcHBsZS5KYXZh U2NyaXB0Q29yZS5yZW1vdGUtaW5zcGVjdG9yLXhwYy1jb25uZWN0aW9uIiwgRElTUEFUQ0hfUVVF VUVfU0VSSUFMKSkKKyAgICAsIG1fcXVldWUocXVldWUpCiAgICAgLCBtX2NsaWVudChjbGllbnQp CiAgICAgLCBtX2Nsb3NlZChmYWxzZSkKIHsKKyAgICBkaXNwYXRjaF9yZXRhaW4obV9xdWV1ZSk7 CisKICAgICB4cGNfcmV0YWluKG1fY29ubmVjdGlvbik7CiAgICAgeHBjX2Nvbm5lY3Rpb25fc2V0 X3RhcmdldF9xdWV1ZShtX2Nvbm5lY3Rpb24sIG1fcXVldWUpOwogICAgIHhwY19jb25uZWN0aW9u X3NldF9ldmVudF9oYW5kbGVyKG1fY29ubmVjdGlvbiwgXih4cGNfb2JqZWN0X3Qgb2JqZWN0KSB7 Cg==