128376 2014-02-07 08:30:33 -0800 [GTK] build-webkit script always generate-gtk-doc even if '--disable-gtk-doc' param is passed 2014-02-08 00:19:19 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Minor --- 1 dpino webkit-unassigned cgarcia commit-queue dbates gustavo mrobinson zan oldest_to_newest 977825 0 dpino 2014-02-07 08:30:33 -0800 How to reproduce: * Execute script Tools/Script/build-webkit --disable-gtk-doc. Expected result: The script Tools/gtk/generate-gtkdoc should not be called. Actual result: The script Tools/gtk/generate-gtkdoc is called. 977827 1 223457 dpino 2014-02-07 08:34:31 -0800 Created attachment 223457 Patch 977839 2 223457 cgarcia 2014-02-07 09:18:30 -0800 Comment on attachment 223457 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223457&action=review > Tools/Scripts/webkitdirs.pm:1858 > + my $disableGTKDoc = grep /^--disable-gtk-doc$/, @buildArgs; Would it be possible to use checkForArgumentAndRemoveFromARGV() here? 977849 3 mrobinson 2014-02-07 09:40:39 -0800 This is by design. Probably we just want to disable it temporarily until the bots are fixed. 977865 4 223463 dpino 2014-02-07 10:11:42 -0800 Created attachment 223463 Patch 977868 5 cgarcia 2014-02-07 10:15:00 -0800 (In reply to comment #3) > This is by design. Probably we just want to disable it temporarily until the bots are fixed. I think we should respect the option. I'm fine with the bots not passing that option, but if I run build-webkit --disable-gtk-doc I don't want the doc to be generated. 977900 6 dpino 2014-02-07 10:43:28 -0800 Actually I had this bug in my local repo. Although I run build-webkit with "--disable-gtk-doc", the script tried to generate the GTK near the end of and the compilation failed. To solve that issued, I had a temporal fix that disabled GTK doc generation in Tools/gtk/generate-gtkdoc. 978327 7 223463 commit-queue 2014-02-08 00:19:16 -0800 Comment on attachment 223463 Patch Clearing flags on attachment: 223463 Committed r163697: <http://trac.webkit.org/changeset/163697> 978329 8 commit-queue 2014-02-08 00:19:19 -0800 All reviewed patches have been landed. Closing bug. 223457 2014-02-07 08:34:31 -0800 2014-02-07 10:11:34 -0800 Patch bug-128376-20140207173429.patch text/plain 1996 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNTI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzI3MWQ2Njc2NzUwM2M3ZjM2YTc4ZmUwMzc3MmU5Yjc4 YTgyY2I3Mi4uZDliMjIzMzg2M2I5ODIzMTNmNzQwOTA3NTZmM2Y4NzBkYjEyMzYxYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTAyLTA3ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gYnVpbGQtd2Via2l0IHNjcmlwdCBhbHdheXMgZ2VuZXJhdGUtZ3RrLWRv YyBldmVuIGlmICctLWRpc2FibGUtZ3RrLWRvYycgcGFyYW0gaXMgcGFzc2VkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgzNzYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGly cy5wbToKKyAgICAgICAgKGJ1aWxkQXV0b3Rvb2xzUHJvamVjdCk6CisKIDIwMTQtMDItMDYgIENz YWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk IGZpeCBhZnRlciByMTYzNTIwLCByZW1vdmUgQW5kcmVpIGZyb20gY29tbWl0dGVycyBsaXN0LCBi ZWNhdXNlCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9T Y3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggNGEzMzU0NGVhOTMxMTBiNzNmNzFjNzhjYjI3YzFj NDA0MTk2MTUwZi4uOGNjYjAwMDI5MDZjNzM2ZDc2NzQ2NTk5MzdjYjlkYTY1NmYzY2NhOCAxMDA3 NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0ZGlycy5wbQpAQCAtMTg1NSwxNCArMTg1NSwxNyBAQCBzdWIgYnVpbGRBdXRvdG9vbHNQ cm9qZWN0KCRAKQogCiAgICAgY2hkaXIgIi4uIiBvciBkaWU7CiAKLSAgICBpZiAoJHByb2plY3Qg ZXEgJ1dlYktpdCcgJiYgIWlzQ3Jvc3NDb21waWxhdGlvbigpICYmICEoJG5vV2ViS2l0MSAmJiAk bm9XZWJLaXQyKSkgewotICAgICAgICBteSBAZG9jR2VuZXJhdGlvbk9wdGlvbnMgPSAoIiRzb3Vy Y2VEaXIvVG9vbHMvZ3RrL2dlbmVyYXRlLWd0a2RvYyIsICItLXNraXAtaHRtbCIpOwotICAgICAg ICBwdXNoKEBkb2NHZW5lcmF0aW9uT3B0aW9ucywgcHJvZHVjdERpcigpKTsKKyAgICBteSAkZGlz YWJsZUdUS0RvYyA9IGdyZXAgL14tLWRpc2FibGUtZ3RrLWRvYyQvLCBAYnVpbGRBcmdzOworICAg IGlmICghJGRpc2FibGVHVEtEb2MpIHsKKyAgICAgICAgaWYgKCRwcm9qZWN0IGVxICdXZWJLaXQn ICYmICFpc0Nyb3NzQ29tcGlsYXRpb24oKSAmJiAhKCRub1dlYktpdDEgJiYgJG5vV2ViS2l0Mikp IHsKKyAgICAgICAgICAgIG15IEBkb2NHZW5lcmF0aW9uT3B0aW9ucyA9ICgiJHNvdXJjZURpci9U b29scy9ndGsvZ2VuZXJhdGUtZ3RrZG9jIiwgIi0tc2tpcC1odG1sIik7CisgICAgICAgICAgICBw dXNoKEBkb2NHZW5lcmF0aW9uT3B0aW9ucywgcHJvZHVjdERpcigpKTsKIAotICAgICAgICB1bnNo aWZ0KEBkb2NHZW5lcmF0aW9uT3B0aW9ucywgamhidWlsZFdyYXBwZXJQcmVmaXhJZk5lZWRlZCgp KTsKKyAgICAgICAgICAgIHVuc2hpZnQoQGRvY0dlbmVyYXRpb25PcHRpb25zLCBqaGJ1aWxkV3Jh cHBlclByZWZpeElmTmVlZGVkKCkpOwogCi0gICAgICAgIGlmIChzeXN0ZW0oQGRvY0dlbmVyYXRp b25PcHRpb25zKSkgewotICAgICAgICAgICAgZGllICJcbiBndGtkb2MgZGlkIG5vdCBidWlsZCB3 aXRob3V0IHdhcm5pbmdzXG4iOworICAgICAgICAgICAgaWYgKHN5c3RlbShAZG9jR2VuZXJhdGlv bk9wdGlvbnMpKSB7CisgICAgICAgICAgICAgICAgZGllICJcbiBndGtkb2MgZGlkIG5vdCBidWls ZCB3aXRob3V0IHdhcm5pbmdzXG4iOworICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQog Cg== 223463 2014-02-07 10:11:42 -0800 2014-02-08 00:19:15 -0800 Patch bug-128376-20140207191140.patch text/plain 1971 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNTI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzI3MWQ2Njc2NzUwM2M3ZjM2YTc4ZmUwMzc3MmU5Yjc4 YTgyY2I3Mi4uZDliMjIzMzg2M2I5ODIzMTNmNzQwOTA3NTZmM2Y4NzBkYjEyMzYxYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTAyLTA3ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gYnVpbGQtd2Via2l0IHNjcmlwdCBhbHdheXMgZ2VuZXJhdGUtZ3RrLWRv YyBldmVuIGlmICctLWRpc2FibGUtZ3RrLWRvYycgcGFyYW0gaXMgcGFzc2VkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgzNzYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGly cy5wbToKKyAgICAgICAgKGJ1aWxkQXV0b3Rvb2xzUHJvamVjdCk6CisKIDIwMTQtMDItMDYgIENz YWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk IGZpeCBhZnRlciByMTYzNTIwLCByZW1vdmUgQW5kcmVpIGZyb20gY29tbWl0dGVycyBsaXN0LCBi ZWNhdXNlCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9T Y3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggNGEzMzU0NGVhOTMxMTBiNzNmNzFjNzhjYjI3YzFj NDA0MTk2MTUwZi4uZTNkZDY3OGI5MzFlYTYxZWZlOTBhNWE4YmIzODk3MjFjNTE3MzkxNSAxMDA3 NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0ZGlycy5wbQpAQCAtMTg1NSwxNCArMTg1NSwxNiBAQCBzdWIgYnVpbGRBdXRvdG9vbHNQ cm9qZWN0KCRAKQogCiAgICAgY2hkaXIgIi4uIiBvciBkaWU7CiAKLSAgICBpZiAoJHByb2plY3Qg ZXEgJ1dlYktpdCcgJiYgIWlzQ3Jvc3NDb21waWxhdGlvbigpICYmICEoJG5vV2ViS2l0MSAmJiAk bm9XZWJLaXQyKSkgewotICAgICAgICBteSBAZG9jR2VuZXJhdGlvbk9wdGlvbnMgPSAoIiRzb3Vy Y2VEaXIvVG9vbHMvZ3RrL2dlbmVyYXRlLWd0a2RvYyIsICItLXNraXAtaHRtbCIpOwotICAgICAg ICBwdXNoKEBkb2NHZW5lcmF0aW9uT3B0aW9ucywgcHJvZHVjdERpcigpKTsKKyAgICBpZiAoIWNo ZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVGcm9tQVJHVigiLS1kaXNhYmxlLWd0ay1kb2MiKSkgewor ICAgICAgICBpZiAoJHByb2plY3QgZXEgJ1dlYktpdCcgJiYgIWlzQ3Jvc3NDb21waWxhdGlvbigp ICYmICEoJG5vV2ViS2l0MSAmJiAkbm9XZWJLaXQyKSkgeworICAgICAgICAgICAgbXkgQGRvY0dl bmVyYXRpb25PcHRpb25zID0gKCIkc291cmNlRGlyL1Rvb2xzL2d0ay9nZW5lcmF0ZS1ndGtkb2Mi LCAiLS1za2lwLWh0bWwiKTsKKyAgICAgICAgICAgIHB1c2goQGRvY0dlbmVyYXRpb25PcHRpb25z LCBwcm9kdWN0RGlyKCkpOwogCi0gICAgICAgIHVuc2hpZnQoQGRvY0dlbmVyYXRpb25PcHRpb25z LCBqaGJ1aWxkV3JhcHBlclByZWZpeElmTmVlZGVkKCkpOworICAgICAgICAgICAgdW5zaGlmdChA ZG9jR2VuZXJhdGlvbk9wdGlvbnMsIGpoYnVpbGRXcmFwcGVyUHJlZml4SWZOZWVkZWQoKSk7CiAK LSAgICAgICAgaWYgKHN5c3RlbShAZG9jR2VuZXJhdGlvbk9wdGlvbnMpKSB7Ci0gICAgICAgICAg ICBkaWUgIlxuIGd0a2RvYyBkaWQgbm90IGJ1aWxkIHdpdGhvdXQgd2FybmluZ3NcbiI7CisgICAg ICAgICAgICBpZiAoc3lzdGVtKEBkb2NHZW5lcmF0aW9uT3B0aW9ucykpIHsKKyAgICAgICAgICAg ICAgICBkaWUgIlxuIGd0a2RvYyBkaWQgbm90IGJ1aWxkIHdpdGhvdXQgd2FybmluZ3NcbiI7Cisg ICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9CiAK