128369 2014-02-07 02:49:21 -0800 [GTK] Re-enable gtk-doc in EWS 2014-02-26 03:27:25 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 129302 1 rego rego aperez cgarcia commit-queue glenn gustavo mrobinson zan oldest_to_newest 977787 0 rego 2014-02-07 02:49:21 -0800 gtk-doc is currently scanning the source dir to generate the document, so if you're doing a clean build and you have added some files gtk-doc is going to fail. 977791 1 cgarcia 2014-02-07 03:02:03 -0800 The problem is not the source dir in the particular case of EWS, but the buildir. What happens is the following: 1.- A patch adding new GObject DOM bindings API is submitted to bugzilla. It's built generating new classes in the derived sources 2.- Another patch is submitted to bugzilla reusing the existing builddir. The new classes generated by the previous patch are still there, but they are not built by this new patch. However, generate-gtkdoc scans the buildir to generate the doc, and it fails when trying to generate the doc of the new classes added by a previous patch and not built. I have had the same problem locally when I'm working on new classes in a branch, switch to another branch leaving the new classes in my source tree, but not building them, and gtkdoc fails when trying to generate docs for those new clases. Again, because it scans the source tree. So yes, the problem is that generate-gtkdoc scans the source tree/derived sources dir, instead of receiving the input files from the makefile like all other tools do (gobject-run-api-break-test, gobject-introspection, etc.). The *only* problem of doing it the right way is that it's more unconvenient to generate the docs manually (currently we only need to call generate-gtkdoc script with no arguments), but we can use a different script to scan the input files, or make the script smart enough to not scan dirs when input is provided. By providing the input files we also avoid all the ugly filters we have to not generate docs for private api/files. 977802 2 rego 2014-02-07 03:42:19 -0800 gtk-doc generation has been disabled in the EWS in r163621 (see bug #128370). 984229 3 rego 2014-02-25 01:18:06 -0800 This was already fixed in bug #128417, so gtk-doc can be enabled again in the EWS and the FIXMEs can be removed. 984230 4 225129 rego 2014-02-25 01:19:52 -0800 Created attachment 225129 Patch 984239 5 225129 commit-queue 2014-02-25 02:00:12 -0800 Comment on attachment 225129 Patch Clearing flags on attachment: 225129 Committed r164639: <http://trac.webkit.org/changeset/164639> 984240 6 commit-queue 2014-02-25 02:00:14 -0800 All reviewed patches have been landed. Closing bug. 984283 7 commit-queue 2014-02-25 05:59:20 -0800 Re-opened since this is blocked by bug 129302 984702 8 rego 2014-02-26 03:27:25 -0800 Committed r164713: <http://trac.webkit.org/changeset/164713> 225129 2014-02-25 01:19:52 -0800 2014-02-25 02:00:12 -0800 Patch bug-128369-20140225101950.patch text/plain 4725 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MzU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDYwZDU1M2RhM2E5NzVjYmUyNzQzMmQyZGUyYTlhNzU4 MzkyNWVmNC4uYmQ3YmZjYjZhZTRiN2UzYTlmN2MwMGFjMmQ3NzdjMmZmMzNhOWY4ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE0LTAyLTI1ICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFJlLWVuYWJsZSBndGstZG9jIGluIEVXUworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MzY5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5hYmxlIGFnYWluIGd0ay1kb2Mg Z2VuZXJhdGlvbiBpbiBFV1Mgb25jZSBidWcgIzEyODQxNyBoYXMgYmVlbiBmaXhlZC4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0cy5weToKKyAgICAgICAg KEd0a1BvcnQuYnVpbGRfd2Via2l0X2NvbW1hbmQpOiBBZGQgLS1kaXNhYmxlLWd0ay1kb2MgYXJn LgorICAgICAgICAoR3RrV0syUG9ydC5idWlsZF93ZWJraXRfY29tbWFuZCk6IERpdHRvLgorICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0c191bml0dGVzdC5weToK KyAgICAgICAgKERlcHJlY2F0ZWRQb3J0VGVzdC50ZXN0X2d0a19wb3J0KTogRGl0dG8uCisgICAg ICAgIChEZXByZWNhdGVkUG9ydFRlc3QudGVzdF9ndGtfd2syX3BvcnQpOiBEaXR0by4KKwogMjAx NC0wMi0xOCAgSmlud29vIFNvbmcgIDxqaW53b283LnNvbmdAc2Ftc3VuZy5jb20+CiAKICAgICAg ICAgW0VGTF1bTWluaUJyb3dzZXJdIFJlbW92ZSB2aWV3X21vZGUgcGFyYW1ldGVyIGluIHdpbmRv d19jcmVhdGUoKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29u ZmlnL3BvcnRzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3BvcnRz LnB5CmluZGV4IGJlZWEzZmJmMzA4NDA0OTE0MjEyODEyZjlkMzQwYjM0ZDFiOWQ5ZTUuLjJiMTA0 YjMwMTgxZDViOTIxNTQ4MWVmMzA2M2Y2YzRiZjYxZDkyNWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0cy5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9jb25maWcvcG9ydHMucHkKQEAgLTE1MCw4ICsxNTAsNiBAQCBjbGFz cyBHdGtQb3J0KERlcHJlY2F0ZWRQb3J0KToKICAgICAgICAgY29tbWFuZC5hcHBlbmQoIi0tZ3Rr IikKICAgICAgICAgY29tbWFuZC5hcHBlbmQoIi0tdXBkYXRlLWd0ayIpCiAgICAgICAgIGNvbW1h bmQuYXBwZW5kKCItLW5vLXdlYmtpdDIiKQotICAgICAgICAjIEZJWE1FOiBEaXNhYmxlIGd0ay1k b2MgdGVtcG9yYXJpbHkgZHVlIHRvIGh0dHA6Ly93ZWJraXQub3JnL2IvMTI4MzY5LgotICAgICAg ICBjb21tYW5kLmFwcGVuZCgiLS1kaXNhYmxlLWd0ay1kb2MiKQogICAgICAgICBjb21tYW5kLmFw cGVuZChzdXBlcihHdGtQb3J0LCBzZWxmKS5tYWtlQXJncygpKQogICAgICAgICByZXR1cm4gY29t bWFuZAogCkBAIC0xNjksOCArMTY3LDYgQEAgY2xhc3MgR3RrV0syUG9ydChEZXByZWNhdGVkUG9y dCk6CiAgICAgICAgIGNvbW1hbmQuYXBwZW5kKCItLWd0ayIpCiAgICAgICAgIGNvbW1hbmQuYXBw ZW5kKCItLXVwZGF0ZS1ndGsiKQogICAgICAgICBjb21tYW5kLmFwcGVuZCgiLS1uby13ZWJraXQx IikKLSAgICAgICAgIyBGSVhNRTogRGlzYWJsZSBndGstZG9jIHRlbXBvcmFyaWx5IGR1ZSB0byBo dHRwOi8vd2Via2l0Lm9yZy9iLzEyODM2OS4KLSAgICAgICAgY29tbWFuZC5hcHBlbmQoIi0tZGlz YWJsZS1ndGstZG9jIikKICAgICAgICAgY29tbWFuZC5hcHBlbmQoc3VwZXIoR3RrV0syUG9ydCwg c2VsZikubWFrZUFyZ3MoKSkKICAgICAgICAgcmV0dXJuIGNvbW1hbmQKIApkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3BvcnRzX3VuaXR0ZXN0LnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3BvcnRzX3VuaXR0ZXN0LnB5Cmlu ZGV4IGQyOGU5NmVjMGRmODU2MWJiZDFkZTBhZTQ0NmIyY2MyNjRlOThjNGYuLmRhY2E1NGE2OGE0 ZGMxOTA1YjkwNzcxYjk0YWRhNDRmMDUzZDE0MzggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0c191bml0dGVzdC5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvcG9ydHNfdW5pdHRlc3QucHkKQEAgLTQyLDE0ICs0 MiwxNCBAQCBjbGFzcyBEZXByZWNhdGVkUG9ydFRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAg IGRlZiB0ZXN0X2d0a19wb3J0KHNlbGYpOgogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKEd0a1Bv cnQoKS5mbGFnKCksICItLXBvcnQ9Z3RrIikKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChHdGtQ b3J0KCkucnVuX3dlYmtpdF90ZXN0c19jb21tYW5kKCksIERlcHJlY2F0ZWRQb3J0KCkuc2NyaXB0 X3NoZWxsX2NvbW1hbmQoInJ1bi13ZWJraXQtdGVzdHMiKSArIFsiLS1ndGsiXSkKLSAgICAgICAg c2VsZi5hc3NlcnRFcXVhbChHdGtQb3J0KCkuYnVpbGRfd2Via2l0X2NvbW1hbmQoKSwgRGVwcmVj YXRlZFBvcnQoKS5zY3JpcHRfc2hlbGxfY29tbWFuZCgiYnVpbGQtd2Via2l0IikgKyBbIi0tZ3Rr IiwgIi0tdXBkYXRlLWd0ayIsICItLW5vLXdlYmtpdDIiLCAiLS1kaXNhYmxlLWd0ay1kb2MiLCBE ZXByZWNhdGVkUG9ydCgpLm1ha2VBcmdzKCldKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKEd0 a1BvcnQoKS5idWlsZF93ZWJraXRfY29tbWFuZChidWlsZF9zdHlsZT0iZGVidWciKSwgRGVwcmVj YXRlZFBvcnQoKS5zY3JpcHRfc2hlbGxfY29tbWFuZCgiYnVpbGQtd2Via2l0IikgKyBbIi0tZGVi dWciLCAiLS1ndGsiLCAiLS11cGRhdGUtZ3RrIiwgIi0tbm8td2Via2l0MiIsICItLWRpc2FibGUt Z3RrLWRvYyIsIERlcHJlY2F0ZWRQb3J0KCkubWFrZUFyZ3MoKV0pCisgICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWwoR3RrUG9ydCgpLmJ1aWxkX3dlYmtpdF9jb21tYW5kKCksIERlcHJlY2F0ZWRQb3J0 KCkuc2NyaXB0X3NoZWxsX2NvbW1hbmQoImJ1aWxkLXdlYmtpdCIpICsgWyItLWd0ayIsICItLXVw ZGF0ZS1ndGsiLCAiLS1uby13ZWJraXQyIiwgRGVwcmVjYXRlZFBvcnQoKS5tYWtlQXJncygpXSkK KyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChHdGtQb3J0KCkuYnVpbGRfd2Via2l0X2NvbW1hbmQo YnVpbGRfc3R5bGU9ImRlYnVnIiksIERlcHJlY2F0ZWRQb3J0KCkuc2NyaXB0X3NoZWxsX2NvbW1h bmQoImJ1aWxkLXdlYmtpdCIpICsgWyItLWRlYnVnIiwgIi0tZ3RrIiwgIi0tdXBkYXRlLWd0ayIs ICItLW5vLXdlYmtpdDIiLCBEZXByZWNhdGVkUG9ydCgpLm1ha2VBcmdzKCldKQogCiAgICAgZGVm IHRlc3RfZ3RrX3drMl9wb3J0KHNlbGYpOgogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKEd0a1dL MlBvcnQoKS5mbGFnKCksICItLXBvcnQ9Z3RrLXdrMiIpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWwoR3RrV0syUG9ydCgpLnJ1bl93ZWJraXRfdGVzdHNfY29tbWFuZCgpLCBEZXByZWNhdGVkUG9y dCgpLnNjcmlwdF9zaGVsbF9jb21tYW5kKCJydW4td2Via2l0LXRlc3RzIikgKyBbIi0tZ3RrIiwg Ii0yIl0pCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoR3RrV0syUG9ydCgpLmJ1aWxkX3dlYmtp dF9jb21tYW5kKCksIERlcHJlY2F0ZWRQb3J0KCkuc2NyaXB0X3NoZWxsX2NvbW1hbmQoImJ1aWxk LXdlYmtpdCIpICsgWyItLWd0ayIsICItLXVwZGF0ZS1ndGsiLCAiLS1uby13ZWJraXQxIiwgIi0t ZGlzYWJsZS1ndGstZG9jIiwgRGVwcmVjYXRlZFBvcnQoKS5tYWtlQXJncygpXSkKLSAgICAgICAg c2VsZi5hc3NlcnRFcXVhbChHdGtXSzJQb3J0KCkuYnVpbGRfd2Via2l0X2NvbW1hbmQoYnVpbGRf c3R5bGU9ImRlYnVnIiksIERlcHJlY2F0ZWRQb3J0KCkuc2NyaXB0X3NoZWxsX2NvbW1hbmQoImJ1 aWxkLXdlYmtpdCIpICsgWyItLWRlYnVnIiwgIi0tZ3RrIiwgIi0tdXBkYXRlLWd0ayIsICItLW5v LXdlYmtpdDEiLCAiLS1kaXNhYmxlLWd0ay1kb2MiLCBEZXByZWNhdGVkUG9ydCgpLm1ha2VBcmdz KCldKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKEd0a1dLMlBvcnQoKS5idWlsZF93ZWJraXRf Y29tbWFuZCgpLCBEZXByZWNhdGVkUG9ydCgpLnNjcmlwdF9zaGVsbF9jb21tYW5kKCJidWlsZC13 ZWJraXQiKSArIFsiLS1ndGsiLCAiLS11cGRhdGUtZ3RrIiwgIi0tbm8td2Via2l0MSIsIERlcHJl Y2F0ZWRQb3J0KCkubWFrZUFyZ3MoKV0pCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoR3RrV0sy UG9ydCgpLmJ1aWxkX3dlYmtpdF9jb21tYW5kKGJ1aWxkX3N0eWxlPSJkZWJ1ZyIpLCBEZXByZWNh dGVkUG9ydCgpLnNjcmlwdF9zaGVsbF9jb21tYW5kKCJidWlsZC13ZWJraXQiKSArIFsiLS1kZWJ1 ZyIsICItLWd0ayIsICItLXVwZGF0ZS1ndGsiLCAiLS1uby13ZWJraXQxIiwgRGVwcmVjYXRlZFBv cnQoKS5tYWtlQXJncygpXSkKIAogICAgIGRlZiB0ZXN0X2VmbF9wb3J0KHNlbGYpOgogICAgICAg ICBzZWxmLmFzc2VydEVxdWFsKEVmbFBvcnQoKS5mbGFnKCksICItLXBvcnQ9ZWZsIikK