128354 2014-02-06 18:14:31 -0800 [WK2] Fitler touch events only based on touch start 2014-02-07 13:57:09 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin simon.fraser oldest_to_newest 977677 0 benjamin 2014-02-06 18:14:31 -0800 [WK2] Fitler touch events only based on touch start 977680 1 223413 benjamin 2014-02-06 18:17:14 -0800 Created attachment 223413 Patch 977736 2 223413 simon.fraser 2014-02-06 22:58:46 -0800 Comment on attachment 223413 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223413&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:1380 > +bool WebPageProxy::shouldTrackTouchEvents(const WebTouchEvent& event) Odd that the name says "events" but the argument is "event". Maybe this should be shouldStartTrackingTouchEvents? The function can be |const| 977743 3 benjamin 2014-02-06 23:39:12 -0800 (In reply to comment #2) > (From update of attachment 223413 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223413&action=review > > > Source/WebKit2/UIProcess/WebPageProxy.cpp:1380 > > +bool WebPageProxy::shouldTrackTouchEvents(const WebTouchEvent& event) > > Odd that the name says "events" but the argument is "event". > > Maybe this should be shouldStartTrackingTouchEvents? That is a good point, I like shouldStartTrackingTouchEvents(). I will also rename the argument from "event" to touchStartEvent. 978027 4 benjamin 2014-02-07 13:57:09 -0800 Committed r163645: <http://trac.webkit.org/changeset/163645> 223413 2014-02-06 18:17:14 -0800 2014-02-06 22:58:46 -0800 Patch bug-128354-20140206181714.patch text/plain 5334 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTFiYjQ0MTI2ODMxZTY4 N2JlN2Y1ODE2ZGY3ZjE3YmRlZTQxZWM1Mi4uOWI4NmZhNzRiMDMxOWU1NDYwNGFmNTkxYTFkZjA0 YzU5OTNiZGEzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTAyLTA2ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIEZpdGxl ciB0b3VjaCBldmVudHMgb25seSBiYXNlZCBvbiB0b3VjaCBzdGFydAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MzU0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVG91Y2ggRXZlbnRzIHRyYWNrIHRoZWly IHRhcmdldCwgd2Ugc2hvdWxkIG5vdCB0ZXN0IHRoZSB0b3VjaCByZWdpb25zCisgICAgICAgIGFn YWluIGFmdGVyIGEgdG91Y2ggc2VxdWVuY2Ugc3RhcnRzLgorCisgICAgICAgIFRoaXMgcGF0Y2gg YWRkcyBhIGJvb2xlYW4gZmxhZyB0byBrbm93IGlmIHdlIGFyZSBzZW5kaW5nIGV2ZW50cyB0byB0 aGUgV2ViUHJvY2VzcworICAgICAgICAobV9pc1RyYWNraW5nVG91Y2hFdmVudHMpLiBUaGUgZmxh ZyBpcyB1cGRhdGVkIGV2ZXJ5IHRpbWUgYSB0b3VjaCBzZXF1ZW5jZSBzdGFydHMuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFn ZVByb3h5OjpXZWJQYWdlUHJveHkpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnNo b3VsZFRyYWNrVG91Y2hFdmVudHMpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6Omhh bmRsZVRvdWNoRXZlbnQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaDoKKwog MjAxNC0wMi0wNiAgUHJhdGlrIFNvbGFua2kgIDxwc29sYW5raUBhcHBsZS5jb20+CiAKICAgICAg ICAgW2lPU10gV2ViS2l0MiBjYW4ndCBhY2Nlc3MgdGhlIEdQVQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCAwYTI4NWRkNzdkYTM2M2ZjMTFiMjQ3M2RhN2Q0 ZjU1MzlkYTNjZDk1Li5jOTljYjA5NmI0M2I0YjliZDk0NjQyZWQxMWZiMzM0MmM5M2JlMDJjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtMjkxLDYgKzI5 MSw5IEBAIFdlYlBhZ2VQcm94eTo6V2ViUGFnZVByb3h5KFBhZ2VDbGllbnQmIHBhZ2VDbGllbnQs IFdlYlByb2Nlc3NQcm94eSYgcHJvY2VzcywgV2ViCiAgICAgLCBtX3N5bmNOYXZpZ2F0aW9uQWN0 aW9uUG9saWN5QWN0aW9uKFBvbGljeVVzZSkKICAgICAsIG1fc3luY05hdmlnYXRpb25BY3Rpb25Q b2xpY3lEb3dubG9hZElEKDApCiAgICAgLCBtX3Byb2Nlc3NpbmdNb3VzZU1vdmVFdmVudChmYWxz ZSkKKyNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQorICAgICwgbV9pc1RyYWNraW5nVG91Y2hFdmVu dHMoZmFsc2UpCisjZW5kaWYKICAgICAsIG1fcGFnZUlEKHBhZ2VJRCkKICAgICAsIG1fc2Vzc2lv bihzZXNzaW9uKQogICAgICwgbV9pc1BhZ2VTdXNwZW5kZWQoZmFsc2UpCkBAIC0xMzczLDM0ICsx Mzc2LDM1IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpmaW5kUGx1Z2luKGNvbnN0IFN0cmluZyYgbWlt ZVR5cGUsIHVpbnQzMl90IHByb2Nlc3NUeXBlLCBjb25zCiAjZW5kaWYgLy8gRU5BQkxFKE5FVFND QVBFX1BMVUdJTl9BUEkpCiAKICNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQotI2lmIEVOQUJMRShB U1lOQ19TQ1JPTExJTkcpCi1zdGF0aWMgYm9vbCBhbnlUb3VjaElzSW5Ob25GYXN0U2Nyb2xsYWJs ZVJlZ2lvbihSZW1vdGVTY3JvbGxpbmdDb29yZGluYXRvclByb3h5JiBzY3JvbGxpbmdDb29yZGlu YXRvciwgY29uc3QgV2ViVG91Y2hFdmVudCYgZXZlbnQpCisKK2Jvb2wgV2ViUGFnZVByb3h5Ojpz aG91bGRUcmFja1RvdWNoRXZlbnRzKGNvbnN0IFdlYlRvdWNoRXZlbnQmIGV2ZW50KQogeworI2lm IEVOQUJMRShBU1lOQ19TQ1JPTExJTkcpCiAgICAgZm9yIChhdXRvIHRvdWNoUG9pbnQgOiBldmVu dC50b3VjaFBvaW50cygpKSB7Ci0gICAgICAgIGlmIChzY3JvbGxpbmdDb29yZGluYXRvci5pc1Bv aW50SW5Ob25GYXN0U2Nyb2xsYWJsZVJlZ2lvbih0b3VjaFBvaW50LmxvY2F0aW9uKCkpKQorICAg ICAgICBpZiAobV9zY3JvbGxpbmdDb29yZGluYXRvclByb3h5LT5pc1BvaW50SW5Ob25GYXN0U2Ny b2xsYWJsZVJlZ2lvbih0b3VjaFBvaW50LmxvY2F0aW9uKCkpKQogICAgICAgICAgICAgcmV0dXJu IHRydWU7CiAgICAgfQogCiAgICAgcmV0dXJuIGZhbHNlOwotfQogI2VuZGlmIC8vIEVOQUJMRShB U1lOQ19TQ1JPTExJTkcpCisgICAgcmV0dXJuIHRydWU7Cit9CiAKIHZvaWQgV2ViUGFnZVByb3h5 OjpoYW5kbGVUb3VjaEV2ZW50KGNvbnN0IE5hdGl2ZVdlYlRvdWNoRXZlbnQmIGV2ZW50KQogewog ICAgIGlmICghaXNWYWxpZCgpKQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAoIW1faXNUcmFj a2luZ1RvdWNoRXZlbnRzICYmIGV2ZW50LnR5cGUoKSA9PSBXZWJFdmVudDo6VG91Y2hTdGFydCAm JiBzaG91bGRUcmFja1RvdWNoRXZlbnRzKGV2ZW50KSkKKyAgICAgICAgbV9pc1RyYWNraW5nVG91 Y2hFdmVudHMgPSB0cnVlOworCisgICAgaWYgKCFtX2lzVHJhY2tpbmdUb3VjaEV2ZW50cykKKyAg ICAgICAgcmV0dXJuOworCiAgICAgLy8gSWYgdGhlIHBhZ2UgaXMgc3VzcGVuZGVkLCB3aGljaCBz aG91bGQgYmUgdGhlIGNhc2UgZHVyaW5nIHBhbm5pbmcsIHBpbmNoaW5nCiAgICAgLy8gYW5kIGFu aW1hdGlvbiBvbiB0aGUgcGFnZSBpdHNlbGYgKGtpbmV0aWMgc2Nyb2xsaW5nLCB0YXAgdG8gem9v bSkgZXRjLCB0aGVuCiAgICAgLy8gd2UgZG8gbm90IHNlbmQgYW55IG9mIHRoZSBldmVudHMgdG8g dGhlIHBhZ2UgZXZlbiBpZiBpcyBoYXMgbGlzdGVuZXJzLgogICAgIGlmICghbV9pc1BhZ2VTdXNw ZW5kZWQpIHsKLQotI2lmIEVOQUJMRShBU1lOQ19TQ1JPTExJTkcpCi0gICAgICAgIC8vIEZJWE1F OiB3ZSBzaG91bGQgb25seSBkbyB0aGlzIGNoZWNrIGZvciB0aGUgc3RhcnQgb2YgYSB0b3VjaCBn ZXN0dXJlLgotICAgICAgICBpZiAoIWFueVRvdWNoSXNJbk5vbkZhc3RTY3JvbGxhYmxlUmVnaW9u KCptX3Njcm9sbGluZ0Nvb3JkaW5hdG9yUHJveHksIGV2ZW50KSkKLSAgICAgICAgICAgIHJldHVy bjsKLSNlbmRpZgotCiAgICAgICAgIG1fdG91Y2hFdmVudFF1ZXVlLmFwcGVuZChldmVudCk7CiAg ICAgICAgIG1fcHJvY2Vzcy0+cmVzcG9uc2l2ZW5lc3NUaW1lcigpLT5zdGFydCgpOwogICAgICAg ICBpZiAobV9zaG91bGRTZW5kRXZlbnRzU3luY2hyb25vdXNseSkgewpAQCAtMTQyMCw2ICsxNDI0 LDkgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmhhbmRsZVRvdWNoRXZlbnQoY29uc3QgTmF0aXZlV2Vi VG91Y2hFdmVudCYgZXZlbnQpCiAgICAgICAgICAgICBsYXN0RXZlbnQuZGVmZXJyZWRUb3VjaEV2 ZW50cy5hcHBlbmQoZXZlbnQpOwogICAgICAgICB9CiAgICAgfQorCisgICAgaWYgKGV2ZW50LnR5 cGUoKSA9PSBXZWJFdmVudDo6VG91Y2hFbmQgfHwgZXZlbnQudHlwZSgpID09IFdlYkV2ZW50OjpU b3VjaENhbmNlbCkKKyAgICAgICAgbV9pc1RyYWNraW5nVG91Y2hFdmVudHMgPSBmYWxzZTsKIH0K ICNlbmRpZiAvLyBFTkFCTEUoVE9VQ0hfRVZFTlRTKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmgKaW5kZXggNjgzZWE3NGIzNDBhYzZjNTc0ODc4MjBmODI2OWQzY2IxOWIy MjliMC4uYjllZDc0ZmU1OTQ3YTM3N2EyZWU2Zjc5MzBkMWM5MjhiZTI4NzFjYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaApAQCAtMTAwMSwxMCArMTAwMSw2IEBAIHBy aXZhdGU6CiAgICAgdm9pZCBkaWRDaGFuZ2VDb250ZW50U2l6ZShjb25zdCBXZWJDb3JlOjpJbnRT aXplJik7CiAjZW5kaWYKIAotI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCi0gICAgdm9pZCBuZWVk VG91Y2hFdmVudHMoYm9vbCk7Ci0jZW5kaWYKLQogI2lmIEVOQUJMRShJTlBVVF9UWVBFX0NPTE9S KQogICAgIHZvaWQgc2hvd0NvbG9yUGlja2VyKGNvbnN0IFdlYkNvcmU6OkNvbG9yJiBpbml0aWFs Q29sb3IsIGNvbnN0IFdlYkNvcmU6OkludFJlY3QmKTsKICAgICB2b2lkIGRpZENob29zZUNvbG9y KGNvbnN0IFdlYkNvcmU6OkNvbG9yJik7CkBAIC0xMTY2LDYgKzExNjIsMTAgQEAgcHJpdmF0ZToK ICAgICB2b2lkIHByb2Nlc3NOZXh0UXVldWVkV2hlZWxFdmVudCgpOwogICAgIHZvaWQgc2VuZFdo ZWVsRXZlbnQoY29uc3QgV2ViV2hlZWxFdmVudCYpOwogCisjaWYgRU5BQkxFKFRPVUNIX0VWRU5U UykKKyAgICBib29sIHNob3VsZFRyYWNrVG91Y2hFdmVudHMoY29uc3QgV2ViVG91Y2hFdmVudCYp OworI2VuZGlmCisKICNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKICAgICB2b2lkIGZp bmRQbHVnaW4oY29uc3QgU3RyaW5nJiBtaW1lVHlwZSwgdWludDMyX3QgcHJvY2Vzc1R5cGUsIGNv bnN0IFN0cmluZyYgdXJsU3RyaW5nLCBjb25zdCBTdHJpbmcmIGZyYW1lVVJMU3RyaW5nLCBjb25z dCBTdHJpbmcmIHBhZ2VVUkxTdHJpbmcsIGJvb2wgYWxsb3dPbmx5QXBwbGljYXRpb25QbHVnaW5z LCB1aW50NjRfdCYgcGx1Z2luUHJvY2Vzc1Rva2VuLCBTdHJpbmcmIG5ld01JTUVUeXBlLCB1aW50 MzJfdCYgcGx1Z2luTG9hZFBvbGljeSwgU3RyaW5nJiB1bmF2YWlsYWJpbGl0eURlc2NyaXB0aW9u KTsKICNlbmRpZgpAQCAtMTMxOCw2ICsxMzE4LDcgQEAgcHJpdmF0ZToKICAgICBPd25QdHI8TmF0 aXZlV2ViTW91c2VFdmVudD4gbV9jdXJyZW50bHlQcm9jZXNzZWRNb3VzZURvd25FdmVudDsKIAog I2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCisgICAgYm9vbCBtX2lzVHJhY2tpbmdUb3VjaEV2ZW50 czsKICAgICBEZXF1ZTxRdWV1ZWRUb3VjaEV2ZW50cz4gbV90b3VjaEV2ZW50UXVldWU7CiAjZW5k aWYKICNpZiBFTkFCTEUoSU5QVVRfVFlQRV9DT0xPUikK