128351 2014-02-06 17:50:05 -0800 [iOS] make should build WebKit2 2014-02-06 20:06:50 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned aestes dbates ddkilzer dfarler joepeck oldest_to_newest 977658 0 joepeck 2014-02-06 17:50:05 -0800 This is almost exactly a year old make file change. excluding WebKit2 on iOS. We should include it, build-webkit includes it. 977661 1 223412 joepeck 2014-02-06 17:51:00 -0800 Created attachment 223412 [PATCH] Proposed Fix 977692 2 223412 dbates 2014-02-06 19:55:17 -0800 Comment on attachment 223412 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=223412&action=review > Source/Makefile:-7 > -ifneq (,$(findstring iphoneos,$(SDKROOT))) > - MODULES = WTF JavaScriptCore ThirdParty/ANGLE WebCore WebKit > -else ifneq (,$(findstring iphonesimulator,$(SDKROOT))) > - MODULES = WTF JavaScriptCore ThirdParty/ANGLE WebCore WebKit > -endif Do we build WebInspectorUI for iOS? If not, then we need to exclude it from the iOS device and simulator builds. 977693 3 223412 joepeck 2014-02-06 19:58:57 -0800 Comment on attachment 223412 [PATCH] Proposed Fix Good call! I'll keep these lines and just add WebKit2 to the. Thanks for the review! 977694 4 joepeck 2014-02-06 20:06:50 -0800 <http://trac.webkit.org/changeset/163608> 223412 2014-02-06 17:51:00 -0800 2014-02-06 19:58:57 -0800 [PATCH] Proposed Fix make.patch text/plain 1025 joepeck ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBkOTQ3YWJjLi45ZTEzMzE3 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTQtMDItMDYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAg ICAgICBbaU9TXSBtYWtlIHNob3VsZCBidWlsZCBXZWJLaXQyCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgzNTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9NYWtlZmlsZToKKwogMjAxNC0w Mi0wNSAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3Zl IEVOQUJMRShESVJFQ1RPUllfVVBMT0FEKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9NYWtlZmlsZSBi L1NvdXJjZS9NYWtlZmlsZQppbmRleCAyMTFmZGYxLi4zZDE4ZGUxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvTWFrZWZpbGUKKysrIGIvU291cmNlL01ha2VmaWxlCkBAIC0xLDExICsxLDUgQEAKIE1PRFVM RVMgPSBXVEYgSmF2YVNjcmlwdENvcmUgVGhpcmRQYXJ0eS9BTkdMRSBXZWJDb3JlIFdlYkluc3Bl Y3RvclVJIFdlYktpdCBXZWJLaXQyCiAKLWlmbmVxICgsJChmaW5kc3RyaW5nIGlwaG9uZW9zLCQo U0RLUk9PVCkpKQotCU1PRFVMRVMgPSBXVEYgSmF2YVNjcmlwdENvcmUgVGhpcmRQYXJ0eS9BTkdM RSBXZWJDb3JlIFdlYktpdAotZWxzZSBpZm5lcSAoLCQoZmluZHN0cmluZyBpcGhvbmVzaW11bGF0 b3IsJChTREtST09UKSkpCi0JTU9EVUxFUyA9IFdURiBKYXZhU2NyaXB0Q29yZSBUaGlyZFBhcnR5 L0FOR0xFIFdlYkNvcmUgV2ViS2l0Ci1lbmRpZgotCiBhbGw6CiAJQGZvciBkaXIgaW4gJChNT0RV TEVTKTsgZG8gJHtNQUtFfSAkQCAtQyAkJGRpcjsgZXhpdF9zdGF0dXM9JCQ/OyBcCiAJaWYgWyAk JGV4aXRfc3RhdHVzIC1uZSAwIF07IHRoZW4gZXhpdCAkJGV4aXRfc3RhdHVzOyBmaTsgZG9uZQo=