128347 2014-02-06 17:23:48 -0800 Workaround REGRESSION(r163195-r163227): Crash beneath NSErrorUserInfoFromJSException when installing AppleInternal.mpkg 2014-02-06 17:58:37 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff oldest_to_newest 977641 0 msaboff 2014-02-06 17:23:48 -0800 The issue is that stack checks are failing when running on a different thread than the thread that created the VM. Disabling stack checking when we call JavaScript by creating a VM via JSGlobalContextCreate() and JSContextGroupCreate(). <rdar://problem/15979363> 977650 1 223409 msaboff 2014-02-06 17:32:23 -0800 Created attachment 223409 Patch 977651 2 223409 ggaren 2014-02-06 17:35:05 -0800 Comment on attachment 223409 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223409&action=review r=me > Source/JavaScriptCore/ChangeLog:11 > + Added a flag to VM class called m_ignoreStackLimit that disables stack limit checks. > + We set this flag in JSContextGroupCreate() and JSGlobalContextCreateInGroup(). > + > + Disabled stack overflow tests in testapi.js since it uses these paths. You should explain that this is a temporary work-around, which we will remove once we have a proper fix. Otherwise, someone who's not you or me will think that we've removed stack checking from JavaScriptCore, and they will be reasonably alarmed. 977668 3 msaboff 2014-02-06 17:58:37 -0800 Committed r163595: <http://trac.webkit.org/changeset/163595> 223409 2014-02-06 17:32:23 -0800 2014-02-06 17:35:05 -0800 Patch 128347.patch text/plain 4617 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYzNTg3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE0LTAyLTA2ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFdvcmthcm91bmQgUkVHUkVTU0lPTihyMTYzMTk1LXIxNjMyMjcpOiBDcmFzaCBiZW5lYXRo IE5TRXJyb3JVc2VySW5mb0Zyb21KU0V4Y2VwdGlvbiB3aGVuIGluc3RhbGxpbmcgQXBwbGVJbnRl cm5hbC5tcGtnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjgzNDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGRlZCBhIGZsYWcgdG8gVk0gY2xhc3MgY2FsbGVkIG1faWdub3JlU3RhY2tMaW1pdCB0aGF0 IGRpc2FibGVzIHN0YWNrIGxpbWl0IGNoZWNrcy4KKyAgICAgICAgV2Ugc2V0IHRoaXMgZmxhZyBp biBKU0NvbnRleHRHcm91cENyZWF0ZSgpIGFuZCBKU0dsb2JhbENvbnRleHRDcmVhdGVJbkdyb3Vw KCkuCisKKyAgICAgICAgRGlzYWJsZWQgc3RhY2sgb3ZlcmZsb3cgdGVzdHMgaW4gdGVzdGFwaS5q cyBzaW5jZSBpdCB1c2VzIHRoZXNlIHBhdGhzLgorCisgICAgICAgICogQVBJL0pTQ29udGV4dFJl Zi5jcHA6CisgICAgICAgIChKU0NvbnRleHRHcm91cENyZWF0ZSk6CisgICAgICAgIChKU0dsb2Jh bENvbnRleHRDcmVhdGVJbkdyb3VwKToKKyAgICAgICAgKiBBUEkvdGVzdHMvdGVzdGFwaS5qczoK KyAgICAgICAgKiBydW50aW1lL1ZNLmNwcDoKKyAgICAgICAgKEpTQzo6Vk06OlZNKToKKyAgICAg ICAgKEpTQzo6Vk06OnVwZGF0ZVN0YWNrTGltaXRXaXRoUmVzZXJ2ZWRab25lU2l6ZSk6CisgICAg ICAgICogcnVudGltZS9WTS5oOgorICAgICAgICAoSlNDOjpWTTo6aWdub3JlU3RhY2tMaW1pdCk6 CisKIDIwMTQtMDItMDYgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4K IAogICAgICAgICBGaXggaU9TIGJ1aWxkcyBhZnRlciByMTYzNTc0CkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvQVBJL0pTQ29udGV4dFJlZi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL0FQSS9KU0NvbnRleHRSZWYuY3BwCShyZXZpc2lvbiAxNjM1ODEpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ29udGV4dFJlZi5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTU3LDcgKzU3LDkgQEAgdXNpbmcgbmFtZXNwYWNlIEpTQzsKIEpTQ29udGV4dEdyb3VwUmVm IEpTQ29udGV4dEdyb3VwQ3JlYXRlKCkKIHsKICAgICBpbml0aWFsaXplVGhyZWFkaW5nKCk7Ci0g ICAgcmV0dXJuIHRvUmVmKFZNOjpjcmVhdGVDb250ZXh0R3JvdXAoKS5sZWFrUmVmKCkpOworICAg IFZNKiB2bSA9IFZNOjpjcmVhdGVDb250ZXh0R3JvdXAoKS5sZWFrUmVmKCk7CisgICAgdm0tPmln bm9yZVN0YWNrTGltaXQoKTsKKyAgICByZXR1cm4gdG9SZWYodm0pOwogfQogCiBKU0NvbnRleHRH cm91cFJlZiBKU0NvbnRleHRHcm91cFJldGFpbihKU0NvbnRleHRHcm91cFJlZiBncm91cCkKQEAg LTEyOSw3ICsxMzEsMTMgQEAgSlNHbG9iYWxDb250ZXh0UmVmIEpTR2xvYmFsQ29udGV4dENyZWF0 ZQogewogICAgIGluaXRpYWxpemVUaHJlYWRpbmcoKTsKIAotICAgIFJlZlB0cjxWTT4gdm0gPSBn cm91cCA/IFBhc3NSZWZQdHI8Vk0+KHRvSlMoZ3JvdXApKSA6IFZNOjpjcmVhdGVDb250ZXh0R3Jv dXAoKTsKKyAgICBSZWZQdHI8Vk0+IHZtOworICAgIGlmIChncm91cCkKKyAgICAgICAgdm0gPSBQ YXNzUmVmUHRyPFZNPih0b0pTKGdyb3VwKSk7CisgICAgZWxzZSB7CisgICAgICAgIHZtID0gVk06 OmNyZWF0ZUNvbnRleHRHcm91cCgpOworICAgICAgICB2bS0+aWdub3JlU3RhY2tMaW1pdCgpOwor ICAgIH0KIAogICAgIEFQSUVudHJ5U2hpbSBlbnRyeVNoaW0odm0uZ2V0KCksIGZhbHNlKTsKICAg ICB2bS0+bWFrZVVzYWJsZUZyb21NdWx0aXBsZVRocmVhZHMoKTsKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkuanMJKHJldmlzaW9uIDE2MzU4MSkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5qcwkod29ya2luZyBjb3B5KQpA QCAtMjQyLDYgKzI0Miw3IEBAIHNob3VsZEJlKCdkZXJpdmVkT25seURlc2NyaXB0b3IuY29uZmln dXIKIHNob3VsZEJlKCdkZXJpdmVkT25seURlc2NyaXB0b3IuZW51bWVyYWJsZScsIGZhbHNlKTsK IAogc2hvdWxkQmUoInVuZGVmaW5lZCBpbnN0YW5jZW9mIE15T2JqZWN0IiwgZmFsc2UpOworLyoK IEV2aWxFeGNlcHRpb25PYmplY3QuaGFzSW5zdGFuY2UgPSBmdW5jdGlvbiBmKCkgeyByZXR1cm4g ZigpOyB9OwogRXZpbEV4Y2VwdGlvbk9iamVjdC5fX3Byb3RvX18gPSB1bmRlZmluZWQ7CiBzaG91 bGRUaHJvdygidW5kZWZpbmVkIGluc3RhbmNlb2YgRXZpbEV4Y2VwdGlvbk9iamVjdCIpOwpAQCAt MjUyLDYgKzI1Myw3IEBAIEV2aWxFeGNlcHRpb25PYmplY3QudG9OdW1iZXIgPSBmdW5jdGlvbiAK IHNob3VsZFRocm93KCJFdmlsRXhjZXB0aW9uT2JqZWN0KjUiKTsKIEV2aWxFeGNlcHRpb25PYmpl Y3QudG9TdHJpbmdFeHBsaWNpdCA9IGZ1bmN0aW9uIGYoKSB7IHJldHVybiBmKCk7IH0KIHNob3Vs ZFRocm93KCJTdHJpbmcoRXZpbEV4Y2VwdGlvbk9iamVjdCkiKTsKKyAqLwogCiBzaG91bGRCZSgi RW1wdHlPYmplY3QiLCAiW29iamVjdCBDYWxsYmFja09iamVjdF0iKTsKIApJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcAkocmV2aXNpb24gMTYzNTgxKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTksNiArMjE5 LDcgQEAgVk06OlZNKFZNVHlwZSB2bVR5cGUsIEhlYXBUeXBlIGhlYXBUeXBlKQogI2lmIEVOQUJM RShHQ19WQUxJREFUSU9OKQogICAgICwgbV9pbml0aWFsaXppbmdPYmplY3RDbGFzcygwKQogI2Vu ZGlmCisgICAgLCBtX2lnbm9yZVN0YWNrTGltaXQoZmFsc2UpCiAgICAgLCBtX3N0YWNrTGltaXQo MCkKICNpZiBFTkFCTEUoTExJTlRfQ19MT09QKQogICAgICwgbV9qc1N0YWNrTGltaXQoMCkKQEAg LTczOCw2ICs3MzksMTEgQEAgdm9pZCBWTTo6IGNsZWFyRXhjZXB0aW9uU3RhY2soKQogCiBzaXpl X3QgVk06OnVwZGF0ZVN0YWNrTGltaXRXaXRoUmVzZXJ2ZWRab25lU2l6ZShzaXplX3QgcmVzZXJ2 ZWRab25lU2l6ZSkKIHsKKyAgICBpZiAobV9pZ25vcmVTdGFja0xpbWl0KSB7CisgICAgICAgIHNl dFN0YWNrTGltaXQoMCk7CisgICAgICAgIHJldHVybiAwOworICAgIH0KKwogICAgIHNpemVfdCBv bGRSZXNlcnZlZFpvbmVTaXplID0gbV9yZXNlcnZlZFpvbmVTaXplOwogICAgIG1fcmVzZXJ2ZWRa b25lU2l6ZSA9IHJlc2VydmVkWm9uZVNpemU7CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL1ZNLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvVk0uaAkocmV2aXNpb24gMTYzNTgxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvVk0uaAkod29ya2luZyBjb3B5KQpAQCAtMzg3LDYgKzM4Nyw4IEBAIG5hbWVzcGFjZSBKU0Mg ewogI2VuZGlmCiAgICAgICAgIHZvaWQqIHN0YWNrTGltaXQoKSB7IHJldHVybiBtX3N0YWNrTGlt aXQ7IH0KIAorICAgICAgICB2b2lkIGlnbm9yZVN0YWNrTGltaXQoKSB7IG1faWdub3JlU3RhY2tM aW1pdCA9IHRydWU7IH0KKwogICAgICAgICBib29sIGlzU2FmZVRvUmVjdXJzZShzaXplX3QgbmVl ZGVkU3RhY2tJbkJ5dGVzID0gMCkgY29uc3QKICAgICAgICAgewogICAgICAgICAgICAgQVNTRVJU KHd0ZlRocmVhZERhdGEoKS5zdGFjaygpLmlzR3Jvd2luZ0Rvd253YXJkKCkpOwpAQCAtNTIxLDYg KzUyMyw3IEBAIG5hbWVzcGFjZSBKU0MgewogI2lmIEVOQUJMRShHQ19WQUxJREFUSU9OKQogICAg ICAgICBjb25zdCBDbGFzc0luZm8qIG1faW5pdGlhbGl6aW5nT2JqZWN0Q2xhc3M7CiAjZW5kaWYK KyAgICAgICAgYm9vbCBtX2lnbm9yZVN0YWNrTGltaXQ7CiAgICAgICAgIHNpemVfdCBtX3Jlc2Vy dmVkWm9uZVNpemU7CiAjaWYgRU5BQkxFKExMSU5UX0NfTE9PUCkKICAgICAgICAgc3RydWN0IHsK