128341 2014-02-06 15:43:04 -0800 IndexedDB assertion at IDBTransactionBackend::~IDBTransactionBackend() 2014-02-10 22:32:37 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan beidson alecflett ap beidson commit-queue jonlee jsbell oldest_to_newest 977577 0 zalan 2014-02-06 15:43:04 -0800 Mavericks Debug WK2 failing test case: svg/W3C-I18N/g-dirRTL-ubOverride.svg output: ASSERTION FAILED: m_state == Finished /Volumes/Data/slave/mavericks-debug/build/Source/WebCore/Modules/indexeddb/IDBTransactionBackend.cpp(87) : WebCore::IDBTransactionBackend::~IDBTransactionBackend() 1 0x1067e80d0 WTFCrash 2 0x108800165 WebCore::IDBTransactionBackend::~IDBTransactionBackend() 3 0x108800115 WebCore::IDBTransactionBackend::~IDBTransactionBackend() 4 0x108814e29 WTF::RefCounted<WebCore::IDBTransactionBackend>::deref() 5 0x108814dd9 void WTF::derefIfNotNull<WebCore::IDBTransactionBackend>(WebCore::IDBTransactionBackend*) 6 0x10881c188 WTF::RefPtr<WebCore::IDBTransactionBackend>::~RefPtr() 7 0x108812795 WTF::RefPtr<WebCore::IDBTransactionBackend>::~RefPtr() 8 0x1088c538c WTF::KeyValuePair<WebCore::IDBTransactionBackend*, WTF::RefPtr<WebCore::IDBTransactionBackend> >::~KeyValuePair() 9 0x1088c5365 WTF::KeyValuePair<WebCore::IDBTransactionBackend*, WTF::RefPtr<WebCore::IDBTransactionBackend> >::~KeyValuePair() 10 0x1088c52f8 WTF::HashTable<WebCore::IDBTransactionBackend*, WTF::KeyValuePair<WebCore::IDBTransactionBackend*, WTF::RefPtr<WebCore::IDBTransactionBackend> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::IDBTransactionBackend*, WTF::RefPtr<WebCore::IDBTransactionBackend> > >, WTF::PtrHash<WebCore::IDBTransactionBackend*>, WTF::HashMap<WebCore::IDBTransactionBackend*, WTF::RefPtr<WebCore::IDBTransactionBackend>, WTF::PtrHash<WebCore::IDBTransactionBackend*>, WTF::HashTraits<WebCore::IDBTransactionBackend*>, WTF::HashTraits<WTF::RefPtr<WebCore::IDBTransactionBackend> > >::KeyValuePairTraits, WTF::HashTraits<WebCore::IDBTransactionBackend*> >::deallocateTable(WTF::KeyValuePair<WebCore::IDBTransactionBackend*, WTF::RefPtr<WebCore::IDBTransactionBackend> >*, int) 11 0x1088c992c WTF::HashTable<WebCore::IDBTransactionBackend*, WTF::KeyValuePair<WebCore::IDBTransactionBackend*, WTF::RefPtr<WebCore::IDBTransactionBackend> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::IDBTransactionBackend*, WTF::RefPtr<WebCore::IDBTransactionBackend> > >, WTF::PtrHash<WebCore::IDBTransactionBackend*>, WTF::HashMap<WebCore::IDBTransactionBackend*, WTF::RefPtr<WebCore::IDBTransactionBackend>, WTF::PtrHash<WebCore::IDBTransactionBackend*>, WTF::HashTraits<WebCore::IDBTransactionBackend*>, WTF::HashTraits<WTF::RefPtr<WebCore::IDBTransactionBackend> > >::KeyValuePairTraits, WTF::HashTraits<WebCore::IDBTransactionBackend*> >::~HashTable() 12 0x1088c98e5 WTF::HashTable<WebCore::IDBTransactionBackend*, WTF::KeyValuePair<WebCore::IDBTransactionBackend*, WTF::RefPtr<WebCore::IDBTransactionBackend> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::IDBTransactionBackend*, WTF::RefPtr<WebCore::IDBTransactionBackend> > >, WTF::PtrHash<WebCore::IDBTransactionBackend*>, WTF::HashMap<WebCore::IDBTransactionBackend*, WTF::RefPtr<WebCore::IDBTransactionBackend>, WTF::PtrHash<WebCore::IDBTransactionBackend*>, WTF::HashTraits<WebCore::IDBTransactionBackend*>, WTF::HashTraits<WTF::RefPtr<WebCore::IDBTransactionBackend> > >::KeyValuePairTraits, WTF::HashTraits<WebCore::IDBTransactionBackend*> >::~HashTable() 13 0x1088c98c5 WTF::HashMap<WebCore::IDBTransactionBackend*, WTF::RefPtr<WebCore::IDBTransactionBackend>, WTF::PtrHash<WebCore::IDBTransactionBackend*>, WTF::HashTraits<WebCore::IDBTransactionBackend*>, WTF::HashTraits<WTF::RefPtr<WebCore::IDBTransactionBackend> > >::~HashMap() 14 0x1088c1d55 WTF::HashMap<WebCore::IDBTransactionBackend*, WTF::RefPtr<WebCore::IDBTransactionBackend>, WTF::PtrHash<WebCore::IDBTransactionBackend*>, WTF::HashTraits<WebCore::IDBTransactionBackend*>, WTF::HashTraits<WTF::RefPtr<WebCore::IDBTransactionBackend> > >::~HashMap() 15 0x1088c1179 WebCore::IDBTransactionCoordinator::~IDBTransactionCoordinator() 16 0x1088c1115 WebCore::IDBTransactionCoordinator::~IDBTransactionCoordinator() 17 0x1088c10e9 WebCore::IDBTransactionCoordinator::~IDBTransactionCoordinator() 18 0x109255d8e void WTF::deleteOwnedPtr<WebCore::IDBTransactionCoordinator>(WebCore::IDBTransactionCoordinator*) 19 0x109255d58 WTF::OwnPtr<WebCore::IDBTransactionCoordinator>::~OwnPtr() 20 0x10924a015 WTF::OwnPtr<WebCore::IDBTransactionCoordinator>::~OwnPtr() 21 0x10923fad7 WebCore::IDBDatabaseBackend::~IDBDatabaseBackend() 22 0x10923f9f5 WebCore::IDBDatabaseBackend::~IDBDatabaseBackend() 23 0x1083954f9 WTF::RefCounted<WebCore::IDBDatabaseBackend>::deref() 24 0x1083954a9 void WTF::derefIfNotNull<WebCore::IDBDatabaseBackend>(WebCore::IDBDatabaseBackend*) 25 0x108395638 WTF::RefPtr<WebCore::IDBDatabaseBackend>::~RefPtr() 26 0x1083944c5 WTF::RefPtr<WebCore::IDBDatabaseBackend>::~RefPtr() 27 0x108b98991 WebCore::IDBDatabase::~IDBDatabase() 28 0x108b988c5 WebCore::IDBDatabase::~IDBDatabase() 29 0x108b98899 WebCore::IDBDatabase::~IDBDatabase() 30 0x1083953f3 WTF::RefCounted<WebCore::IDBDatabase>::deref() 31 0x10839538f void WTF::derefIfNotNull<WebCore::IDBDatabase>(WebCore::IDBDatabase*) 977578 1 ap 2014-02-06 15:45:53 -0800 Obviously caused by a preceding IndexedDB test, not by g-dirRTL-ubOverride.svg. 977589 2 beidson 2014-02-06 16:09:05 -0800 Right. Are our tools good enough yet to pinpoint a check-in? :) 977832 3 jonlee 2014-02-07 09:06:32 -0800 Also see 128375 977834 4 beidson 2014-02-07 09:07:51 -0800 *** Bug 128375 has been marked as a duplicate of this bug. *** 977835 5 beidson 2014-02-07 09:08:11 -0800 Better backtrace in https://bugs.webkit.org/show_bug.cgi?id=128375 978979 6 beidson 2014-02-10 11:38:59 -0800 Skipped tests in http://trac.webkit.org/changeset/163805 for now. 979256 7 beidson 2014-02-10 21:46:58 -0800 Couldn't reproduce this worth squat on one machine, fairly easy to reproduce on another. The value of m_state when we ASSERT that it's Finished is actually Unused. Unused is okay in this brave new multi-process world. Updating the ASSERT shall suffice. 979257 8 223806 beidson 2014-02-10 21:50:10 -0800 Created attachment 223806 Patch v1 - Update the ASSERT and re-enable the indexeddb tests 979258 9 223806 mjs 2014-02-10 21:52:11 -0800 Comment on attachment 223806 Patch v1 - Update the ASSERT and re-enable the indexeddb tests r=me 979284 10 223806 commit-queue 2014-02-10 22:32:34 -0800 Comment on attachment 223806 Patch v1 - Update the ASSERT and re-enable the indexeddb tests Clearing flags on attachment: 223806 Committed r163864: <http://trac.webkit.org/changeset/163864> 979285 11 commit-queue 2014-02-10 22:32:37 -0800 All reviewed patches have been landed. Closing bug. 223806 2014-02-10 21:50:10 -0800 2014-02-10 22:32:34 -0800 Patch v1 - Update the ASSERT and re-enable the indexeddb tests patch text/plain 4784 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyOTVkOTU3Li5jNWM1NDkzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTQtMDIt MTAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAgICAgIEluZGV4ZWRE QiBhc3NlcnRpb24gYXQgSURCVHJhbnNhY3Rpb25CYWNrZW5kOjp+SURCVHJhbnNhY3Rpb25CYWNr ZW5kKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy ODM0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog cGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zOiBSZWVuYWJsZSB0aGUgaW5kZXhlZGRi IHRlc3RzIHRoYXQgYXJlIGtub3duIHRvIHBhc3MuCisKKzIwMTQtMDItMTAgIEJyYWR5IEVpZHNv biAgPGJlaWRzb25AYXBwbGUuY29tPgorCiAgICAgICAgIElEQjogc3RvcmFnZS9pbmRleGVkZGIv bW96aWxsYS9vYmplY3Qtc3RvcmUtaW5saW5lLWF1dG9pbmNyZW1lbnQta2V5LWFkZGVkLW9uLXB1 dC5odG1sIGZhaWxzCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNjAzMzI4Nj4gYW5kIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg1NzQKIApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDQ0MTliMzcuLjY3YzNm YTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0 aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMK QEAgLTQ3MiwxOSArNDcyLDE5IEBAIGZ1bGxzY3JlZW4vYW5vbnltb3VzLWJsb2NrLW1lcmdlLWNy YXNoLmh0bWwgWyBQYXNzIF0KICMgQWxsIEluZGV4ZWREQiB0ZXN0cyBhcmUgc2tpcHBlZCBpbiBX SzEuCiAjIFJlZW5hYmxlIGluZGl2aWR1YWwgdGVzdHMgaGVyZSB0aGF0IGFyZSBrbm93biB0byBw YXNzLCB3aXRoIHRoZSBldmVudHVhbCBnb2FsIG9mIHJlLWVuYWJsaW5nIHRoZSBlbnRpcmUgZGly ZWN0b3J5LgogIyAoRXhjZXB0LCBza2lwIHRoZW0gZm9yIG5vdyBzaW5jZSBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MzQxIGlzIGdldHRpbmcgaW4gdGhlIHdheSBv ZiB0ZXN0aW5nIGluIGdlbmVyYWwpCi0jIHN0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvYWRkLXR3 aWNlLWZhaWx1cmUuaHRtbCBbIFBhc3MgXQotIyBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2F1 dG9pbmNyZW1lbnQtaW5kZXhlcy5odG1sIFsgUGFzcyBdCi0jIHN0b3JhZ2UvaW5kZXhlZGRiL21v emlsbGEvY2xlYXIuaHRtbCBbIFBhc3MgXQotIyBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2Ny ZWF0ZS1pbmRleC13aXRoLWludGVnZXIta2V5cy5odG1sIFsgUGFzcyBdCi0jIHN0b3JhZ2UvaW5k ZXhlZGRiL21vemlsbGEvY3Vyc29yLW11dGF0aW9uLW9iamVjdHN0b3JlLW9ubHkuaHRtbCBbIFBh c3MgXQotIyBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2N1cnNvci1tdXRhdGlvbi5odG1sIFsg UGFzcyBdCi0jIHN0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvY3Vyc29ycy5odG1sIFsgUGFzcyBd Ci0jIHN0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvaW5kZXgtcHJldi1uby1kdXBsaWNhdGUuaHRt bCBbIFBhc3MgXQotIyBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2luZGV4ZXMuaHRtbCBbIFBh c3MgXQotIyBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL29iamVjdC1jdXJzb3JzLmh0bWwgWyBQ YXNzIF0KLSMgc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9vYmplY3Qtc3RvcmUtaW5saW5lLWF1 dG9pbmNyZW1lbnQta2V5LWFkZGVkLW9uLXB1dC5odG1sIFsgUGFzcyBdCi0jIHN0b3JhZ2UvaW5k ZXhlZGRiL21vemlsbGEvb2JqZWN0LXN0b3JlLXJlbW92ZS12YWx1ZXMuaHRtbCBbIFBhc3MgXQot IyBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL3ZlcnNpb25jaGFuZ2UtYWJvcnQuaHRtbCBbIFBh c3MgXQorc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9hZGQtdHdpY2UtZmFpbHVyZS5odG1sIFsg UGFzcyBdCitzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2F1dG9pbmNyZW1lbnQtaW5kZXhlcy5o dG1sIFsgUGFzcyBdCitzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2NsZWFyLmh0bWwgWyBQYXNz IF0KK3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvY3JlYXRlLWluZGV4LXdpdGgtaW50ZWdlci1r ZXlzLmh0bWwgWyBQYXNzIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvY3Vyc29yLW11dGF0 aW9uLW9iamVjdHN0b3JlLW9ubHkuaHRtbCBbIFBhc3MgXQorc3RvcmFnZS9pbmRleGVkZGIvbW96 aWxsYS9jdXJzb3ItbXV0YXRpb24uaHRtbCBbIFBhc3MgXQorc3RvcmFnZS9pbmRleGVkZGIvbW96 aWxsYS9jdXJzb3JzLmh0bWwgWyBQYXNzIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvaW5k ZXgtcHJldi1uby1kdXBsaWNhdGUuaHRtbCBbIFBhc3MgXQorc3RvcmFnZS9pbmRleGVkZGIvbW96 aWxsYS9pbmRleGVzLmh0bWwgWyBQYXNzIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvb2Jq ZWN0LWN1cnNvcnMuaHRtbCBbIFBhc3MgXQorc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9vYmpl Y3Qtc3RvcmUtaW5saW5lLWF1dG9pbmNyZW1lbnQta2V5LWFkZGVkLW9uLXB1dC5odG1sIFsgUGFz cyBdCitzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL29iamVjdC1zdG9yZS1yZW1vdmUtdmFsdWVz Lmh0bWwgWyBQYXNzIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvdmVyc2lvbmNoYW5nZS1h Ym9ydC5odG1sIFsgUGFzcyBdCiAKICMjIyBFTkQgT0YgKDUpIEZlYXR1cmVzIHRoYXQgYXJlIG5v dCBzdXBwb3J0ZWQgaW4gV2ViS2l0MSwgc28gc2tpcHBlZCBpbiBtYWMvVGVzdEV4cGVjdGF0aW9u cyB0aGVuIHJlLWVuYWJsZWQgaGVyZQogIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCmluZGV4IDRmYWY3ZmQuLjUxNzhhMWMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNC0wMi0xMCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+ CisKKyAgICAgICAgSW5kZXhlZERCIGFzc2VydGlvbiBhdCBJREJUcmFuc2FjdGlvbkJhY2tlbmQ6 On5JREJUcmFuc2FjdGlvbkJhY2tlbmQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MzQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9JREJUcmFuc2FjdGlvbkJhY2tl bmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCVHJhbnNhY3Rpb25CYWNrZW5kOjp+SURCVHJh bnNhY3Rpb25CYWNrZW5kKTogIkZpbmlzaGVkIiBpcyBub3QgdGhlIG9ubHkKKyAgICAgICAgICB2 YWxpZCB2YWx1ZSBoZXJlIC0gSW4gV0syLCAiVW51c2VkIiBpcyBhbHNvIHZhbGlkLiBVcGRhdGUg dGhlIEFTU0VSVC4KKwogMjAxNC0wMi0xMCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+ CiAKICAgICAgICAgUmVtb3ZpbmcgbGltaXRhdGlvbiBvbiBKU0xvY2vigJlzIGxvY2tEcm9wRGVw dGguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJUcmFu c2FjdGlvbkJhY2tlbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURC VHJhbnNhY3Rpb25CYWNrZW5kLmNwcAppbmRleCAxNDIwMWI3Li5kNTBkNjI5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJUcmFuc2FjdGlvbkJhY2tlbmQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQlRyYW5zYWN0aW9u QmFja2VuZC5jcHAKQEAgLTgzLDggKzgzLDggQEAgSURCVHJhbnNhY3Rpb25CYWNrZW5kOjpJREJU cmFuc2FjdGlvbkJhY2tlbmQoSURCRGF0YWJhc2VCYWNrZW5kKiBkYXRhYmFzZUJhY2tlbmQKIAog SURCVHJhbnNhY3Rpb25CYWNrZW5kOjp+SURCVHJhbnNhY3Rpb25CYWNrZW5kKCkKIHsKLSAgICAv LyBJdCBzaG91bGRuJ3QgYmUgcG9zc2libGUgZm9yIHRoaXMgb2JqZWN0IHRvIGdldCBkZWxldGVk IHVudGlsIGl0J3MgZWl0aGVyIGNvbXBsZXRlIG9yIGFib3J0ZWQuCi0gICAgQVNTRVJUKG1fc3Rh dGUgPT0gRmluaXNoZWQpOworICAgIC8vIEl0IHNob3VsZG4ndCBiZSBwb3NzaWJsZSBmb3IgdGhp cyBvYmplY3QgdG8gZ2V0IGRlbGV0ZWQgdW5sZXNzIGl0J3MgdW51c2VkLCBjb21wbGV0ZSwgb3Ig YWJvcnRlZC4KKyAgICBBU1NFUlQobV9zdGF0ZSA9PSBGaW5pc2hlZCB8fCBtX3N0YXRlID09IFVu dXNlZCk7CiB9CiAKIHZvaWQgSURCVHJhbnNhY3Rpb25CYWNrZW5kOjpzY2hlZHVsZVRhc2soSURC RGF0YWJhc2VCYWNrZW5kOjpUYXNrVHlwZSB0eXBlLCBQYXNzUmVmUHRyPElEQk9wZXJhdGlvbj4g dGFzaywgUGFzc1JlZlB0cjxJREJTeW5jaHJvbm91c09wZXJhdGlvbj4gYWJvcnRUYXNrKQo=