12834 2007-02-20 21:49:22 -0800 Drosera should remember scroll position of open files like Xcode 2008-05-17 09:56:03 -0700 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 CLOSED FIXED P3 Minor --- 0 vladimir.olexa webkit-unassigned oldest_to_newest 22438 0 vladimir.olexa 2007-02-20 21:49:22 -0800 Let's say you open file A and select a function from the function list which scrolls down to position posA. When you then select a different file B, you'll see that it is still scrolled to position posA (relative to the size of file B). Proper behavior should be remembering scroll positions for each open file like Xcode does. Patch forthcoming. 22440 1 13287 vladimir.olexa 2007-02-20 23:43:08 -0800 Created attachment 13287 Patch I am only remembering the top position. I wasn't sure if horizontal position is really important to remember. If it is, it would be an easy change. 22437 2 vladimir.olexa 2007-02-20 23:45:10 -0800 Just to note, Xcode only remembers y-position as well. 22405 3 13287 timothy 2007-02-21 08:30:34 -0800 Comment on attachment 13287 Patch Looks good, please add a ChangeLog and I'll r+ this. 22398 4 13298 vladimir.olexa 2007-02-21 09:42:51 -0800 Created attachment 13298 Patch with Changelog oops, I thought I did. Here it is again with Changelog attached. 22370 5 13298 timothy 2007-02-21 12:02:20 -0800 Comment on attachment 13298 Patch with Changelog Always good to put the bug link and number in the ChangeLog. I'll add that. Thanks for the patch! 22366 6 timothy 2007-02-21 12:12:00 -0800 Landed in r19775. 80796 7 timothy 2008-05-17 09:56:03 -0700 Closing since Drosera has been replaced by the new Web Inspector debugger. Moving to the New Bugs component so the Drosera component can be closed and removed. 13287 2007-02-20 23:43:08 -0800 2007-02-21 09:42:51 -0800 Patch drosera-scrolling-memory-patch.txt text/plain 1280 vladimir.olexa SW5kZXg6IERyb3NlcmEvZGVidWdnZXIuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gRHJvc2VyYS9kZWJ1Z2dl ci5qcwkocmV2aXNpb24gMTk3MjYpCisrKyBEcm9zZXJhL2RlYnVnZ2VyLmpzCSh3b3JraW5nIGNv cHkpCkBAIC0xMDM0LDcgKzEwMzQsNyBAQCBmdW5jdGlvbiBsb2FkRmlsZShmaWxlSW5kZXgsIG1h bmFnZU5hdkxpCiAgICAgICAgIAogICAgICAgICBmdW5jdGlvblNlbGVjdC5yZW1vdmVDaGlsZHJl bigpOwogICAgICAgICBmdW5jdGlvbk9wdGlvbi52YWx1ZSA9IG51bGw7Ci0gICAgICAgIGZ1bmN0 aW9uT3B0aW9uLnRleHQgPSAiPCBubyBzZWxlY3RlZCBzeW1ib2wgPiI7CisgICAgICAgIGZ1bmN0 aW9uT3B0aW9uLnRleHQgPSAiPE5vIHNlbGVjdGVkIHN5bWJvbD4iOwogICAgICAgICBmdW5jdGlv blNlbGVjdC5hcHBlbmRDaGlsZChmdW5jdGlvbk9wdGlvbik7CiAgICAgICAgIAogICAgICAgICBm b3IgKHZhciBpID0gMDsgaSA8IGZpbGUuZnVuY3Rpb25OYW1lcy5sZW5ndGg7IGkrKykgewpAQCAt MTA1MSwxMCArMTA1MSwxNyBAQCBmdW5jdGlvbiBsb2FkRmlsZShmaWxlSW5kZXgsIG1hbmFnZU5h dkxpCiAgICAgICAgIGlmIChjdXJyZW50RmlsZSAhPSAtMSkKICAgICAgICAgICAgIHByZXZpb3Vz RmlsZXMucHVzaChjdXJyZW50RmlsZSk7CiAgICAgfQotCisgICAgCiAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoIm5hdkZpbGVMZWZ0QnV0dG9uIikuZGlzYWJsZWQgPSAocHJldmlvdXNGaWxl cy5sZW5ndGggPT0gMCk7CiAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm5hdkZpbGVSaWdo dEJ1dHRvbiIpLmRpc2FibGVkID0gKG5leHRGaWxlcy5sZW5ndGggPT0gMCk7CiAKKyAgICAvL1Jl bWVtYmVyIGFuZCByZWNhbGwgc2Nyb2xsIHBvc2l0aW9uIGZvciBjdXJyZW50IGZpbGUgYW5kIGZp bGUgd2UganVzdCBsb2FkZWQKKyAgICB2YXIgZnJhbWVCb2R5ID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoInNvdXJjZXMiKS5jb250ZW50RG9jdW1lbnQuYm9keTsKKyAgICBpZiAoY3VycmVudEZp bGUgIT0gLTEpIAorICAgICAgICBmaWxlc1tjdXJyZW50RmlsZV0uc2Nyb2xsUG9zaXRpb24gPSBm cmFtZUJvZHkuc2Nyb2xsVG9wOworICAgIGZyYW1lQm9keS5zY3JvbGxUb3AgPSBmaWxlLnNjcm9s bFBvc2l0aW9uOworICAgIGZyYW1lQm9keS5zY3JvbGxMZWZ0ID0gMDsKKyAgICAKICAgICBjdXJy ZW50RmlsZSA9IGZpbGVJbmRleDsKIH0KIAo= 13298 2007-02-21 09:42:51 -0800 2007-02-21 12:02:20 -0800 Patch with Changelog drosera-scrolling-memory-patch.txt text/plain 1695 vladimir.olexa SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE5Nzcz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsOSBAQAorMjAwNy0wMi0y MSAgVmxhZGltaXIgT2xleGEgIDx2bGFkaW1pci5vbGV4YUBnbWFpbC5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEcm9zZXJhL2RlYnVnZ2Vy LmpzOiBJbXBsZW1lbnRlZCBzY3JvbGxpbmcgbWVtb3J5IAorCiAyMDA3LTAyLTIwICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgVG9vbHMgdHdlYWsuIE5vIHJl dmlldyBuZWNlc3NhcnkuCkluZGV4OiBEcm9zZXJhL2RlYnVnZ2VyLmpzCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IERyb3NlcmEvZGVidWdnZXIuanMJKHJldmlzaW9uIDE5NzI2KQorKysgRHJvc2VyYS9kZWJ1Z2dl ci5qcwkod29ya2luZyBjb3B5KQpAQCAtMTAzNCw3ICsxMDM0LDcgQEAgZnVuY3Rpb24gbG9hZEZp bGUoZmlsZUluZGV4LCBtYW5hZ2VOYXZMaQogICAgICAgICAKICAgICAgICAgZnVuY3Rpb25TZWxl Y3QucmVtb3ZlQ2hpbGRyZW4oKTsKICAgICAgICAgZnVuY3Rpb25PcHRpb24udmFsdWUgPSBudWxs OwotICAgICAgICBmdW5jdGlvbk9wdGlvbi50ZXh0ID0gIjwgbm8gc2VsZWN0ZWQgc3ltYm9sID4i OworICAgICAgICBmdW5jdGlvbk9wdGlvbi50ZXh0ID0gIjxObyBzZWxlY3RlZCBzeW1ib2w+IjsK ICAgICAgICAgZnVuY3Rpb25TZWxlY3QuYXBwZW5kQ2hpbGQoZnVuY3Rpb25PcHRpb24pOwogICAg ICAgICAKICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBmaWxlLmZ1bmN0aW9uTmFtZXMubGVu Z3RoOyBpKyspIHsKQEAgLTEwNTEsMTAgKzEwNTEsMTcgQEAgZnVuY3Rpb24gbG9hZEZpbGUoZmls ZUluZGV4LCBtYW5hZ2VOYXZMaQogICAgICAgICBpZiAoY3VycmVudEZpbGUgIT0gLTEpCiAgICAg ICAgICAgICBwcmV2aW91c0ZpbGVzLnB1c2goY3VycmVudEZpbGUpOwogICAgIH0KLQorICAgIAog ICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJuYXZGaWxlTGVmdEJ1dHRvbiIpLmRpc2FibGVk ID0gKHByZXZpb3VzRmlsZXMubGVuZ3RoID09IDApOwogICAgIGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJuYXZGaWxlUmlnaHRCdXR0b24iKS5kaXNhYmxlZCA9IChuZXh0RmlsZXMubGVuZ3RoID09 IDApOwogCisgICAgLy9SZW1lbWJlciBhbmQgcmVjYWxsIHNjcm9sbCBwb3NpdGlvbiBmb3IgY3Vy cmVudCBmaWxlIGFuZCBmaWxlIHdlIGp1c3QgbG9hZGVkCisgICAgdmFyIGZyYW1lQm9keSA9IGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCJzb3VyY2VzIikuY29udGVudERvY3VtZW50LmJvZHk7Cisg ICAgaWYgKGN1cnJlbnRGaWxlICE9IC0xKSAKKyAgICAgICAgZmlsZXNbY3VycmVudEZpbGVdLnNj cm9sbFBvc2l0aW9uID0gZnJhbWVCb2R5LnNjcm9sbFRvcDsKKyAgICBmcmFtZUJvZHkuc2Nyb2xs VG9wID0gZmlsZS5zY3JvbGxQb3NpdGlvbjsKKyAgICBmcmFtZUJvZHkuc2Nyb2xsTGVmdCA9IDA7 CisgICAgCiAgICAgY3VycmVudEZpbGUgPSBmaWxlSW5kZXg7CiB9CiAK