128323 2014-02-06 12:09:34 -0800 [Win] Correct IME Regression after r141479 2014-02-06 12:44:35 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC All RESOLVED FIXED InRadar P1 Critical --- 107737 1 bfulgham bfulgham ap oldest_to_newest 977473 0 bfulgham 2014-02-06 12:09:34 -0800 Some sloppy refactoring in http://trac.webkit.org/changeset/141479 broke IME under Windows. 977476 1 223363 bfulgham 2014-02-06 12:11:32 -0800 Created attachment 223363 Patch 977482 2 223365 bfulgham 2014-02-06 12:15:43 -0800 Created attachment 223365 Patch 977484 3 223365 bfulgham 2014-02-06 12:16:23 -0800 Comment on attachment 223365 Patch Remove extraneous cancelComposition, since the refactored Editor::cancelCompositionIfSelectionIsInvalid() already does this. 977487 4 223365 thorton 2014-02-06 12:22:14 -0800 Comment on attachment 223365 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223365&action=review > Source/WebKit/win/WebView.cpp:-5556 > - if (targetFrame) > - targetFrame->editor().cancelComposition(); > - updateSelectionForIME is not the only caller of resetIME, please revert this part. 977488 5 223367 bfulgham 2014-02-06 12:22:48 -0800 Created attachment 223367 Patch 977493 6 bfulgham 2014-02-06 12:33:56 -0800 Committed r163557: <http://trac.webkit.org/changeset/163557> 977498 7 bfulgham 2014-02-06 12:44:35 -0800 <rdar://problem/15952986> 223363 2014-02-06 12:11:32 -0800 2014-02-06 12:15:41 -0800 Patch bug-128323-20140206121131.patch text/plain 1311 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzU1NCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAyLTA2 ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIENv cnJlY3QgSU1FIFJlZ3Jlc3Npb24gYWZ0ZXIgcjE0MTQ3OQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MzIzCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8xNTk1Mjk4Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFdlYlZpZXcuY3BwOgorICAgICAgICAoV2ViVmlldzo6dXBkYXRlU2VsZWN0aW9uRm9y SU1FKTogUmVmYWN0b3JpbmcgZmxpcHBlZCB0aGUgbWVhbmluZyBvZiB0aGUgdGVzdCB1c2VkCisg ICAgICAgIHRvIHNlbGVjdCB0aGUgcmVzZXRJTUUgY2FzZS4gQ29ycmVjdGVkIGZvciBiZWhhdmlv ciBvZiBuZXcgY2FuY2VsIG1ldGhvZC4KKwogMjAxNC0wMi0wNCAgQW5kcmVhcyBLbGluZyAgPGFr bGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIDxpZnJhbWUgc2VhbWxlc3M+IHN1cHBv cnQuCkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkocmV2aXNpb24gMTYzNTM3KQorKysgU291cmNl L1dlYktpdC93aW4vV2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU1NjMsNyArNTU2Myw3 IEBAIHZvaWQgV2ViVmlldzo6cmVzZXRJTUUoRnJhbWUqIHRhcmdldEZyYW0KIHZvaWQgV2ViVmll dzo6dXBkYXRlU2VsZWN0aW9uRm9ySU1FKCkKIHsKICAgICBGcmFtZSYgdGFyZ2V0RnJhbWUgPSBt X3BhZ2UtPmZvY3VzQ29udHJvbGxlcigpLmZvY3VzZWRPck1haW5GcmFtZSgpOwotICAgIGlmICgh dGFyZ2V0RnJhbWUuZWRpdG9yKCkuY2FuY2VsQ29tcG9zaXRpb25JZlNlbGVjdGlvbklzSW52YWxp ZCgpKQorICAgIGlmICh0YXJnZXRGcmFtZS5lZGl0b3IoKS5jYW5jZWxDb21wb3NpdGlvbklmU2Vs ZWN0aW9uSXNJbnZhbGlkKCkpCiAgICAgICAgIHJlc2V0SU1FKCZ0YXJnZXRGcmFtZSk7CiB9CiAK 223365 2014-02-06 12:15:43 -0800 2014-02-06 12:22:46 -0800 Patch bug-128323-20140206121542.patch text/plain 1861 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzU1NCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAyLTA2 ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIENv cnJlY3QgSU1FIFJlZ3Jlc3Npb24gYWZ0ZXIgcjE0MTQ3OQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MzIzCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8xNTk1Mjk4Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFdlYlZpZXcuY3BwOgorICAgICAgICAoV2ViVmlldzo6cmVzZXRJTUUpOiBSZW1vdmUg ZHVwbGljYXRlIGNhbGwgdG8gZWRpdG9yKCkuY2FuY2VsQ29tcG9zaXRpb24sIHNpbmNlCisgICAg ICAgIHRoZSByZWZhY3RvcmVkIGNvZGUgY2FsbHMgaXQgYXMgcGFydCBvZiBFZGl0b3I6OmNhbmNl bENvbXBvc2l0aW9uSWZTZWxlY3Rpb25Jc0ludmFsaWQuCisgICAgICAgIChXZWJWaWV3Ojp1cGRh dGVTZWxlY3Rpb25Gb3JJTUUpOiBSZWZhY3RvcmluZyBmbGlwcGVkIHRoZSBtZWFuaW5nIG9mIHRo ZSB0ZXN0IHVzZWQKKyAgICAgICAgdG8gc2VsZWN0IHRoZSByZXNldElNRSBjYXNlLiBDb3JyZWN0 ZWQgZm9yIGJlaGF2aW9yIG9mIG5ldyBjYW5jZWwgbWV0aG9kLgorCiAyMDE0LTAyLTA0ICBBbmRy ZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgPGlmcmFtZSBz ZWFtbGVzcz4gc3VwcG9ydC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCShyZXZpc2lvbiAxNjM1 MzcpCisrKyBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAt NTU1MSw5ICs1NTUxLDYgQEAgdm9pZCBXZWJWaWV3OjpwcmVwYXJlQ2FuZGlkYXRlV2luZG93KEZy YQogCiB2b2lkIFdlYlZpZXc6OnJlc2V0SU1FKEZyYW1lKiB0YXJnZXRGcmFtZSkKIHsKLSAgICBp ZiAodGFyZ2V0RnJhbWUpCi0gICAgICAgIHRhcmdldEZyYW1lLT5lZGl0b3IoKS5jYW5jZWxDb21w b3NpdGlvbigpOwotCiAgICAgaWYgKEhJTUMgaElucHV0Q29udGV4dCA9IGdldElNTUNvbnRleHQo KSkgewogICAgICAgICBJTU1EaWN0OjpkaWN0KCkubm90aWZ5SU1FKGhJbnB1dENvbnRleHQsIE5J X0NPTVBPU0lUSU9OU1RSLCBDUFNfQ0FOQ0VMLCAwKTsKICAgICAgICAgcmVsZWFzZUlNTUNvbnRl eHQoaElucHV0Q29udGV4dCk7CkBAIC01NTYzLDcgKzU1NjAsNyBAQCB2b2lkIFdlYlZpZXc6OnJl c2V0SU1FKEZyYW1lKiB0YXJnZXRGcmFtCiB2b2lkIFdlYlZpZXc6OnVwZGF0ZVNlbGVjdGlvbkZv cklNRSgpCiB7CiAgICAgRnJhbWUmIHRhcmdldEZyYW1lID0gbV9wYWdlLT5mb2N1c0NvbnRyb2xs ZXIoKS5mb2N1c2VkT3JNYWluRnJhbWUoKTsKLSAgICBpZiAoIXRhcmdldEZyYW1lLmVkaXRvcigp LmNhbmNlbENvbXBvc2l0aW9uSWZTZWxlY3Rpb25Jc0ludmFsaWQoKSkKKyAgICBpZiAodGFyZ2V0 RnJhbWUuZWRpdG9yKCkuY2FuY2VsQ29tcG9zaXRpb25JZlNlbGVjdGlvbklzSW52YWxpZCgpKQog ICAgICAgICByZXNldElNRSgmdGFyZ2V0RnJhbWUpOwogfQogCg== 223367 2014-02-06 12:22:48 -0800 2014-02-06 12:33:06 -0800 Patch bug-128323-20140206122247.patch text/plain 1311 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzU1NCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAyLTA2 ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIENv cnJlY3QgSU1FIFJlZ3Jlc3Npb24gYWZ0ZXIgcjE0MTQ3OQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MzIzCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8xNTk1Mjk4Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFdlYlZpZXcuY3BwOgorICAgICAgICAoV2ViVmlldzo6dXBkYXRlU2VsZWN0aW9uRm9y SU1FKTogUmVmYWN0b3JpbmcgZmxpcHBlZCB0aGUgbWVhbmluZyBvZiB0aGUgdGVzdCB1c2VkCisg ICAgICAgIHRvIHNlbGVjdCB0aGUgcmVzZXRJTUUgY2FzZS4gQ29ycmVjdGVkIGZvciBiZWhhdmlv ciBvZiBuZXcgY2FuY2VsIG1ldGhvZC4KKwogMjAxNC0wMi0wNCAgQW5kcmVhcyBLbGluZyAgPGFr bGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIDxpZnJhbWUgc2VhbWxlc3M+IHN1cHBv cnQuCkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkocmV2aXNpb24gMTYzNTM3KQorKysgU291cmNl L1dlYktpdC93aW4vV2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU1NjMsNyArNTU2Myw3 IEBAIHZvaWQgV2ViVmlldzo6cmVzZXRJTUUoRnJhbWUqIHRhcmdldEZyYW0KIHZvaWQgV2ViVmll dzo6dXBkYXRlU2VsZWN0aW9uRm9ySU1FKCkKIHsKICAgICBGcmFtZSYgdGFyZ2V0RnJhbWUgPSBt X3BhZ2UtPmZvY3VzQ29udHJvbGxlcigpLmZvY3VzZWRPck1haW5GcmFtZSgpOwotICAgIGlmICgh dGFyZ2V0RnJhbWUuZWRpdG9yKCkuY2FuY2VsQ29tcG9zaXRpb25JZlNlbGVjdGlvbklzSW52YWxp ZCgpKQorICAgIGlmICh0YXJnZXRGcmFtZS5lZGl0b3IoKS5jYW5jZWxDb21wb3NpdGlvbklmU2Vs ZWN0aW9uSXNJbnZhbGlkKCkpCiAgICAgICAgIHJlc2V0SU1FKCZ0YXJnZXRGcmFtZSk7CiB9CiAK