128301 2014-02-06 02:50:09 -0800 Misused PLATFORM(MIDDLE_ENDIAN) and PLATFORM(BIG_ENDIAN) 2014-06-18 00:00:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tgergely.u-szeged webkit-unassigned benjamin cmarcelo commit-queue dbates ossy oldest_to_newest 977302 0 tgergely.u-szeged 2014-02-06 02:50:09 -0800 MIDDLE_ENDIAN and BIG_ENDIAN are CPU attributes and not platform. They should be used with CPU() macro, and not with PLATFORM(). 977303 1 223320 tgergely.u-szeged 2014-02-06 02:51:53 -0800 Created attachment 223320 patch 1016263 2 223320 dbates 2014-06-17 14:59:41 -0700 Comment on attachment 223320 patch r=me Is there any way we can prevent this? From briefly searching, GCC has option -Wundef to warn about undefined identifiers. Would enabling it lead to many false positives? 1016277 3 223320 commit-queue 2014-06-17 15:35:54 -0700 Comment on attachment 223320 patch Clearing flags on attachment: 223320 Committed r170081: <http://trac.webkit.org/changeset/170081> 1016278 4 commit-queue 2014-06-17 15:35:57 -0700 All reviewed patches have been landed. Closing bug. 1016387 5 ossy 2014-06-18 00:00:05 -0700 (In reply to comment #2) > (From update of attachment 223320 [details]) > r=me > > Is there any way we can prevent this? From briefly searching, GCC has option -Wundef to warn about undefined identifiers. Would enabling it lead to many false positives? -Wundef is used by EFL port, but it doesn't help similar issues, because PLATFORM macro has the following definition: #define PLATFORM(WTF_FEATURE) (defined WTF_PLATFORM_##WTF_FEATURE && WTF_PLATFORM_##WTF_FEATURE) 223320 2014-02-06 02:51:53 -0800 2014-06-17 15:35:54 -0700 patch fix_platform_cpu_endianness.patch text/plain 1402 tgergely.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggNjZkMTgwNS4uZTVjMjVmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNC0wMi0wNiAg VGFtYXMgR2VyZ2VseSAgPHRnZXJnZWx5LnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisK KyAgICAgICAgTWlzdXNlZCBQTEFURk9STShNSURETEVfRU5ESUFOKSBhbmQgUExBVEZPUk0oQklH X0VORElBTikuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjgzMDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBFbmRpYW5uZXNzIGlzIGEgQ1BVIGF0dHJpYnV0ZSwgbm90IGEgUExBVEZPUk0uIFBMQVRGT1JN KCkgbWFjcm8gaXMgcmVwbGFjZWQgdG8gQ1BVKCkuCisKKyAgICAgICAgKiB3dGYvdGV4dC9BU0NJ SUZhc3RQYXRoLmg6CisgICAgICAgIChXVEY6OmNvcHlMQ2hhcnNGcm9tVUNoYXJTb3VyY2UpOgor CiAyMDE0LTAyLTA1ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAg ICAgICBSZW1vdmUgdGhlIFdURl9DT01QSUxFUl9TVVBQT1JUU19DWFhfR0VORVJBTElaRURfSU5J VElBTElaRVJTIG1hY3JvCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0FTQ0lJRmFz dFBhdGguaCBiL1NvdXJjZS9XVEYvd3RmL3RleHQvQVNDSUlGYXN0UGF0aC5oCmluZGV4IDg1ZTk2 ZWIuLjRhZDFiMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvQVNDSUlGYXN0UGF0 aC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvQVNDSUlGYXN0UGF0aC5oCkBAIC0xNjAsNyAr MTYwLDcgQEAgaW5saW5lIHZvaWQgY29weUxDaGFyc0Zyb21VQ2hhclNvdXJjZShMQ2hhciogZGVz dGluYXRpb24sIGNvbnN0IFVDaGFyKiBzb3VyY2UsIHMKIAogICAgIHdoaWxlIChkZXN0aW5hdGlv biAhPSBlbmQpCiAgICAgICAgICpkZXN0aW5hdGlvbisrID0gc3RhdGljX2Nhc3Q8TENoYXI+KCpz b3VyY2UrKyk7Ci0jZWxpZiBDT01QSUxFUihHQ0MpICYmIENQVShBUk1fTkVPTikgJiYgIShQTEFU Rk9STShCSUdfRU5ESUFOKSB8fCBQTEFURk9STShNSURETEVfRU5ESUFOKSkgJiYgZGVmaW5lZChO REVCVUcpCisjZWxpZiBDT01QSUxFUihHQ0MpICYmIENQVShBUk1fTkVPTikgJiYgIShDUFUoQklH X0VORElBTikgfHwgQ1BVKE1JRERMRV9FTkRJQU4pKSAmJiBkZWZpbmVkKE5ERUJVRykKICAgICBj b25zdCBMQ2hhciogY29uc3QgZW5kID0gZGVzdGluYXRpb24gKyBsZW5ndGg7CiAgICAgY29uc3Qg dWludHB0cl90IG1lbW9yeUFjY2Vzc1NpemUgPSA4OwogCg==