128299 2014-02-06 00:23:32 -0800 Fix the build after r163516 for !ENABLE(ASYNC_SCROLLING) platforms 2014-02-06 09:02:31 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 128293 1 ossy ossy benjamin ossy simon.fraser oldest_to_newest 977275 0 ossy 2014-02-06 00:23:32 -0800 /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/WebPageProxy.cpp: In function 'bool WebKit::anyTouchIsInNonFastScrollableRegion(WebKit::RemoteScrollingCoordinatorProxy&, const WebKit::WebTouchEvent&)': /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:1379:33: error: invalid use of incomplete type 'class WebKit::RemoteScrollingCoordinatorProxy' In file included from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:28:0: /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/WebPageProxy.h:143:7: error: forward declaration of 'class WebKit::RemoteScrollingCoordinatorProxy' /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:1379:78: error: 'class WebKit::WebPlatformTouchPoint' has no member named 'location' /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/WebPageProxy.cpp: In member function 'void WebKit::WebPageProxy::handleTouchEvent(const WebKit::NativeWebTouchEvent&)': /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:1396:51: error: 'm_scrollingCoordinatorProxy' was not declared in this scope Fix is coming soon. 977276 1 223314 ossy 2014-02-06 00:35:45 -0800 Created attachment 223314 Patch WIP patch for EWS and will be tested locally too 977280 2 223314 ossy 2014-02-06 00:51:44 -0800 Comment on attachment 223314 Patch It builds on EFL locally, so set r? 977282 3 223314 ossy 2014-02-06 00:56:44 -0800 Comment on attachment 223314 Patch Clearing flags on attachment: 223314 Committed r163526: <http://trac.webkit.org/changeset/163526> 977283 4 ossy 2014-02-06 00:56:50 -0800 All reviewed patches have been landed. Closing bug. 977367 5 simon.fraser 2014-02-06 09:02:31 -0800 Sorry for the breakage. 223314 2014-02-06 00:35:45 -0800 2014-02-06 00:56:44 -0800 Patch bug-128299-20140206093759.patch text/plain 2471 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzk4NjI4NGYyNmYzNmY1 NDAwYWVmYTgwMGEyNDZmNWZlMDhiNWJkNC4uNTA0MmMwYWU1M2YxYjVjYWI2ZjFjMjkzYjA4ZThk ZWMwNGNjMDE3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAyLTA2ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSBidWls ZCBhZnRlciByMTYzNTE2IGZvciAhRU5BQkxFKEFTWU5DX1NDUk9MTElORykgcGxhdGZvcm1zCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgyOTkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmhhbmRs ZVRvdWNoRXZlbnQpOgorCiAyMDE0LTAyLTA1ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xv dWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBDaGFuZ2UgUGFnZSwgRm9jdXNDb250cm9sbGVyIHRv IHVzZSBWaWV3U3RhdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAK aW5kZXggNmY0MDcwOTkxZWZiOGNmMjAzZjczYjFjMzgzYTRhOWE1NWM1YWEwYy4uMGEyODVkZDc3 ZGEzNjNmYzExYjI0NzNkYTdkNGY1NTM5ZGEzY2Q5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTEzNzMsNiArMTM3Myw3IEBAIHZvaWQgV2ViUGFnZVBy b3h5OjpmaW5kUGx1Z2luKGNvbnN0IFN0cmluZyYgbWltZVR5cGUsIHVpbnQzMl90IHByb2Nlc3NU eXBlLCBjb25zCiAjZW5kaWYgLy8gRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCiAKICNpZiBF TkFCTEUoVE9VQ0hfRVZFTlRTKQorI2lmIEVOQUJMRShBU1lOQ19TQ1JPTExJTkcpCiBzdGF0aWMg Ym9vbCBhbnlUb3VjaElzSW5Ob25GYXN0U2Nyb2xsYWJsZVJlZ2lvbihSZW1vdGVTY3JvbGxpbmdD b29yZGluYXRvclByb3h5JiBzY3JvbGxpbmdDb29yZGluYXRvciwgY29uc3QgV2ViVG91Y2hFdmVu dCYgZXZlbnQpCiB7CiAgICAgZm9yIChhdXRvIHRvdWNoUG9pbnQgOiBldmVudC50b3VjaFBvaW50 cygpKSB7CkBAIC0xMzgyLDYgKzEzODMsNyBAQCBzdGF0aWMgYm9vbCBhbnlUb3VjaElzSW5Ob25G YXN0U2Nyb2xsYWJsZVJlZ2lvbihSZW1vdGVTY3JvbGxpbmdDb29yZGluYXRvclByb3h5JgogCiAg ICAgcmV0dXJuIGZhbHNlOwogfQorI2VuZGlmIC8vIEVOQUJMRShBU1lOQ19TQ1JPTExJTkcpCiAK IHZvaWQgV2ViUGFnZVByb3h5OjpoYW5kbGVUb3VjaEV2ZW50KGNvbnN0IE5hdGl2ZVdlYlRvdWNo RXZlbnQmIGV2ZW50KQogewpAQCAtMTM5Miw5ICsxMzk0LDEyIEBAIHZvaWQgV2ViUGFnZVByb3h5 OjpoYW5kbGVUb3VjaEV2ZW50KGNvbnN0IE5hdGl2ZVdlYlRvdWNoRXZlbnQmIGV2ZW50KQogICAg IC8vIGFuZCBhbmltYXRpb24gb24gdGhlIHBhZ2UgaXRzZWxmIChraW5ldGljIHNjcm9sbGluZywg dGFwIHRvIHpvb20pIGV0YywgdGhlbgogICAgIC8vIHdlIGRvIG5vdCBzZW5kIGFueSBvZiB0aGUg ZXZlbnRzIHRvIHRoZSBwYWdlIGV2ZW4gaWYgaXMgaGFzIGxpc3RlbmVycy4KICAgICBpZiAoIW1f aXNQYWdlU3VzcGVuZGVkKSB7CisKKyNpZiBFTkFCTEUoQVNZTkNfU0NST0xMSU5HKQogICAgICAg ICAvLyBGSVhNRTogd2Ugc2hvdWxkIG9ubHkgZG8gdGhpcyBjaGVjayBmb3IgdGhlIHN0YXJ0IG9m IGEgdG91Y2ggZ2VzdHVyZS4KICAgICAgICAgaWYgKCFhbnlUb3VjaElzSW5Ob25GYXN0U2Nyb2xs YWJsZVJlZ2lvbigqbV9zY3JvbGxpbmdDb29yZGluYXRvclByb3h5LCBldmVudCkpCiAgICAgICAg ICAgICByZXR1cm47CisjZW5kaWYKIAogICAgICAgICBtX3RvdWNoRXZlbnRRdWV1ZS5hcHBlbmQo ZXZlbnQpOwogICAgICAgICBtX3Byb2Nlc3MtPnJlc3BvbnNpdmVuZXNzVGltZXIoKS0+c3RhcnQo KTsKQEAgLTE0MTYsNyArMTQyMSw3IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpoYW5kbGVUb3VjaEV2 ZW50KGNvbnN0IE5hdGl2ZVdlYlRvdWNoRXZlbnQmIGV2ZW50KQogICAgICAgICB9CiAgICAgfQog fQotI2VuZGlmCisjZW5kaWYgLy8gRU5BQkxFKFRPVUNIX0VWRU5UUykKIAogdm9pZCBXZWJQYWdl UHJveHk6OnNjcm9sbEJ5KFNjcm9sbERpcmVjdGlvbiBkaXJlY3Rpb24sIFNjcm9sbEdyYW51bGFy aXR5IGdyYW51bGFyaXR5KQogewo=