128298 2014-02-05 22:28:33 -0800 [EFL][WK2] Remove legacy behavior mode in MiniBrowser 2014-02-06 04:32:15 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song commit-queue ryuan.choi oldest_to_newest 977246 0 jinwoo7.song 2014-02-05 22:28:33 -0800 MiniBrowser is crashing when the legacy mode is set in creating webview. As EFL application cannot use this API for creating webview after r146265, it would be better to remove this invalid option. 977249 1 223310 jinwoo7.song 2014-02-05 22:31:39 -0800 Created attachment 223310 Patch 977250 2 223311 jinwoo7.song 2014-02-05 22:33:18 -0800 Created attachment 223311 Patch 977254 3 223311 gyuyoung.kim 2014-02-05 22:44:41 -0800 Comment on attachment 223311 Patch r=me 977259 4 223311 commit-queue 2014-02-05 23:19:37 -0800 Comment on attachment 223311 Patch Clearing flags on attachment: 223311 Committed r163518: <http://trac.webkit.org/changeset/163518> 977260 5 commit-queue 2014-02-05 23:19:40 -0800 All reviewed patches have been landed. Closing bug. 977261 6 ryuan.choi 2014-02-05 23:31:18 -0800 (In reply to comment #0) > MiniBrowser is crashing when the legacy mode is set in creating webview. > As EFL application cannot use this API for creating webview after r146265, > it would be better to remove this invalid option. I don't have objection about this because it was not maintained very long time. But, I really hope that we have a way to make applications like almost desktop based browsers using webkit2. Now, MiniBrowser/Efl scaled and fitted contents to webview without any consideration. :( 977263 7 jinwoo7.song 2014-02-05 23:38:34 -0800 (In reply to comment #6) > (In reply to comment #0) > > MiniBrowser is crashing when the legacy mode is set in creating webview. > > As EFL application cannot use this API for creating webview after r146265, > > it would be better to remove this invalid option. > > I don't have objection about this because it was not maintained very long time. > > But, I really hope that we have a way to make applications like almost desktop based browsers using webkit2. > > Now, MiniBrowser/Efl scaled and fitted contents to webview without any consideration. :( I definitely agree to you, so I have a plan to make a API to set fixedLayout and let application to configure it. 977315 8 jinwoo7.song 2014-02-06 04:32:15 -0800 (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #0) > > > MiniBrowser is crashing when the legacy mode is set in creating webview. > > > As EFL application cannot use this API for creating webview after r146265, > > > it would be better to remove this invalid option. > > > > I don't have objection about this because it was not maintained very long time. > > > > But, I really hope that we have a way to make applications like almost desktop based browsers using webkit2. > > > > Now, MiniBrowser/Efl scaled and fitted contents to webview without any consideration. :( > > I definitely agree to you, so I have a plan to make a API to set fixedLayout and let application to configure it. I filed a bug and upload a patch in bug 128300. 223310 2014-02-05 22:31:39 -0800 2014-02-05 22:33:13 -0800 Patch bug-128298-20140206153137.patch text/plain 3227 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNDA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDFkOWQ1MmIxZmMxOTk1ZThlYzVjMDBhMDM4ZjgzNmEz YjdkN2U0Zi4uNWFmNjhlMjNkMDUzNmQ4MTE4YTFkMDI4MzIyM2ZiMjZiMjBiMTQwMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE0LTAyLTA1ICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4K KworICAgICAgICBbRUZMXVtXSzJdIFJlbW92ZSBsZWdhY3kgYmVoYXZpb3IgbW9kZSBpbiBNaW5p QnJvd3NlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTI4Mjk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBNaW5pQnJvd3Nlci9lZmwvbWFpbi5jOgorICAgICAgICAod2luZG93X2NyZWF0ZSk6IERvIG5v dCBjcmVhdGUgd2VidmlldyB3aXRoIFdLVmlld0NyZWF0ZSBBUEkuCisgICAgICAgIChlbG1fbWFp bik6IFJlbW92ZSAnbGVnYWN5JyBvcHRpb24uCisKIDIwMTQtMDItMDQgIENhcmxvcyBHYXJuYWNo byAgPGNhcmxvc2dAZ25vbWUub3JnPgogCiAgICAgICAgIFtBdXRvbWFrZV0gQWRkIG1pc3Npbmcg JChmZWF0dXJlX2RlZmluZXMpIHdoZW4gZ2VuZXJhdGluZyBJbmplY3RlZEJ1bmRsZSBiaW5kaW5n cwpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYyBiL1Rvb2xzL01pbmlC cm93c2VyL2VmbC9tYWluLmMKaW5kZXggMmE4ZmRhMTAxODAxOTUwNzM1ZWFkYWJlZTQ3OGE1MmI1 NDk4YmUwNC4uODgzNjQ5NDA3YTllNWRkYjE2YTQ4OWViZGNhNzc0YWNhZDNkMzBmNCAxMDA2NDQK LS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYworKysgYi9Ub29scy9NaW5pQnJvd3Nl ci9lZmwvbWFpbi5jCkBAIC0xNTEsOCArMTUxLDYgQEAgc3RhdGljIGNvbnN0IEVjb3JlX0dldG9w dCBvcHRpb25zID0gewogICAgICAgICAgICAgKCdzJywgIndpbmRvdy1zaXplIiwgIndpbmRvdyBz aXplIGluIGZvbGxvd2luZyBmb3JtYXQgKHdpZHRoKXgoaGVpZ2h0KS4iKSwKICAgICAgICAgRUNP UkVfR0VUT1BUX1NUT1JFX1NUUgogICAgICAgICAgICAgKCd1JywgInVzZXItYWdlbnQiLCAidXNl ciBhZ2VudCB0byBzZXQuIiksCi0gICAgICAgIEVDT1JFX0dFVE9QVF9TVE9SRV9ERUZfQk9PTAot ICAgICAgICAgICAgKCdiJywgImxlZ2FjeSIsICJMZWdhY3kgbW9kZSIsIEVJTkFfRkFMU0UpLAog ICAgICAgICBFQ09SRV9HRVRPUFRfU1RPUkVfRE9VQkxFCiAgICAgICAgICAgICAoJ3InLCAiZGV2 aWNlLXBpeGVsLXJhdGlvIiwgIlJhdGlvIGJldHdlZW4gdGhlIENTUyB1bml0cyBhbmQgZGV2aWNl IHBpeGVscy4iKSwKICAgICAgICAgRUNPUkVfR0VUT1BUX0NBTExCQUNLX05PQVJHUwpAQCAtMTgx OSwxNSArMTgxNywxMSBAQCBzdGF0aWMgQnJvd3Nlcl9XaW5kb3cgKndpbmRvd19jcmVhdGUoRXZh c19PYmplY3QgKm9wZW5lciwgaW50IHdpZHRoLCBpbnQgaGVpZ2h0LAogICAgIGV3a1ZpZXdDbGFz cy0+aW5wdXRfcGlja2VyX2NvbG9yX2Rpc21pc3MgPSBvbl9jb2xvcl9waWNrZXJfZGlzbWlzczsK IAogICAgIEV2YXMgKmV2YXMgPSBldmFzX29iamVjdF9ldmFzX2dldCh3aW5kb3ctPmVsbV93aW5k b3cpOwotICAgIGlmIChsZWdhY3lfYmVoYXZpb3JfZW5hYmxlZCkgewotICAgICAgICAvLyBVc2Ug cmF3IFdLMiBhcGkgdG8gY3JlYXRlIGEgdmlldyB1c2luZyBsZWdhY3kgbW9kZS4KLSAgICAgICAg d2luZG93LT5ld2tfdmlldyA9IChFdmFzX09iamVjdCopV0tWaWV3Q3JlYXRlKGV2YXMsIDAsIDAp OwotICAgIH0gZWxzZSB7Ci0gICAgICAgIEV2YXNfU21hcnQgKnNtYXJ0ID0gZXZhc19zbWFydF9j bGFzc19uZXcoJmV3a1ZpZXdDbGFzcy0+c2MpOwotICAgICAgICBFd2tfQ29udGV4dCAqY29udGV4 dCA9IG9wZW5lciA/IGV3a192aWV3X2NvbnRleHRfZ2V0KG9wZW5lcikgOiBld2tfY29udGV4dF9k ZWZhdWx0X2dldCgpOwotICAgICAgICBFd2tfUGFnZV9Hcm91cCAqcGFnZUdyb3VwID0gb3BlbmVy ID8gZXdrX3ZpZXdfcGFnZV9ncm91cF9nZXQob3BlbmVyKSA6IGV3a19wYWdlX2dyb3VwX2NyZWF0 ZSgiIik7Ci0gICAgICAgIHdpbmRvdy0+ZXdrX3ZpZXcgPSBld2tfdmlld19zbWFydF9hZGQoZXZh cywgc21hcnQsIGNvbnRleHQsIHBhZ2VHcm91cCk7Ci0gICAgfQorICAgIEV2YXNfU21hcnQgKnNt YXJ0ID0gZXZhc19zbWFydF9jbGFzc19uZXcoJmV3a1ZpZXdDbGFzcy0+c2MpOworICAgIEV3a19D b250ZXh0ICpjb250ZXh0ID0gb3BlbmVyID8gZXdrX3ZpZXdfY29udGV4dF9nZXQob3BlbmVyKSA6 IGV3a19jb250ZXh0X2RlZmF1bHRfZ2V0KCk7CisgICAgRXdrX1BhZ2VfR3JvdXAgKnBhZ2VHcm91 cCA9IG9wZW5lciA/IGV3a192aWV3X3BhZ2VfZ3JvdXBfZ2V0KG9wZW5lcikgOiBld2tfcGFnZV9n cm91cF9jcmVhdGUoIiIpOworICAgIHdpbmRvdy0+ZXdrX3ZpZXcgPSBld2tfdmlld19zbWFydF9h ZGQoZXZhcywgc21hcnQsIGNvbnRleHQsIHBhZ2VHcm91cCk7CisKICAgICBld2tfdmlld190aGVt ZV9zZXQod2luZG93LT5ld2tfdmlldywgVEVTVF9USEVNRV9ESVIgIi9kZWZhdWx0LmVkaiIpOwog ICAgIGlmIChkZXZpY2VfcGl4ZWxfcmF0aW8pCiAgICAgICAgIGV3a192aWV3X2RldmljZV9waXhl bF9yYXRpb19zZXQod2luZG93LT5ld2tfdmlldywgKGZsb2F0KWRldmljZV9waXhlbF9yYXRpbyk7 CkBAIC0xOTQwLDcgKzE5MzQsNiBAQCBlbG1fbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltdKQog ICAgICAgICBFQ09SRV9HRVRPUFRfVkFMVUVfU1RSKGV2YXNfZW5naW5lX25hbWUpLAogICAgICAg ICBFQ09SRV9HRVRPUFRfVkFMVUVfU1RSKHdpbmRvd19zaXplX3N0cmluZyksCiAgICAgICAgIEVD T1JFX0dFVE9QVF9WQUxVRV9TVFIodXNlcl9hZ2VudF9zdHJpbmcpLAotICAgICAgICBFQ09SRV9H RVRPUFRfVkFMVUVfQk9PTChsZWdhY3lfYmVoYXZpb3JfZW5hYmxlZCksCiAgICAgICAgIEVDT1JF X0dFVE9QVF9WQUxVRV9ET1VCTEUoZGV2aWNlX3BpeGVsX3JhdGlvKSwKICAgICAgICAgRUNPUkVf R0VUT1BUX1ZBTFVFX0JPT0wocXVpdE9wdGlvbiksCiAgICAgICAgIEVDT1JFX0dFVE9QVF9WQUxV RV9CT09MKGVuY29kaW5nX2RldGVjdG9yX2VuYWJsZWQpLAo= 223311 2014-02-05 22:33:18 -0800 2014-02-05 23:19:36 -0800 Patch bug-128298-20140206153316.patch text/plain 3454 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNDA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDFkOWQ1MmIxZmMxOTk1ZThlYzVjMDBhMDM4ZjgzNmEz YjdkN2U0Zi4uODNkMzU2MmJlMzdkYWIwMzY1MmYzMTk1Njc3MTQ4MTUwMjU0MjgzYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE0LTAyLTA1ICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4K KworICAgICAgICBbRUZMXVtXSzJdIFJlbW92ZSBsZWdhY3kgYmVoYXZpb3IgbW9kZSBpbiBNaW5p QnJvd3NlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTI4Mjk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TWluaUJyb3dzZXIgaXMgY3Jhc2hpbmcgd2hlbiB0aGUgbGVnYWN5IG1vZGUgaXMgc2V0IGluIGNy ZWF0aW5nIHdlYnZpZXcuCisgICAgICAgIEFzIEVGTCBhcHBsaWNhdGlvbiBjYW5ub3QgdXNlIHRo aXMgQVBJIGZvciBjcmVhdGluZyB3ZWJ2aWV3IGFmdGVyIHIxNDYyNjUsCisgICAgICAgIGl0IHdv dWxkIGJlIGJldHRlciB0byByZW1vdmUgdGhpcyBpbnZhbGlkIG9wdGlvbi4KKworICAgICAgICAq IE1pbmlCcm93c2VyL2VmbC9tYWluLmM6CisgICAgICAgICh3aW5kb3dfY3JlYXRlKTogRG8gbm90 IGNyZWF0ZSB3ZWJ2aWV3IHdpdGggV0tWaWV3Q3JlYXRlIEFQSS4KKyAgICAgICAgKGVsbV9tYWlu KTogUmVtb3ZlICdsZWdhY3knIG9wdGlvbi4KKwogMjAxNC0wMi0wNCAgQ2FybG9zIEdhcm5hY2hv ICA8Y2FybG9zZ0Bnbm9tZS5vcmc+CiAKICAgICAgICAgW0F1dG9tYWtlXSBBZGQgbWlzc2luZyAk KGZlYXR1cmVfZGVmaW5lcykgd2hlbiBnZW5lcmF0aW5nIEluamVjdGVkQnVuZGxlIGJpbmRpbmdz CmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJy b3dzZXIvZWZsL21haW4uYwppbmRleCAyYThmZGExMDE4MDE5NTA3MzVlYWRhYmVlNDc4YTUyYjU0 OThiZTA0Li44ODM2NDk0MDdhOWU1ZGRiMTZhNDg5ZWJkY2E3NzRhY2FkM2QzMGY0IDEwMDY0NAot LS0gYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2Vy L2VmbC9tYWluLmMKQEAgLTE1MSw4ICsxNTEsNiBAQCBzdGF0aWMgY29uc3QgRWNvcmVfR2V0b3B0 IG9wdGlvbnMgPSB7CiAgICAgICAgICAgICAoJ3MnLCAid2luZG93LXNpemUiLCAid2luZG93IHNp emUgaW4gZm9sbG93aW5nIGZvcm1hdCAod2lkdGgpeChoZWlnaHQpLiIpLAogICAgICAgICBFQ09S RV9HRVRPUFRfU1RPUkVfU1RSCiAgICAgICAgICAgICAoJ3UnLCAidXNlci1hZ2VudCIsICJ1c2Vy IGFnZW50IHRvIHNldC4iKSwKLSAgICAgICAgRUNPUkVfR0VUT1BUX1NUT1JFX0RFRl9CT09MCi0g ICAgICAgICAgICAoJ2InLCAibGVnYWN5IiwgIkxlZ2FjeSBtb2RlIiwgRUlOQV9GQUxTRSksCiAg ICAgICAgIEVDT1JFX0dFVE9QVF9TVE9SRV9ET1VCTEUKICAgICAgICAgICAgICgncicsICJkZXZp Y2UtcGl4ZWwtcmF0aW8iLCAiUmF0aW8gYmV0d2VlbiB0aGUgQ1NTIHVuaXRzIGFuZCBkZXZpY2Ug cGl4ZWxzLiIpLAogICAgICAgICBFQ09SRV9HRVRPUFRfQ0FMTEJBQ0tfTk9BUkdTCkBAIC0xODE5 LDE1ICsxODE3LDExIEBAIHN0YXRpYyBCcm93c2VyX1dpbmRvdyAqd2luZG93X2NyZWF0ZShFdmFz X09iamVjdCAqb3BlbmVyLCBpbnQgd2lkdGgsIGludCBoZWlnaHQsCiAgICAgZXdrVmlld0NsYXNz LT5pbnB1dF9waWNrZXJfY29sb3JfZGlzbWlzcyA9IG9uX2NvbG9yX3BpY2tlcl9kaXNtaXNzOwog CiAgICAgRXZhcyAqZXZhcyA9IGV2YXNfb2JqZWN0X2V2YXNfZ2V0KHdpbmRvdy0+ZWxtX3dpbmRv dyk7Ci0gICAgaWYgKGxlZ2FjeV9iZWhhdmlvcl9lbmFibGVkKSB7Ci0gICAgICAgIC8vIFVzZSBy YXcgV0syIGFwaSB0byBjcmVhdGUgYSB2aWV3IHVzaW5nIGxlZ2FjeSBtb2RlLgotICAgICAgICB3 aW5kb3ctPmV3a192aWV3ID0gKEV2YXNfT2JqZWN0KilXS1ZpZXdDcmVhdGUoZXZhcywgMCwgMCk7 Ci0gICAgfSBlbHNlIHsKLSAgICAgICAgRXZhc19TbWFydCAqc21hcnQgPSBldmFzX3NtYXJ0X2Ns YXNzX25ldygmZXdrVmlld0NsYXNzLT5zYyk7Ci0gICAgICAgIEV3a19Db250ZXh0ICpjb250ZXh0 ID0gb3BlbmVyID8gZXdrX3ZpZXdfY29udGV4dF9nZXQob3BlbmVyKSA6IGV3a19jb250ZXh0X2Rl ZmF1bHRfZ2V0KCk7Ci0gICAgICAgIEV3a19QYWdlX0dyb3VwICpwYWdlR3JvdXAgPSBvcGVuZXIg PyBld2tfdmlld19wYWdlX2dyb3VwX2dldChvcGVuZXIpIDogZXdrX3BhZ2VfZ3JvdXBfY3JlYXRl KCIiKTsKLSAgICAgICAgd2luZG93LT5ld2tfdmlldyA9IGV3a192aWV3X3NtYXJ0X2FkZChldmFz LCBzbWFydCwgY29udGV4dCwgcGFnZUdyb3VwKTsKLSAgICB9CisgICAgRXZhc19TbWFydCAqc21h cnQgPSBldmFzX3NtYXJ0X2NsYXNzX25ldygmZXdrVmlld0NsYXNzLT5zYyk7CisgICAgRXdrX0Nv bnRleHQgKmNvbnRleHQgPSBvcGVuZXIgPyBld2tfdmlld19jb250ZXh0X2dldChvcGVuZXIpIDog ZXdrX2NvbnRleHRfZGVmYXVsdF9nZXQoKTsKKyAgICBFd2tfUGFnZV9Hcm91cCAqcGFnZUdyb3Vw ID0gb3BlbmVyID8gZXdrX3ZpZXdfcGFnZV9ncm91cF9nZXQob3BlbmVyKSA6IGV3a19wYWdlX2dy b3VwX2NyZWF0ZSgiIik7CisgICAgd2luZG93LT5ld2tfdmlldyA9IGV3a192aWV3X3NtYXJ0X2Fk ZChldmFzLCBzbWFydCwgY29udGV4dCwgcGFnZUdyb3VwKTsKKwogICAgIGV3a192aWV3X3RoZW1l X3NldCh3aW5kb3ctPmV3a192aWV3LCBURVNUX1RIRU1FX0RJUiAiL2RlZmF1bHQuZWRqIik7CiAg ICAgaWYgKGRldmljZV9waXhlbF9yYXRpbykKICAgICAgICAgZXdrX3ZpZXdfZGV2aWNlX3BpeGVs X3JhdGlvX3NldCh3aW5kb3ctPmV3a192aWV3LCAoZmxvYXQpZGV2aWNlX3BpeGVsX3JhdGlvKTsK QEAgLTE5NDAsNyArMTkzNCw2IEBAIGVsbV9tYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAg ICAgICAgIEVDT1JFX0dFVE9QVF9WQUxVRV9TVFIoZXZhc19lbmdpbmVfbmFtZSksCiAgICAgICAg IEVDT1JFX0dFVE9QVF9WQUxVRV9TVFIod2luZG93X3NpemVfc3RyaW5nKSwKICAgICAgICAgRUNP UkVfR0VUT1BUX1ZBTFVFX1NUUih1c2VyX2FnZW50X3N0cmluZyksCi0gICAgICAgIEVDT1JFX0dF VE9QVF9WQUxVRV9CT09MKGxlZ2FjeV9iZWhhdmlvcl9lbmFibGVkKSwKICAgICAgICAgRUNPUkVf R0VUT1BUX1ZBTFVFX0RPVUJMRShkZXZpY2VfcGl4ZWxfcmF0aW8pLAogICAgICAgICBFQ09SRV9H RVRPUFRfVkFMVUVfQk9PTChxdWl0T3B0aW9uKSwKICAgICAgICAgRUNPUkVfR0VUT1BUX1ZBTFVF X0JPT0woZW5jb2RpbmdfZGV0ZWN0b3JfZW5hYmxlZCksCg==