128286 2014-02-05 17:17:41 -0800 run-webkit-tests should have a --no-timeout option 2014-03-31 11:15:58 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned ap commit-queue glenn matthew_hanson ossy oldest_to_newest 977158 0 joepeck 2014-02-05 17:17:41 -0800 It is very difficult to debug a test in DumpRenderTree if there is a timeout. Also, --time-out-ms doesn't seem to be respected. 977388 1 ap 2014-02-06 09:36:33 -0800 FWIW, --time-out-ms always works for me. It gets tricker with WebKit2, because there is an additional option to pass to disable a different timeout, I don't remember which one offhand. 995805 2 228164 jberta.u-szeged 2014-03-31 03:20:34 -0700 Created attachment 228164 Adding --no-timeout option 995919 3 228164 joepeck 2014-03-31 10:45:53 -0700 Comment on attachment 228164 Adding --no-timeout option r=me, nice! 995922 4 228164 commit-queue 2014-03-31 11:15:54 -0700 Comment on attachment 228164 Adding --no-timeout option Clearing flags on attachment: 228164 Committed r166515: <http://trac.webkit.org/changeset/166515> 995923 5 commit-queue 2014-03-31 11:15:58 -0700 All reviewed patches have been landed. Closing bug. 228164 2014-03-31 03:20:34 -0700 2014-03-31 11:15:54 -0700 Adding --no-timeout option patch.diff text/plain 3886 jberta.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2NTJm Mzg0Li45NGJlODAyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTQtMDMtMzEgIEpvenNlZiBCZXJ0YSAgPGpiZXJ0 YS51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgorCisgICAgICAgIHJ1bi13ZWJraXQtdGVz dHMgc2hvdWxkIGhhdmUgYSAtLW5vLXRpbWVvdXQgb3B0aW9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgyODYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL2NvbnRyb2xsZXJzL2xheW91dF90ZXN0X3J1bm5lci5weToKKyAgICAgICAgKFdvcmtlci5f cnVuX3Rlc3QpOiBSZW5hbWluZyBfcnVuX3Rlc3Rfd2l0aF90aW1lb3V0KCkKKyAgICAgICAgKFdv cmtlci5fcnVuX3Rlc3Rfd2l0aF9vcl93aXRob3V0X3RpbWVvdXQpOiBSZW5hbWluZyBfcnVuX3Rl c3Rfd2l0aF90aW1lb3V0KCksIGJlY2F1c2UgdGVzdHMgY2FuIG5vdyBydW4gd2l0aG91dCB0aW1l b3V0LgorICAgICAgICAoV29ya2VyLl9ydW5fdGVzdF9pbl9hbm90aGVyX3RocmVhZCk6IFBhc3Np bmcgdGhlIC0tbm8tdGltZW91dCBvcHRpb24gdG8gdGhlIGRyaXZlcgorICAgICAgICAoV29ya2Vy Ll9ydW5fdGVzdF9pbl90aGlzX3RocmVhZCk6CisgICAgICAgIChXb3JrZXIuX3J1bl90ZXN0X3dp dGhfdGltZW91dCk6IERlbGV0ZWQuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weToKKyAgICAgICAgKHBhcnNlX2FyZ3MpOiBBZGRlZCB0 aGUgLS1uby10aW1lb3V0IG9wdGlvbgorCiAyMDE0LTAzLTMwICBBbmR5IEVzdGVzICA8YWVzdGVz QGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggdHdvIGZhaWxpbmcgbGF5b3V0IHRlc3RzIG9uIE1v dW50YWluIExpb24gYWZ0ZXIgcjE2NjQ2Ni4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL2xheW91dF90ZXN0X3J1bm5lci5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL2xheW91dF90ZXN0 X3J1bm5lci5weQppbmRleCBkYzA5ZWFkLi4wZmRmMGQ2IDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9sYXlvdXRfdGVzdF9ydW5uZXIu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMv bGF5b3V0X3Rlc3RfcnVubmVyLnB5CkBAIC0zMDUsNyArMzA1LDcgQEAgY2xhc3MgV29ya2VyKG9i amVjdCk6CiAgICAgICAgIHN0YXJ0ID0gdGltZS50aW1lKCkKICAgICAgICAgc2VsZi5fY2FsbGVy LnBvc3QoJ3N0YXJ0ZWRfdGVzdCcsIHRlc3RfaW5wdXQsIHRlc3RfdGltZW91dF9zZWMpCiAKLSAg ICAgICAgcmVzdWx0ID0gc2VsZi5fcnVuX3Rlc3Rfd2l0aF90aW1lb3V0KHRlc3RfaW5wdXQsIHRl c3RfdGltZW91dF9zZWMsIHN0b3Bfd2hlbl9kb25lKQorICAgICAgICByZXN1bHQgPSBzZWxmLl9y dW5fdGVzdF93aXRoX29yX3dpdGhvdXRfdGltZW91dCh0ZXN0X2lucHV0LCB0ZXN0X3RpbWVvdXRf c2VjLCBzdG9wX3doZW5fZG9uZSkKICAgICAgICAgcmVzdWx0LnNoYXJkX25hbWUgPSBzaGFyZF9u YW1lCiAgICAgICAgIHJlc3VsdC53b3JrZXJfbmFtZSA9IHNlbGYuX25hbWUKICAgICAgICAgcmVz dWx0LnRvdGFsX3J1bl90aW1lID0gdGltZS50aW1lKCkgLSBzdGFydApAQCAtMzQ1LDcgKzM0NSw3 IEBAIGNsYXNzIFdvcmtlcihvYmplY3QpOgogICAgICAgICAgICAgX2xvZy5kZWJ1ZygiJXMga2ls bGluZyBkcml2ZXIiICUgc2VsZi5fbmFtZSkKICAgICAgICAgICAgIGRyaXZlci5zdG9wKCkKIAot ICAgIGRlZiBfcnVuX3Rlc3Rfd2l0aF90aW1lb3V0KHNlbGYsIHRlc3RfaW5wdXQsIHRpbWVvdXQs IHN0b3Bfd2hlbl9kb25lKToKKyAgICBkZWYgX3J1bl90ZXN0X3dpdGhfb3Jfd2l0aG91dF90aW1l b3V0KHNlbGYsIHRlc3RfaW5wdXQsIHRpbWVvdXQsIHN0b3Bfd2hlbl9kb25lKToKICAgICAgICAg aWYgc2VsZi5fb3B0aW9ucy5ydW5fc2luZ2x5OgogICAgICAgICAgICAgcmV0dXJuIHNlbGYuX3J1 bl90ZXN0X2luX2Fub3RoZXJfdGhyZWFkKHRlc3RfaW5wdXQsIHRpbWVvdXQsIHN0b3Bfd2hlbl9k b25lKQogICAgICAgICByZXR1cm4gc2VsZi5fcnVuX3Rlc3RfaW5fdGhpc190aHJlYWQodGVzdF9p bnB1dCwgc3RvcF93aGVuX2RvbmUpCkBAIC0zODQsNyArMzg0LDcgQEAgY2xhc3MgV29ya2VyKG9i amVjdCk6CiAgICAgICAgICIiIgogICAgICAgICB3b3JrZXIgPSBzZWxmCiAKLSAgICAgICAgZHJp dmVyID0gc2VsZi5fcG9ydC5jcmVhdGVfZHJpdmVyKHNlbGYuX3dvcmtlcl9udW1iZXIpCisgICAg ICAgIGRyaXZlciA9IHNlbGYuX3BvcnQuY3JlYXRlX2RyaXZlcihzZWxmLl93b3JrZXJfbnVtYmVy LCBzZWxmLl9vcHRpb25zLm5vX3RpbWVvdXQpCiAKICAgICAgICAgY2xhc3MgU2luZ2xlVGVzdFRo cmVhZCh0aHJlYWRpbmcuVGhyZWFkKToKICAgICAgICAgICAgIGRlZiBfX2luaXRfXyhzZWxmKToK QEAgLTQyOCw3ICs0MjgsNyBAQCBjbGFzcyBXb3JrZXIob2JqZWN0KToKICAgICAgICAgaWYgc2Vs Zi5fZHJpdmVyIGFuZCBzZWxmLl9kcml2ZXIuaGFzX2NyYXNoZWQoKToKICAgICAgICAgICAgIHNl bGYuX2tpbGxfZHJpdmVyKCkKICAgICAgICAgaWYgbm90IHNlbGYuX2RyaXZlcjoKLSAgICAgICAg ICAgIHNlbGYuX2RyaXZlciA9IHNlbGYuX3BvcnQuY3JlYXRlX2RyaXZlcihzZWxmLl93b3JrZXJf bnVtYmVyKQorICAgICAgICAgICAgc2VsZi5fZHJpdmVyID0gc2VsZi5fcG9ydC5jcmVhdGVfZHJp dmVyKHNlbGYuX3dvcmtlcl9udW1iZXIsIHNlbGYuX29wdGlvbnMubm9fdGltZW91dCkKICAgICAg ICAgcmV0dXJuIHNlbGYuX3J1bl9zaW5nbGVfdGVzdChzZWxmLl9kcml2ZXIsIHRlc3RfaW5wdXQs IHN0b3Bfd2hlbl9kb25lKQogCiAgICAgZGVmIF9ydW5fc2luZ2xlX3Rlc3Qoc2VsZiwgZHJpdmVy LCB0ZXN0X2lucHV0LCBzdG9wX3doZW5fZG9uZSk6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQppbmRleCA2OGRjOGUz Li5jODVkYjdkIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9ydW5fd2Via2l0X3Rlc3RzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKQEAgLTI4MSw2ICsyODEsNyBAQCBkZWYgcGFyc2Vf YXJncyhhcmdzKToKICAgICAgICAgICAgIGhlbHA9Ik91dHB1dCBwZXItdGVzdCBwcm9maWxlIGlu Zm9ybWF0aW9uLiIpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1wcm9maWxlciIs IGFjdGlvbj0ic3RvcmUiLAogICAgICAgICAgICAgaGVscD0iT3V0cHV0IHBlci10ZXN0IHByb2Zp bGUgaW5mb3JtYXRpb24sIHVzaW5nIHRoZSBzcGVjaWZpZWQgcHJvZmlsZXIuIiksCisgICAgICAg IG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLW5vLXRpbWVvdXQiLCBhY3Rpb249InN0b3JlX3RydWUi LCBkZWZhdWx0PUZhbHNlLCBoZWxwPSJEaXNhYmxlIHRlc3QgdGltZW91dHMiKSwKICAgICBdKSkK IAogICAgIG9wdGlvbl9ncm91cF9kZWZpbml0aW9ucy5hcHBlbmQoKCJNaXNjZWxsYW5lb3VzIE9w dGlvbnMiLCBbCg==