128277 2014-02-05 15:51:01 -0800 WK2: Tap highlight is positioned incorrectly in iframes 2014-02-05 17:15:53 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica oldest_to_newest 977111 0 223275 enrica 2014-02-05 15:51:01 -0800 Created attachment 223275 Test case Open the attached testcase (iframe-page.html) and tap on the link in the iframe. Note that the tap hightlight is offset. <rdar://problem/15975993> 977114 1 223277 enrica 2014-02-05 15:53:40 -0800 Created attachment 223277 Patch 977148 2 223277 benjamin 2014-02-05 17:00:07 -0800 Comment on attachment 223277 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223277&action=review Thanks! > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:328 > + currentQuad.setP1(view->contentsToRootView(IntPoint(currentQuad.p1()))); > + currentQuad.setP2(view->contentsToRootView(IntPoint(currentQuad.p2()))); > + currentQuad.setP3(view->contentsToRootView(IntPoint(currentQuad.p3()))); > + currentQuad.setP4(view->contentsToRootView(IntPoint(currentQuad.p4()))); Can you please file a bug to me to convert this to floating point? 977154 3 223277 simon.fraser 2014-02-05 17:12:08 -0800 Comment on attachment 223277 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223277&action=review >> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:328 >> + currentQuad.setP1(view->contentsToRootView(IntPoint(currentQuad.p1()))); >> + currentQuad.setP2(view->contentsToRootView(IntPoint(currentQuad.p2()))); >> + currentQuad.setP3(view->contentsToRootView(IntPoint(currentQuad.p3()))); >> + currentQuad.setP4(view->contentsToRootView(IntPoint(currentQuad.p4()))); > > Can you please file a bug to me to convert this to floating point? It sucks that we all the mapping 4 times (it can be expensive). We should have a way to convert a set of points all at the same time too. 977155 4 enrica 2014-02-05 17:15:44 -0800 (In reply to comment #3) > (From update of attachment 223277 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223277&action=review > > >> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:328 > >> + currentQuad.setP1(view->contentsToRootView(IntPoint(currentQuad.p1()))); > >> + currentQuad.setP2(view->contentsToRootView(IntPoint(currentQuad.p2()))); > >> + currentQuad.setP3(view->contentsToRootView(IntPoint(currentQuad.p3()))); > >> + currentQuad.setP4(view->contentsToRootView(IntPoint(currentQuad.p4()))); > > > > Can you please file a bug to me to convert this to floating point? > > It sucks that we all the mapping 4 times (it can be expensive). We should have a way to convert a set of points all at the same time too. The upside is that we do this conversion only for tap highlight and only if it is not the main frame. 977156 5 enrica 2014-02-05 17:15:53 -0800 Committed revision 163499. 223275 2014-02-05 15:51:01 -0800 2014-02-05 15:51:01 -0800 Test case Archive.zip application/zip 2500 enrica UEsDBBQACAAIAAiLN0QAAAAAAAAAAAAAAAAQABAAaWZyYW1lLXBhZ2UuaHRtbFVYDADEUvBSwMDh UvYBFACzUXTxdw6JDHBVyCjJzbHj4rKB0DYZqYkpdlwKQGBTXFKZkwphg0BSfkqlQjWcCwIZqZnp GSVWCkYGBgYFFdZwuVo4KzOtKDE3FYc2E1RdIFCemVKSYaVgiimTm1iUnplnpWCIzSobfahjbfQh HrABuRbkLagDiouSbZWKS5PAPEM9kGeV7Gz0IbIgdfoQDUD94HAAAFBLBwg+yoDqlQAAACABAABQ SwMECgAAAAAALJVDRAAAAAAAAAAAAAAAAAkAEABfX01BQ09TWC9VWAwAVFPwUlRT8FL2ARQAUEsD BBQACAAIAAiLN0QAAAAAAAAAAAAAAAAbABAAX19NQUNPU1gvLl9pZnJhbWUtcGFnZS5odG1sVVgM AMRS8FLAwOFS9gEUAGNgFWNnYGJg8E1MVvAPVohQgAKQGAMnEBsB8TsgBvIZFRiQAR8DDuAYEhIE YYF1nADiCDQlTFBxUwYGleT8XL3EgoKcVL3c1JLElMSSRKv4bF8Xz5LU3NDi1KKQxPRisJ6/QKzM wCAKUp+bmFyUn5tYklqsl5xYlFrCkFSQk1lcYmCwkDHCvygxLz2Vy5yDC+oIRiRLkYFwNRfIq8n5 OaW5eQq2CkZm1mCBnMy8VCDX0NCaqxYAUEsHCPpNA+W2AAAAIAEAAFBLAwQUAAgACAADizdEAAAA AAAAAAAAAAAADgAQAHN1YmZyYW1lMS5odG1sVVgMAMRS8FK1wOFS9gEUADWSu3LbQAxFa+krENcO qbQKwyZ2l5mkSIqU0C5EYrwv7wKWNJn8e7CiU3Ef2HsvDjh9ePr+9efvH8+wSgzzfj9t32kl9PN+ NzW5BbLFKfsb/Nnvdid0L0vNmvxHl0OuR1gq3j7bzUq8rHKET4fDoVzt5K+9H98FpnFTnLrQvP+W K0Xg0jSC7zLQWAAjySNMCGul85eHVaQcx/FyuQxYSqDB5fgwu5waOSHRCui5cGPHaZlGnIECm0Aj b6JArC1mD0KxmAEnx569JgEVCHiyCECy2RNEXBICBn5VHOCXACWOZgCR++LNthgf4VW5QcpNqnqg K1XHgsI5gYaA0eVNuRdZsO50l+RixUAI1oJlynDvwqxkgKcuiSoEXNWSbDw4QaVSaaXkqRocO3jL QYvZkcWxToFaI3Acwn+K1pDCWRdGgdQDQcFqG60DPF8dFSHtqI1Bdg7JWZ3Twh6lv7AuSs3sKXWK nZSZOg0Fe9+Qz2dDjeCpUe23MYceAzsgNhztnavGwQa+TdoGf/+j/gFQSwcIt/ITyo0BAABqAgAA UEsDBBQACAAIAAOLN0QAAAAAAAAAAAAAAAAZABAAX19NQUNPU1gvLl9zdWJmcmFtZTEuaHRtbFVY DADEUvBStcDhUvYBFABjYBVjZ2BiYPBNTFbwD1aIUIACkBgDJxAbAXEHEIP4uxiIAo4hIUFQJkjH DCBWQlPCiBAXTc7P1ctNTC7Kz00sSS3WS04sSi1hqOYCuSI5P6c0N0/BVsHQzBoskJOZlwrkmltz 1QIAUEsHCFquhBZnAAAAugAAAFBLAwQUAAgACAC6XpNDAAAAAAAAAAAAAAAADgAQAHN1YmZyYW1l Mi5odG1sVVgMAJ3A4VLPTrNS9gEUAGVSTW8TMRA9J7/i0RNITVquYemF9oYEBzjAbdaeZEf1x9Ye p6kQ/51xNkhFrNby2B6/ee95hjf3Xz59+/H1AZPGcLdeD8s8TEz+br0aqr4EtmA1Zv+CXxasJpbD pDu8v7VvPn3oeyO5x0PJLfmNyyGXHaqEI5d++NuG/dsxn84AwCuE5T7wLF6nf3b+hxxD49eALsc5 V1H2F9zNM4+PohstlOo+l7jDOQyk/PPt7bvL5eHmomq4WWQOXZyJ/JwLR8hcW4TvNU2FgiLrNVxO lZ2ytgLyMksVJ+kADmKn1Tj4DJZWY/ZQNmYFkpx48S0pmiLQaPhgXbAZkQ6JQEGeGm3xXcFJooEj Sg+OtqR4jacmFSlXLc2DT1ycKKnkhBYCRZcX5J5kpHqlM6TMlgwmYx6NU14UWCnd4r5DUlOGlGZM FrGSUHguPHHyXEy5bRxzaLOVY6NjSsG1MpyE8NciE9SwbwchReqEMFOxRStbPJwcz8qt+2geZOeI neW5Nosn7TdMxVyyeE7dxe6UFXUtzNR1I+/3ZjPBc+XST2MOnQZ1g8TsqBdfW9yurSkGL0e4QLV+ vHrVHtZ6V/a+AKj6fR+9Cyy398Dy+NYL587/A1BLBwjuZLhXzgEAABIDAABQSwMEFAAIAAgAul6T QwAAAAAAAAAAAAAAABkAEABfX01BQ09TWC8uX3N1YmZyYW1lMi5odG1sVVgMAJ3A4VLPTrNS9gEU AGNgFWNnYGJg8E1MVvAPVohQgAKQGAMnEBsBcQcQg/i7GIgCjiEhQVAmSMcMIFZCU8KIEBdNzs/V y01MLsrPTSxJLdZLTixKLWGo5gK5Ijk/pzQ3T8FWwdAazM/JzEsF8UysuWoBUEsHCK0iSQtlAAAA ugAAAFBLAQIVAxQACAAIAAiLN0Q+yoDqlQAAACABAAAQAAwAAAAAAAAAAECkgQAAAABpZnJhbWUt cGFnZS5odG1sVVgIAMRS8FLAwOFSUEsBAhUDCgAAAAAALJVDRAAAAAAAAAAAAAAAAAkADAAAAAAA AAAAQP1B4wAAAF9fTUFDT1NYL1VYCABUU/BSVFPwUlBLAQIVAxQACAAIAAiLN0T6TQPltgAAACAB AAAbAAwAAAAAAAAAAECkgRoBAABfX01BQ09TWC8uX2lmcmFtZS1wYWdlLmh0bWxVWAgAxFLwUsDA 4VJQSwECFQMUAAgACAADizdEt/ITyo0BAABqAgAADgAMAAAAAAAAAABApIEpAgAAc3ViZnJhbWUx Lmh0bWxVWAgAxFLwUrXA4VJQSwECFQMUAAgACAADizdEWq6EFmcAAAC6AAAAGQAMAAAAAAAAAABA pIECBAAAX19NQUNPU1gvLl9zdWJmcmFtZTEuaHRtbFVYCADEUvBStcDhUlBLAQIVAxQACAAIALpe k0PuZLhXzgEAABIDAAAOAAwAAAAAAAAAAECkgcAEAABzdWJmcmFtZTIuaHRtbFVYCACdwOFSz06z UlBLAQIVAxQACAAIALpek0OtIkkLZQAAALoAAAAZAAwAAAAAAAAAAECkgdoGAABfX01BQ09TWC8u X3N1YmZyYW1lMi5odG1sVVgIAJ3A4VLPTrNSUEsFBgAAAAAHAAcAGAIAAJYHAAAAAA== 223277 2014-02-05 15:53:40 -0800 2014-02-05 17:12:08 -0800 Patch iframehighlight.txt text/plain 1947 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzQ4MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAyLTA1ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgV0syOiBUYXAgaGlnaGxpZ2h0 IGlzIHBvc2l0aW9uZWQgaW5jb3JyZWN0bHkgaW4gaWZyYW1lcy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODI3NworICAgICAgICA8cmRhcjovL3By b2JsZW0vMTU5NzU5OTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2UgbmVlZCB0byBjb252ZXJ0IHRoZSBxdWFkIHRvIHJvb3QgdmlldyBjb29yZGlu YXRlcworICAgICAgICBiZWZvcmUgcmV0dXJuaW5nIGl0IHRvIHRoZSBVSVByb2Nlc3MgZm9yIGRy YXdpbmcgdGhlIGhpZ2hsaWdodC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3Mv V2ViUGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6dGFwSGlnaGxpZ2h0QXRQ b3NpdGlvbik6CisKIDIwMTQtMDItMDUgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxl LmNvbT4KIAogICAgICAgICBHZXQgcmlkIG9mIFdlYlVJQ2xpZW50CkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCShyZXZp c2lvbiAxNjM0NzgpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dl YlBhZ2VJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTMxOCw2ICszMTgsMTYgQEAgdm9pZCBXZWJQ YWdlOjp0YXBIaWdobGlnaHRBdFBvc2l0aW9uKHVpbgogICAgIGlmIChyZW5kZXJlcikgewogICAg ICAgICByZW5kZXJlci0+YWJzb2x1dGVRdWFkcyhxdWFkcyk7CiAgICAgICAgIENvbG9yIGhpZ2hs aWdodENvbG9yID0gbm9kZS0+Y29tcHV0ZWRTdHlsZSgpLT50YXBIaWdobGlnaHRDb2xvcigpOwor ICAgICAgICBpZiAoIW5vZGUtPmRvY3VtZW50KCkuZnJhbWUoKS0+aXNNYWluRnJhbWUoKSkgewor ICAgICAgICAgICAgRnJhbWVWaWV3KiB2aWV3ID0gbm9kZS0+ZG9jdW1lbnQoKS5mcmFtZSgpLT52 aWV3KCk7CisgICAgICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHF1YWRzLnNpemUoKTsg KytpKSB7CisgICAgICAgICAgICAgICAgRmxvYXRRdWFkJiBjdXJyZW50UXVhZCA9IHF1YWRzW2ld OworICAgICAgICAgICAgICAgIGN1cnJlbnRRdWFkLnNldFAxKHZpZXctPmNvbnRlbnRzVG9Sb290 VmlldyhJbnRQb2ludChjdXJyZW50UXVhZC5wMSgpKSkpOworICAgICAgICAgICAgICAgIGN1cnJl bnRRdWFkLnNldFAyKHZpZXctPmNvbnRlbnRzVG9Sb290VmlldyhJbnRQb2ludChjdXJyZW50UXVh ZC5wMigpKSkpOworICAgICAgICAgICAgICAgIGN1cnJlbnRRdWFkLnNldFAzKHZpZXctPmNvbnRl bnRzVG9Sb290VmlldyhJbnRQb2ludChjdXJyZW50UXVhZC5wMygpKSkpOworICAgICAgICAgICAg ICAgIGN1cnJlbnRRdWFkLnNldFA0KHZpZXctPmNvbnRlbnRzVG9Sb290VmlldyhJbnRQb2ludChj dXJyZW50UXVhZC5wNCgpKSkpOworICAgICAgICAgICAgfQorICAgICAgICB9CiAKICAgICAgICAg Um91bmRlZFJlY3Q6OlJhZGlpIGJvcmRlclJhZGlpOwogICAgICAgICBpZiAocmVuZGVyZXItPmlz Qm94KCkpIHsK