<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>12826</bug_id>
          
          <creation_ts>2007-02-19 22:00:09 -0800</creation_ts>
          <short_desc>Allow overwriting Product, ProductSub, Vendor and VendorSub js properties</short_desc>
          <delta_ts>2007-02-20 13:27:27 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>420+</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Krzysztof Kowalczyk">kkowalczyk</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>public</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>22753</commentid>
    <comment_count>0</comment_count>
    <who name="Krzysztof Kowalczyk">kkowalczyk</who>
    <bug_when>2007-02-19 22:00:09 -0800</bug_when>
    <thetext>Allow over-writting Product, ProductSub, Vendor and VendorSub js properties via #define WEBCORE_NAVIGATOR_*</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22754</commentid>
    <comment_count>1</comment_count>
      <attachid>13266</attachid>
    <who name="Krzysztof Kowalczyk">kkowalczyk</who>
    <bug_when>2007-02-19 22:01:03 -0800</bug_when>
    <thetext>Created attachment 13266
Allow overwriting Product, ProductSub, Vendor and VendorSub js properties</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22772</commentid>
    <comment_count>2</comment_count>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2007-02-20 00:54:36 -0800</bug_when>
    <thetext>Product and ProductSub are defined as they are for compatibility reasons. I am not sure it is wise to change them. It might make sense to make Vendor and VendorSub configurable, but perhaps doing this at runtime as for the user agent string would make more sense.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22505</commentid>
    <comment_count>3</comment_count>
      <attachid>13266</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2007-02-20 11:22:48 -0800</bug_when>
    <thetext>Comment on attachment 13266
Allow overwriting Product, ProductSub, Vendor and VendorSub js properties

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22485</commentid>
    <comment_count>4</comment_count>
    <who name="Krzysztof Kowalczyk">kkowalczyk</who>
    <bug_when>2007-02-20 13:27:27 -0800</bug_when>
    <thetext>Landed in r19740</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>13266</attachid>
            <date>2007-02-19 22:01:03 -0800</date>
            <delta_ts>2007-02-20 11:22:48 -0800</delta_ts>
            <desc>Allow overwriting Product, ProductSub, Vendor and VendorSub js properties</desc>
            <filename>wc.patch</filename>
            <type>text/plain</type>
            <size>2084</size>
            <attacher name="Krzysztof Kowalczyk">kkowalczyk</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiAxOTcyNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTMgQEAKKzIwMDctMDItMTkgIEtyenlzenRvZiBLb3dhbGN6eWsgIDxra293YWxj
enlrQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBBbGxvdyBvdmVyLXdyaXR0aW5nIFByb2R1Y3QsIFByb2R1Y3RTdWIsIFZlbmRvciBh
bmQgVmVuZG9yU3ViCisgICAgICAgIGpzIHByb3BlcnRpZXMgdmlhICNkZWZpbmUgV0VCQ09SRV9O
QVZJR0FUT1JfKgorCisgICAgICAgICogYmluZGluZ3MvanMva2pzX25hdmlnYXRvci5jcHA6Cisg
ICAgICAgIChLSlM6Ok5hdmlnYXRvcjo6Z2V0VmFsdWVQcm9wZXJ0eSk6CisKIDIwMDctMDItMTkg
IEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi
eSBBZGFtIFJvYmVuLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy9qcy9ranNfbmF2aWdhdG9yLmNw
cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL2pzL2tqc19uYXZpZ2F0b3IuY3BwCShy
ZXZpc2lvbiAxOTcxOSkKKysrIFdlYkNvcmUvYmluZGluZ3MvanMva2pzX25hdmlnYXRvci5jcHAJ
KHdvcmtpbmcgY29weSkKQEAgLTQ0LDYgKzQ0LDIyIEBACiAjZW5kaWYKICNlbmRpZiAvLyBpZm5k
ZWYgV0VCQ09SRV9OQVZJR0FUT1JfUExBVEZPUk0KIAorI2lmbmRlZiBXRUJDT1JFX05BVklHQVRP
Ul9QUk9EVUNUCisjZGVmaW5lIFdFQkNPUkVfTkFWSUdBVE9SX1BST0RVQ1QgIkdlY2tvIgorI2Vu
ZGlmIC8vIGlmbmRlZiBXRUJDT1JFX05BVklHQVRPUl9QUk9EVUNUCisKKyNpZm5kZWYgV0VCQ09S
RV9OQVZJR0FUT1JfUFJPRFVDVF9TVUIKKyNkZWZpbmUgV0VCQ09SRV9OQVZJR0FUT1JfUFJPRFVD
VF9TVUIgIjIwMDMwMTA3IgorI2VuZGlmIC8vIGlmbmRlZiBXRUJDT1JFX05BVklHQVRPUl9QUk9E
VUNUX1NVQgorCisjaWZuZGVmIFdFQkNPUkVfTkFWSUdBVE9SX1ZFTkRPUgorI2RlZmluZSBXRUJD
T1JFX05BVklHQVRPUl9WRU5ET1IgIkFwcGxlIENvbXB1dGVyLCBJbmMuIgorI2VuZGlmIC8vIGlm
bmRlZiBXRUJDT1JFX05BVklHQVRPUl9WRU5ET1IKKworI2lmbmRlZiBXRUJDT1JFX05BVklHQVRP
Ul9WRU5ET1JfU1VCCisjZGVmaW5lIFdFQkNPUkVfTkFWSUdBVE9SX1ZFTkRPUl9TVUIgIiIKKyNl
bmRpZiAvLyBpZm5kZWYgV0VCQ09SRV9OQVZJR0FUT1JfVkVORE9SX1NVQgorCiB1c2luZyBuYW1l
c3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIEtKUyB7CkBAIC0xNzgsMTMgKzE5NCwxMyBAQCBK
U1ZhbHVlKiBOYXZpZ2F0b3I6OmdldFZhbHVlUHJvcGVydHkoRXhlCiAgICAgcmV0dXJuIGpzU3Ry
aW5nKHVzZXJBZ2VudC5zdWJzdHJpbmcodXNlckFnZW50LmZpbmQoJy8nKSArIDEpKTsKICAgfQog
ICBjYXNlIFByb2R1Y3Q6Ci0gICAgcmV0dXJuIGpzU3RyaW5nKCJHZWNrbyIpOworICAgIHJldHVy
biBqc1N0cmluZyhXRUJDT1JFX05BVklHQVRPUl9QUk9EVUNUKTsKICAgY2FzZSBQcm9kdWN0U3Vi
OgotICAgIHJldHVybiBqc1N0cmluZygiMjAwMzAxMDciKTsKKyAgICByZXR1cm4ganNTdHJpbmco
V0VCQ09SRV9OQVZJR0FUT1JfUFJPRFVDVF9TVUIpOwogICBjYXNlIFZlbmRvcjoKLSAgICByZXR1
cm4ganNTdHJpbmcoIkFwcGxlIENvbXB1dGVyLCBJbmMuIik7CisgICAgcmV0dXJuIGpzU3RyaW5n
KFdFQkNPUkVfTkFWSUdBVE9SX1ZFTkRPUik7CiAgIGNhc2UgVmVuZG9yU3ViOgotICAgIHJldHVy
biBqc1N0cmluZygiIik7CisgICAgcmV0dXJuIGpzU3RyaW5nKFdFQkNPUkVfTkFWSUdBVE9SX1ZF
TkRPUl9TVUIpOwogICBjYXNlIExhbmd1YWdlOgogICAgIHJldHVybiBqc1N0cmluZyhkZWZhdWx0
TGFuZ3VhZ2UoKSk7CiAgIGNhc2UgVXNlckFnZW50Ogo=
</data>
<flag name="review"
          id="5184"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>