128250 2014-02-05 08:44:46 -0800 HashMap can't be used with std::unique_ptr as value when it has a custom deleter 2014-02-05 11:09:10 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98931 1 cgarcia webkit-unassigned andersca benjamin carlosg cmarcelo commit-queue darin oldest_to_newest 976750 0 cgarcia 2014-02-05 08:44:46 -0800 /usr/include/c++/4.8/bits/unique_ptr.h: In instantiation of 'typename std::enable_if<std::__and_<std::is_convertible<typename std::unique_ptr<_Up, _Ep>::pointer, typename std::unique_ptr<_Tp, _Dp>::_Pointer::type>, std::__not_<std::is_array<_Up> > >::value, std::unique_ptr<_Tp, _Dp>&>::type std::unique_ptr<_Tp, _Dp>::operator=(std::unique_ptr<_Up, _Ep>&&) [with _Up = _GdkEvent; _Ep = WTF::GPtrDeleter<_GdkEvent>; _Tp = _GdkEvent; _Dp = std::default_delete<_GdkEvent>; typename std::enable_if<std::__and_<std::is_convertible<typename std::unique_ptr<_Up, _Ep>::pointer, typename std::unique_ptr<_Tp, _Dp>::_Pointer::type>, std::__not_<std::is_array<_Up> > >::value, std::unique_ptr<_Tp, _Dp>&>::type = std::unique_ptr<_GdkEvent, std::default_delete<_GdkEvent> >&]': ../../Source/WTF/wtf/HashMap.h:162:24: required from 'static void WTF::HashMapTranslator<ValueTraits, HashFunctions>::translate(T&, U&&, V&&) [with T = WTF::KeyValuePair<unsigned int, std::unique_ptr<_GdkEvent, std::default_delete<_GdkEvent> > >; U = const unsigned int&; V = std::unique_ptr<_GdkEvent, WTF::GPtrDeleter<_GdkEvent> >; ValueTraits = WTF::HashMap<unsigned int, std::unique_ptr<_GdkEvent, WTF::GPtrDeleter<_GdkEvent> > >::KeyValuePairTraits; HashFunctions = WTF::IntHash<unsigned int>]' ../../Source/WTF/wtf/HashTable.h:858:91: required from 'WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::AddResult WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::add(T&&, Extra&&) [with HashTranslator = WTF::HashMapTranslator<WTF::HashMap<unsigned int, std::unique_ptr<_GdkEvent, WTF::GPtrDeleter<_GdkEvent> > >::KeyValuePairTraits, WTF::IntHash<unsigned int> >; T = const unsigned int&; Extra = std::unique_ptr<_GdkEvent, WTF::GPtrDeleter<_GdkEvent> >; Key = unsigned int; Value = WTF::KeyValuePair<unsigned int, std::unique_ptr<_GdkEvent, std::default_delete<_GdkEvent> > >; Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned int, std::unique_ptr<_GdkEvent, std::default_delete<_GdkEvent> > > >; HashFunctions = WTF::IntHash<unsigned int>; Traits = WTF::HashMap<unsigned int, std::unique_ptr<_GdkEvent, WTF::GPtrDeleter<_GdkEvent> > >::KeyValuePairTraits; KeyTraits = WTF::HashTraits<unsigned int>; WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::AddResult = WTF::HashTableAddResult<WTF::HashTableIterator<unsigned int, WTF::KeyValuePair<unsigned int, std::unique_ptr<_GdkEvent, std::default_delete<_GdkEvent> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned int, std::unique_ptr<_GdkEvent, std::default_delete<_GdkEvent> > > >, WTF::IntHash<unsigned int>, WTF::HashMap<unsigned int, std::unique_ptr<_GdkEvent, WTF::GPtrDeleter<_GdkEvent> > >::KeyValuePairTraits, WTF::HashTraits<unsigned int> > >]' ../../Source/WTF/wtf/HashMap.h:282:130: required from 'WTF::HashMap<KeyArg, MappedArg, HashArg, KeyTraitsArg, MappedTraitsArg>::AddResult WTF::HashMap<KeyArg, MappedArg, HashArg, KeyTraitsArg, MappedTraitsArg>::inlineAdd(K&&, V&&) [with K = const unsigned int&; V = std::unique_ptr<_GdkEvent, WTF::GPtrDeleter<_GdkEvent> >; KeyArg = unsigned int; MappedArg = std::unique_ptr<_GdkEvent, WTF::GPtrDeleter<_GdkEvent> >; HashArg = WTF::IntHash<unsigned int>; KeyTraitsArg = WTF::HashTraits<unsigned int>; MappedTraitsArg = WTF::HashTraits<std::unique_ptr<_GdkEvent, WTF::GPtrDeleter<_GdkEvent> > >; WTF::HashMap<KeyArg, MappedArg, HashArg, KeyTraitsArg, MappedTraitsArg>::AddResult = WTF::HashTableAddResult<WTF::HashTableIterator<unsigned int, WTF::KeyValuePair<unsigned int, std::unique_ptr<_GdkEvent, std::default_delete<_GdkEvent> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned int, std::unique_ptr<_GdkEvent, std::default_delete<_GdkEvent> > > >, WTF::IntHash<unsigned int>, WTF::HashMap<unsigned int, std::unique_ptr<_GdkEvent, WTF::GPtrDeleter<_GdkEvent> > >::KeyValuePairTraits, WTF::HashTraits<unsigned int> > >]' ../../Source/WTF/wtf/HashMap.h:310:50: required from 'WTF::HashMap<KeyArg, MappedArg, HashArg, KeyTraitsArg, MappedTraitsArg>::AddResult WTF::HashMap<KeyArg, MappedArg, HashArg, KeyTraitsArg, MappedTraitsArg>::add(const KeyType&, T&&) [with V = std::unique_ptr<_GdkEvent, WTF::GPtrDeleter<_GdkEvent> >; KeyArg = unsigned int; MappedArg = std::unique_ptr<_GdkEvent, WTF::GPtrDeleter<_GdkEvent> >; HashArg = WTF::IntHash<unsigned int>; KeyTraitsArg = WTF::HashTraits<unsigned int>; MappedTraitsArg = WTF::HashTraits<std::unique_ptr<_GdkEvent, WTF::GPtrDeleter<_GdkEvent> > >; WTF::HashMap<KeyArg, MappedArg, HashArg, KeyTraitsArg, MappedTraitsArg>::AddResult = WTF::HashTableAddResult<WTF::HashTableIterator<unsigned int, WTF::KeyValuePair<unsigned int, std::unique_ptr<_GdkEvent, std::default_delete<_GdkEvent> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned int, std::unique_ptr<_GdkEvent, std::default_delete<_GdkEvent> > > >, WTF::IntHash<unsigned int>, WTF::HashMap<unsigned int, std::unique_ptr<_GdkEvent, WTF::GPtrDeleter<_GdkEvent> > >::KeyValuePairTraits, WTF::HashTraits<unsigned int> > >; WTF::HashMap<KeyArg, MappedArg, HashArg, KeyTraitsArg, MappedTraitsArg>::KeyType = unsigned int]' ../../Source/WebCore/platform/gtk/GtkTouchContextHelper.cpp:42:53: required from here /usr/include/c++/4.8/bits/unique_ptr.h:206:18: error: no match for 'operator=' (operand types are 'std::unique_ptr<_GdkEvent, std::default_delete<_GdkEvent> >::deleter_type {aka std::default_delete<_GdkEvent>}' and 'WTF::GPtrDeleter<_GdkEvent>') get_deleter() = std::forward<_Ep>(__u.get_deleter()); ^ /usr/include/c++/4.8/bits/unique_ptr.h:206:18: note: candidates are: /usr/include/c++/4.8/bits/unique_ptr.h:54:12: note: std::default_delete<_GdkEvent>& std::default_delete<_GdkEvent>::operator=(const std::default_delete<_GdkEvent>&) struct default_delete ^ /usr/include/c++/4.8/bits/unique_ptr.h:54:12: note: no known conversion for argument 1 from 'WTF::GPtrDeleter<_GdkEvent>' to 'const std::default_delete<_GdkEvent>&' /usr/include/c++/4.8/bits/unique_ptr.h:54:12: note: std::default_delete<_GdkEvent>& std::default_delete<_GdkEvent>::operator=(std::default_delete<_GdkEvent>&&) /usr/include/c++/4.8/bits/unique_ptr.h:54:12: note: no known conversion for argument 1 from 'WTF::GPtrDeleter<_GdkEvent>' to 'std::default_delete<_GdkEvent>&&' The problem is that the HashMap is using a unique_ptr with the default deleter, so that when trying to move the unique_ptr the deleters don't match. 976753 1 223242 cgarcia 2014-02-05 08:47:20 -0800 Created attachment 223242 Patch 976932 2 223242 commit-queue 2014-02-05 11:09:06 -0800 Comment on attachment 223242 Patch Clearing flags on attachment: 223242 Committed r163460: <http://trac.webkit.org/changeset/163460> 976933 3 commit-queue 2014-02-05 11:09:10 -0800 All reviewed patches have been landed. Closing bug. 223242 2014-02-05 08:47:20 -0800 2014-02-05 11:09:06 -0800 Patch wtf-hash-traits-unique-ptr.diff text/plain 1586 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZDU2NjEwOS4uMWU4MGExNyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNC0wMi0wNSAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgSGFz aE1hcCBjYW4ndCBiZSB1c2VkIHdpdGggc3RkOjp1bmlxdWVfcHRyIGFzIHZhbHVlIHdoZW4gaXQg aGFzIGEgY3VzdG9tIGRlbGV0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyODI1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoZSBwcm9ibGVtIGlzIHRoYXQgdGhlIEhhc2hNYXAgaXMgdXNpbmcgYSB1 bmlxdWVfcHRyIHdpdGggdGhlCisgICAgICAgIGRlZmF1bHQgZGVsZXRlciwgc28gdGhhdCB3aGVu IHRyeWluZyB0byBtb3ZlIHRoZSB1bmlxdWVfcHRyIHRoZQorICAgICAgICBkZWxldGVycyBkb24n dCBtYXRjaC4KKworICAgICAgICAqIHd0Zi9IYXNoVHJhaXRzLmg6IEFkZCB0aGUgZGVsZXRlciBh bHNvIGluIHRoZSB0ZW1wbGF0ZQorICAgICAgICBkZWZpbml0YXRpb24gb2YgdGhlIHBhcmVudCBj bGFzcyBmb3IgdGhlIEhhc2hUcmFpdHM8c3RkOjp1bmlxdWVfcHRyPFQsIERlbGV0ZXI+PgorCiAy MDE0LTAxLTI5ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAg ICAgUmVtb3ZlIEVOQUJMRShKQVZBU0NSSVBUX0RFQlVHR0VSKSBndWFyZHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XVEYvd3RmL0hhc2hUcmFpdHMuaCBiL1NvdXJjZS9XVEYvd3RmL0hhc2hUcmFpdHMu aAppbmRleCA0OWM0Yzc3Li5mMTQ4MTAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9IYXNo VHJhaXRzLmgKKysrIGIvU291cmNlL1dURi93dGYvSGFzaFRyYWl0cy5oCkBAIC0xMDEsNyArMTAx LDcgQEAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gc3RydWN0IFNpbXBsZUNsYXNzSGFzaFRyYWl0cyA6 IEdlbmVyaWNIYXNoVHJhaXRzPFQ+IHsKICAgICBzdGF0aWMgYm9vbCBpc0RlbGV0ZWRWYWx1ZShj b25zdCBUJiB2YWx1ZSkgeyByZXR1cm4gdmFsdWUuaXNIYXNoVGFibGVEZWxldGVkVmFsdWUoKTsg fQogfTsKIAotdGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlwZW5hbWUgRGVsZXRlcj4gc3RydWN0IEhh c2hUcmFpdHM8c3RkOjp1bmlxdWVfcHRyPFQsIERlbGV0ZXI+PiA6IFNpbXBsZUNsYXNzSGFzaFRy YWl0czxzdGQ6OnVuaXF1ZV9wdHI8VD4+IHsKK3RlbXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1l IERlbGV0ZXI+IHN0cnVjdCBIYXNoVHJhaXRzPHN0ZDo6dW5pcXVlX3B0cjxULCBEZWxldGVyPj4g OiBTaW1wbGVDbGFzc0hhc2hUcmFpdHM8c3RkOjp1bmlxdWVfcHRyPFQsIERlbGV0ZXI+PiB7CiAg ICAgdHlwZWRlZiBzdGQ6Om51bGxwdHJfdCBFbXB0eVZhbHVlVHlwZTsKICAgICBzdGF0aWMgRW1w dHlWYWx1ZVR5cGUgZW1wdHlWYWx1ZSgpIHsgcmV0dXJuIG51bGxwdHI7IH0KIAo=