128249 2014-02-05 07:48:43 -0800 Add support for MallocScribble to FastMalloc 2022-02-28 03:46:29 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX https://bugs.webkit.org/show_bug.cgi?id=164431 InRadar P2 Normal --- 1 ddkilzer ddkilzer benjamin cmarcelo commit-queue dbates ggaren jeffrey+webkit oliver webkit-bug-importer oldest_to_newest 976734 0 ddkilzer 2014-02-05 07:48:43 -0800 We should add support for MallocScribble to FastMalloc. 976735 1 ddkilzer 2014-02-05 07:49:00 -0800 <rdar://problem/15946481> 977014 2 223252 ddkilzer 2014-02-05 11:37:30 -0800 Created attachment 223252 Patch v1 977015 3 commit-queue 2014-02-05 11:40:05 -0800 Attachment 223252 did not pass style-queue: ERROR: Source/WTF/wtf/FastMalloc.cpp:460: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/FastMalloc.cpp:1273: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 977017 4 223252 oliver 2014-02-05 11:48:29 -0800 Comment on attachment 223252 Patch v1 It would be better to just modify POISON_DEALLOCATION as that will get all deallocations, and already has the correct allocation size 1248259 5 ddkilzer 2016-11-04 13:58:34 -0700 FastMalloc was replaced by bmalloc. 223252 2014-02-05 11:37:30 -0800 2022-02-28 03:46:29 -0800 Patch v1 bug-128249-20140205113729.patch text/plain 5946 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMzgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDA1YzQyYzAwMjIxOTI1MGI1YzMzNGFl MzM5ODY0MTU3Y2E4MDk5NzguLjRkNjU3MWViYWQyMjViMDkwZGE3YTU4OTk4NTNmMDNhOGRmOTE3 ZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTQtMDItMDUgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgc3VwcG9ydCBmb3IgTWFsbG9jU2NyaWJibGUg dG8gRmFzdE1hbGxvYworICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMjgyNDk+CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8xNTk0NjQ4MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9GYXN0TWFsbG9jLmNwcDoKKyAgICAgICAgKElu aXRNYWxsb2NTY3JpYmJsZSk6IEFkZC4gIEluaXRpYWxpemVzIGdsb2JhbAorICAgICAgICBXVEY6 OnNfaXNNYWxsb2NTY3JpYmJsZUVuYWJsZWQgdG8gdHJ1ZSBpZiBNYWxsb2NTY3JpYmJsZQorICAg ICAgICBlbnZpcm9ubWVudCB2YXJpYWJsZSBpcyBzZXQgKG1hdGNoZXMgbGlibWFsbG9jIGJlaGF2 aW9yKS4KKyAgICAgICAgKFdURjo6RGVsZXRlU3Bhbik6IFNjcmliYmxlIDB4NTUgb24gZnJlZWQg c3BhbnMuCisgICAgICAgIChXVEY6OlRDTWFsbG9jX1RocmVhZENhY2hlOjpJbml0TW9kdWxlKTog Q2FsbAorICAgICAgICBJbml0TWFsbG9jU2NyaWJibGUoKS4KKyAgICAgICAgKGZyZWUpOiBTY3Jp YmJsZSAweDU1IG9uIGZyZWVkIGFsbG9jYXRpb25zIGlmIE1hbGxvY1NjcmliYmxlIGlzCisgICAg ICAgIGVuYWJsZWQuCisgICAgICAgICogd3RmL0Zhc3RNYWxsb2MuaDoKKyAgICAgICAgKFdURjo6 c19pc01hbGxvY1NjcmliYmxlRW5hYmxlZCk6IEV4cG9ydCBnbG9iYWwuCisgICAgICAgIChXVEY6 OmlzTWFsbG9jU2NyaWJibGVFbmFibGVkKTogQWRkLiAgSW5saW5lIG1ldGhvZCBmb3IKKyAgICAg ICAgY2hlY2tpbmcgV1RGOjpzX2lzTWFsbG9jU2NyaWJibGVFbmFibGVkLgorCiAyMDE0LTAyLTAz ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IFdp bmRvd3MgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmU3MTVhZjc1MzY3NzRiZTUwNjM1ODBkMzBhZDk1 YjMwYWI3YWFkZC4uYmQ4NjZjMTdkNTZiZWE5YzBhNTZmNjhmZDI4MzZlODE2NTE5MWI5YSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTAyLTA1ICBEYXZpZCBLaWx6ZXIgIDxkZGtp bHplckBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIE1hbGxvY1NjcmliYmxl IHRvIEZhc3RNYWxsb2MKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTI4MjQ5PgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMTU5NDY0ODE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9QT0RGcmVlTGlzdEFyZW5hLmg6Cisg ICAgICAgIChXZWJDb3JlOjpQT0RGcmVlTGlzdEFyZW5hOjpyb3VuZGVkU2l6ZSk6IEFkZC4gIEV4 dHJhY3QgZnJvbQorICAgICAgICBQT0RGcmVlTGlzdEFyZW5hOjphbGxvY2F0ZU9iamVjdCgpLgor ICAgICAgICAoV2ViQ29yZTo6UE9ERnJlZUxpc3RBcmVuYTo6YWxsb2NhdGVPYmplY3QpOiBVc2Ug cm91bmRlZFNpemUoKQorICAgICAgICBtZXRob2QuCisgICAgICAgIChXZWJDb3JlOjpQT0RGcmVl TGlzdEFyZW5hOjpmcmVlT2JqZWN0KTogU2NyaWJibGUgMHg1NSBvbgorICAgICAgICBkZWFsbG9j YXRlZCBvYmplY3RzIGlmIE1hbGxvY1NjcmliYmxlIGlzIGVuYWJsZWQuICBVc2UKKyAgICAgICAg cm91bmRlZFNpemUoKSB0byBkZXRlcm1pbmUgdGhlIHNpemUgb2YgZWFjaCBvYmplY3QuCisKIDIw MTQtMDItMDQgIFJhZHUgU3RhdmlsYSAgPHN0YXZpbGFAYWRvYmUuY29tPgogCiAgICAgICAgIFJF R1JFU1NJT04gKHIxNTk2MDkpOiBJbWFnZXMgYXJlIGNvcnJ1cHRlZCB3aGVuIGhvdmVyaW5nIG92 ZXIgYnV0dG9ucyBAIGdpdGh1Yi5jb20KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Zhc3RN YWxsb2MuY3BwIGIvU291cmNlL1dURi93dGYvRmFzdE1hbGxvYy5jcHAKaW5kZXggZGNmMDkzN2I2 MmYwYWI3MzhkYjBmYjk0MDMwZWY2MGM2NWJmMDBjMC4uYTNmZWUwZjMwMDNmNjdkMTI2NTM4YjZl OTRlZTg5MTc4NWRhYTdkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvRmFzdE1hbGxvYy5j cHAKKysrIGIvU291cmNlL1dURi93dGYvRmFzdE1hbGxvYy5jcHAKQEAgLTQ1MSw2ICs0NTEsMTcg QEAgZXh0ZXJuICJDIiBXVEZfRVhQT1JUX1BSSVZBVEUgY29uc3QgaW50IGpzY29yZV9mYXN0bWFs bG9jX2ludHJvc3BlY3Rpb24gPSAwOwogCiAjaWZkZWYgV1RGX0NIQU5HRVMKIAorI2luY2x1ZGUg PG11dGV4PgorCitib29sIFdURjo6c19pc01hbGxvY1NjcmliYmxlRW5hYmxlZDsKK3N0YXRpYyB2 b2lkIEluaXRNYWxsb2NTY3JpYmJsZSgpCit7CisgICAgc3RhdGljIHN0ZDo6b25jZV9mbGFnIG9u Y2VNYWxsb2NTY3JpYmJsZUVuYWJsZWRGbGFnOworICAgIHN0ZDo6Y2FsbF9vbmNlKG9uY2VNYWxs b2NTY3JpYmJsZUVuYWJsZWRGbGFnLCBbXXsKKyAgICAgICAgV1RGOjpzX2lzTWFsbG9jU2NyaWJi bGVFbmFibGVkID0gZ2V0ZW52KCJNYWxsb2NTY3JpYmJsZSIpOworICAgIH0pOworfQorCiAjaWYg T1MoREFSV0lOKQogI2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+CiAjaW5jbHVkZSA8d3RmL1ZlY3Rv ci5oPgpAQCAtMTI1OCw2ICsxMjY5LDkgQEAgc3RhdGljIGlubGluZSB2b2lkIERlbGV0ZVNwYW4o U3Bhbiogc3BhbikgewogI2lmbmRlZiBOREVCVUcKICAgLy8gSW4gZGVidWcgbW9kZSwgdHJhc2gg dGhlIGNvbnRlbnRzIG9mIGRlbGV0ZWQgU3BhbnMKICAgbWVtc2V0KHNwYW4sIDB4M2YsIHNpemVv Zigqc3BhbikpOworI2Vsc2UKKyAgaWYgKFVOTElLRUxZKFdURjo6aXNNYWxsb2NTY3JpYmJsZUVu YWJsZWQoKSkpCisgICAgbWVtc2V0KHNwYW4sIDB4NTUsIHNpemVvZigqc3BhbikpOwogI2VuZGlm CiAgIHNwYW4tPmNsZWFyQ29va2llKCk7CiAgIHNwYW5fYWxsb2NhdG9yLkRlbGV0ZShzcGFuKTsK QEAgLTM0NDYsNiArMzQ2MCw3IEBAIHZvaWQgVENNYWxsb2NfVGhyZWFkQ2FjaGU6OkluaXRNb2R1 bGUoKSB7CiAgICAgdWludHB0cl90IGVudHJvcHkgPSBIQVJERU5JTkdfRU5UUk9QWTsKICNpZmRl ZiBXVEZfQ0hBTkdFUwogICAgIEluaXRUU0QoKTsKKyAgICBJbml0TWFsbG9jU2NyaWJibGUoKTsK ICNlbmRpZgogICAgIEluaXRTaXplQ2xhc3NlcygpOwogICAgIHRocmVhZGhlYXBfYWxsb2NhdG9y LkluaXQoZW50cm9weSk7CkBAIC00MzAxLDYgKzQzMTYsOCBAQCB2b2lkIGZyZWUodm9pZCogcHRy KSB7CiAgICAgbWVtc2V0KHB0ciwgMHhDQywgaGVhZGVyLT5tX3NpemUpOwogICAgIGRvX2ZyZWUo aGVhZGVyKTsKICNlbHNlCisgICAgaWYgKFVOTElLRUxZKFdURjo6aXNNYWxsb2NTY3JpYmJsZUVu YWJsZWQoKSkpCisgICAgICAgIG1lbXNldChwdHIsIDB4NTUsIGZhc3RNYWxsb2NTaXplKHB0cikp OwogICAgIGRvX2ZyZWUocHRyKTsKICNlbmRpZgogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93 dGYvRmFzdE1hbGxvYy5oIGIvU291cmNlL1dURi93dGYvRmFzdE1hbGxvYy5oCmluZGV4IGYwNGRj OTdkYzdkY2M2ZDllYTIwYjFkNzM2NTQ2N2U4MGQxMmIxMjQuLjA4M2YyZGUyM2FmMmJiNzk1NzFh OTI5NDFjYzZlZmE5ODVjMjhlYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Zhc3RNYWxs b2MuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9GYXN0TWFsbG9jLmgKQEAgLTM4LDYgKzM4LDkgQEAg bmFtZXNwYWNlIFdURiB7CiAgICAgV1RGX0VYUE9SVF9QUklWQVRFIHNpemVfdCBmYXN0TWFsbG9j U2l6ZShjb25zdCB2b2lkKik7CiAgICAgV1RGX0VYUE9SVF9QUklWQVRFIHNpemVfdCBmYXN0TWFs bG9jR29vZFNpemUoc2l6ZV90KTsKIAorICAgIFdURl9FWFBPUlRfUFJJVkFURSBleHRlcm4gYm9v bCBzX2lzTWFsbG9jU2NyaWJibGVFbmFibGVkOworICAgIGlubGluZSBib29sIGlzTWFsbG9jU2Ny aWJibGVFbmFibGVkKCkgeyByZXR1cm4gc19pc01hbGxvY1NjcmliYmxlRW5hYmxlZDsgfQorCiAg ICAgc3RydWN0IFRyeU1hbGxvY1JldHVyblZhbHVlIHsKICAgICAgICAgVHJ5TWFsbG9jUmV0dXJu VmFsdWUodm9pZCogZGF0YSkKICAgICAgICAgICAgIDogbV9kYXRhKGRhdGEpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9QT0RGcmVlTGlzdEFyZW5hLmggYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9QT0RGcmVlTGlzdEFyZW5hLmgKaW5kZXggZGVlMWExOTBlMGUzOWE0YTQ5 OGRmYzBjYjkzZDQxZTYwZTViODE4Ny4uYWNmZTM4ZTdjNTJhM2U4NGRmZjRlNGUxYzY5NjZiMjAw YmE5ODliYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUE9ERnJlZUxpc3RB cmVuYS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BPREZyZWVMaXN0QXJlbmEuaApA QCAtMjgsNiArMjgsOCBAQAogCiAjaW5jbHVkZSAiUE9EQXJlbmEuaCIKIAorI2luY2x1ZGUgPHd0 Zi9GYXN0TWFsbG9jLmg+CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdGVtcGxhdGUgPGNsYXNz IFQ+CkBAIC0zOCwxMCArNDAsMTQgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gYWRvcHRSZWYo bmV3IFBPREZyZWVMaXN0QXJlbmEpOwogICAgIH0KIAorICAgIHNpemVfdCByb3VuZGVkU2l6ZSgp CisgICAgeworICAgICAgICByZXR1cm4gcm91bmRVcChzaXplb2YoVCksIG1pbkFsaWdubWVudDxU PigpKTsKKyAgICB9CisKICAgICB0ZW1wbGF0ZTxjbGFzcyBBcmd1bWVudDFUeXBlPiBUKiBhbGxv Y2F0ZU9iamVjdChjb25zdCBBcmd1bWVudDFUeXBlJiBhcmd1bWVudDEpCiAgICAgewotICAgICAg ICBzaXplX3Qgcm91bmRlZFNpemUgPSByb3VuZFVwKHNpemVvZihUKSwgbWluQWxpZ25tZW50PFQ+ KCkpOwotICAgICAgICB2b2lkKiBwdHIgPSBhbGxvY2F0ZShyb3VuZGVkU2l6ZSk7CisgICAgICAg IHZvaWQqIHB0ciA9IGFsbG9jYXRlKHJvdW5kZWRTaXplKCkpOwogICAgICAgICBpZiAocHRyKSB7 CiAgICAgICAgICAgICAvLyBVc2UgcGxhY2VtZW50IG9wZXJhdG9yIG5ldyB0byBhbGxvY2F0ZSBh IFQgYXQgdGhpcyBsb2NhdGlvbi4KICAgICAgICAgICAgIG5ldyhwdHIpIFQoYXJndW1lbnQxKTsK QEAgLTUzLDggKzU5LDExIEBAIHB1YmxpYzoKICAgICB7CiAgICAgICAgIGZvciAodHlwZW5hbWUg VmVjdG9yPE93blB0cjxGcmVlTGlzdENodW5rPj46OmNvbnN0X2l0ZXJhdG9yIGl0ID0gbV9jaHVu a3MuYmVnaW4oKSwgZW5kID0gbV9jaHVua3MuZW5kKCk7IGl0ICE9IGVuZDsgKytpdCkgewogICAg ICAgICAgICAgRnJlZUxpc3RDaHVuayogY2h1bmsgPSBzdGF0aWNfY2FzdDxGcmVlTGlzdENodW5r Kj4oaXQtPmdldCgpKTsKLSAgICAgICAgICAgIGlmIChjaHVuay0+Y29udGFpbnMocHRyKSkKKyAg ICAgICAgICAgIGlmIChjaHVuay0+Y29udGFpbnMocHRyKSkgeworICAgICAgICAgICAgICAgIGlm IChVTkxJS0VMWShXVEY6OmlzTWFsbG9jU2NyaWJibGVFbmFibGVkKCkpKQorICAgICAgICAgICAg ICAgICAgICBtZW1zZXQoc3RhdGljX2Nhc3Q8dm9pZCo+KHB0ciksIDB4NTUsIHJvdW5kZWRTaXpl KCkpOwogICAgICAgICAgICAgICAgIGNodW5rLT5mcmVlKHB0cik7CisgICAgICAgICAgICB9CiAg ICAgICAgIH0KICAgICB9CiAK