128242 2014-02-05 03:59:51 -0800 Code cleanup: Remove BUILDING_ON / TARGETING definitions. 2014-02-10 03:20:41 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tgergely.u-szeged webkit-unassigned benjamin cmarcelo commit-queue mrowe ossy oldest_to_newest 976706 0 tgergely.u-szeged 2014-02-05 03:59:51 -0800 According to the FIXME, BUILDING_ON_* and TARGETING_* macros can be removed. They have been used nowhere in the code for a while. 976707 1 223226 tgergely.u-szeged 2014-02-05 04:02:53 -0800 Created attachment 223226 patch 977126 2 223226 bfulgham 2014-02-05 16:27:36 -0800 Comment on attachment 223226 patch Seems fine to me! r=me 978804 3 223226 commit-queue 2014-02-10 03:20:39 -0800 Comment on attachment 223226 patch Clearing flags on attachment: 223226 Committed r163776: <http://trac.webkit.org/changeset/163776> 978805 4 commit-queue 2014-02-10 03:20:41 -0800 All reviewed patches have been landed. Closing bug. 223226 2014-02-05 04:02:53 -0800 2014-02-10 03:20:39 -0800 patch code_cleanup_building_on_targeting.patch text/plain 3469 tgergely.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZDI1YzJmMy4uMjQ3MGYwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNC0wMi0wNSAg VGFtYXMgR2VyZ2VseSAgPHRnZXJnZWx5LnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisK KyAgICAgICAgQ29kZSBjbGVhbnVwOiBSZW1vdmUgQlVJTERJTkdfT04gLyBUQVJHRVRJTkcgZGVm aW5pdGlvbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjgyNDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGUgQlVJTERJTkdfT05fKiBhbmQgVEFSR0VUSU5HXyogbWFjcm9zIGhhdmUgbm90IGJlZW4g dXNlZCBmb3IgYSB3aGlsZS4KKyAgICAgICAgQWNjb3JkaW5nIHRvIHRoZSBGSVhNRTogdGhleSBh cmUgcmVtb3ZlZC4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDE0LTAyLTA0ICBN YXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBUaGUgc3RhY2sgbGltaXQg Y29tcHV0YXRpb24gZG9lcyBub3Qgd29yayBmb3IgV2luZG93cy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XVEYvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IDUw MDgxMzEuLjc2NzEyYzFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisr KyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTM0MiwxOSArMzQyLDYgQEAKICNkZWZp bmUgV1RGX09TX0lPUyAxCiAjZWxpZiBPUyhEQVJXSU4pICYmIGRlZmluZWQoVEFSR0VUX09TX01B QykgJiYgVEFSR0VUX09TX01BQwogI2RlZmluZSBXVEZfT1NfTUFDX09TX1ggMQotCi0vKiBGSVhN RTogVGhlc2UgY2FuIGJlIHJlbW92ZWQgYWZ0ZXIgc3VmZmljaWVudCB0aW1lIGhhcyBwYXNzZWQg c2luY2UgdGhlIHJlbW92YWwgb2YgQlVJTERJTkdfT04gLyBUQVJHRVRJTkcgbWFjcm9zLiAqLwot Ci0jZGVmaW5lIEVSUk9SX1BMRUFTRV9DT01QQVJFX1dJVEhfTUFDX09TX1hfVkVSU0lPTl9NSU5f UkVRVUlSRUQgMCAvIDAKLSNkZWZpbmUgRVJST1JfUExFQVNFX0NPTVBBUkVfV0lUSF9NQUNfT1Nf WF9WRVJTSU9OX01BWF9BTExPV0VEIDAgLyAwCi0KLSNkZWZpbmUgQlVJTERJTkdfT05fTEVPUEFS RCBFUlJPUl9QTEVBU0VfQ09NUEFSRV9XSVRIX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVE Ci0jZGVmaW5lIEJVSUxESU5HX09OX1NOT1dfTEVPUEFSRCBFUlJPUl9QTEVBU0VfQ09NUEFSRV9X SVRIX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVECi0jZGVmaW5lIEJVSUxESU5HX09OX0xJ T04gRVJST1JfUExFQVNFX0NPTVBBUkVfV0lUSF9NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJF RAotCi0jZGVmaW5lIFRBUkdFVElOR19MRU9QQVJEIEVSUk9SX1BMRUFTRV9DT01QQVJFX1dJVEhf TUFDX09TX1hfVkVSU0lPTl9NQVhfQUxMT1dFRAotI2RlZmluZSBUQVJHRVRJTkdfU05PV19MRU9Q QVJEIEVSUk9SX1BMRUFTRV9DT01QQVJFX1dJVEhfTUFDX09TX1hfVkVSU0lPTl9NQVhfQUxMT1dF RAotI2RlZmluZSBUQVJHRVRJTkdfTElPTiBFUlJPUl9QTEVBU0VfQ09NUEFSRV9XSVRIX01BQ19P U19YX1ZFUlNJT05fTUFYX0FMTE9XRUQKICNlbmRpZgogCiAvKiBPUyhGUkVFQlNEKSAtIEZyZWVC U0QgKi8KZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRl eCBiMjZkNTM1Li45NWNmN2Y4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9v bHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDItMDUgIFRhbWFzIEdlcmdlbHkg IDx0Z2VyZ2VseS51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgorCisgICAgICAgIENvZGUg Y2xlYW51cDogUmVtb3ZlIEJVSUxESU5HX09OIC8gVEFSR0VUSU5HIGRlZmluaXRpb25zLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MjQyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIEJVSUxESU5H X09OXyogYW5kIFRBUkdFVElOR18qIG1hY3JvcyBoYXZlIG5vdCBiZWVuIHVzZWQgZm9yIGEgd2hp bGUuCisgICAgICAgIEFjY29yZGluZyB0byB0aGUgRklYTUU6IHRoZXkgYXJlIHJlbW92ZWQuCisK KyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jb25maWcuaDoKKwogMjAxNC0wMi0wNCAgQW5kcmVh cyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIDxpZnJhbWUgc2Vh bWxlc3M+IHN1cHBvcnQuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jb25maWcu aCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2NvbmZpZy5oCmluZGV4IGRkYjFkNTEuLjk5MzNkN2Qg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2NvbmZpZy5oCisrKyBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2NvbmZpZy5oCkBAIC00MCwyMCArNDAsNiBAQAogCiAjaWYgUExBVEZPUk0o TUFDKQogI2RlZmluZSBXVEZfVVNFX0NGIDEKLQotLy8gRklYTUU6IFRoZXNlIGNhbiBiZSByZW1v dmVkIGFmdGVyIHN1ZmZpY2llbnQgdGltZSBoYXMgcGFzc2VkIHNpbmNlIHRoZSByZW1vdmFsIG9m IEJVSUxESU5HX09OIC8gVEFSR0VUSU5HIG1hY3Jvcy4KLQotI2RlZmluZSBFUlJPUl9QTEVBU0Vf Q09NUEFSRV9XSVRIX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEIDAgLyAwCi0jZGVmaW5l IEVSUk9SX1BMRUFTRV9DT01QQVJFX1dJVEhfTUFDX09TX1hfVkVSU0lPTl9NQVhfQUxMT1dFRCAw IC8gMAotCi0jZGVmaW5lIEJVSUxESU5HX09OX0xFT1BBUkQgRVJST1JfUExFQVNFX0NPTVBBUkVf V0lUSF9NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRAotI2RlZmluZSBCVUlMRElOR19PTl9T Tk9XX0xFT1BBUkQgRVJST1JfUExFQVNFX0NPTVBBUkVfV0lUSF9NQUNfT1NfWF9WRVJTSU9OX01J Tl9SRVFVSVJFRAotI2RlZmluZSBCVUlMRElOR19PTl9MSU9OIEVSUk9SX1BMRUFTRV9DT01QQVJF X1dJVEhfTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQKLQotI2RlZmluZSBUQVJHRVRJTkdf TEVPUEFSRCBFUlJPUl9QTEVBU0VfQ09NUEFSRV9XSVRIX01BQ19PU19YX1ZFUlNJT05fTUFYX0FM TE9XRUQKLSNkZWZpbmUgVEFSR0VUSU5HX1NOT1dfTEVPUEFSRCBFUlJPUl9QTEVBU0VfQ09NUEFS RV9XSVRIX01BQ19PU19YX1ZFUlNJT05fTUFYX0FMTE9XRUQKLSNkZWZpbmUgVEFSR0VUSU5HX0xJ T04gRVJST1JfUExFQVNFX0NPTVBBUkVfV0lUSF9NQUNfT1NfWF9WRVJTSU9OX01BWF9BTExPV0VE Ci0KICNlbmRpZiAvLyBQTEFURk9STShNQUMpCiAKICNpZiBQTEFURk9STShXSU4pCg==