128224 2014-02-04 17:36:46 -0800 Move characterAt index checks from InlineIterator to RenderText 2016-07-13 17:59:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 104810 1 mmaxfield mmaxfield dino jonlee rniwa simon.fraser thorton webkit-bug-importer oldest_to_newest 976596 0 mmaxfield 2014-02-04 17:36:46 -0800 Move characterAt index checks from InlineIterator to RenderText 976599 1 mmaxfield 2014-02-04 17:40:13 -0800 <rdar://problem/13666410> 976627 2 223203 mmaxfield 2014-02-04 19:49:46 -0800 Created attachment 223203 Patch 977025 3 mmaxfield 2014-02-05 12:01:02 -0800 http://trac.webkit.org/changeset/163465 1210822 4 bfulgham 2016-07-13 17:59:56 -0700 *** Bug 116920 has been marked as a duplicate of this bug. *** 223203 2014-02-04 19:49:46 -0800 2014-02-04 22:49:39 -0800 Patch bug-128224-20140204194945.patch text/plain 6787 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMjAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmNjMWE0NjVmYjNmNjNh OTk0YTYxYWI4ZDQ0Yjg4NmJjNjkyMDlmMy4uOTY5OGI4MDQxMTVlNzgxYjJjNmJjMDE3YzU3MzBl YjJjNzQ5YmM0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE0LTAyLTA0ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgTW92ZSBjaGFy YWN0ZXJBdCBpbmRleCBjaGVja3MgZnJvbSBJbmxpbmVJdGVyYXRvciB0byBSZW5kZXJUZXh0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgyMjQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3ZlIGNoYXJh Y3RlckF0IGluZGV4IGNoZWNrcyBmcm9tIElubGluZUl0ZXJhdG9yIHRvIFJlbmRlclRleHQKKyAg ICAgICAgc28gdGhhdCBhbGwgUmVuZGVyVGV4dCBjYWxscyBhcmUgY292ZXJlZC4gRmV3IHNhZmUg aW5zdGFuY2VzIGFyZQorICAgICAgICBub3cgY292ZXJlZCB3aXRoIHVuY2hlY2tlZENoYXJhY3Rl ckF0LgorCisgICAgICAgIE1lcmdlZCBmcm9tIEJsaW5rOgorICAgICAgICBodHRwOi8vc3JjLmNo cm9taXVtLm9yZy92aWV3dmMvYmxpbms/dmlldz1yZXZpc2lvbiZyZXZpc2lvbj0xNTA4MzAKKwor ICAgICAgICBUZXN0OiBmYXN0L3RleHQvY2hhcmFjdGVyLWF0LWNyYXNoLmh0bWwKKworICAgICAg ICAqIHJlbmRlcmluZy9JbmxpbmVJdGVyYXRvci5oOgorICAgICAgICAoV2ViQ29yZTo6SW5saW5l SXRlcmF0b3I6OmNoYXJhY3RlckF0KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGV4dC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUZXh0Ojpjb21wdXRlUHJlZmVycmVkTG9naWNh bFdpZHRocyk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRleHQuaDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlclRleHQ6Om9wZXJhdG9yW10pOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy VGV4dDo6dW5jaGVja2VkQ2hhcmFjdGVyQXQpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGV4 dDo6Y2hhcmFjdGVyQXQpOgorCiAyMDE0LTAxLTI5ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBs ZS5jb20+CiAKICAgICAgICAgTWFrZSBpdCBwb3NzaWJsZSB0byBpbXBsZW1lbnQgSlMgYnVpbHRp bnMgaW4gSlMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVJdGVy YXRvci5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUl0ZXJhdG9yLmgKaW5kZXgg MTk4Y2Y1Y2UyOGJkMTJiMGNiMTQ5ZTMxNWM1OTAwODVlZmRjYTliZC4uMGU2ZWIxZDdlMzViMDgy N2YwZmYxZWY2MmE1YTdkMWY0MWM5MjliZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL0lubGluZUl0ZXJhdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lu bGluZUl0ZXJhdG9yLmgKQEAgLTM3NSwxMSArMzc1LDcgQEAgaW5saW5lIFVDaGFyIElubGluZUl0 ZXJhdG9yOjpjaGFyYWN0ZXJBdCh1bnNpZ25lZCBpbmRleCkgY29uc3QKICAgICBpZiAoIW1fcmVu ZGVyZXIgfHwgIW1fcmVuZGVyZXItPmlzVGV4dCgpKQogICAgICAgICByZXR1cm4gMDsKIAotICAg IFJlbmRlclRleHQqIHRleHQgPSB0b1JlbmRlclRleHQobV9yZW5kZXJlcik7Ci0gICAgaWYgKGlu ZGV4ID49IHRleHQtPnRleHRMZW5ndGgoKSkKLSAgICAgICAgcmV0dXJuIDA7Ci0KLSAgICByZXR1 cm4gdGV4dC0+Y2hhcmFjdGVyQXQoaW5kZXgpOworICAgIHJldHVybiB0b1JlbmRlclRleHQobV9y ZW5kZXJlciktPmNoYXJhY3RlckF0KGluZGV4KTsKIH0KIAogaW5saW5lIFVDaGFyIElubGluZUl0 ZXJhdG9yOjpjdXJyZW50KCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0 LmNwcAppbmRleCBlMjc2YTI3OTc4MjYwZjczMDFjMTFjYjA3NzI5ZmIzYzg3Y2FlM2ZkLi41Mjdm YjMzYzk5M2RmNTc3YjQ4NWQxNmZlZDRkZWI0NjI0ZWM3N2MyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRleHQuY3BwCkBAIC03MjIsNyArNzIyLDcgQEAgdm9pZCBSZW5kZXJUZXh0 Ojpjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyhmbG9hdCBsZWFkV2lkdGgsIEhhc2hTZXQ8 Y29uc3QgU2kKICAgICBib29sIGJyZWFrQWxsID0gKHN0eWxlLndvcmRCcmVhaygpID09IEJyZWFr QWxsV29yZEJyZWFrIHx8IHN0eWxlLndvcmRCcmVhaygpID09IEJyZWFrV29yZEJyZWFrKSAmJiBz dHlsZS5hdXRvV3JhcCgpOwogCiAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBsZW47IGkrKykgewot ICAgICAgICBVQ2hhciBjID0gY2hhcmFjdGVyQXQoaSk7CisgICAgICAgIFVDaGFyIGMgPSB1bmNo ZWNrZWRDaGFyYWN0ZXJBdChpKTsKIAogICAgICAgICBib29sIHByZXZpb3VzQ2hhcmFjdGVySXNT cGFjZSA9IGlzU3BhY2U7CiAKQEAgLTc3NCw3ICs3NzQsNyBAQCB2b2lkIFJlbmRlclRleHQ6OmNv bXB1dGVQcmVmZXJyZWRMb2dpY2FsV2lkdGhzKGZsb2F0IGxlYWRXaWR0aCwgSGFzaFNldDxjb25z dCBTaQogICAgICAgICAgICAgaisrOwogICAgICAgICAgICAgaWYgKGogPT0gbGVuKQogICAgICAg ICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgYyA9IGNoYXJhY3RlckF0KGopOworICAgICAg ICAgICAgYyA9IHVuY2hlY2tlZENoYXJhY3RlckF0KGopOwogICAgICAgICAgICAgaWYgKGlzQnJl YWthYmxlKGJyZWFrSXRlcmF0b3IsIGosIG5leHRCcmVha2FibGUsIGJyZWFrTkJTUCkgJiYgY2hh cmFjdGVyQXQoaiAtIDEpICE9IHNvZnRIeXBoZW4pCiAgICAgICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgICAgICBpZiAoYnJlYWtBbGwpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUZXh0LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4 dC5oCmluZGV4IDNhYmYxYWNiNzNjMjk0MjU0NDdhOTgyOWQyNDk1YjRlNjFhMzQzMDAuLjZhZWE5 ZDk3MjExYTMwMGIzMTAwNjYxNDBlMTkzMDZiMzlkNTk5ZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRleHQuaApAQCAtNzksOCArNzksOSBAQCBwdWJsaWM6CiAgICAgY29uc3QgVUNo YXIqIGNoYXJhY3RlcnMxNigpIGNvbnN0IHsgcmV0dXJuIG1fdGV4dC5pbXBsKCktPmNoYXJhY3Rl cnMxNigpOyB9CiAgICAgY29uc3QgVUNoYXIqIGNoYXJhY3RlcnMoKSBjb25zdCB7IHJldHVybiBk ZXByZWNhdGVkQ2hhcmFjdGVycygpOyB9IC8vIEZJWE1FOiBEZWxldGUgdGhpcy4KICAgICBjb25z dCBVQ2hhciogZGVwcmVjYXRlZENoYXJhY3RlcnMoKSBjb25zdCB7IHJldHVybiBtX3RleHQuZGVw cmVjYXRlZENoYXJhY3RlcnMoKTsgfQotICAgIFVDaGFyIGNoYXJhY3RlckF0KHVuc2lnbmVkIGkp IGNvbnN0IHsgcmV0dXJuIGlzOEJpdCgpID8gY2hhcmFjdGVyczgoKVtpXSA6IGNoYXJhY3RlcnMx NigpW2ldOyB9Ci0gICAgVUNoYXIgb3BlcmF0b3JbXSh1bnNpZ25lZCBpKSBjb25zdCB7IHJldHVy biBjaGFyYWN0ZXJBdChpKTsgfQorICAgIFVDaGFyIGNoYXJhY3RlckF0KHVuc2lnbmVkKSBjb25z dDsKKyAgICBVQ2hhciB1bmNoZWNrZWRDaGFyYWN0ZXJBdCh1bnNpZ25lZCkgY29uc3Q7CisgICAg VUNoYXIgb3BlcmF0b3JbXSh1bnNpZ25lZCBpKSBjb25zdCB7IHJldHVybiB1bmNoZWNrZWRDaGFy YWN0ZXJBdChpKTsgfQogICAgIHVuc2lnbmVkIHRleHRMZW5ndGgoKSBjb25zdCB7IHJldHVybiBt X3RleHQuaW1wbCgpLT5sZW5ndGgoKTsgfSAvLyBub24gdmlydHVhbCBpbXBsZW1lbnRhdGlvbiBv ZiBsZW5ndGgoKQogICAgIHZvaWQgcG9zaXRpb25MaW5lQm94KElubGluZVRleHRCb3gmKTsKIApA QCAtMjE4LDYgKzIxOSwyMCBAQCBwcml2YXRlOgogICAgIFJlbmRlclRleHRMaW5lQm94ZXMgbV9s aW5lQm94ZXM7CiB9OwogCitpbmxpbmUgVUNoYXIgUmVuZGVyVGV4dDo6dW5jaGVja2VkQ2hhcmFj dGVyQXQodW5zaWduZWQgaSkgY29uc3QKK3sKKyAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBM SUNBVElPTihpIDwgdGV4dExlbmd0aCgpKTsKKyAgICByZXR1cm4gaXM4Qml0KCkgPyBjaGFyYWN0 ZXJzOCgpW2ldIDogY2hhcmFjdGVyczE2KClbaV07Cit9CisKK2lubGluZSBVQ2hhciBSZW5kZXJU ZXh0OjpjaGFyYWN0ZXJBdCh1bnNpZ25lZCBpKSBjb25zdAoreworICAgIGlmIChpID49IHRleHRM ZW5ndGgoKSkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICByZXR1cm4gdW5jaGVja2VkQ2hhcmFj dGVyQXQoaSk7Cit9CisKIHRlbXBsYXRlIDw+IGlubGluZSBib29sIGlzUmVuZGVyZXJPZlR5cGU8 Y29uc3QgUmVuZGVyVGV4dD4oY29uc3QgUmVuZGVyT2JqZWN0JiByZW5kZXJlcikgeyByZXR1cm4g cmVuZGVyZXIuaXNUZXh0KCk7IH0KIFJFTkRFUl9PQkpFQ1RfVFlQRV9DQVNUUyhSZW5kZXJUZXh0 LCBpc1RleHQoKSkKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDU1YmJlMmJkMmY0NmQyYTYyMDI0OGRjMjZiMmU4ODdkMjNl YmQyNWUuLmEzMDFlNWViYjFjYTNlYWY2ZGMxNzk3N2FlODcyNzY2M2ZlM2RlNTIgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyMCBAQAorMjAxNC0wMi0wNCAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRA YXBwbGUuY29tPgorCisgICAgICAgIE1vdmUgY2hhcmFjdGVyQXQgaW5kZXggY2hlY2tzIGZyb20g SW5saW5lSXRlcmF0b3IgdG8gUmVuZGVyVGV4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MjI0CisKKyAgICAgICAgTW92ZSBjaGFyYWN0ZXJBdCBp bmRleCBjaGVja3MgZnJvbSBJbmxpbmVJdGVyYXRvciB0byBSZW5kZXJUZXh0CisgICAgICAgIHNv IHRoYXQgYWxsIFJlbmRlclRleHQgY2FsbHMgYXJlIGNvdmVyZWQuIEZldyBzYWZlIGluc3RhbmNl cyBhcmUKKyAgICAgICAgbm93IGNvdmVyZWQgd2l0aCB1bmNoZWNrZWRDaGFyYWN0ZXJBdC4KKwor ICAgICAgICBNZXJnZWQgZnJvbSBCbGluazoKKyAgICAgICAgaHR0cDovL3NyYy5jaHJvbWl1bS5v cmcvdmlld3ZjL2JsaW5rP3ZpZXc9cmV2aXNpb24mcmV2aXNpb249MTUwODMwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L3RleHQvY2hhcmFj dGVyLWF0LWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC90ZXh0L2No YXJhY3Rlci1hdC1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAxNC0wMS0yOSAgT2xpdmVyIEh1bnQg IDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgaXQgcG9zc2libGUgdG8gaW1wbGVt ZW50IEpTIGJ1aWx0aW5zIGluIEpTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3RleHQv Y2hhcmFjdGVyLWF0LWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9j aGFyYWN0ZXItYXQtY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmI0MWM0YmIwMWI5NDQw ZWYwYjQzMmRkZmZhOTZmNTM1ODEzMTMyOGIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L3RleHQvY2hhcmFjdGVyLWF0LWNyYXNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBA CitQYXNzLiBUZXN0IGRpZG4ndCBjcmFzaC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv dGV4dC9jaGFyYWN0ZXItYXQtY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9jaGFy YWN0ZXItYXQtY3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5hMGZkMDY3ZDdlMjM0MDI0NTU4MjA4ZmMz ZTkyNmNkMTVmOGJmM2MxCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0 L2NoYXJhY3Rlci1hdC1jcmFzaC5odG1sCkBAIC0wLDAgKzEsMjIgQEAKKzwhRE9DVFlQRSBodG1s PgorPGh0bWw+Cis8c3R5bGU+CitkaXYgeworICAtd2Via2l0LXdyaXRpbmctbW9kZTogdmVydGlj YWwtbHI7CisgIC13ZWJraXQtdGV4dC1jb21iaW5lOiBob3Jpem9udGFsOworICBoZWlnaHQ6IDdw eDsKKyAgd2hpdGUtc3BhY2U6IHByZS13cmFwOworfQorPC9zdHlsZT4KKzxkaXY+Citmb28KKyAg PHNjcmlwdD48L3NjcmlwdD4KKyAgPHNjcmlwdD48L3NjcmlwdD4KKzwvZGl2PgorPHNjcmlwdD4K K2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Citkb2N1 bWVudC5kb2N1bWVudEVsZW1lbnQub2Zmc2V0VG9wOworZG9jdW1lbnQuZG9jdW1lbnRFbGVtZW50 LmlubmVySFRNTCA9ICJQYXNzLiBUZXN0IGRpZG4ndCBjcmFzaC4iOworPC9zY3JpcHQ+Cis8L2h0 bWw+Cg==