128222 2014-02-04 16:07:19 -0800 Reduce boilerplate in BlockAllocator.h 2014-02-04 17:23:22 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg oldest_to_newest 976569 0 mhahnenberg 2014-02-04 16:07:19 -0800 There are a lot of template specializations for the various types of HeapBlocks in BlockAllocator.h. We could reduce the spew by using a macro. 976571 1 223179 mhahnenberg 2014-02-04 16:11:09 -0800 Created attachment 223179 Patch 976583 2 223179 fpizlo 2014-02-04 17:15:28 -0800 Comment on attachment 223179 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223179&action=review > Source/JavaScriptCore/heap/BlockAllocator.h:238 > +REGION_SET_FOR(HandleBlock, m_fourKBBlockRegionSet); > Maybe can you #undef REGION_SET_FOR here? 976590 3 mhahnenberg 2014-02-04 17:23:22 -0800 Committed r163419: <http://trac.webkit.org/changeset/163419> 223179 2014-02-04 16:11:09 -0800 2014-02-04 17:15:28 -0800 Patch bug-128222-20140204161053.patch text/plain 3585 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYzNDE1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTAyLTA0ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgUmVkdWNlIGJvaWxlcnBsYXRlIGluIEJsb2NrQWxsb2NhdG9yLmgKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODIyMgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGFyZSBhIGxvdCBv ZiB0ZW1wbGF0ZSBzcGVjaWFsaXphdGlvbnMgZm9yIHRoZSB2YXJpb3VzIHR5cGVzIG9mIEhlYXBC bG9ja3MgCisgICAgICAgIGluIEJsb2NrQWxsb2NhdG9yLmguIFdlIGNvdWxkIHJlZHVjZSB0aGUg c3BldyBieSB1c2luZyBhIG1hY3JvLgorCisgICAgICAgICogaGVhcC9CbG9ja0FsbG9jYXRvci5o OgorCiAyMDE0LTAyLTA0ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+ CiAKICAgICAgICAgUmVmYWN0b3IgTWFya1N0YWNrQXJyYXkgdG8gYWxsb3cgbW9yZSB0aGFuIEpT Q2VsbHMgdG8gYmUgc3RvcmVkCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9CbG9j a0FsbG9jYXRvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0Js b2NrQWxsb2NhdG9yLmgJKHJldmlzaW9uIDE2MzQxNSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9oZWFwL0Jsb2NrQWxsb2NhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTIxNyw3NyArMjE3LDI0 IEBAIGlubGluZSB2b2lkIEJsb2NrQWxsb2NhdG9yOjpkZWFsbG9jYXRlQ3UKICAgICByZWdpb24t PmRlc3Ryb3koKTsKIH0KIAotdGVtcGxhdGUgPD4KLWlubGluZSBCbG9ja0FsbG9jYXRvcjo6UmVn aW9uU2V0JiBCbG9ja0FsbG9jYXRvcjo6cmVnaW9uU2V0Rm9yPENvcGllZEJsb2NrPigpCi17Ci0g ICAgcmV0dXJuIG1fY29waWVkUmVnaW9uU2V0OwotfQotCi10ZW1wbGF0ZSA8PgotaW5saW5lIEJs b2NrQWxsb2NhdG9yOjpSZWdpb25TZXQmIEJsb2NrQWxsb2NhdG9yOjpyZWdpb25TZXRGb3I8TWFy a2VkQmxvY2s+KCkKLXsKLSAgICByZXR1cm4gbV9tYXJrZWRSZWdpb25TZXQ7Ci19Ci0KLXRlbXBs YXRlIDw+Ci1pbmxpbmUgQmxvY2tBbGxvY2F0b3I6OlJlZ2lvblNldCYgQmxvY2tBbGxvY2F0b3I6 OnJlZ2lvblNldEZvcjxXZWFrQmxvY2s+KCkKLXsKLSAgICByZXR1cm4gbV9mb3VyS0JCbG9ja1Jl Z2lvblNldDsKLX0KLQotdGVtcGxhdGUgPD4KLWlubGluZSBCbG9ja0FsbG9jYXRvcjo6UmVnaW9u U2V0JiBCbG9ja0FsbG9jYXRvcjo6cmVnaW9uU2V0Rm9yPEdDQXJyYXlTZWdtZW50PGNvbnN0IEpT Q2VsbCo+PigpCi17Ci0gICAgcmV0dXJuIG1fZm91cktCQmxvY2tSZWdpb25TZXQ7Ci19Ci0KLXRl bXBsYXRlIDw+Ci1pbmxpbmUgQmxvY2tBbGxvY2F0b3I6OlJlZ2lvblNldCYgQmxvY2tBbGxvY2F0 b3I6OnJlZ2lvblNldEZvcjxDb3B5V29ya0xpc3RTZWdtZW50PigpCi17Ci0gICAgcmV0dXJuIG1f d29ya0xpc3RSZWdpb25TZXQ7Ci19Ci0KLXRlbXBsYXRlIDw+Ci1pbmxpbmUgQmxvY2tBbGxvY2F0 b3I6OlJlZ2lvblNldCYgQmxvY2tBbGxvY2F0b3I6OnJlZ2lvblNldEZvcjxIYW5kbGVCbG9jaz4o KQotewotICAgIHJldHVybiBtX2ZvdXJLQkJsb2NrUmVnaW9uU2V0OwotfQotCi10ZW1wbGF0ZSA8 PgotaW5saW5lIEJsb2NrQWxsb2NhdG9yOjpSZWdpb25TZXQmIEJsb2NrQWxsb2NhdG9yOjpyZWdp b25TZXRGb3I8SGVhcEJsb2NrPENvcGllZEJsb2NrPj4oKQotewotICAgIHJldHVybiBtX2NvcGll ZFJlZ2lvblNldDsKLX0KLQotdGVtcGxhdGUgPD4KLWlubGluZSBCbG9ja0FsbG9jYXRvcjo6UmVn aW9uU2V0JiBCbG9ja0FsbG9jYXRvcjo6cmVnaW9uU2V0Rm9yPEhlYXBCbG9jazxNYXJrZWRCbG9j az4+KCkKLXsKLSAgICByZXR1cm4gbV9tYXJrZWRSZWdpb25TZXQ7Ci19Ci0KLXRlbXBsYXRlIDw+ Ci1pbmxpbmUgQmxvY2tBbGxvY2F0b3I6OlJlZ2lvblNldCYgQmxvY2tBbGxvY2F0b3I6OnJlZ2lv blNldEZvcjxIZWFwQmxvY2s8V2Vha0Jsb2NrPj4oKQotewotICAgIHJldHVybiBtX2ZvdXJLQkJs b2NrUmVnaW9uU2V0OwotfQotCi10ZW1wbGF0ZSA8PgotaW5saW5lIEJsb2NrQWxsb2NhdG9yOjpS ZWdpb25TZXQmIEJsb2NrQWxsb2NhdG9yOjpyZWdpb25TZXRGb3I8SGVhcEJsb2NrPEdDQXJyYXlT ZWdtZW50PGNvbnN0IEpTQ2VsbCo+Pj4oKQotewotICAgIHJldHVybiBtX2ZvdXJLQkJsb2NrUmVn aW9uU2V0OwotfQotCi10ZW1wbGF0ZSA8PgotaW5saW5lIEJsb2NrQWxsb2NhdG9yOjpSZWdpb25T ZXQmIEJsb2NrQWxsb2NhdG9yOjpyZWdpb25TZXRGb3I8SGVhcEJsb2NrPENvcHlXb3JrTGlzdFNl Z21lbnQ+PigpCi17Ci0gICAgcmV0dXJuIG1fd29ya0xpc3RSZWdpb25TZXQ7Ci19Ci0KLXRlbXBs YXRlIDw+Ci1pbmxpbmUgQmxvY2tBbGxvY2F0b3I6OlJlZ2lvblNldCYgQmxvY2tBbGxvY2F0b3I6 OnJlZ2lvblNldEZvcjxIZWFwQmxvY2s8SGFuZGxlQmxvY2s+PigpCi17Ci0gICAgcmV0dXJuIG1f Zm91cktCQmxvY2tSZWdpb25TZXQ7Ci19CisjZGVmaW5lIFJFR0lPTl9TRVRfRk9SKGJsb2NrVHlw ZSwgc2V0KSBcCisgICAgdGVtcGxhdGUgPD4gXAorICAgIGlubGluZSBCbG9ja0FsbG9jYXRvcjo6 UmVnaW9uU2V0JiBCbG9ja0FsbG9jYXRvcjo6cmVnaW9uU2V0Rm9yPGJsb2NrVHlwZT4oKSBcCisg ICAgeyBcCisgICAgICAgIHJldHVybiBzZXQ7IFwKKyAgICB9IFwKKyAgICB0ZW1wbGF0ZSA8PiBc CisgICAgaW5saW5lIEJsb2NrQWxsb2NhdG9yOjpSZWdpb25TZXQmIEJsb2NrQWxsb2NhdG9yOjpy ZWdpb25TZXRGb3I8SGVhcEJsb2NrPGJsb2NrVHlwZT4+KCkgXAorICAgIHsgXAorICAgICAgICBy ZXR1cm4gc2V0OyBcCisgICAgfSBcCisKK1JFR0lPTl9TRVRfRk9SKE1hcmtlZEJsb2NrLCBtX21h cmtlZFJlZ2lvblNldCk7CitSRUdJT05fU0VUX0ZPUihDb3BpZWRCbG9jaywgbV9jb3BpZWRSZWdp b25TZXQpOworUkVHSU9OX1NFVF9GT1IoV2Vha0Jsb2NrLCBtX2ZvdXJLQkJsb2NrUmVnaW9uU2V0 KTsKK1JFR0lPTl9TRVRfRk9SKEdDQXJyYXlTZWdtZW50PGNvbnN0IEpTQ2VsbCo+LCBtX2ZvdXJL QkJsb2NrUmVnaW9uU2V0KTsKK1JFR0lPTl9TRVRfRk9SKENvcHlXb3JrTGlzdFNlZ21lbnQsIG1f d29ya0xpc3RSZWdpb25TZXQpOworUkVHSU9OX1NFVF9GT1IoSGFuZGxlQmxvY2ssIG1fZm91cktC QmxvY2tSZWdpb25TZXQpOwogCiB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4KIGlubGluZSBCbG9ja0Fs bG9jYXRvcjo6UmVnaW9uU2V0JiBCbG9ja0FsbG9jYXRvcjo6cmVnaW9uU2V0Rm9yKCkK