128220 2014-02-04 15:51:26 -0800 Store StringImpl substring backpointers as tail data 2014-02-04 16:18:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue oldest_to_newest 976558 0 andersca 2014-02-04 15:51:26 -0800 Store StringImpl substring backpointers as tail data 976559 1 223177 andersca 2014-02-04 15:52:06 -0800 Created attachment 223177 Patch 976561 2 223177 ggaren 2014-02-04 15:53:57 -0800 Comment on attachment 223177 Patch r=me 976572 3 andersca 2014-02-04 16:18:43 -0800 Committed r163416: <http://trac.webkit.org/changeset/163416> 223177 2014-02-04 15:52:06 -0800 2014-02-04 15:53:56 -0800 Patch bug-128220-20140204155211.patch text/plain 7180 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDUyNTM2NTk0ZDYxN2ExZWE4OWExMDhi MmY1YjdjZjUzNmUwYTk2MTQuLmU5NDM2NTY2NDRhZmEzODYwZjgwZDgwMmUyNDNlOWMwYzkwMDVi ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjUgQEAKIDIwMTQtMDItMDQgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KIAorICAgICAgICBTdG9yZSBTdHJpbmdJbXBsIHN1YnN0cmluZyBi YWNrcG9pbnRlcnMgYXMgdGFpbCBkYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjgyMjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIGxldHMgdXMgZ2V0IHJpZCBvZiBtX3N1YnN0cmluZ0J1ZmZl ciBmcm9tIHRoZSB1bmlvbi4KKworICAgICAgICAqIHd0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwOgor ICAgICAgICAoV1RGOjpTdHJpbmdJbXBsOjp+U3RyaW5nSW1wbCk6CisgICAgICAgIChXVEY6OlN0 cmluZ0ltcGw6OmdldERhdGExNlNsb3dDYXNlKToKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdJ bXBsLmg6CisgICAgICAgIChXVEY6OlN0cmluZ0ltcGw6OlN0cmluZ0ltcGwpOgorICAgICAgICAo V1RGOjpTdHJpbmdJbXBsOjpjcmVhdGVTdWJzdHJpbmdTaGFyaW5nSW1wbDgpOgorICAgICAgICAo V1RGOjpTdHJpbmdJbXBsOjpjcmVhdGVTdWJzdHJpbmdTaGFyaW5nSW1wbCk6CisgICAgICAgIChX VEY6OlN0cmluZ0ltcGw6OmNvc3QpOgorICAgICAgICAoV1RGOjpTdHJpbmdJbXBsOjpjb3N0RHVy aW5nR0MpOgorICAgICAgICAoV1RGOjpTdHJpbmdJbXBsOjpzdWJzdHJpbmdCdWZmZXIpOgorCisy MDE0LTAyLTA0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAg ICAgUmVuYW1lIHRoZSBzdWJzdHJpbmcgc2hhcmluZyBTdHJpbmdJbXBsOjpjcmVhdGUgdmFyaWFu dHMgdG8gYmV0dGVyIGluZGljYXRlIHdoYXQgdGhleSBkbwogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MjE0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X VEYvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0lt cGwuY3BwCmluZGV4IDAwNzhjMzdiYjIwMDQwN2IwMGYxZjZjZmJhODc3YmE1NmYyMmZiMWMuLjUy Y2ViZjFiOWFkOGY2YWE3YjQwNjllMDBiMjc1NGIzN2UwNzI4YmMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAKKysrIGIvU291cmNlL1dURi93dGYvdGV4dC9T dHJpbmdJbXBsLmNwcApAQCAtMTM3LDggKzEzNyw4IEBAIFN0cmluZ0ltcGw6On5TdHJpbmdJbXBs KCkKICAgICB9CiAKICAgICBBU1NFUlQob3duZXJzaGlwID09IEJ1ZmZlclN1YnN0cmluZyk7Ci0g ICAgQVNTRVJUKG1fc3Vic3RyaW5nQnVmZmVyKTsKLSAgICBtX3N1YnN0cmluZ0J1ZmZlci0+ZGVy ZWYoKTsKKyAgICBBU1NFUlQoc3Vic3RyaW5nQnVmZmVyKCkpOworICAgIHN1YnN0cmluZ0J1ZmZl cigpLT5kZXJlZigpOwogfQogCiB2b2lkIFN0cmluZ0ltcGw6OmRlc3Ryb3koU3RyaW5nSW1wbCog c3RyaW5nSW1wbCkKQEAgLTMwNyw4ICszMDcsOCBAQCBjb25zdCBVQ2hhciogU3RyaW5nSW1wbDo6 Z2V0RGF0YTE2U2xvd0Nhc2UoKSBjb25zdAogICAgIGlmIChidWZmZXJPd25lcnNoaXAoKSA9PSBC dWZmZXJTdWJzdHJpbmcpIHsKICAgICAgICAgLy8gSWYgdGhpcyBpcyBhIHN1YnN0cmluZywgcmV0 dXJuIGEgcG9pbnRlciBpbnRvIHRoZSBwYXJlbnQgc3RyaW5nLgogICAgICAgICAvLyBUT0RPOiBD b25zaWRlciBzZXZlcmluZyB0aGlzIHN0cmluZyBmcm9tIHRoZSBwYXJlbnQgc3RyaW5nCi0gICAg ICAgIHVuc2lnbmVkIG9mZnNldCA9IG1fZGF0YTggLSBtX3N1YnN0cmluZ0J1ZmZlci0+Y2hhcmFj dGVyczgoKTsKLSAgICAgICAgcmV0dXJuIG1fc3Vic3RyaW5nQnVmZmVyLT5kZXByZWNhdGVkQ2hh cmFjdGVycygpICsgb2Zmc2V0OworICAgICAgICB1bnNpZ25lZCBvZmZzZXQgPSBtX2RhdGE4IC0g c3Vic3RyaW5nQnVmZmVyKCktPmNoYXJhY3RlcnM4KCk7CisgICAgICAgIHJldHVybiBzdWJzdHJp bmdCdWZmZXIoKS0+ZGVwcmVjYXRlZENoYXJhY3RlcnMoKSArIG9mZnNldDsKICAgICB9CiAKICAg ICBTVFJJTkdfU1RBVFNfQUREX1VQQ09OVkVSVEVEX1NUUklORyhtX2xlbmd0aCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaCBiL1NvdXJjZS9XVEYvd3RmL3Rl eHQvU3RyaW5nSW1wbC5oCmluZGV4IGRjYjc1ZjczM2E0NmMxN2I0OGE0ZGQ2NWY4OGM3YTczNzY4 MzllZGIuLjI0NWQ5ODUzYTNiMDkyNzcxMDAzNDk4ZTgxMDg2ODdhMzI4MGFlM2QgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCisrKyBiL1NvdXJjZS9XVEYvd3Rm L3RleHQvU3RyaW5nSW1wbC5oCkBAIC0yNzMsMTMgKzI3MywxNCBAQCBwcml2YXRlOgogICAgICAg ICA6IG1fcmVmQ291bnQoc19yZWZDb3VudEluY3JlbWVudCkKICAgICAgICAgLCBtX2xlbmd0aChs ZW5ndGgpCiAgICAgICAgICwgbV9kYXRhOChjaGFyYWN0ZXJzKQotICAgICAgICAsIG1fc3Vic3Ry aW5nQnVmZmVyKGJhc2UubGVha1JlZigpKQogICAgICAgICAsIG1faGFzaEFuZEZsYWdzKHNfaGFz aEZsYWc4Qml0QnVmZmVyIHwgQnVmZmVyU3Vic3RyaW5nKQogICAgIHsKICAgICAgICAgQVNTRVJU KGlzOEJpdCgpKTsKICAgICAgICAgQVNTRVJUKG1fZGF0YTgpOwogICAgICAgICBBU1NFUlQobV9s ZW5ndGgpOwotICAgICAgICBBU1NFUlQobV9zdWJzdHJpbmdCdWZmZXItPmJ1ZmZlck93bmVyc2hp cCgpICE9IEJ1ZmZlclN1YnN0cmluZyk7CisgICAgICAgIEFTU0VSVChiYXNlLT5idWZmZXJPd25l cnNoaXAoKSAhPSBCdWZmZXJTdWJzdHJpbmcpOworCisgICAgICAgIHN1YnN0cmluZ0J1ZmZlcigp ID0gYmFzZS5sZWFrUmVmKCk7CiAKICAgICAgICAgU1RSSU5HX1NUQVRTX0FERF84QklUX1NUUklO RzIobV9sZW5ndGgsIHRydWUpOwogICAgIH0KQEAgLTI4OSwxMyArMjkwLDE0IEBAIHByaXZhdGU6 CiAgICAgICAgIDogbV9yZWZDb3VudChzX3JlZkNvdW50SW5jcmVtZW50KQogICAgICAgICAsIG1f bGVuZ3RoKGxlbmd0aCkKICAgICAgICAgLCBtX2RhdGExNihjaGFyYWN0ZXJzKQotICAgICAgICAs IG1fc3Vic3RyaW5nQnVmZmVyKGJhc2UubGVha1JlZigpKQogICAgICAgICAsIG1faGFzaEFuZEZs YWdzKEJ1ZmZlclN1YnN0cmluZykKICAgICB7CiAgICAgICAgIEFTU0VSVCghaXM4Qml0KCkpOwog ICAgICAgICBBU1NFUlQobV9kYXRhMTYpOwogICAgICAgICBBU1NFUlQobV9sZW5ndGgpOwotICAg ICAgICBBU1NFUlQobV9zdWJzdHJpbmdCdWZmZXItPmJ1ZmZlck93bmVyc2hpcCgpICE9IEJ1ZmZl clN1YnN0cmluZyk7CisgICAgICAgIEFTU0VSVChiYXNlLT5idWZmZXJPd25lcnNoaXAoKSAhPSBC dWZmZXJTdWJzdHJpbmcpOworCisgICAgICAgIHN1YnN0cmluZ0J1ZmZlcigpID0gYmFzZS5sZWFr UmVmKCk7CiAKICAgICAgICAgU1RSSU5HX1NUQVRTX0FERF8xNkJJVF9TVFJJTkcyKG1fbGVuZ3Ro LCB0cnVlKTsKICAgICB9CkBAIC0zNTEsOCArMzUzLDExIEBAIHB1YmxpYzoKICAgICAgICAgICAg IHJldHVybiAqZW1wdHkoKTsKIAogICAgICAgICBBU1NFUlQocmVwLT5pczhCaXQoKSk7Ci0gICAg ICAgIFN0cmluZ0ltcGwqIG93bmVyUmVwID0gKHJlcC0+YnVmZmVyT3duZXJzaGlwKCkgPT0gQnVm ZmVyU3Vic3RyaW5nKSA/IHJlcC0+bV9zdWJzdHJpbmdCdWZmZXIgOiByZXAuZ2V0KCk7Ci0gICAg ICAgIHJldHVybiBhZG9wdFJlZigqbmV3IFN0cmluZ0ltcGwocmVwLT5tX2RhdGE4ICsgb2Zmc2V0 LCBsZW5ndGgsIG93bmVyUmVwKSk7CisgICAgICAgIFN0cmluZ0ltcGwqIG93bmVyUmVwID0gKHJl cC0+YnVmZmVyT3duZXJzaGlwKCkgPT0gQnVmZmVyU3Vic3RyaW5nKSA/IHJlcC0+c3Vic3RyaW5n QnVmZmVyKCkgOiByZXAuZ2V0KCk7CisKKyAgICAgICAgLy8gV2UgYWxsb2NhdGUgYSBidWZmZXIg dGhhdCBjb250YWlucyBib3RoIHRoZSBTdHJpbmdJbXBsIHN0cnVjdCBhcyB3ZWxsIGFzIHRoZSBw b2ludGVyIHRvIHRoZSBvd25lciBzdHJpbmcuCisgICAgICAgIFN0cmluZ0ltcGwqIHN0cmluZ0lt cGwgPSBzdGF0aWNfY2FzdDxTdHJpbmdJbXBsKj4oZmFzdE1hbGxvYyhhbGxvY2F0aW9uU2l6ZTxT dHJpbmdJbXBsKj4oMSkpKTsKKyAgICAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgKE5vdE51bGws IHN0cmluZ0ltcGwpIFN0cmluZ0ltcGwocmVwLT5tX2RhdGE4ICsgb2Zmc2V0LCBsZW5ndGgsIG93 bmVyUmVwKSk7CiAgICAgfQogCiAgICAgc3RhdGljIEFMV0FZU19JTkxJTkUgUGFzc1JlZjxTdHJp bmdJbXBsPiBjcmVhdGVTdWJzdHJpbmdTaGFyaW5nSW1wbChQYXNzUmVmUHRyPFN0cmluZ0ltcGw+ IHJlcCwgdW5zaWduZWQgb2Zmc2V0LCB1bnNpZ25lZCBsZW5ndGgpCkBAIC0zNjMsMTAgKzM2OCwx MyBAQCBwdWJsaWM6CiAgICAgICAgIGlmICghbGVuZ3RoKQogICAgICAgICAgICAgcmV0dXJuICpl bXB0eSgpOwogCi0gICAgICAgIFN0cmluZ0ltcGwqIG93bmVyUmVwID0gKHJlcC0+YnVmZmVyT3du ZXJzaGlwKCkgPT0gQnVmZmVyU3Vic3RyaW5nKSA/IHJlcC0+bV9zdWJzdHJpbmdCdWZmZXIgOiBy ZXAuZ2V0KCk7CisgICAgICAgIFN0cmluZ0ltcGwqIG93bmVyUmVwID0gKHJlcC0+YnVmZmVyT3du ZXJzaGlwKCkgPT0gQnVmZmVyU3Vic3RyaW5nKSA/IHJlcC0+c3Vic3RyaW5nQnVmZmVyKCkgOiBy ZXAuZ2V0KCk7CisKKyAgICAgICAgLy8gV2UgYWxsb2NhdGUgYSBidWZmZXIgdGhhdCBjb250YWlu cyBib3RoIHRoZSBTdHJpbmdJbXBsIHN0cnVjdCBhcyB3ZWxsIGFzIHRoZSBwb2ludGVyIHRvIHRo ZSBvd25lciBzdHJpbmcuCisgICAgICAgIFN0cmluZ0ltcGwqIHN0cmluZ0ltcGwgPSBzdGF0aWNf Y2FzdDxTdHJpbmdJbXBsKj4oZmFzdE1hbGxvYyhhbGxvY2F0aW9uU2l6ZTxTdHJpbmdJbXBsKj4o MSkpKTsKICAgICAgICAgaWYgKHJlcC0+aXM4Qml0KCkpCi0gICAgICAgICAgICByZXR1cm4gYWRv cHRSZWYoKm5ldyBTdHJpbmdJbXBsKHJlcC0+bV9kYXRhOCArIG9mZnNldCwgbGVuZ3RoLCBvd25l clJlcCkpOwotICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBTdHJpbmdJbXBsKHJlcC0+bV9k YXRhMTYgKyBvZmZzZXQsIGxlbmd0aCwgb3duZXJSZXApKTsKKyAgICAgICAgICAgIHJldHVybiBh ZG9wdFJlZigqbmV3IChOb3ROdWxsLCBzdHJpbmdJbXBsKSBTdHJpbmdJbXBsKHJlcC0+bV9kYXRh OCArIG9mZnNldCwgbGVuZ3RoLCBvd25lclJlcCkpOworICAgICAgICByZXR1cm4gYWRvcHRSZWYo Km5ldyAoTm90TnVsbCwgc3RyaW5nSW1wbCkgU3RyaW5nSW1wbChyZXAtPm1fZGF0YTE2ICsgb2Zm c2V0LCBsZW5ndGgsIG93bmVyUmVwKSk7CiAgICAgfQogCiAgICAgdGVtcGxhdGU8dW5zaWduZWQg Y2hhcmFjdGVyc0NvdW50PgpAQCAtNDU5LDcgKzQ2Nyw3IEBAIHB1YmxpYzoKICAgICB7CiAgICAg ICAgIC8vIEZvciBzdWJzdHJpbmdzLCByZXR1cm4gdGhlIGNvc3Qgb2YgdGhlIGJhc2Ugc3RyaW5n LgogICAgICAgICBpZiAoYnVmZmVyT3duZXJzaGlwKCkgPT0gQnVmZmVyU3Vic3RyaW5nKQotICAg ICAgICAgICAgcmV0dXJuIG1fc3Vic3RyaW5nQnVmZmVyLT5jb3N0KCk7CisgICAgICAgICAgICBy ZXR1cm4gc3Vic3RyaW5nQnVmZmVyKCktPmNvc3QoKTsKIAogICAgICAgICBpZiAobV9oYXNoQW5k RmxhZ3MgJiBzX2hhc2hGbGFnRGlkUmVwb3J0Q29zdCkKICAgICAgICAgICAgIHJldHVybiAwOwpA QCAtNDc3LDcgKzQ4NSw3IEBAIHB1YmxpYzoKICAgICAgICAgICAgIHJldHVybiAwOwogICAgICAg ICAKICAgICAgICAgaWYgKGJ1ZmZlck93bmVyc2hpcCgpID09IEJ1ZmZlclN1YnN0cmluZykKLSAg ICAgICAgICAgIHJldHVybiBkaXZpZGVSb3VuZGVkVXAobV9zdWJzdHJpbmdCdWZmZXItPmNvc3RE dXJpbmdHQygpLCByZWZDb3VudCgpKTsKKyAgICAgICAgICAgIHJldHVybiBkaXZpZGVSb3VuZGVk VXAoc3Vic3RyaW5nQnVmZmVyKCktPmNvc3REdXJpbmdHQygpLCByZWZDb3VudCgpKTsKICAgICAg ICAgCiAgICAgICAgIHNpemVfdCByZXN1bHQgPSBtX2xlbmd0aDsKICAgICAgICAgaWYgKCFpczhC aXQoKSkKQEAgLTc4OSw2ICs3OTcsMjAgQEAgcHJpdmF0ZToKICAgICAgICAgcmV0dXJuIHJlaW50 ZXJwcmV0X2Nhc3Q8VCo+KHJlaW50ZXJwcmV0X2Nhc3Q8dWludDhfdCo+KHRoaXMpICsgdGFpbE9m ZnNldDxUPigpKTsKICAgICB9CiAKKyAgICBTdHJpbmdJbXBsKiBjb25zdCYgc3Vic3RyaW5nQnVm ZmVyKCkgY29uc3QKKyAgICB7CisgICAgICAgIEFTU0VSVChidWZmZXJPd25lcnNoaXAoKSA9PSBC dWZmZXJTdWJzdHJpbmcpOworCisgICAgICAgIHJldHVybiAqdGFpbFBvaW50ZXI8U3RyaW5nSW1w bCo+KCk7CisgICAgfQorCisgICAgU3RyaW5nSW1wbComIHN1YnN0cmluZ0J1ZmZlcigpCisgICAg eworICAgICAgICBBU1NFUlQoYnVmZmVyT3duZXJzaGlwKCkgPT0gQnVmZmVyU3Vic3RyaW5nKTsK KworICAgICAgICByZXR1cm4gKnRhaWxQb2ludGVyPFN0cmluZ0ltcGwqPigpOworICAgIH0KKwog ICAgIC8vIFRoaXMgbnVtYmVyIG11c3QgYmUgYXQgbGVhc3QgMiB0byBhdm9pZCBzaGFyaW5nIGVt cHR5LCBudWxsIGFzIHdlbGwgYXMgMSBjaGFyYWN0ZXIgc3RyaW5ncyBmcm9tIFNtYWxsU3RyaW5n cy4KICAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgc19jb3B5Q2hhcnNJbmxpbmVDdXRPZmYgPSAy MDsKIApAQCAtODU0LDEwICs4NzYsNyBAQCBwcml2YXRlOgogICAgICAgICBjb25zdCBMQ2hhciog bV9kYXRhODsKICAgICAgICAgY29uc3QgVUNoYXIqIG1fZGF0YTE2OwogICAgIH07Ci0gICAgdW5p b24gewotICAgICAgICBTdHJpbmdJbXBsKiBtX3N1YnN0cmluZ0J1ZmZlcjsKLSAgICAgICAgbXV0 YWJsZSBVQ2hhciogbV9jb3B5RGF0YTE2OwotICAgIH07CisgICAgbXV0YWJsZSBVQ2hhciogbV9j b3B5RGF0YTE2OwogICAgIG11dGFibGUgdW5zaWduZWQgbV9oYXNoQW5kRmxhZ3M7CiB9OwogCg==