128218 2014-02-04 15:41:59 -0800 [CSS Regions] Null dereference applying animation with CSS regions 2014-02-06 06:37:13 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED AdobeTracked, InRadar P2 Normal --- 84900 1 jhoneycutt stavila abucur allan.jensen commit-queue dino esprehn+autocc glenn gyuyoung.kim macpherson menard mihnea mmaerean simon.fraser stavila webkit-bug-importer WebkitBugTracker oldest_to_newest 976549 0 223174 jhoneycutt 2014-02-04 15:41:59 -0800 Created attachment 223174 Repro case Crash when opening the attached test case, which applies a CSS animation when using CSS regions. <rdar://problem/15983499> 976726 1 223230 stavila 2014-02-05 07:16:02 -0800 Created attachment 223230 Patch 976748 2 223230 abucur 2014-02-05 08:37:29 -0800 Comment on attachment 223230 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223230&action=review > Source/WebCore/css/StyleResolver.cpp:3144 > + if (!parentStyle) Are we sure early returning is the right behavior here? What's the expected result in the case of regions? E.g. Maybe we don't properly zoom when we actually should do it. I see that the parent style is not used in the code below the checks so maybe we're supposed to actually zoom the thing. We should test and file a bug if zooming doesn't work correctly. Probably the same applies for the generic family change function. > Source/WebCore/style/StyleResolveTree.cpp:455 > + ASSERT((!child->renderer() || child->inNamedFlow()) || current.shadowRoot() || isInsertionPoint(current)); What certain situations are you talking about in the CL? 976751 3 223230 stavila 2014-02-05 08:45:18 -0800 Comment on attachment 223230 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223230&action=review >> Source/WebCore/css/StyleResolver.cpp:3144 >> + if (!parentStyle) > > Are we sure early returning is the right behavior here? What's the expected result in the case of regions? E.g. Maybe we don't properly zoom when we actually should do it. I see that the parent style is not used in the code below the checks so maybe we're supposed to actually zoom the thing. We should test and file a bug if zooming doesn't work correctly. Probably the same applies for the generic family change function. Yes, I believe early returning is the right behaviour because it follows the same pattern as the checkForGenericFamilyChange method, which is called just before checkForZoomChange. But I agree that zooming with regions should be tested and a bug filed if some problems are discovered. >> Source/WebCore/style/StyleResolveTree.cpp:455 >> + ASSERT((!child->renderer() || child->inNamedFlow()) || current.shadowRoot() || isInsertionPoint(current)); > > What certain situations are you talking about in the CL? The case described in the test-case, animations applied to a region containing an element and a child of that element being flowed into a different flow. 977273 4 223230 commit-queue 2014-02-06 00:16:29 -0800 Comment on attachment 223230 Patch Rejecting attachment 223230 from review queue. simon.fraser@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 977284 5 abucur 2014-02-06 01:00:17 -0800 (In reply to comment #4) > (From update of attachment 223230 [details]) > Rejecting attachment 223230 [details] from review queue. > > simon.fraser@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. > > - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. > > - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. I suppose the duplicate entry for abucur in contributors.json confused the commit bot. Reapplying Simon's r+. 977286 6 223230 commit-queue 2014-02-06 01:09:12 -0800 Comment on attachment 223230 Patch Rejecting attachment 223230 from review queue. abucur@adobe.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 977296 7 223230 commit-queue 2014-02-06 02:09:56 -0800 Comment on attachment 223230 Patch Rejecting attachment 223230 from review queue. abucur@adobe.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 977329 8 223230 commit-queue 2014-02-06 06:37:10 -0800 Comment on attachment 223230 Patch Clearing flags on attachment: 223230 Committed r163531: <http://trac.webkit.org/changeset/163531> 977330 9 commit-queue 2014-02-06 06:37:13 -0800 All reviewed patches have been landed. Closing bug. 223174 2014-02-04 15:41:59 -0800 2014-02-04 15:41:59 -0800 Repro case 15983499-repro-case.html text/html 296 jhoneycutt PHN0eWxlPgogICAgZGl2IHsKICAgICAgICAtd2Via2l0LWFuaW1hdGlvbi1uYW1lOiBuOwogICAg ICAgIC13ZWJraXQtYW5pbWF0aW9uLWR1cmF0aW9uOiAxczsKICAgIH0KCiAgICBALXdlYmtpdC1r ZXlmcmFtZXMgbiB7CiAgICAgICAgdG8geyBmb250LXdlaWdodDogYm9sZDsgfQogICAgfQo8L3N0 eWxlPgoKPGRpdiBzdHlsZT0iLXdlYmtpdC1mbG93LWZyb206IGE7Ij4KICAgIDxkaXY+CiAgICAg ICAgPGRpdiBzdHlsZT0iLXdlYmtpdC1mbG93LWludG86IGI7Ij50ZXN0PC9kaXY+CiAgICA8L2Rp dj4KPC9kaXY+Cgo= 223230 2014-02-05 07:16:02 -0800 2014-02-06 06:37:10 -0800 Patch 128218.patch text/plain 4886 stavila ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhYzllYTZjLi5jOTgyMzNmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMDIt MDUgIFJhZHUgU3RhdmlsYSAgPHN0YXZpbGFAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1MgUmVn aW9uc10gTnVsbCBkZXJlZmVyZW5jZSBhcHBseWluZyBhbmltYXRpb24gd2l0aCBDU1MgcmVnaW9u cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MjE4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQg dGVzdCBmb3IgY3Jhc2ggY2F1c2VkIGJ5IHVzaW5nIGFuaW1hdGlvbnMgd2l0aCBET00gY2hpbGRy ZW4gb2YgcmVnaW9ucyBmbG93ZWQKKyAgICAgICAgaW50byBhbm90aGVyIGZsb3cgdGhyZWFkLgor CisgICAgICAgICogZmFzdC9yZWdpb25zL2FuaW1hdGlvbi1lbGVtZW50LWluLXJlZ2lvbi1mbG93 ZWQtdG8tb3RoZXItdGhyZWFkLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv cmVnaW9ucy9hbmltYXRpb24tZWxlbWVudC1pbi1yZWdpb24tZmxvd2VkLXRvLW90aGVyLXRocmVh ZC5odG1sOiBBZGRlZC4KKwogMjAxNC0wMi0wNCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBs ZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIDxpZnJhbWUgc2VhbWxlc3M+IHN1cHBvcnQuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvYW5pbWF0aW9uLWVsZW1lbnQtaW4tcmVn aW9uLWZsb3dlZC10by1vdGhlci10aHJlYWQtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zh c3QvcmVnaW9ucy9hbmltYXRpb24tZWxlbWVudC1pbi1yZWdpb24tZmxvd2VkLXRvLW90aGVyLXRo cmVhZC1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmEy ZDYwOWIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvYW5pbWF0 aW9uLWVsZW1lbnQtaW4tcmVnaW9uLWZsb3dlZC10by1vdGhlci10aHJlYWQtZXhwZWN0ZWQuaHRt bApAQCAtMCwwICsxLDIgQEAKKzxwPlRoaXMgdGVzdCBwYXNzZXMgaWYgaXQgZG9lc24ndCBjcmFz aCBvciBhc3NlcnQ8L3A+Cis8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTI4MjE4Ij5CdWcgMTI4MjE4IC0gW0NTUyBSZWdpb25zXSBOdWxsIGRlcmVmZXJl bmNlIGFwcGx5aW5nIGFuaW1hdGlvbiB3aXRoIENTUyByZWdpb25zPC9hPgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL2FuaW1hdGlvbi1lbGVtZW50LWluLXJlZ2lvbi1mbG93 ZWQtdG8tb3RoZXItdGhyZWFkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvYW5pbWF0 aW9uLWVsZW1lbnQtaW4tcmVnaW9uLWZsb3dlZC10by1vdGhlci10aHJlYWQuaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi43Y2E1MzcyCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL2FuaW1hdGlvbi1lbGVtZW50LWluLXJlZ2lvbi1mbG93 ZWQtdG8tb3RoZXItdGhyZWFkLmh0bWwKQEAgLTAsMCArMSwxOSBAQAorPHN0eWxlPgorICAgIGRp diB7CisgICAgICAgIC13ZWJraXQtYW5pbWF0aW9uLW5hbWU6IG47CisgICAgICAgIC13ZWJraXQt YW5pbWF0aW9uLWR1cmF0aW9uOiAxczsKKyAgICB9CisKKyAgICBALXdlYmtpdC1rZXlmcmFtZXMg biB7CisgICAgICAgIHRvIHsgZm9udC13ZWlnaHQ6IGJvbGQ7IH0KKyAgICB9Cis8L3N0eWxlPgor Cis8cD5UaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXNuJ3QgY3Jhc2ggb3IgYXNzZXJ0PC9wPgor PGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODIxOCI+ QnVnIDEyODIxOCAtIFtDU1MgUmVnaW9uc10gTnVsbCBkZXJlZmVyZW5jZSBhcHBseWluZyBhbmlt YXRpb24gd2l0aCBDU1MgcmVnaW9uczwvYT4KKzxkaXYgaWQ9ImRpdjEiIHN0eWxlPSItd2Via2l0 LWZsb3ctZnJvbTogYTsiPgorICAgIDxkaXYgaWQ9ImRpdjIiPgorICAgICAgICA8ZGl2IGlkPSJk aXYzIiBzdHlsZT0iLXdlYmtpdC1mbG93LWludG86IGI7Ij50ZXN0PC9kaXY+CisgICAgPC9kaXY+ Cis8L2Rpdj4KKwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDI3NTlhZTkuLjE2ZDJkNTQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyNiBAQAorMjAxNC0wMi0wNSAgUmFkdSBTdGF2aWxhICA8c3RhdmlsYUBhZG9iZS5j b20+CisKKyAgICAgICAgW0NTUyBSZWdpb25zXSBOdWxsIGRlcmVmZXJlbmNlIGFwcGx5aW5nIGFu aW1hdGlvbiB3aXRoIENTUyByZWdpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjgyMTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgZmlyc3QgaXNzdWUgKHRoZSBudWxsIGRlcmVmZXJlbmNlKSB3 YXMgY2F1c2VkIGJ5IHRoZSBjaGVja0Zvclpvb21DaGFuZ2UgbWV0aG9kCisgICAgICAgIG5vdCBn dWFyZGluZyBhZ2FpbnN0IGEgbnVsbCBwYXJlbnRTdHlsZSBwYXJhbWV0ZXIsIGFzIHRoZSBjaGVj a0ZvckdlbmVyaWNGYW1pbHlDaGFuZ2UgCisgICAgICAgIG1ldGhvZCBkb2VzLCB3aGljaCBpbiB0 aGUgY3Jhc2hpbmcgc2NlbmFyaW8gaXMgY2FsbGVkIGp1c3QgYmVmb3JlIHRoZSBmYXVsdHkKKyAg ICAgICAgY2hlY2tGb3Jab29tQ2hhbmdlIG1ldGhvZC4KKyAgICAgICAgVGhlIHNlY29uZCBpc3N1 ZSB3YXMgYW4gYXNzZXJ0IHdoaWNoIHdhcyBjYXVzZWQgYnkgdGhlIGZhY3QgdGhhdCBkZXRhY2hp bmcgaXMgcGVyZm9ybWVkCisgICAgICAgIGluIGEgY2VydGFpbiBzaXR1YXRpb24gaWYgdGhlIGVs ZW1lbnQgaGFzIGEgcmVuZGVyZXIgb3IgaWYgaXQncyBpbnNpZGUgYSBuYW1lZCBmbG93LgorICAg ICAgICBIb3dldmVyLCB3aGVuIHJlYXR0YWNoaW5nIGFuZCBhc3NlcnRpbmcgdGhlIGVsZW1lbnQg aGFzIG5vIHJlbmRlcmVyLCB0aGUgCisgICAgICAgICJpbnNpZGUgbmFtZWQgZmxvdyIgY29uZGl0 aW9uIHdhcyBubyBsb25nZXIgY29uc2lkZXJlZC4KKworICAgICAgICBUZXN0OiBmYXN0L3JlZ2lv bnMvYW5pbWF0aW9uLWVsZW1lbnQtaW4tcmVnaW9uLWZsb3dlZC10by1vdGhlci10aHJlYWQuaHRt bAorCisgICAgICAgICogY3NzL1N0eWxlUmVzb2x2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 U3R5bGVSZXNvbHZlcjo6Y2hlY2tGb3Jab29tQ2hhbmdlKToKKyAgICAgICAgKiBzdHlsZS9TdHls ZVJlc29sdmVUcmVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlOjphdHRhY2hDaGlsZHJl bik6CisKIDIwMTQtMDItMDQgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAg ICAgICAgIFJlbW92ZSA8aWZyYW1lIHNlYW1sZXNzPiBzdXBwb3J0LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0 eWxlUmVzb2x2ZXIuY3BwCmluZGV4IDM0YjI2YTYuLmNiMzM1MTIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv U3R5bGVSZXNvbHZlci5jcHAKQEAgLTMxNDEsNiArMzE0MSw5IEBAIHZvaWQgU3R5bGVSZXNvbHZl cjo6Y2hlY2tGb3JUZXh0U2l6ZUFkanVzdChSZW5kZXJTdHlsZSogc3R5bGUpCiAKIHZvaWQgU3R5 bGVSZXNvbHZlcjo6Y2hlY2tGb3Jab29tQ2hhbmdlKFJlbmRlclN0eWxlKiBzdHlsZSwgUmVuZGVy U3R5bGUqIHBhcmVudFN0eWxlKQogeworICAgIGlmICghcGFyZW50U3R5bGUpCisgICAgICAgIHJl dHVybjsKKyAgICAKICAgICBpZiAoc3R5bGUtPmVmZmVjdGl2ZVpvb20oKSA9PSBwYXJlbnRTdHls ZS0+ZWZmZWN0aXZlWm9vbSgpKQogICAgICAgICByZXR1cm47CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3N0eWxlL1N0eWxlUmVzb2x2ZVRyZWUuY3BwIGIvU291cmNlL1dlYkNvcmUvc3R5 bGUvU3R5bGVSZXNvbHZlVHJlZS5jcHAKaW5kZXggYWQ3ZTEzOC4uMjcwN2I4NCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVSZXNvbHZlVHJlZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvc3R5bGUvU3R5bGVSZXNvbHZlVHJlZS5jcHAKQEAgLTQ1Miw3ICs0NTIsNyBAQCBz dGF0aWMgdm9pZCBhdHRhY2hDaGlsZHJlbihDb250YWluZXJOb2RlJiBjdXJyZW50KQogICAgICAg ICBhdHRhY2hEaXN0cmlidXRlZENoaWxkcmVuKHRvSW5zZXJ0aW9uUG9pbnQoY3VycmVudCkpOwog CiAgICAgZm9yIChOb2RlKiBjaGlsZCA9IGN1cnJlbnQuZmlyc3RDaGlsZCgpOyBjaGlsZDsgY2hp bGQgPSBjaGlsZC0+bmV4dFNpYmxpbmcoKSkgewotICAgICAgICBBU1NFUlQoIWNoaWxkLT5yZW5k ZXJlcigpIHx8IGN1cnJlbnQuc2hhZG93Um9vdCgpIHx8IGlzSW5zZXJ0aW9uUG9pbnQoY3VycmVu dCkpOworICAgICAgICBBU1NFUlQoKCFjaGlsZC0+cmVuZGVyZXIoKSB8fCBjaGlsZC0+aW5OYW1l ZEZsb3coKSkgfHwgY3VycmVudC5zaGFkb3dSb290KCkgfHwgaXNJbnNlcnRpb25Qb2ludChjdXJy ZW50KSk7CiAgICAgICAgIGlmIChjaGlsZC0+cmVuZGVyZXIoKSkKICAgICAgICAgICAgIGNvbnRp bnVlOwogICAgICAgICBpZiAoY2hpbGQtPmlzVGV4dE5vZGUoKSkgewo=