<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>12821</bug_id>
          
          <creation_ts>2007-02-19 16:33:30 -0800</creation_ts>
          <short_desc>Number.toExponential doesn&apos;t work for negative numbers</short_desc>
          <delta_ts>2007-05-04 10:43:53 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>420+</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>HasReduction, InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Malone">markmalone</reporter>
          <assigned_to name="Justin Haygood">jhaygood</assigned_to>
          <cc>ap</cc>
    
    <cc>darin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>22704</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Malone">markmalone</who>
    <bug_when>2007-02-19 16:33:30 -0800</bug_when>
    <thetext>here&apos;s the sample script:
var val = -18450000000000000000;
var res = val.toExponential(6);


Expected it to return &quot;-1.845000e+19&quot; but got NaN instead.

After further investigation it appears that this problem only exists for negative numbers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22705</commentid>
    <comment_count>1</comment_count>
    <who name="Mark Malone">markmalone</who>
    <bug_when>2007-02-19 16:34:01 -0800</bug_when>
    <thetext>rdar://5007921</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22706</commentid>
    <comment_count>2</comment_count>
      <attachid>13255</attachid>
    <who name="Mark Malone">markmalone</who>
    <bug_when>2007-02-19 16:35:51 -0800</bug_when>
    <thetext>Created attachment 13255
test case</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22732</commentid>
    <comment_count>3</comment_count>
    <who name="Justin Haygood">jhaygood</who>
    <bug_when>2007-02-19 18:50:12 -0800</bug_when>
    <thetext>Verified, I&apos;ll take a look at it. I can&apos;t guarantee a patch, so if someone else wants to take a look, go ahead.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22736</commentid>
    <comment_count>4</comment_count>
      <attachid>13261</attachid>
    <who name="Justin Haygood">jhaygood</who>
    <bug_when>2007-02-19 19:22:00 -0800</bug_when>
    <thetext>Created attachment 13261
Inverts negative numbers so that they pass

This might not be the cleanest method, but its the least intrusive, and fixes the test case, as well as the simpler one of just using -1, and pretty much every negative numbers since positive numbers do indeed pass. By using the positive codebase either way....</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22739</commentid>
    <comment_count>5</comment_count>
      <attachid>13261</attachid>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2007-02-19 19:39:05 -0800</bug_when>
    <thetext>Comment on attachment 13261
Inverts negative numbers so that they pass

r- for style issues.  As mentioned on IRC I&apos;m not sure that this is the best solution to the problem.  The if (!fractionDigits-&gt;isUndefined()) { ... } block is resulting in a negative x value becoming NaN.  If you can work out why that happens a cleaner fix may present itself.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22740</commentid>
    <comment_count>6</comment_count>
      <attachid>13262</attachid>
    <who name="Justin Haygood">jhaygood</who>
    <bug_when>2007-02-19 19:45:53 -0800</bug_when>
    <thetext>Created attachment 13262
Fixes logic error

High school math came in handy. Its a big no-no to do a log on a negative number. However, taking the absolute value of it fixes it in this case.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22742</commentid>
    <comment_count>7</comment_count>
      <attachid>13263</attachid>
    <who name="Justin Haygood">jhaygood</who>
    <bug_when>2007-02-19 19:57:43 -0800</bug_when>
    <thetext>Created attachment 13263
Same as previous with better ChangeLog.

bdash says ChangeLog needs more... added to ChangeLog.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22743</commentid>
    <comment_count>8</comment_count>
      <attachid>13263</attachid>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2007-02-19 19:59:11 -0800</bug_when>
    <thetext>Comment on attachment 13263
Same as previous with better ChangeLog.

Looks good.  Thanks for the patch Justin.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22539</commentid>
    <comment_count>9</comment_count>
      <attachid>13263</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2007-02-20 08:04:50 -0800</bug_when>
    <thetext>Comment on attachment 13263
Same as previous with better ChangeLog.

This patch really should have a layout test with it.  Marking r-.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22475</commentid>
    <comment_count>10</comment_count>
    <who name="Justin Haygood">jhaygood</who>
    <bug_when>2007-02-20 14:46:08 -0800</bug_when>
    <thetext>I can write a layout test, but due to my lack of Mac operating system, can&apos;t produce an expected results file. I tested on WebKit/Qt...

I&apos;ll reattach patch with a LayoutTest once I&apos;m at home where I can edit it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22018</commentid>
    <comment_count>11</comment_count>
      <attachid>13340</attachid>
    <who name="Justin Haygood">jhaygood</who>
    <bug_when>2007-02-22 21:46:34 -0800</bug_when>
    <thetext>Created attachment 13340
Fixes mathematical error in Number, with LayoutTest

There isn&apos;t an expected results, due to lack of a Mac and lack of working WebKit/Qt, so whoever checks this in will need to generate one for me?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22026</commentid>
    <comment_count>12</comment_count>
      <attachid>13340</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2007-02-22 23:25:53 -0800</bug_when>
    <thetext>Comment on attachment 13340
Fixes mathematical error in Number, with LayoutTest

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>21905</commentid>
    <comment_count>13</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2007-02-23 10:57:27 -0800</bug_when>
    <thetext>See also: bug 5259.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>21109</commentid>
    <comment_count>14</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2007-02-27 10:52:52 -0800</bug_when>
    <thetext>I have tried to land this, but the layout tests fails (I haven&apos;t investigated why):

FAIL (0).toExponential(0) should be 0e+0 (of type string). Was NaN (of type string).
FAIL (0).toExponential(2) should be 0.00e+0 (of type string). Was NaN (of type string).
FAIL (-1).toExponential(2) should be -1.00e+0 (of type string). Was -1e+0 (of type string).
FAIL (-0.1).toExponential(2) should be -1.00e-1 (of type string). Was -1e+1 (of type string).
FAIL (0.1).toExponential(2) should be 1.00e-1 (of type string). Was 1e+1 (of type string).
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>21098</commentid>
    <comment_count>15</comment_count>
    <who name="Justin Haygood">jhaygood</who>
    <bug_when>2007-02-27 11:38:35 -0800</bug_when>
    <thetext>The layout tests was based on behavior of Mozilla Firefox. The layout tests should fail prior to landing as well. I can change the LayoutTests to match the current behavior( except for 0 failing ).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>21088</commentid>
    <comment_count>16</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2007-02-27 12:17:44 -0800</bug_when>
    <thetext>I think that a test that accompanies a bugfix should fail without the fix, and pass (with correct results) with it. Just changing shouldBe() expectations to match the current results (rather than expected ones) would be rather confusing.

The included test shows that toExponential() is still pretty much broken even in very basic cases. If I were working on in and not seeing a simple fix, I&apos;d probably comment out the failing cases in the test, and file separate bug(s) for them.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>20936</commentid>
    <comment_count>17</comment_count>
      <attachid>13340</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2007-02-27 23:00:26 -0800</bug_when>
    <thetext>Comment on attachment 13340
Fixes mathematical error in Number, with LayoutTest

Moving to r- based on Alexey&apos;s comments - we don&apos;t want to check in a new test in a way that fails right out of the gate. That does not do a very good job of showing the fix. Better would be something that fails before and passes after.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>11167</commentid>
    <comment_count>18</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2007-05-04 10:43:53 -0700</bug_when>
    <thetext>Fixed by Darin in r21256. See also: bug 5259.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>13255</attachid>
            <date>2007-02-19 16:35:51 -0800</date>
            <delta_ts>2007-02-19 16:35:51 -0800</delta_ts>
            <desc>test case</desc>
            <filename>5007921.html</filename>
            <type>text/html</type>
            <size>587</size>
            <attacher name="Mark Malone">markmalone</attacher>
            
              <data encoding="base64">PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs
Ly9FTiIKICAgICAgICAiaHR0cDovL3d3dy53My5vcmcvVFIvaHRtbDQvbG9vc2UuZHRkIj4KPGh0
bWwgbGFuZz0iZW4iPgo8aGVhZD4KCTxtZXRhIGh0dHAtZXF1aXY9ImNvbnRlbnQtdHlwZSIgY29u
dGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KCTx0aXRsZT5VbnRpdGxlZDwvdGl0bGU+
Cgk8bWV0YSBuYW1lPSJnZW5lcmF0b3IiIGNvbnRlbnQ9IkJCRWRpdCA4LjYiPgo8c2NyaXB0IHR5
cGU9InRleHQvamF2YXNjcmlwdCIgbGFuZ3VhZ2U9ImphdmFzY3JpcHQiPgpmdW5jdGlvbiBkb0l0
KCkKewo8IS0tCnZhciB2YWwgPSAtMTg0NTAwMDAwMDAwMDAwMDAwMDA7CnZhciByZXMgPSB2YWwu
dG9FeHBvbmVudGlhbCg2KTsKZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJzbHQiKS5pbm5lckhU
TUwgPSByZXM7Cn0KLy8tLT4KPC9zY3JpcHQ+PC9oZWFkPgo8Ym9keT48ZGl2IGlkPSJyc2x0Ij48
L2Rpdj4KPGlucHV0IHR5cGU9ImJ1dHRvbiIgb25jbGljaz0iZG9JdCgpIiB2YWx1ZT0idGVzdCI+
CjwvYm9keT4KPC9odG1sPgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>13261</attachid>
            <date>2007-02-19 19:22:00 -0800</date>
            <delta_ts>2007-02-19 19:45:53 -0800</delta_ts>
            <desc>Inverts negative numbers so that they pass</desc>
            <filename>jscorepatch.diff</filename>
            <type>text/plain</type>
            <size>1486</size>
            <attacher name="Justin Haygood">jhaygood</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE5NzE5
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDctMDIt
MTkgIEp1c3RpbiBIYXlnb29kICA8amhheWdvb2RAc3BzdS5lZHU+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBranMvbnVtYmVyX29iamVjdC5jcHA6
CisgICAgICAgIChOdW1iZXJQcm90b0Z1bmM6OmNhbGxBc0Z1bmN0aW9uKToKKwogMjAwNy0wMi0x
OCAgS2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4KIAogICAgICAgICBS
ZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRleDoga2pzL251bWJlcl9vYmplY3QuY3BwCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIGtqcy9udW1iZXJfb2JqZWN0LmNwcAkocmV2aXNpb24gMTk3MTkpCisrKyBranMv
bnVtYmVyX29iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI5LDYgKzI5LDggQEAKICNpbmNs
dWRlIDx3dGYvTWF0aEV4dHJhcy5oPgogI2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4KIAorI2luY2x1
ZGUgPFFEZWJ1Zz4KKwogdXNpbmcgbmFtZXNwYWNlIEtKUzsKIAogLy8gLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tIE51bWJlckluc3RhbmNlIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0KQEAgLTI0OCw5ICsyNTAsMTIgQEAgSlNWYWx1ZSAqTnVtYmVyUHJvdG9GdW5jOjpjYWxsQXNG
dW5jdGlvbgogICBjYXNlIFRvRXhwb25lbnRpYWw6IHsKICAgICAgIGRvdWJsZSB4ID0gdi0+dG9O
dW1iZXIoZXhlYyk7CiAgICAgICAKKyAgICAgIGJvb2wgaXNOZWdhdGl2ZSA9ICggeCA8IDAgKTsK
KyAgICAgIGlmKCBpc05lZ2F0aXZlICkgeCA9IC14OworCiAgICAgICBpZiAoaXNOYU4oeCkgfHwg
aXNJbmYoeCkpCiAgICAgICAgICAgcmV0dXJuIGpzU3RyaW5nKFVTdHJpbmc6OmZyb20oeCkpOwot
ICAgICAgCisKICAgICAgIEpTVmFsdWUgKmZyYWN0aW9uRGlnaXRzID0gYXJnc1swXTsKICAgICAg
IGRvdWJsZSBkZiA9IGZyYWN0aW9uRGlnaXRzLT50b0ludGVnZXIoZXhlYyk7CiAgICAgICBpZiAo
IWZyYWN0aW9uRGlnaXRzLT5pc1VuZGVmaW5lZCgpICYmICEoZGYgPj0gMCAmJiBkZiA8PSAyMCkp
IC8vIHRydWUgZm9yIE5hTgpAQCAtMjg0LDcgKzI4OSw3IEBAIEpTVmFsdWUgKk51bWJlclByb3Rv
RnVuYzo6Y2FsbEFzRnVuY3Rpb24KICAgICAgIGRlY2ltYWxQb2ludCArPSBkZWNpbWFsQWRqdXN0
OwogICAgICAgCiAgICAgICBpbnQgaSA9IDA7Ci0gICAgICBpZiAoc2lnbikgeworICAgICAgaWYg
KCBpc05lZ2F0aXZlICkgewogICAgICAgICAgIGJ1ZltpKytdID0gJy0nOwogICAgICAgfQogICAg
ICAgCg==
</data>
<flag name="review"
          id="5179"
          type_id="1"
          status="-"
          setter="mrowe"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>13262</attachid>
            <date>2007-02-19 19:45:53 -0800</date>
            <delta_ts>2007-02-19 19:57:43 -0800</delta_ts>
            <desc>Fixes logic error</desc>
            <filename>jscorepatch.diff</filename>
            <type>text/plain</type>
            <size>995</size>
            <attacher name="Justin Haygood">jhaygood</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE5NzE5
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDctMDIt
MTkgIEp1c3RpbiBIYXlnb29kICA8amhheWdvb2RAc3BzdS5lZHU+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBranMvbnVtYmVyX29iamVjdC5jcHA6
CisgICAgICAgIChOdW1iZXJQcm90b0Z1bmM6OmNhbGxBc0Z1bmN0aW9uKToKKwogMjAwNy0wMi0x
OCAgS2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4KIAogICAgICAgICBS
ZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRleDoga2pzL251bWJlcl9vYmplY3QuY3BwCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIGtqcy9udW1iZXJfb2JqZWN0LmNwcAkocmV2aXNpb24gMTk3MTkpCisrKyBranMv
bnVtYmVyX29iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI1OSw3ICsyNTksNyBAQCBKU1Zh
bHVlICpOdW1iZXJQcm90b0Z1bmM6OmNhbGxBc0Z1bmN0aW9uCiAgICAgICAKICAgICAgIGludCBk
ZWNpbWFsQWRqdXN0ID0gMDsKICAgICAgIGlmICghZnJhY3Rpb25EaWdpdHMtPmlzVW5kZWZpbmVk
KCkpIHsKLSAgICAgICAgICBkb3VibGUgbG9neCA9IGZsb29yKGxvZzEwKHgpKTsKKyAgICAgICAg
ICBkb3VibGUgbG9neCA9IGZsb29yKGxvZzEwKGZhYnMoeCkpKTsKICAgICAgICAgICB4IC89IHBv
dygxMC4wLCBsb2d4KTsKICAgICAgICAgICBkb3VibGUgZnggPSBmbG9vcih4ICogcG93KDEwLjAs
IGYpKSAvIHBvdygxMC4wLCBmKTsKICAgICAgICAgICBkb3VibGUgY3ggPSBjZWlsKHggKiBwb3co
MTAuMCwgZikpIC8gcG93KDEwLjAsIGYpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>13263</attachid>
            <date>2007-02-19 19:57:43 -0800</date>
            <delta_ts>2007-02-22 21:46:34 -0800</delta_ts>
            <desc>Same as previous with better ChangeLog.</desc>
            <filename>jscorepatch.diff</filename>
            <type>text/plain</type>
            <size>1396</size>
            <attacher name="Justin Haygood">jhaygood</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE5NzE5
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDctMDIt
MTkgIEp1c3RpbiBIYXlnb29kICA8amhheWdvb2RAc3BzdS5lZHU+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBGaXhlcyA8aHR0cDovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MjE+OiBOdW1iZXIudG9FeHBvbmVudGlh
bCBmYWlscyBmb3IgCisgICAgICAgIG5lZ2F0aXZlIG51bWJlcnMuCisKKyAgICAgICAgTG9ncyBv
biBuZWdhdGl2ZSBudW1iZXJzIGRvbid0IHdvcmssIHdoaWNoIHByb2R1Y2VzIGEgTmFOIGluIHRo
aXMgY2FzZS4gQnkgdXNpbmcgdGhlCisgICAgICAgIGFic29sdXRlIHZhbHVlIG9mIHRoZSBuZWdh
dGl2ZSBudW1iZXJzIGFzIHRoZSBpbnB1dCB0byBsb2csIHRoZSBudW1iZXIgb2YgZGlnaXRzIG9m
ICd4JworICAgICAgICBpcyBjYWxjdWxhdGVkIGNvcnJlY3RseSBmb3IgYWxsIHZhbHVlcyBvZiB4
IHRoYXQgZml0IGluIGEgZG91YmxlLgorCQorICAgICAgICAqIGtqcy9udW1iZXJfb2JqZWN0LmNw
cDoKKyAgICAgICAgKE51bWJlclByb3RvRnVuYzo6Y2FsbEFzRnVuY3Rpb24pOgorCiAyMDA3LTAy
LTE4ICBLZXZpbiBPbGxpdmllciAgPGtldmlub0B0aGVvbGxpdmllcnMuY29tPgogCiAgICAgICAg
IFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCkluZGV4OiBranMvbnVtYmVyX29iamVjdC5jcHAKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0ga2pzL251bWJlcl9vYmplY3QuY3BwCShyZXZpc2lvbiAxOTcxOSkKKysrIGtq
cy9udW1iZXJfb2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjU5LDcgKzI1OSw3IEBAIEpT
VmFsdWUgKk51bWJlclByb3RvRnVuYzo6Y2FsbEFzRnVuY3Rpb24KICAgICAgIAogICAgICAgaW50
IGRlY2ltYWxBZGp1c3QgPSAwOwogICAgICAgaWYgKCFmcmFjdGlvbkRpZ2l0cy0+aXNVbmRlZmlu
ZWQoKSkgewotICAgICAgICAgIGRvdWJsZSBsb2d4ID0gZmxvb3IobG9nMTAoeCkpOworICAgICAg
ICAgIGRvdWJsZSBsb2d4ID0gZmxvb3IobG9nMTAoZmFicyh4KSkpOwogICAgICAgICAgIHggLz0g
cG93KDEwLjAsIGxvZ3gpOwogICAgICAgICAgIGRvdWJsZSBmeCA9IGZsb29yKHggKiBwb3coMTAu
MCwgZikpIC8gcG93KDEwLjAsIGYpOwogICAgICAgICAgIGRvdWJsZSBjeCA9IGNlaWwoeCAqIHBv
dygxMC4wLCBmKSkgLyBwb3coMTAuMCwgZik7Cg==
</data>
<flag name="review"
          id="5181"
          type_id="1"
          status="-"
          setter="sam"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>13340</attachid>
            <date>2007-02-22 21:46:34 -0800</date>
            <delta_ts>2007-02-27 23:00:26 -0800</delta_ts>
            <desc>Fixes mathematical error in Number, with LayoutTest</desc>
            <filename>jscorepatch.diff</filename>
            <type>text/plain</type>
            <size>3918</size>
            <attacher name="Justin Haygood">jhaygood</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODIxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDctMDItMjIgIEp1c3RpbiBI
YXlnb29kICA8amhheWdvb2RAZXlld29uZGVyLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEZpeGVzIDxodHRwOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgyMT46IE51bWJlci50b0V4cG9uZW50aWFsIGZhaWxz
IGZvciAKKyAgICAgICAgbmVnYXRpdmUgbnVtYmVycy4KKworICAgICAgICBMb2dzIG9uIG5lZ2F0
aXZlIG51bWJlcnMgZG9uJ3Qgd29yaywgd2hpY2ggcHJvZHVjZXMgYSBOYU4gaW4gdGhpcyBjYXNl
LiBCeSB1c2luZyB0aGUKKyAgICAgICAgYWJzb2x1dGUgdmFsdWUgb2YgdGhlIG5lZ2F0aXZlIG51
bWJlcnMgYXMgdGhlIGlucHV0IHRvIGxvZywgdGhlIG51bWJlciBvZiBkaWdpdHMgb2YgJ3gnCisg
ICAgICAgIGlzIGNhbGN1bGF0ZWQgY29ycmVjdGx5IGZvciBhbGwgdmFsdWVzIG9mIHggdGhhdCBm
aXQgaW4gYSBkb3VibGUuCisJCisgICAgICAgICoga2pzL251bWJlcl9vYmplY3QuY3BwOgorICAg
ICAgICAoTnVtYmVyUHJvdG9GdW5jOjpjYWxsQXNGdW5jdGlvbik6CisKIDIwMDctMDItMjIgIE9z
Y2FyIEN3YWpiYXVtICA8cHVibGljQG9zY2FyYy5uZXQ+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg
TWFjaWVqLgpJbmRleDogSmF2YVNjcmlwdENvcmUva2pzL251bWJlcl9vYmplY3QuY3BwCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2tqcy9udW1iZXJfb2JqZWN0LmNwcAkocmV2aXNpb24g
MTk4MjEpCisrKyBKYXZhU2NyaXB0Q29yZS9ranMvbnVtYmVyX29iamVjdC5jcHAJKHdvcmtpbmcg
Y29weSkKQEAgLTIsNiArMiw4IEBACiAvKgogICogIFRoaXMgZmlsZSBpcyBwYXJ0IG9mIHRoZSBL
REUgbGlicmFyaWVzCiAgKiAgQ29weXJpZ2h0IChDKSAxOTk5LTIwMDAsMjAwMyBIYXJyaSBQb3J0
ZW4gKHBvcnRlbkBrZGUub3JnKQorICogIENvcHlyaWdodCAoQykgMjAwNyBFeWVXb25kZXIsIElu
Yy4gCisgKiAgQ29weXJpZ2h0IChDKSAyMDA3IEp1c3RpbiBIYXlnb29kIDxqaGF5Z29vZEBleWV3
b25kZXIuY29tPgogICoKICAqICBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNh
biByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCiAgKiAgbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBv
ZiB0aGUgR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYwpAQCAtMjU5LDcgKzI2MSw3IEBAIEpTVmFs
dWUgKk51bWJlclByb3RvRnVuYzo6Y2FsbEFzRnVuY3Rpb24KICAgICAgIAogICAgICAgaW50IGRl
Y2ltYWxBZGp1c3QgPSAwOwogICAgICAgaWYgKCFmcmFjdGlvbkRpZ2l0cy0+aXNVbmRlZmluZWQo
KSkgewotICAgICAgICAgIGRvdWJsZSBsb2d4ID0gZmxvb3IobG9nMTAoeCkpOworICAgICAgICAg
IGRvdWJsZSBsb2d4ID0gZmxvb3IobG9nMTAoZmFicyh4KSkpOwogICAgICAgICAgIHggLz0gcG93
KDEwLjAsIGxvZ3gpOwogICAgICAgICAgIGRvdWJsZSBmeCA9IGZsb29yKHggKiBwb3coMTAuMCwg
ZikpIC8gcG93KDEwLjAsIGYpOwogICAgICAgICAgIGRvdWJsZSBjeCA9IGNlaWwoeCAqIHBvdygx
MC4wLCBmKSkgLyBwb3coMTAuMCwgZik7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxOTgyMSkKKysrIExh
eW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDA3
LTAyLTIzICBKdXN0aW4gSGF5Z29vZCAgPHNldCBFTUFJTF9BRERSRVNTIGVudmlyb25tZW50IHZh
cmlhYmxlPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IC0gVGVzdCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MjEK
KyAgICAgICAgLSBOdW1iZXIudG9FeHBvbmVudGlhbCBkb2Vzbid0IHdvcmsgZm9yIG5lZ2F0aXZl
IG51bWJlcnMKKworICAgICAgICAqIGZhc3QvanMvbnVtYmVyLXRvZXhwb25lbnRpYWwuaHRtbDog
QWRkZWQuCisgICAgICAgICogZmFzdC9qcy9yZXNvdXJjZXMvbnVtYmVyLXRvZXhwb25lbnRpYWwu
anM6IEFkZGVkLgorCiAyMDA3LTAyLTIyICBJYW4gRW5nICA8aWFuLmVuZy53ZWJraXRAZ21haWwu
Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llai4KSW5kZXg6IExheW91dFRlc3RzL2Zh
c3QvanMvbnVtYmVyLXRvZXhwb25lbnRpYWwuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0
cy9mYXN0L2pzL251bWJlci10b2V4cG9uZW50aWFsLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlv
dXRUZXN0cy9mYXN0L2pzL251bWJlci10b2V4cG9uZW50aWFsLmh0bWwJKHJldmlzaW9uIDApCkBA
IC0wLDAgKzEsMTMgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwv
L0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9InJlc291
cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL2pzLXRlc3Qt
cHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48
L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvbnVt
YmVyLXRvZXhwb25lbnRpYWwuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9q
cy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0
VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvbnVtYmVyLXRvZXhwb25lbnRpYWwuanMKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvbnVtYmVyLXRvZXhwb25lbnRpYWwu
anMJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9udW1iZXIt
dG9leHBvbmVudGlhbC5qcwkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMiBAQAorZGVzY3JpcHRp
b24oCisgICAgJ1RoaXMgdGVzdCBjaGVja3MgYSBmZXcgTnVtYmVyLnRvRXhwb25lbnRpYWwgY2Fz
ZXMsIGluY2x1ZGluZyAnICsKKyAgICAnPGEgaHJlZj0iaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTI4MjEiPjEyODIxOiBOdW1iZXIudG9FeHBvbmVudGlhbCBkb2VzIG5v
dCB3b3JrIGZvciBuZWdhdGl2ZSBudW1iZXJzPC9hPicgKworICAgICcuJyk7CisKK3Nob3VsZEJl
KCIoMCkudG9FeHBvbmVudGlhbCgwKSIsICInMGUrMCciKTsKK3Nob3VsZEJlKCIoMCkudG9FeHBv
bmVudGlhbCgyKSIsICInMC4wMGUrMCciKTsKK3Nob3VsZEJlKCIoLTEpLnRvRXhwb25lbnRpYWwo
MikiLCAiJy0xLjAwZSswJyIpOworc2hvdWxkQmUoIigtMC4xKS50b0V4cG9uZW50aWFsKDIpIiwg
IictMS4wMGUtMSciKTsKK3Nob3VsZEJlKCIoMC4xKS50b0V4cG9uZW50aWFsKDIpIiwgIicxLjAw
ZS0xJyIpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK
</data>
<flag name="review"
          id="5231"
          type_id="1"
          status="-"
          setter="mjs"
    />
          </attachment>
      

    </bug>

</bugzilla>