128206 2014-02-04 12:58:22 -0800 Rename equalNonNull to equal and make it take const StringImpl& instead 2014-02-04 13:28:07 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue esprehn+autocc gyuyoung.kim oldest_to_newest 976480 0 andersca 2014-02-04 12:58:22 -0800 Rename equalNonNull to equal and make it take const StringImpl& instead 976481 1 223153 andersca 2014-02-04 12:59:10 -0800 Created attachment 223153 Patch 976488 2 andersca 2014-02-04 13:28:07 -0800 Committed r163398: <http://trac.webkit.org/changeset/163398> 223153 2014-02-04 12:59:10 -0800 2014-02-04 13:25:55 -0800 Patch bug-128206-20140204125914.patch text/plain 6606 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDk0ZDgzNzc1ODgwMWU5ZDU1NjQ5YmZl MGI5NjMwM2JhMjk2YjAwZTEuLmExMjFiMDViNjA0YzM0MDM0ZGI2YmE1MGNkMWM5NGY2MzU3YjRk OTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTQtMDItMDQgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KIAorICAgICAgICBSZW5hbWUgZXF1YWxOb25OdWxsIHRvIGVxdWFs IGFuZCBtYWtlIGl0IHRha2UgY29uc3QgU3RyaW5nSW1wbCYgaW5zdGVhZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MjA2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdIYXNo Lmg6CisgICAgICAgIChXVEY6OlN0cmluZ0hhc2g6OmVxdWFsKToKKyAgICAgICAgKiB3dGYvdGV4 dC9TdHJpbmdJbXBsLmNwcDoKKyAgICAgICAgKFdURjo6c3RyaW5nSW1wbENvbnRlbnRFcXVhbCk6 CisgICAgICAgIChXVEY6OmVxdWFsKToKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdJbXBsLmg6 CisKKzIwMTQtMDItMDQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwog ICAgICAgICBHZXQgcmlkIG9mIFN0cmluZ0ltcGw6Om1fYnVmZmVyCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgyMDAKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDNh MTM5YTg5ZjEyNjBiNWZkOTI4NDU3MTU1ZTI3YzdkYjJmNzZmZGQuLjhmMjQyYTczM2Y5NzAyMDA2 NzM3MzkzZGJjZWY1NGE5Nzk5YjMxNDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAx NC0wMi0wNCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAg IFJlbmFtZSBlcXVhbE5vbk51bGwgdG8gZXF1YWwgYW5kIG1ha2UgaXQgdGFrZSBjb25zdCBTdHJp bmdJbXBsJiBpbnN0ZWFkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjgyMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxQYXJzZXJJZGlvbXMuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6dGhyZWFkU2FmZUVxdWFsKToKKyAgICAgICAgKFdlYkNvcmU6OnRocmVhZFNhZmVNYXRj aCk6CisKKzIwMTQtMDItMDQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4K KwogICAgICAgICBSZW5hbWUgU3RyaW5nOjpnZXRDaGFyYWN0ZXJzIHRvIFN0cmluZzo6Y2hhcmFj dGVycwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4 MTk2CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSGFzaC5oIGIvU291 cmNlL1dURi93dGYvdGV4dC9TdHJpbmdIYXNoLmgKaW5kZXggODhiZGQ5MzY5YzIyOTRkMzg3ODc0 OTY1ZjgyMWViMjY4Mzc0M2E2Yy4uZTE2OTJjNzNmZTRjYzZhODcwODJjODYwYTljZGQ5NGI3NWQz OWFlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdIYXNoLmgKKysrIGIv U291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdIYXNoLmgKQEAgLTQ1LDcgKzQ1LDcgQEAgbmFtZXNw YWNlIFdURiB7CiAgICAgICAgIHN0YXRpYyB1bnNpZ25lZCBoYXNoKFN0cmluZ0ltcGwqIGtleSkg eyByZXR1cm4ga2V5LT5oYXNoKCk7IH0KICAgICAgICAgc3RhdGljIGlubGluZSBib29sIGVxdWFs KGNvbnN0IFN0cmluZ0ltcGwqIGEsIGNvbnN0IFN0cmluZ0ltcGwqIGIpCiAgICAgICAgIHsKLSAg ICAgICAgICAgIHJldHVybiBlcXVhbE5vbk51bGwoYSwgYik7CisgICAgICAgICAgICByZXR1cm4g V1RGOjplcXVhbCgqYSwgKmIpOwogICAgICAgICB9CiAKICAgICAgICAgc3RhdGljIHVuc2lnbmVk IGhhc2goY29uc3QgUmVmUHRyPFN0cmluZ0ltcGw+JiBrZXkpIHsgcmV0dXJuIGtleS0+aGFzaCgp OyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwIGIvU291 cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAppbmRleCA5YzI3MmRmYWU4MzdkMGFjZGI5 YWIzM2U5MTA1YWY0ZjhlNTk0ZmFjLi41Mzk2MGI1ZDczYmE5NjMyOTdjNDAxYjNjNjdkNDUzN2Fl ZWViMWZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwCisr KyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAKQEAgLTE3NjksMjQgKzE3Njks MjQgQEAgUGFzc1JlZjxTdHJpbmdJbXBsPiBTdHJpbmdJbXBsOjpyZXBsYWNlKFN0cmluZ0ltcGwq IHBhdHRlcm4sIFN0cmluZ0ltcGwqIHJlcGxhY2UKICAgICByZXR1cm4gbmV3SW1wbDsKIH0KIAot c3RhdGljIGlubGluZSBib29sIHN0cmluZ0ltcGxDb250ZW50RXF1YWwoY29uc3QgU3RyaW5nSW1w bCogYSwgY29uc3QgU3RyaW5nSW1wbCogYikKK3N0YXRpYyBpbmxpbmUgYm9vbCBzdHJpbmdJbXBs Q29udGVudEVxdWFsKGNvbnN0IFN0cmluZ0ltcGwmIGEsIGNvbnN0IFN0cmluZ0ltcGwmIGIpCiB7 Ci0gICAgdW5zaWduZWQgYUxlbmd0aCA9IGEtPmxlbmd0aCgpOwotICAgIHVuc2lnbmVkIGJMZW5n dGggPSBiLT5sZW5ndGgoKTsKKyAgICB1bnNpZ25lZCBhTGVuZ3RoID0gYS5sZW5ndGgoKTsKKyAg ICB1bnNpZ25lZCBiTGVuZ3RoID0gYi5sZW5ndGgoKTsKICAgICBpZiAoYUxlbmd0aCAhPSBiTGVu Z3RoKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBpZiAoYS0+aXM4Qml0KCkpIHsKLSAg ICAgICAgaWYgKGItPmlzOEJpdCgpKQotICAgICAgICAgICAgcmV0dXJuIGVxdWFsKGEtPmNoYXJh Y3RlcnM4KCksIGItPmNoYXJhY3RlcnM4KCksIGFMZW5ndGgpOworICAgIGlmIChhLmlzOEJpdCgp KSB7CisgICAgICAgIGlmIChiLmlzOEJpdCgpKQorICAgICAgICAgICAgcmV0dXJuIGVxdWFsKGEu Y2hhcmFjdGVyczgoKSwgYi5jaGFyYWN0ZXJzOCgpLCBhTGVuZ3RoKTsKIAotICAgICAgICByZXR1 cm4gZXF1YWwoYS0+Y2hhcmFjdGVyczgoKSwgYi0+Y2hhcmFjdGVyczE2KCksIGFMZW5ndGgpOwor ICAgICAgICByZXR1cm4gZXF1YWwoYS5jaGFyYWN0ZXJzOCgpLCBiLmNoYXJhY3RlcnMxNigpLCBh TGVuZ3RoKTsKICAgICB9CiAKLSAgICBpZiAoYi0+aXM4Qml0KCkpCi0gICAgICAgIHJldHVybiBl cXVhbChhLT5jaGFyYWN0ZXJzMTYoKSwgYi0+Y2hhcmFjdGVyczgoKSwgYUxlbmd0aCk7CisgICAg aWYgKGIuaXM4Qml0KCkpCisgICAgICAgIHJldHVybiBlcXVhbChhLmNoYXJhY3RlcnMxNigpLCBi LmNoYXJhY3RlcnM4KCksIGFMZW5ndGgpOwogCi0gICAgcmV0dXJuIGVxdWFsKGEtPmNoYXJhY3Rl cnMxNigpLCBiLT5jaGFyYWN0ZXJzMTYoKSwgYUxlbmd0aCk7CisgICAgcmV0dXJuIGVxdWFsKGEu Y2hhcmFjdGVyczE2KCksIGIuY2hhcmFjdGVyczE2KCksIGFMZW5ndGgpOwogfQogCiBib29sIGVx dWFsKGNvbnN0IFN0cmluZ0ltcGwqIGEsIGNvbnN0IFN0cmluZ0ltcGwqIGIpCkBAIC0xNzk2LDcg KzE3OTYsNyBAQCBib29sIGVxdWFsKGNvbnN0IFN0cmluZ0ltcGwqIGEsIGNvbnN0IFN0cmluZ0lt cGwqIGIpCiAgICAgaWYgKCFhIHx8ICFiKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBy ZXR1cm4gc3RyaW5nSW1wbENvbnRlbnRFcXVhbChhLCBiKTsKKyAgICByZXR1cm4gc3RyaW5nSW1w bENvbnRlbnRFcXVhbCgqYSwgKmIpOwogfQogCiB0ZW1wbGF0ZSA8dHlwZW5hbWUgQ2hhclR5cGU+ CkBAIC0xODU5LDEwICsxODU5LDkgQEAgYm9vbCBlcXVhbChjb25zdCBTdHJpbmdJbXBsKiBhLCBj b25zdCBMQ2hhciogYikKICAgICByZXR1cm4gIWJbbGVuZ3RoXTsKIH0KIAotYm9vbCBlcXVhbE5v bk51bGwoY29uc3QgU3RyaW5nSW1wbCogYSwgY29uc3QgU3RyaW5nSW1wbCogYikKK2Jvb2wgZXF1 YWwoY29uc3QgU3RyaW5nSW1wbCYgYSwgY29uc3QgU3RyaW5nSW1wbCYgYikKIHsKLSAgICBBU1NF UlQoYSAmJiBiKTsKLSAgICBpZiAoYSA9PSBiKQorICAgIGlmICgmYSA9PSAmYikKICAgICAgICAg cmV0dXJuIHRydWU7CiAKICAgICByZXR1cm4gc3RyaW5nSW1wbENvbnRlbnRFcXVhbChhLCBiKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oIGIvU291cmNlL1dU Ri93dGYvdGV4dC9TdHJpbmdJbXBsLmgKaW5kZXggOTIzNDZmMmZhZjZkMGQ3YWIyNzE2YWM5YTNk MGViNWM2ODI1NTAyZi4uOWViZmRjNGMzYzFhNTI0YzYwNTlmZGQ5OTVmMWQ2ODFmYzYyYzAyYiAx MDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmgKKysrIGIvU291cmNl L1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmgKQEAgLTg5NCw3ICs4OTQsNyBAQCBXVEZfRVhQT1JU X1NUUklOR19BUEkgYm9vbCBlcXVhbChjb25zdCBTdHJpbmdJbXBsKiwgY29uc3QgVUNoYXIqLCB1 bnNpZ25lZCk7CiBpbmxpbmUgYm9vbCBlcXVhbChjb25zdCBTdHJpbmdJbXBsKiBhLCBjb25zdCBj aGFyKiBiLCB1bnNpZ25lZCBsZW5ndGgpIHsgcmV0dXJuIGVxdWFsKGEsIHJlaW50ZXJwcmV0X2Nh c3Q8Y29uc3QgTENoYXIqPihiKSwgbGVuZ3RoKTsgfQogaW5saW5lIGJvb2wgZXF1YWwoY29uc3Qg TENoYXIqIGEsIFN0cmluZ0ltcGwqIGIpIHsgcmV0dXJuIGVxdWFsKGIsIGEpOyB9CiBpbmxpbmUg Ym9vbCBlcXVhbChjb25zdCBjaGFyKiBhLCBTdHJpbmdJbXBsKiBiKSB7IHJldHVybiBlcXVhbChi LCByZWludGVycHJldF9jYXN0PGNvbnN0IExDaGFyKj4oYSkpOyB9Ci1XVEZfRVhQT1JUX1NUUklO R19BUEkgYm9vbCBlcXVhbE5vbk51bGwoY29uc3QgU3RyaW5nSW1wbCogYSwgY29uc3QgU3RyaW5n SW1wbCogYik7CitXVEZfRVhQT1JUX1NUUklOR19BUEkgYm9vbCBlcXVhbChjb25zdCBTdHJpbmdJ bXBsJiBhLCBjb25zdCBTdHJpbmdJbXBsJiBiKTsKIAogLy8gRG8gY29tcGFyaXNvbnMgOCBvciA0 IGJ5dGVzLWF0LWEtdGltZSBvbiBhcmNoaXRlY3R1cmVzIHdoZXJlIGl0J3Mgc2FmZS4KICNpZiBD UFUoWDg2XzY0KSB8fCBDUFUoQVJNNjQpCkBAIC0xMzc5LDcgKzEzNzksNiBAQCB0ZW1wbGF0ZTw+ IHN0cnVjdCBEZWZhdWx0SGFzaDxSZWZQdHI8U3RyaW5nSW1wbD4+IHsKIAogdXNpbmcgV1RGOjpT dHJpbmdJbXBsOwogdXNpbmcgV1RGOjplcXVhbDsKLXVzaW5nIFdURjo6ZXF1YWxOb25OdWxsOwog dXNpbmcgV1RGOjpUZXh0Q2FzZVNlbnNpdGl2aXR5OwogdXNpbmcgV1RGOjpUZXh0Q2FzZVNlbnNp dGl2ZTsKIHVzaW5nIFdURjo6VGV4dENhc2VJbnNlbnNpdGl2ZTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxQYXJzZXJJZGlvbXMuY3BwIGIvU291cmNlL1dlYkNv cmUvaHRtbC9wYXJzZXIvSFRNTFBhcnNlcklkaW9tcy5jcHAKaW5kZXggNDNkZDEzY2U0OTUwYmI0 NjJhOTNhNWIyNzA5NTU3NTQzM2QzYTNkZi4uOTQxZTNkN2Q5NDFhZmZjN2IwNTg4NDEzODYwNTVh ZTI1OGYwMWJjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFBh cnNlcklkaW9tcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFBhcnNl cklkaW9tcy5jcHAKQEAgLTI3NiwxOCArMjc2LDE4IEBAIGJvb2wgcGFyc2VIVE1MTm9uTmVnYXRp dmVJbnRlZ2VyKGNvbnN0IFN0cmluZyYgaW5wdXQsIHVuc2lnbmVkJiB2YWx1ZSkKICAgICByZXR1 cm4gcGFyc2VIVE1MTm9uTmVnYXRpdmVJbnRlZ2VySW50ZXJuYWwoc3RhcnQsIHN0YXJ0ICsgbGVu Z3RoLCB2YWx1ZSk7CiB9CiAKLXN0YXRpYyBib29sIHRocmVhZFNhZmVFcXVhbChjb25zdCBTdHJp bmdJbXBsKiBhLCBjb25zdCBTdHJpbmdJbXBsKiBiKQorc3RhdGljIGJvb2wgdGhyZWFkU2FmZUVx dWFsKGNvbnN0IFN0cmluZ0ltcGwmIGEsIGNvbnN0IFN0cmluZ0ltcGwmIGIpCiB7Ci0gICAgaWYg KGEgPT0gYikKKyAgICBpZiAoJmEgPT0gJmIpCiAgICAgICAgIHJldHVybiB0cnVlOwotICAgIGlm IChhLT5oYXNoKCkgIT0gYi0+aGFzaCgpKQorICAgIGlmIChhLmhhc2goKSAhPSBiLmhhc2goKSkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIHJldHVybiBlcXVhbE5vbk51bGwoYSwgYik7Cisg ICAgcmV0dXJuIGVxdWFsKGEsIGIpOwogfQogCiBib29sIHRocmVhZFNhZmVNYXRjaChjb25zdCBR dWFsaWZpZWROYW1lJiBhLCBjb25zdCBRdWFsaWZpZWROYW1lJiBiKQogewotICAgIHJldHVybiB0 aHJlYWRTYWZlRXF1YWwoYS5sb2NhbE5hbWUoKS5pbXBsKCksIGIubG9jYWxOYW1lKCkuaW1wbCgp KTsKKyAgICByZXR1cm4gdGhyZWFkU2FmZUVxdWFsKCphLmxvY2FsTmFtZSgpLmltcGwoKSwgKmIu bG9jYWxOYW1lKCkuaW1wbCgpKTsKIH0KIAogc3RydWN0IEltYWdlV2l0aFNjYWxlIHsK