128202 2014-02-04 12:08:10 -0800 Malloc called beneath MachineThreads::gatherFromOtherThread(), while forbidden 2014-02-05 09:32:20 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 128203 1 mhahnenberg mhahnenberg mitz oldest_to_newest 976469 0 mhahnenberg 2014-02-04 12:08:10 -0800 This will require a data structure that doesn't use FastMalloc to record CodeBlocks during the stack scan. We already have something along these lines: MarkStackArray. It assumes it's only storing JSCells, but we could generalize it to serve more than one purpose. 976608 1 223194 mhahnenberg 2014-02-04 18:35:16 -0800 Created attachment 223194 Patch 976612 2 mhahnenberg 2014-02-04 18:56:50 -0800 <rdar://problem/15980362> 976643 3 223194 ggaren 2014-02-04 20:54:46 -0800 Comment on attachment 223194 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223194&action=review r=me > Source/JavaScriptCore/heap/GCSegmentedArray.h:137 > + if (!m_currentSegment) > + return *this; This should be an ASSERT. It's undefined behavior to ++ past the end of an iterator. 976767 4 mhahnenberg 2014-02-05 09:27:17 -0800 Committed r163450: <http://trac.webkit.org/changeset/163450> 223194 2014-02-04 18:35:16 -0800 2014-02-04 20:54:45 -0800 Patch bug-128202-20140204183456.patch text/plain 7590 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYzNDIxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMzIEBA CisyMDE0LTAyLTA0ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgTWFsbG9jIGNhbGxlZCBiZW5lYXRoIE1hY2hpbmVUaHJlYWRzOjpnYXRoZXJGcm9t T3RoZXJUaHJlYWQoKSwgd2hpbGUgZm9yYmlkZGVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgyMDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIHVzZXMgdGhlIG5ldyBHQ1NlZ21lbnRl ZEFycmF5IHRvIHJlcGxhY2UgdGhlIFZlY3RvciB0aGF0IHdhcyB1c2VkIAorICAgICAgICB0byBy ZWNvcmQgdGhlIHNldCBvZiBjdXJyZW50bHkgZXhlY3V0aW5nIENvZGVCbG9ja3MgZHVyaW5nIHRo ZSBjb25zZXJ2YXRpdmUgCisgICAgICAgIHN0YWNrIHNjYW4uIFRoaXMgaXMgcHJpbWFyaWx5IHRv IGF2b2lkIHRoZSBwb3NzaWJpbGl0eSBvZiB0aGUgVmVjdG9yIHJlc2l6aW5nIAorICAgICAgICB3 aGlsZSBGYXN0TWFsbG9jIGlzIGZvcmJpZGRlbi4KKworICAgICAgICAqIGhlYXAvQmxvY2tBbGxv Y2F0b3IuaDoKKyAgICAgICAgKiBoZWFwL0NvZGVCbG9ja1NldC5jcHA6CisgICAgICAgIChKU0M6 OkNvZGVCbG9ja1NldDo6Q29kZUJsb2NrU2V0KToKKyAgICAgICAgKEpTQzo6Q29kZUJsb2NrU2V0 OjpyZW1lbWJlckN1cnJlbnRseUV4ZWN1dGluZ0NvZGVCbG9ja3MpOgorICAgICAgICAqIGhlYXAv Q29kZUJsb2NrU2V0Lmg6CisgICAgICAgICogaGVhcC9HQ1NlZ21lbnRlZEFycmF5Lmg6CisgICAg ICAgIChKU0M6OkdDU2VnbWVudGVkQXJyYXk6OmJlZ2luKToKKyAgICAgICAgKEpTQzo6R0NTZWdt ZW50ZWRBcnJheTo6ZW5kKToKKyAgICAgICAgKEpTQzo6R0NTZWdtZW50ZWRBcnJheUl0ZXJhdG9y OjpHQ1NlZ21lbnRlZEFycmF5SXRlcmF0b3IpOgorICAgICAgICAoSlNDOjpHQ1NlZ21lbnRlZEFy cmF5SXRlcmF0b3I6OmdldCk6CisgICAgICAgIChKU0M6OkdDU2VnbWVudGVkQXJyYXlJdGVyYXRv cjo6b3BlcmF0b3IqKToKKyAgICAgICAgKEpTQzo6R0NTZWdtZW50ZWRBcnJheUl0ZXJhdG9yOjpv cGVyYXRvci0+KToKKyAgICAgICAgKEpTQzo6R0NTZWdtZW50ZWRBcnJheUl0ZXJhdG9yOjpvcGVy YXRvcj09KToKKyAgICAgICAgKEpTQzo6R0NTZWdtZW50ZWRBcnJheUl0ZXJhdG9yOjpvcGVyYXRv ciE9KToKKyAgICAgICAgKEpTQzo6R0NTZWdtZW50ZWRBcnJheUl0ZXJhdG9yOjpvcGVyYXRvcisr KToKKyAgICAgICAgKiBoZWFwL0hlYXAuY3BwOgorICAgICAgICAoSlNDOjpIZWFwOjpIZWFwKToK KwogMjAxNC0wMi0wNCAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgog CiAgICAgICAgIEZpeCAhRU5BQkxFKEpJVCkgYnVpbGRzIGFmdGVyIHIxNjM0MTgKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0Jsb2NrQWxsb2NhdG9yLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQmxvY2tBbGxvY2F0b3IuaAkocmV2aXNpb24gMTYz NDIxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQmxvY2tBbGxvY2F0b3IuaAkod29y a2luZyBjb3B5KQpAQCAtMzksNiArMzksNyBAQAogbmFtZXNwYWNlIEpTQyB7CiAKIGNsYXNzIEJs b2NrQWxsb2NhdG9yOworY2xhc3MgQ29kZUJsb2NrOwogY2xhc3MgQ29waWVkQmxvY2s7CiBjbGFz cyBDb3B5V29ya0xpc3RTZWdtZW50OwogdGVtcGxhdGUgPHR5cGVuYW1lIFQ+IGNsYXNzIEdDQXJy YXlTZWdtZW50OwpAQCAtMjMzLDYgKzIzNCw3IEBAIFJFR0lPTl9TRVRfRk9SKE1hcmtlZEJsb2Nr LCBtX21hcmtlZFJlZ2kKIFJFR0lPTl9TRVRfRk9SKENvcGllZEJsb2NrLCBtX2NvcGllZFJlZ2lv blNldCk7CiBSRUdJT05fU0VUX0ZPUihXZWFrQmxvY2ssIG1fZm91cktCQmxvY2tSZWdpb25TZXQp OwogUkVHSU9OX1NFVF9GT1IoR0NBcnJheVNlZ21lbnQ8Y29uc3QgSlNDZWxsKj4sIG1fZm91cktC QmxvY2tSZWdpb25TZXQpOworUkVHSU9OX1NFVF9GT1IoR0NBcnJheVNlZ21lbnQ8Q29kZUJsb2Nr Kj4sIG1fZm91cktCQmxvY2tSZWdpb25TZXQpOwogUkVHSU9OX1NFVF9GT1IoQ29weVdvcmtMaXN0 U2VnbWVudCwgbV93b3JrTGlzdFJlZ2lvblNldCk7CiBSRUdJT05fU0VUX0ZPUihIYW5kbGVCbG9j aywgbV9mb3VyS0JCbG9ja1JlZ2lvblNldCk7CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9oZWFwL0NvZGVCbG9ja1NldC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2hlYXAvQ29kZUJsb2NrU2V0LmNwcAkocmV2aXNpb24gMTYzNDIxKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvQ29kZUJsb2NrU2V0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzMs NyArMzMsMTAgQEAgbmFtZXNwYWNlIEpTQyB7CiAKIHN0YXRpYyBjb25zdCBib29sIHZlcmJvc2Ug PSBmYWxzZTsKIAotQ29kZUJsb2NrU2V0OjpDb2RlQmxvY2tTZXQoKSB7IH0KK0NvZGVCbG9ja1Nl dDo6Q29kZUJsb2NrU2V0KEJsb2NrQWxsb2NhdG9yJiBibG9ja0FsbG9jYXRvcikKKyAgICA6IG1f Y3VycmVudGx5RXhlY3V0aW5nKGJsb2NrQWxsb2NhdG9yKQoreworfQogCiBDb2RlQmxvY2tTZXQ6 On5Db2RlQmxvY2tTZXQoKQogewpAQCAtMTA5LDggKzExMiw4IEBAIHZvaWQgQ29kZUJsb2NrU2V0 Ojp0cmFjZU1hcmtlZChTbG90VmlzaXQKIHZvaWQgQ29kZUJsb2NrU2V0OjpyZW1lbWJlckN1cnJl bnRseUV4ZWN1dGluZ0NvZGVCbG9ja3MoSGVhcCogaGVhcCkKIHsKICNpZiBFTkFCTEUoR0dDKQot ICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbV9jdXJyZW50bHlFeGVjdXRpbmcuc2l6ZSgpOyAr K2kpCi0gICAgICAgIGhlYXAtPmFkZFRvUmVtZW1iZXJlZFNldChtX2N1cnJlbnRseUV4ZWN1dGlu Z1tpXS0+b3duZXJFeGVjdXRhYmxlKCkpOworICAgIGZvciAoQ29kZUJsb2NrKiBjb2RlQmxvY2sg OiBtX2N1cnJlbnRseUV4ZWN1dGluZykKKyAgICAgICAgaGVhcC0+YWRkVG9SZW1lbWJlcmVkU2V0 KGNvZGVCbG9jay0+b3duZXJFeGVjdXRhYmxlKCkpOwogICAgIG1fY3VycmVudGx5RXhlY3V0aW5n LmNsZWFyKCk7CiAjZWxzZQogICAgIFVOVVNFRF9QQVJBTShoZWFwKTsKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9oZWFwL0NvZGVCbG9ja1NldC5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9oZWFwL0NvZGVCbG9ja1NldC5oCShyZXZpc2lvbiAxNjM0MjEpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db2RlQmxvY2tTZXQuaAkod29ya2luZyBjb3B5KQpA QCAtMjYsMTQgKzI2LDE1IEBACiAjaWZuZGVmIENvZGVCbG9ja1NldF9oCiAjZGVmaW5lIENvZGVC bG9ja1NldF9oCiAKKyNpbmNsdWRlICJHQ1NlZ21lbnRlZEFycmF5LmgiCiAjaW5jbHVkZSA8d3Rm L0hhc2hTZXQuaD4KICNpbmNsdWRlIDx3dGYvTm9uY29weWFibGUuaD4KICNpbmNsdWRlIDx3dGYv UGFzc1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KLSNpbmNsdWRlIDx3dGYvVmVj dG9yLmg+CiAKIG5hbWVzcGFjZSBKU0MgewogCitjbGFzcyBCbG9ja0FsbG9jYXRvcjsKIGNsYXNz IENvZGVCbG9jazsKIGNsYXNzIEhlYXA7CiBjbGFzcyBTbG90VmlzaXRvcjsKQEAgLTQ2LDcgKzQ3 LDcgQEAgY2xhc3MgQ29kZUJsb2NrU2V0IHsKICAgICBXVEZfTUFLRV9OT05DT1BZQUJMRShDb2Rl QmxvY2tTZXQpOwogCiBwdWJsaWM6Ci0gICAgQ29kZUJsb2NrU2V0KCk7CisgICAgQ29kZUJsb2Nr U2V0KEJsb2NrQWxsb2NhdG9yJik7CiAgICAgfkNvZGVCbG9ja1NldCgpOwogICAgIAogICAgIC8v IEFkZCBhIENvZGVCbG9jay4gVGhpcyBpcyBvbmx5IGNhbGxlZCBieSBDb2RlQmxvY2sgY29uc3Ry dWN0b3JzLgpAQCAtODgsNyArODksNyBAQCBwcml2YXRlOgogICAgIC8vIGFyYml0cmFyeSBib2d1 cyBwb2ludGVycy4gSSBjb3VsZCBoYXZlIHdyaXR0ZW4gYSB0aGluZ3kgdGhhdCBoYWQgcGVlayB0 eXBlcwogICAgIC8vIGFuZCBhbGwsIGJ1dCB0aGF0IHNlZW1lZCBsaWtlIG92ZXJraWxsLgogICAg IEhhc2hTZXQ8Q29kZUJsb2NrKiA+IG1fc2V0OwotICAgIFZlY3RvcjxDb2RlQmxvY2sqPiBtX2N1 cnJlbnRseUV4ZWN1dGluZzsKKyAgICBHQ1NlZ21lbnRlZEFycmF5PENvZGVCbG9jayo+IG1fY3Vy cmVudGx5RXhlY3V0aW5nOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgSlNDCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaGVhcC9HQ1NlZ21lbnRlZEFycmF5LmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvR0NTZWdtZW50ZWRBcnJheS5oCShyZXZpc2lvbiAxNjM0 MjEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9HQ1NlZ21lbnRlZEFycmF5LmgJKHdv cmtpbmcgY29weSkKQEAgLTU5LDggKzU5LDExIEBAIHB1YmxpYzoKICNlbmRpZgogfTsKIAordGVt cGxhdGUgPHR5cGVuYW1lIFQ+IGNsYXNzIEdDU2VnbWVudGVkQXJyYXlJdGVyYXRvcjsKKwogdGVt cGxhdGUgPHR5cGVuYW1lIFQ+CiBjbGFzcyBHQ1NlZ21lbnRlZEFycmF5IHsKKyAgICBmcmllbmQg Y2xhc3MgR0NTZWdtZW50ZWRBcnJheUl0ZXJhdG9yPFQ+OwogcHVibGljOgogICAgIEdDU2VnbWVu dGVkQXJyYXkoQmxvY2tBbGxvY2F0b3ImKTsKICAgICB+R0NTZWdtZW50ZWRBcnJheSgpOwpAQCAt NzcsNiArODAsMTAgQEAgcHVibGljOgogICAgIHZvaWQgZmlsbFZlY3RvcihWZWN0b3I8VD4mKTsK ICAgICB2b2lkIGNsZWFyKCk7CiAKKyAgICB0eXBlZGVmIEdDU2VnbWVudGVkQXJyYXlJdGVyYXRv cjxUPiBpdGVyYXRvcjsKKyAgICBpdGVyYXRvciBiZWdpbigpIHsgcmV0dXJuIEdDU2VnbWVudGVk QXJyYXlJdGVyYXRvcjxUPihtX3NlZ21lbnRzLmhlYWQoKSwgbV90b3ApOyB9CisgICAgaXRlcmF0 b3IgZW5kKCkgeyByZXR1cm4gR0NTZWdtZW50ZWRBcnJheUl0ZXJhdG9yPFQ+KCk7IH0KKwogcHJv dGVjdGVkOgogICAgIHRlbXBsYXRlIDxzaXplX3Qgc2l6ZT4gc3RydWN0IENhcGFjaXR5RnJvbVNp emUgewogICAgICAgICBzdGF0aWMgY29uc3Qgc2l6ZV90IHZhbHVlID0gKHNpemUgLSBzaXplb2Yo R0NBcnJheVNlZ21lbnQ8VD4pKSAvIHNpemVvZihUKTsKQEAgLTEwMCw2ICsxMDcsNjEgQEAgcHJv dGVjdGVkOgogICAgIHNpemVfdCBtX251bWJlck9mU2VnbWVudHM7CiB9OwogCit0ZW1wbGF0ZSA8 dHlwZW5hbWUgVD4KK2NsYXNzIEdDU2VnbWVudGVkQXJyYXlJdGVyYXRvciB7CisgICAgZnJpZW5k IGNsYXNzIEdDU2VnbWVudGVkQXJyYXk8VD47CitwdWJsaWM6CisgICAgR0NTZWdtZW50ZWRBcnJh eUl0ZXJhdG9yKCkKKyAgICAgICAgOiBtX2N1cnJlbnRTZWdtZW50KDApCisgICAgICAgICwgbV9j dXJyZW50T2Zmc2V0KDApCisgICAgeworICAgIH0KKworICAgIFQmIGdldCgpIHsgcmV0dXJuIG1f Y3VycmVudFNlZ21lbnQtPmRhdGEoKVttX2N1cnJlbnRPZmZzZXRdOyB9CisgICAgVCYgb3BlcmF0 b3IqKCkgeyByZXR1cm4gZ2V0KCk7IH0KKyAgICBUJiBvcGVyYXRvci0+KCkgeyByZXR1cm4gZ2V0 KCk7IH0KKworICAgIGJvb2wgb3BlcmF0b3I9PShjb25zdCBHQ1NlZ21lbnRlZEFycmF5SXRlcmF0 b3ImIG90aGVyKQorICAgIHsKKyAgICAgICAgcmV0dXJuIG1fY3VycmVudFNlZ21lbnQgPT0gb3Ro ZXIubV9jdXJyZW50U2VnbWVudCAmJiBtX2N1cnJlbnRPZmZzZXQgPT0gb3RoZXIubV9jdXJyZW50 T2Zmc2V0OworICAgIH0KKworICAgIGJvb2wgb3BlcmF0b3IhPShjb25zdCBHQ1NlZ21lbnRlZEFy cmF5SXRlcmF0b3ImIG90aGVyKQorICAgIHsKKyAgICAgICAgcmV0dXJuICEoKnRoaXMgPT0gb3Ro ZXIpOworICAgIH0KKworICAgIEdDU2VnbWVudGVkQXJyYXlJdGVyYXRvciYgb3BlcmF0b3IrKygp CisgICAgeworICAgICAgICBpZiAoIW1fY3VycmVudFNlZ21lbnQpCisgICAgICAgICAgICByZXR1 cm4gKnRoaXM7CisKKyAgICAgICAgbV9jdXJyZW50T2Zmc2V0Kys7CisKKyAgICAgICAgaWYgKG1f Y3VycmVudE9mZnNldCA+PSBtX29mZnNldExpbWl0KSB7CisgICAgICAgICAgICBtX2N1cnJlbnRT ZWdtZW50ID0gbV9jdXJyZW50U2VnbWVudC0+bmV4dCgpOworICAgICAgICAgICAgbV9jdXJyZW50 T2Zmc2V0ID0gMDsKKyAgICAgICAgICAgIG1fb2Zmc2V0TGltaXQgPSBHQ1NlZ21lbnRlZEFycmF5 PFQ+OjpzX3NlZ21lbnRDYXBhY2l0eTsKKyAgICAgICAgfQorCisgICAgICAgIHJldHVybiAqdGhp czsKKyAgICB9CisKK3ByaXZhdGU6CisgICAgR0NTZWdtZW50ZWRBcnJheUl0ZXJhdG9yKEdDQXJy YXlTZWdtZW50PFQ+KiBzdGFydCwgc2l6ZV90IHRvcCkKKyAgICAgICAgOiBtX2N1cnJlbnRTZWdt ZW50KHN0YXJ0KQorICAgICAgICAsIG1fY3VycmVudE9mZnNldCgwKQorICAgICAgICAsIG1fb2Zm c2V0TGltaXQodG9wKQorICAgIHsKKyAgICAgICAgaWYgKCFtX29mZnNldExpbWl0KQorICAgICAg ICAgICAgbV9jdXJyZW50U2VnbWVudCA9IG51bGxwdHI7CisgICAgfQorCisgICAgR0NBcnJheVNl Z21lbnQ8VD4qIG1fY3VycmVudFNlZ21lbnQ7CisgICAgc2l6ZV90IG1fY3VycmVudE9mZnNldDsK KyAgICBzaXplX3QgbV9vZmZzZXRMaW1pdDsKK307CisKIH0gLy8gbmFtZXNwYWNlIEpTQwogCiAj ZW5kaWYgLy8gR0NTZWdtZW50ZWRBcnJheV9oCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9IZWFwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9I ZWFwLmNwcAkocmV2aXNpb24gMTYzNDIxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAv SGVhcC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI3MCw2ICsyNzAsNyBAQCBIZWFwOjpIZWFwKFZN KiB2bSwgSGVhcFR5cGUgaGVhcFR5cGUpCiAgICAgLCBtX3Nsb3RWaXNpdG9yKG1fc2hhcmVkRGF0 YSkKICAgICAsIG1fY29weVZpc2l0b3IobV9zaGFyZWREYXRhKQogICAgICwgbV9oYW5kbGVTZXQo dm0pCisgICAgLCBtX2NvZGVCbG9ja3MobV9ibG9ja0FsbG9jYXRvcikKICAgICAsIG1faXNTYWZl VG9Db2xsZWN0KGZhbHNlKQogICAgICwgbV93cml0ZUJhcnJpZXJCdWZmZXIoMjU2KQogICAgICwg bV92bSh2bSkK