128201 2014-02-04 11:50:12 -0800 webKitCookieStorageCopyRequestHeaderFieldsForURL builds an empty Cookie header when there are no cookies 2014-02-04 15:29:08 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap beidson commit-queue jer.noble oldest_to_newest 976465 0 ap 2014-02-04 11:50:12 -0800 On platforms that use our webKitCookieStorageCopyRequestHeaderFieldsForURL shim, we fail two regression tests: http/tests/navigation/ping-same-origin.html http/tests/navigation/ping-cross-origin.html This is because we send an empty Cookie header. We shouldn't send one when there are no cookies. 976466 1 223150 ap 2014-02-04 11:52:20 -0800 Created attachment 223150 proposed fix 976506 2 223150 sam 2014-02-04 14:27:38 -0800 Comment on attachment 223150 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=223150&action=review > Source/WebKit2/Shared/mac/CookieStorageShim.mm:64 > + if (cookies.isNull()) I think we usually do if (!cookies) 976535 3 223150 commit-queue 2014-02-04 15:29:06 -0800 Comment on attachment 223150 proposed fix Clearing flags on attachment: 223150 Committed r163409: <http://trac.webkit.org/changeset/163409> 976536 4 commit-queue 2014-02-04 15:29:08 -0800 All reviewed patches have been landed. Closing bug. 223150 2014-02-04 11:52:20 -0800 2014-02-04 15:29:06 -0800 proposed fix EmptyCookie.txt text/plain 1694 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzM5NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAyLTA0ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIHdlYktpdENvb2tpZVN0b3Jh Z2VDb3B5UmVxdWVzdEhlYWRlckZpZWxkc0ZvclVSTCBidWlsZHMgYW4gZW1wdHkgQ29va2llIGhl YWRlciB3aGVuIHRoZXJlIGFyZSBubyBjb29raWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgyMDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9tYWMvQ29va2llU3RvcmFnZVNoaW0ubW06 IChXZWJLaXQ6OndlYktpdENvb2tpZVN0b3JhZ2VDb3B5UmVxdWVzdEhlYWRlckZpZWxkc0ZvclVS TCk6CisgICAgICAgIFJldHVybiBudWxsIHdoZW4gTmV0d29ya1Byb2Nlc3MgcHJvdmlkZWQgYSBu dWxsIHN0cmluZywgZG9uJ3QgYnVpbGQgYSBoZWFkZXIgZGljdGlvbmFyeQorICAgICAgICB3aXRo IGFuIGVtcHR5IENvb2tpZSB2YWx1ZS4KKwogMjAxNC0wMi0wNCAgRW5yaWNhIENhc3VjY2kgIDxl bnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFdLMjogU2VsZWN0aW9uIGNhbGxvdXQgYmFyIGRv ZXMgbm90IHNjcm9sbCB3aXRoIHRoZSBzZWxlY3Rpb24uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9T aGFyZWQvbWFjL0Nvb2tpZVN0b3JhZ2VTaGltLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1NoYXJlZC9tYWMvQ29va2llU3RvcmFnZVNoaW0ubW0JKHJldmlzaW9uIDE2MzMxMikKKysr IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvQ29va2llU3RvcmFnZVNoaW0ubW0JKHdvcmtpbmcg Y29weSkKQEAgLTYxLDYgKzYxLDkgQEAgc3RhdGljIENGRGljdGlvbmFyeVJlZiB3ZWJLaXRDb29r aWVTdG9yYQogICAgIGlmICghV2ViUHJvY2Vzczo6c2hhcmVkKCkubmV0d29ya0Nvbm5lY3Rpb24o KS0+Y29ubmVjdGlvbigpLT5zZW5kU3luYyhNZXNzYWdlczo6TmV0d29ya0Nvbm5lY3Rpb25Ub1dl YlByb2Nlc3M6OkNvb2tpZVJlcXVlc3RIZWFkZXJGaWVsZFZhbHVlKFNlc3Npb25UcmFja2VyOjpk ZWZhdWx0U2Vzc2lvbklELCBmaXJzdFBhcnR5Rm9yQ29va2llc1VSTCwgaW5SZXF1ZXN0VVJMKSwg TWVzc2FnZXM6Ok5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpDb29raWVzRm9yRE9NOjpS ZXBseShjb29raWVzKSwgMCkpCiAgICAgICAgIHJldHVybiAwOwogCisgICAgaWYgKGNvb2tpZXMu aXNOdWxsKCkpCisgICAgICAgIHJldHVybiAwOworCiAgICAgUmV0YWluUHRyPENGU3RyaW5nUmVm PiBjZkNvb2tpZXMgPSBjb29raWVzLmNyZWF0ZUNGU3RyaW5nKCk7CiAgICAgc3RhdGljIGNvbnN0 IHZvaWQqIGNvb2tpZUtleXNbXSA9IHsgQ0ZTVFIoIkNvb2tpZSIpIH07CiAgICAgY29uc3Qgdm9p ZCogY29va2llVmFsdWVzW10gPSB7IGNmQ29va2llcy5nZXQoKSB9Owo=