128200 2014-02-04 11:34:01 -0800 Get rid of StringImpl::m_buffer 2014-02-04 12:25:29 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue oldest_to_newest 976460 0 andersca 2014-02-04 11:34:01 -0800 Get rid of StringImpl::m_buffer 976461 1 223147 andersca 2014-02-04 11:35:53 -0800 Created attachment 223147 Patch 976472 2 andersca 2014-02-04 12:25:29 -0800 Committed r163396: <http://trac.webkit.org/changeset/163396> 223147 2014-02-04 11:35:53 -0800 2014-02-04 11:39:52 -0800 Patch bug-128200-20140204113557.patch text/plain 5453 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDA1YzQyYzAwMjIxOTI1MGI1YzMzNGFl MzM5ODY0MTU3Y2E4MDk5NzguLmJmYzZhNWVlNjE0M2FkYjE2MmMxMmQ5ODAzYWMzMTk3ZmIzMDM4 N2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTQtMDItMDQgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBHZXQgcmlkIG9mIFN0cmluZ0ltcGw6Om1fYnVm ZmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgy MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUcmFk ZSBvbmUgbG91c3kgaGFjayBmb3IgYW5vdGhlciBieSBjaGFuZ2luZyB0aGUgQ3JlYXRlRW1wdHlV bmlxdWUgU3RyaW5nSW1wbAorICAgICAgICBjb25zdHJ1Y3RvciB0byBpbml0aWFsaXplIGl0cyBj aGFyYWN0ZXIgYnVmZmVyIHRvIHBvaW50IHRvIG1fbGVuZ3RoIGluc3RlYWQKKyAgICAgICAgc2lu Y2UgaXQgd2lsbCBhbHdheXMgYmUgbnVsbC4KKworICAgICAgICBBbHNvIGNoYW5nZSBpdCB0byBi ZSBhbiA4LWJpdCBzdHJpbmcgYmVjYXVzZSB3aHkgbm90LgorCisgICAgICAgICogd3RmL3RleHQv U3RyaW5nSW1wbC5oOgorICAgICAgICAoV1RGOjpTdHJpbmdJbXBsOjpTdHJpbmdJbXBsKToKKwog MjAxNC0wMi0wMyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAg ICAgIEZpeCBXaW5kb3dzIGJ1aWxkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9T dHJpbmdJbXBsLmggYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaAppbmRleCA0MDI0 ZTZiMWEwMzU0YmEwYjgzOWRkMmEzY2ExOWJjNjcxMDFmMGYwLi45MjM0NmYyZmFmNmQwZDdhYjI3 MTZhYzlhM2QwZWI1YzY4MjU1MDJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0 cmluZ0ltcGwuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaApAQCAtMTYy LDcgKzE2Miw2IEBAIHByaXZhdGU6CiAgICAgICAgIDogbV9yZWZDb3VudChzX3JlZkNvdW50Rmxh Z0lzU3RhdGljU3RyaW5nKQogICAgICAgICAsIG1fbGVuZ3RoKGxlbmd0aCkKICAgICAgICAgLCBt X2RhdGExNihjaGFyYWN0ZXJzKQotICAgICAgICAsIG1fYnVmZmVyKDApCiAgICAgICAgICwgbV9o YXNoQW5kRmxhZ3Moc19oYXNoRmxhZ0lzSWRlbnRpZmllciB8IEJ1ZmZlck93bmVkKQogICAgIHsK ICAgICAgICAgLy8gRW5zdXJlIHRoYXQgdGhlIGhhc2ggaXMgY29tcHV0ZWQgc28gdGhhdCBBdG9t aWNTdHJpbmdIYXNoIGNhbiBjYWxsIGV4aXN0aW5nSGFzaCgpCkBAIC0xODAsNyArMTc5LDYgQEAg cHJpdmF0ZToKICAgICAgICAgOiBtX3JlZkNvdW50KHNfcmVmQ291bnRGbGFnSXNTdGF0aWNTdHJp bmcpCiAgICAgICAgICwgbV9sZW5ndGgobGVuZ3RoKQogICAgICAgICAsIG1fZGF0YTgoY2hhcmFj dGVycykKLSAgICAgICAgLCBtX2J1ZmZlcigwKQogICAgICAgICAsIG1faGFzaEFuZEZsYWdzKHNf aGFzaEZsYWc4Qml0QnVmZmVyIHwgc19oYXNoRmxhZ0lzSWRlbnRpZmllciB8IEJ1ZmZlck93bmVk KQogICAgIHsKICAgICAgICAgLy8gRW5zdXJlIHRoYXQgdGhlIGhhc2ggaXMgY29tcHV0ZWQgc28g dGhhdCBBdG9taWNTdHJpbmdIYXNoIGNhbiBjYWxsIGV4aXN0aW5nSGFzaCgpCkBAIC0xOTgsNyAr MTk2LDYgQEAgcHJpdmF0ZToKICAgICAgICAgOiBtX3JlZkNvdW50KHNfcmVmQ291bnRJbmNyZW1l bnQpCiAgICAgICAgICwgbV9sZW5ndGgobGVuZ3RoKQogICAgICAgICAsIG1fZGF0YTgodGFpbFBv aW50ZXI8TENoYXI+KCkpCi0gICAgICAgICwgbV9idWZmZXIoMCkKICAgICAgICAgLCBtX2hhc2hB bmRGbGFncyhzX2hhc2hGbGFnOEJpdEJ1ZmZlciB8IEJ1ZmZlckludGVybmFsKQogICAgIHsKICAg ICAgICAgQVNTRVJUKG1fZGF0YTgpOwpAQCAtMjEyLDcgKzIwOSw2IEBAIHByaXZhdGU6CiAgICAg ICAgIDogbV9yZWZDb3VudChzX3JlZkNvdW50SW5jcmVtZW50KQogICAgICAgICAsIG1fbGVuZ3Ro KGxlbmd0aCkKICAgICAgICAgLCBtX2RhdGExNih0YWlsUG9pbnRlcjxVQ2hhcj4oKSkKLSAgICAg ICAgLCBtX2J1ZmZlcigwKQogICAgICAgICAsIG1faGFzaEFuZEZsYWdzKEJ1ZmZlckludGVybmFs KQogICAgIHsKICAgICAgICAgQVNTRVJUKG1fZGF0YTE2KTsKQEAgLTIyNiw3ICsyMjIsNiBAQCBw cml2YXRlOgogICAgICAgICA6IG1fcmVmQ291bnQoc19yZWZDb3VudEluY3JlbWVudCkKICAgICAg ICAgLCBtX2xlbmd0aChsZW5ndGgpCiAgICAgICAgICwgbV9kYXRhOChjaGFyYWN0ZXJzLmxlYWtQ dHIoKSkKLSAgICAgICAgLCBtX2J1ZmZlcigwKQogICAgICAgICAsIG1faGFzaEFuZEZsYWdzKHNf aGFzaEZsYWc4Qml0QnVmZmVyIHwgQnVmZmVyT3duZWQpCiAgICAgewogICAgICAgICBBU1NFUlQo bV9kYXRhOCk7CkBAIC0yNDAsNyArMjM1LDYgQEAgcHJpdmF0ZToKICAgICAgICAgOiBtX3JlZkNv dW50KHNfcmVmQ291bnRJbmNyZW1lbnQpCiAgICAgICAgICwgbV9sZW5ndGgobGVuZ3RoKQogICAg ICAgICAsIG1fZGF0YTE2KGNoYXJhY3RlcnMpCi0gICAgICAgICwgbV9idWZmZXIoMCkKICAgICAg ICAgLCBtX2hhc2hBbmRGbGFncyhCdWZmZXJJbnRlcm5hbCkKICAgICB7CiAgICAgICAgIEFTU0VS VChtX2RhdGExNik7CkBAIC0yNTMsNyArMjQ3LDYgQEAgcHJpdmF0ZToKICAgICAgICAgOiBtX3Jl ZkNvdW50KHNfcmVmQ291bnRJbmNyZW1lbnQpCiAgICAgICAgICwgbV9sZW5ndGgobGVuZ3RoKQog ICAgICAgICAsIG1fZGF0YTgoY2hhcmFjdGVycykKLSAgICAgICAgLCBtX2J1ZmZlcigwKQogICAg ICAgICAsIG1faGFzaEFuZEZsYWdzKHNfaGFzaEZsYWc4Qml0QnVmZmVyIHwgQnVmZmVySW50ZXJu YWwpCiAgICAgewogICAgICAgICBBU1NFUlQobV9kYXRhOCk7CkBAIC0yNjcsNyArMjYwLDYgQEAg cHJpdmF0ZToKICAgICAgICAgOiBtX3JlZkNvdW50KHNfcmVmQ291bnRJbmNyZW1lbnQpCiAgICAg ICAgICwgbV9sZW5ndGgobGVuZ3RoKQogICAgICAgICAsIG1fZGF0YTE2KGNoYXJhY3RlcnMubGVh a1B0cigpKQotICAgICAgICAsIG1fYnVmZmVyKDApCiAgICAgICAgICwgbV9oYXNoQW5kRmxhZ3Mo QnVmZmVyT3duZWQpCiAgICAgewogICAgICAgICBBU1NFUlQobV9kYXRhMTYpOwpAQCAtMzA4LDE2 ICszMDAsMTUgQEAgcHJpdmF0ZToKICAgICAgICAgU1RSSU5HX1NUQVRTX0FERF8xNkJJVF9TVFJJ TkcyKG1fbGVuZ3RoLCB0cnVlKTsKICAgICB9CiAKLSAgICBlbnVtIENyZWF0ZUVtcHR5VW5pcXVl X1QgeyBDcmVhdGVFbXB0eVVuaXF1ZSB9OwotICAgIFN0cmluZ0ltcGwoQ3JlYXRlRW1wdHlVbmlx dWVfVCkKKyAgICBlbnVtIENyZWF0ZUVtcHR5VW5pcXVlVGFnIHsgQ3JlYXRlRW1wdHlVbmlxdWUg fTsKKyAgICBTdHJpbmdJbXBsKENyZWF0ZUVtcHR5VW5pcXVlVGFnKQogICAgICAgICA6IG1fcmVm Q291bnQoc19yZWZDb3VudEluY3JlbWVudCkKICAgICAgICAgLCBtX2xlbmd0aCgwKQotICAgICAg ICAvLyBXZSBleHBlY3QgbV9idWZmZXIgdG8gYmUgaW5pdGlhbGl6ZWQgdG8gMCBhcyB3ZSB1c2Ug aXQKKyAgICAgICAgLy8gV2UgZXhwZWN0IG1fbGVuZ3RoIHRvIGJlIGluaXRpYWxpemVkIHRvIDAg YXMgd2UgdXNlIGl0CiAgICAgICAgIC8vIHRvIHJlcHJlc2VudCBhIG51bGwgdGVybWluYXRlZCBi dWZmZXIuCi0gICAgICAgICwgbV9kYXRhMTYocmVpbnRlcnByZXRfY2FzdDxjb25zdCBVQ2hhcio+ KCZtX2J1ZmZlcikpCi0gICAgICAgICwgbV9idWZmZXIoMCkKKyAgICAgICAgLCBtX2RhdGE4KHJl aW50ZXJwcmV0X2Nhc3Q8Y29uc3QgTENoYXIqPigmbV9sZW5ndGgpKQogICAgIHsKLSAgICAgICAg QVNTRVJUKG1fZGF0YTE2KTsKKyAgICAgICAgQVNTRVJUKG1fZGF0YTgpOwogICAgICAgICAvLyBT ZXQgdGhlIGhhc2ggZWFybHksIHNvIHRoYXQgYWxsIGVtcHR5IHVuaXF1ZSBTdHJpbmdJbXBscyBo YXZlIGEgaGFzaCwKICAgICAgICAgLy8gYW5kIGRvbid0IHVzZSB0aGUgbm9ybWFsIGhhc2hpbmcg YWxnb3JpdGhtIC0gdGhlIHVuaXF1ZSBuYXR1cmUgb2YgdGhlc2UKICAgICAgICAgLy8ga2V5cyBt ZWFucyB0aGF0IHdlIGRvbid0IG5lZWQgdGhlbSB0byBtYXRjaCBhbnkgb3RoZXIgc3RyaW5nIChp biBmYWN0LApAQCAtMzI3LDkgKzMxOCw5IEBAIHByaXZhdGU6CiAgICAgICAgIGhhc2ggPDw9IHNf ZmxhZ0NvdW50OwogICAgICAgICBpZiAoIWhhc2gpCiAgICAgICAgICAgICBoYXNoID0gMSA8PCBz X2ZsYWdDb3VudDsKLSAgICAgICAgbV9oYXNoQW5kRmxhZ3MgPSBoYXNoIHwgQnVmZmVySW50ZXJu YWw7CisgICAgICAgIG1faGFzaEFuZEZsYWdzID0gaGFzaCB8IEJ1ZmZlckludGVybmFsIHwgc19o YXNoRmxhZzhCaXRCdWZmZXI7CiAKLSAgICAgICAgU1RSSU5HX1NUQVRTX0FERF8xNkJJVF9TVFJJ TkcobV9sZW5ndGgpOworICAgICAgICBTVFJJTkdfU1RBVFNfQUREXzhCSVRfU1RSSU5HKG1fbGVu Z3RoKTsKICAgICB9CiAKICAgICB+U3RyaW5nSW1wbCgpOwpAQCAtODM4LDcgKzgyOSw3IEBAIHB1 YmxpYzoKICAgICAgICAgdW5zaWduZWQgbV9yZWZDb3VudDsKICAgICAgICAgdW5zaWduZWQgbV9s ZW5ndGg7CiAgICAgICAgIGNvbnN0IExDaGFyKiBtX2RhdGE4OwotICAgICAgICB2b2lkKiBtX2J1 ZmZlcjsKKyAgICAgICAgbXV0YWJsZSBVQ2hhciogbV9jb3B5RGF0YTE2OwogICAgICAgICB1bnNp Z25lZCBtX2hhc2hBbmRGbGFnczsKIAogICAgICAgICAvLyBUaGVzZSB2YWx1ZXMgbWltaWMgQ29u c3RydWN0RnJvbUxpdGVyYWwuCkBAIC04NjQsMTQgKzg1NSwxMyBAQCBwcml2YXRlOgogICAgICAg ICBjb25zdCBVQ2hhciogbV9kYXRhMTY7CiAgICAgfTsKICAgICB1bmlvbiB7Ci0gICAgICAgIHZv aWQqIG1fYnVmZmVyOwogICAgICAgICBTdHJpbmdJbXBsKiBtX3N1YnN0cmluZ0J1ZmZlcjsKICAg ICAgICAgbXV0YWJsZSBVQ2hhciogbV9jb3B5RGF0YTE2OwogICAgIH07CiAgICAgbXV0YWJsZSB1 bnNpZ25lZCBtX2hhc2hBbmRGbGFnczsKIH07CiAKLUNPTVBJTEVfQVNTRVJUKHNpemVvZihTdHJp bmdJbXBsKSA9PSBzaXplb2YoU3RyaW5nSW1wbDo6U3RhdGljQVNDSUlMaXRlcmFsKSwgU3RyaW5n SW1wbF9zaG91bGRfbWF0Y2hfaXRzX1N0YXRpY0FTQ0lJTGl0ZXJhbCk7CitzdGF0aWNfYXNzZXJ0 KHNpemVvZihTdHJpbmdJbXBsKSA9PSBzaXplb2YoU3RyaW5nSW1wbDo6U3RhdGljQVNDSUlMaXRl cmFsKSwgIiIpOwogCiAjaWYgIUFTU0VSVF9ESVNBQkxFRAogLy8gU3RyaW5nSW1wbHMgY3JlYXRl ZCBmcm9tIFN0YXRpY0FTQ0lJTGl0ZXJhbCB3aWxsIEFTU0VSVAo=