128197 2014-02-04 11:16:04 -0800 WK: Cannot select text inside clickable containers. 2014-02-04 13:35:38 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica oldest_to_newest 976448 0 enrica 2014-02-04 11:16:04 -0800 Open www.repubblica.it and navigate to a page that has comments at the bottom. Tap and hold to select text in a comment. Expected The text is selected. Actual Nothing happens. <rdar://problem/15970890> 976455 1 223145 enrica 2014-02-04 11:24:57 -0800 Created attachment 223145 Patch 976458 2 223145 simon.fraser 2014-02-04 11:28:30 -0800 Comment on attachment 223145 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223145&action=review > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:846 > + info.url = linkElement->document().completeURL(stripLeadingAndTrailingHTMLSpaces(linkElement->getAttribute(HTMLNames::hrefAttr))); > + } else if (element->isLink()) { > info.url = element->document().completeURL(stripLeadingAndTrailingHTMLSpaces(element->getAttribute(HTMLNames::hrefAttr))); > + elementIsLinkOrImage = true; Would be slightly nice to factor this so you only call completeURL() once. > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:852 > + } > + if (!elementIsLinkOrImage) { I would prefer a blank line between these two. 976490 3 enrica 2014-02-04 13:33:59 -0800 Thanks for the review. I've followed your suggestion and factored out CompleteURL. 976491 4 enrica 2014-02-04 13:35:38 -0800 Committed revision 163400. 223145 2014-02-04 11:24:57 -0800 2014-02-04 11:28:30 -0800 Patch noselectioninclickable.txt text/plain 3065 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzM5MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE0LTAyLTA0ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgV0s6IENhbm5vdCBzZWxlY3Qg dGV4dCBpbnNpZGUgY2xpY2thYmxlIGNvbnRhaW5lcnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgxOTcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzE1OTcwODkwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdoZW4gcmV0cmlldmluZyBwb3NpdGlvbiBpbmZvcm1hdGlvbiwgd2UgZmlyc3QgdHJ5IHRv CisgICAgICAgIGZpbmQgdGhlIG5vZGUgcmVzcG9uZGluZyB0byBjbGljayBldmVudHMgYmVjYXVz ZSB3ZSB3YW50CisgICAgICAgIHRvIGtub3cgd2hldGhlciB3ZSBhcmUgb24gYSBsaW5rIG9yIGFu IGltYWdlIHRvIHNob3cKKyAgICAgICAgdGhlIGFwcHJvcHJpYXRlIGFjdGlvbiBzaGVldC4KKyAg ICAgICAgV2UgY291bGQgc3RpbGwgaGF2ZSBhIG5vZGUgcmVzcG9uZGluZyB0byBjbGljayBldmVu dHMgaWYKKyAgICAgICAgZm9yIGV4YW1wbGUgd2UgaGF2ZSBhIERJViB3aXRoIGEgY2xpY2sgaGFu ZGxlciBidXQgdGhhdAorICAgICAgICBkb2Vzbid0IHJlcXVpcmUgYW55IHNwZWNpYWwgaGFuZGxp bmcgYW5kIHdlIHN0aWxsIG5lZWQgdG8KKyAgICAgICAgcGVyZm9ybSByZWd1bGFyIGhpdCB0ZXN0 aW5nLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tOgor ICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpnZXRQb3NpdGlvbkluZm9ybWF0aW9uKToKKwogMjAx NC0wMi0wNCAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFdL MjogU2VsZWN0aW9uIGNhbGxvdXQgYmFyIGRvZXMgbm90IHNjcm9sbCB3aXRoIHRoZSBzZWxlY3Rp b24uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJ T1MubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lv cy9XZWJQYWdlSU9TLm1tCShyZXZpc2lvbiAxNjMzODcpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTgyNyw2 ICs4MjcsNyBAQCB2b2lkIFdlYlBhZ2U6OmdldFBvc2l0aW9uSW5mb3JtYXRpb24oY29uCiAKICAg ICBpbmZvLnBvaW50ID0gcG9pbnQ7CiAgICAgaW5mby5ub2RlQXRQb3NpdGlvbklzQXNzaXN0ZWRO b2RlID0gKGhpdE5vZGUgPT0gbV9hc3Npc3RlZE5vZGUpOworICAgIGJvb2wgZWxlbWVudElzTGlu a09ySW1hZ2UgPSBmYWxzZTsKICAgICBpZiAoaGl0Tm9kZSkgewogICAgICAgICBpbmZvLmNsaWNr YWJsZUVsZW1lbnROYW1lID0gaGl0Tm9kZS0+bm9kZU5hbWUoKTsKIApAQCAtODM1LDE2ICs4MzYs MjAgQEAgdm9pZCBXZWJQYWdlOjpnZXRQb3NpdGlvbkluZm9ybWF0aW9uKGNvbgogICAgICAgICAg ICAgcmV0dXJuOwogCiAgICAgICAgIGlmIChlbGVtZW50LT5yZW5kZXJlcigpICYmIGVsZW1lbnQt PnJlbmRlcmVyKCktPmlzUmVuZGVySW1hZ2UoKSkgeworICAgICAgICAgICAgZWxlbWVudElzTGlu a09ySW1hZ2UgPSB0cnVlOwogICAgICAgICAgICAgRWxlbWVudCogbGlua0VsZW1lbnQgPSBjb250 YWluaW5nTGlua0VsZW1lbnQoZWxlbWVudCk7CiAKICAgICAgICAgICAgIGlmIChsaW5rRWxlbWVu dCkKLSAgICAgICAgICAgICAgICBpbmZvLnVybCA9IGxpbmtFbGVtZW50LT5kb2N1bWVudCgpLmNv bXBsZXRlVVJMKHN0cmlwTGVhZGluZ0FuZFRyYWlsaW5nSFRNTFNwYWNlcyhsaW5rRWxlbWVudC0+ Z2V0QXR0cmlidXRlKEhUTUxOYW1lczo6aHJlZkF0dHIpKSk7OwotICAgICAgICB9IGVsc2UgaWYg KGVsZW1lbnQtPmlzTGluaygpKQorICAgICAgICAgICAgICAgIGluZm8udXJsID0gbGlua0VsZW1l bnQtPmRvY3VtZW50KCkuY29tcGxldGVVUkwoc3RyaXBMZWFkaW5nQW5kVHJhaWxpbmdIVE1MU3Bh Y2VzKGxpbmtFbGVtZW50LT5nZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpocmVmQXR0cikpKTsKKyAg ICAgICAgfSBlbHNlIGlmIChlbGVtZW50LT5pc0xpbmsoKSkgewogICAgICAgICAgICAgaW5mby51 cmwgPSBlbGVtZW50LT5kb2N1bWVudCgpLmNvbXBsZXRlVVJMKHN0cmlwTGVhZGluZ0FuZFRyYWls aW5nSFRNTFNwYWNlcyhlbGVtZW50LT5nZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpocmVmQXR0cikp KTsKKyAgICAgICAgICAgIGVsZW1lbnRJc0xpbmtPckltYWdlID0gdHJ1ZTsKKyAgICAgICAgfQog ICAgICAgICBpbmZvLnRpdGxlID0gZWxlbWVudC0+Z2V0QXR0cmlidXRlKEhUTUxOYW1lczo6dGl0 bGVBdHRyKS5zdHJpbmcoKTsKICAgICAgICAgaWYgKGVsZW1lbnQtPnJlbmRlcmVyKCkpCiAgICAg ICAgICAgICBpbmZvLmJvdW5kcyA9IGVsZW1lbnQtPnJlbmRlcmVyKCktPmFic29sdXRlQm91bmRp bmdCb3hSZWN0KHRydWUpOwotICAgIH0gZWxzZSB7CisgICAgfQorICAgIGlmICghZWxlbWVudElz TGlua09ySW1hZ2UpIHsKICAgICAgICAgRnJhbWUmIGZyYW1lID0gbV9wYWdlLT5tYWluRnJhbWUo KTsKICAgICAgICAgaGl0Tm9kZSA9IGZyYW1lLmV2ZW50SGFuZGxlcigpLmhpdFRlc3RSZXN1bHRB dFBvaW50KChwb2ludCksIEhpdFRlc3RSZXF1ZXN0OjpSZWFkT25seSB8IEhpdFRlc3RSZXF1ZXN0 OjpBY3RpdmUgfCBIaXRUZXN0UmVxdWVzdDo6RGlzYWxsb3dTaGFkb3dDb250ZW50KS5pbm5lck5v ZGUoKTsKICAgICAgICAgaWYgKGhpdE5vZGUtPmlzVGV4dE5vZGUoKSkgewo=