128186 2014-02-04 08:41:03 -0800 GC timer should always do a FullCollection 2014-02-04 10:34:48 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg ggaren oldest_to_newest 976369 0 mhahnenberg 2014-02-04 08:41:03 -0800 Right now the GC timer does whatever type of collection the next collection would have been, which is almost always an EdenCollection. It then thinks that it has done all of the work it was supposed to do and never schedules another GC. Ideally we'd like to have some heuristics for the timer that would schedule both EdenCollections and FullCollections, but the easiest fix for now is to always do FullCollections, since that will at least be a non-regression. 976383 1 223125 mhahnenberg 2014-02-04 09:26:16 -0800 Created attachment 223125 Patch 976403 2 mhahnenberg 2014-02-04 09:51:27 -0800 Committed r163384: <http://trac.webkit.org/changeset/163384> 976431 3 ggaren 2014-02-04 10:34:48 -0800 > Ideally we'd like to have some heuristics for the timer that would schedule both EdenCollections and FullCollections Yeah -- and the schedule for full collections should be very long, to avoid touching too many pages. 223125 2014-02-04 09:26:16 -0800 2014-02-04 09:47:30 -0800 Patch bug-128186-20140204092615.patch text/plain 2171 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYzMzgyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE0LTAyLTA0ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgR0MgdGltZXIgc2hvdWxkIGFsd2F5cyBkbyBhIEZ1bGxDb2xsZWN0aW9uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgxODYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSaWdodCBub3cgdGhl IEdDIHRpbWVyIGRvZXMgd2hhdGV2ZXIgdHlwZSBvZiBjb2xsZWN0aW9uIHRoZSBuZXh0IGNvbGxl Y3Rpb24gCisgICAgICAgIHdvdWxkIGhhdmUgYmVlbiwgd2hpY2ggaXMgYWxtb3N0IGFsd2F5cyBh biBFZGVuQ29sbGVjdGlvbi4gSXQgdGhlbiB0aGlua3MgCisgICAgICAgIHRoYXQgaXQgaGFzIGRv bmUgYWxsIG9mIHRoZSB3b3JrIGl0IHdhcyBzdXBwb3NlZCB0byBkbyBhbmQgbmV2ZXIgc2NoZWR1 bGVzIAorICAgICAgICBhbm90aGVyIEdDLiBJZGVhbGx5IHdlJ2QgbGlrZSB0byBoYXZlIHNvbWUg aGV1cmlzdGljcyBmb3IgdGhlIHRpbWVyIHRoYXQgCisgICAgICAgIHdvdWxkIHNjaGVkdWxlIGJv dGggRWRlbkNvbGxlY3Rpb25zIGFuZCBGdWxsQ29sbGVjdGlvbnMsIGJ1dCB0aGUgZWFzaWVzdCAK KyAgICAgICAgZml4IGZvciBub3cgaXMgdG8gYWx3YXlzIGRvIEZ1bGxDb2xsZWN0aW9ucyBzaW5j ZSB0aGF0IHdpbGwgYXQgbGVhc3QgYmUgCisgICAgICAgIGEgbm9uLXJlZ3Jlc3Npb24uCisKKyAg ICAgICAgKiBoZWFwL0hlYXAuaDoKKyAgICAgICAgKEpTQzo6SGVhcDo6Z2NUaW1lckRpZEZpcmUp OgorICAgICAgICAqIHJ1bnRpbWUvR0NBY3Rpdml0eUNhbGxiYWNrLmNwcDoKKyAgICAgICAgKEpT Qzo6RGVmYXVsdEdDQWN0aXZpdHlDYWxsYmFjazo6ZG9Xb3JrKToKKwogMjAxNC0wMi0wMyAgRmls aXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIExpZnQgdGhlIEZUTCB0aWVy LXVwIHRocmVzaG9sZCBmcm9tIDI1MDAwIHRvIDEwMDAwMApJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2hlYXAvSGVhcC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9o ZWFwL0hlYXAuaAkocmV2aXNpb24gMTYzMzgwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvSGVhcC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDcsNiArMTQ3LDcgQEAgbmFtZXNwYWNlIEpT QyB7CiAKICAgICAgICAgSlNfRVhQT1JUX1BSSVZBVEUgdm9pZCBjb2xsZWN0QWxsR2FyYmFnZSgp OwogICAgICAgICBib29sIHNob3VsZENvbGxlY3QoKTsKKyAgICAgICAgdm9pZCBnY1RpbWVyRGlk RmlyZSgpIHsgbV9zaG91bGREb0Z1bGxDb2xsZWN0aW9uID0gdHJ1ZTsgfQogICAgICAgICB2b2lk IGNvbGxlY3QoKTsKICAgICAgICAgYm9vbCBjb2xsZWN0SWZOZWNlc3NhcnlPckRlZmVyKCk7IC8v IFJldHVybnMgdHJ1ZSBpZiBpdCBkaWQgY29sbGVjdC4KIApJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvR0NBY3Rpdml0eUNhbGxiYWNrLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9HQ0FjdGl2aXR5Q2FsbGJhY2suY3BwCShyZXZpc2lv biAxNjMzODApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9HQ0FjdGl2aXR5Q2Fs bGJhY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05NSw2ICs5NSw3IEBAIHZvaWQgRGVmYXVsdEdD QWN0aXZpdHlDYWxsYmFjazo6ZG9Xb3JrKCkKICAgICAgICAgcmV0dXJuOwogICAgIH0KICNlbmRp ZgorICAgIGhlYXAtPmdjVGltZXJEaWRGaXJlKCk7CiAgICAgaGVhcC0+Y29sbGVjdCgpOwogfQog ICAgIAo=